Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 ) Change subject: Added BSC tests for terminating voice group calls ...................................................................... Patch Set 1: (7 comments) File bsc/BSC_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/ab8cbccf_e46ee... PS1, Line 38: const charstring VGCS_CALL_EST := "VGCS_CALL_EST"; what about prefixing them with COORD_ or VGCS_COORD_MSG to quicjlt understand those are coordination messages? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/5bff433a_e6911... PS1, Line 98: var boolean uplink_free := false; I have the feeling you actually want to have some sort of enum containing states, and then update the stat einstead of having N booleans. Furthermore, you can add conditions to the alt step to limit where those messages are expected based on that state value (between the [] in each alt step). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/80f5d964_4ea55... PS1, Line 106: if (true) { /* VGCS/VBS ASS REQ in SCCP CR */ sounds like this needs fixing ;) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/bd0ab794_52d28... PS1, Line 187: [] T.timeout { iiuc the timeout happens at the end, so you can move all this code block after the alt? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/34556ca2_1ca28... PS1, Line 382: f_sleep(2.0); why is this needed? it shouldn't? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/73465db8_86ce1... PS1, Line 494: f_sleep(1.0); check all this sleeps, I don't see a need for them? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/ad5af8f7_bfd9d... PS1, Line 507: connect(call_conn:COORD, chan_conn:COORD); smells like race condition if this connect takes to much and some of them already sent a message. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6762e8adfb7d5f77df837c698ff70cd7fd715ffe Gerrit-Change-Number: 33150 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Comment-Date: Thu, 01 Jun 2023 17:01:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment