June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: Write explicit role & sctp-role fields in ASP configurations
by laforge 08 Jun '23

08 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33242 ) Change subject: Write explicit role & sctp-role fields in ASP configurations ...................................................................... Write explicit role & sctp-role fields in ASP configurations Change-Id: I4901ea309cd5975117480642d068df3ca2f73662 --- M doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg M doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg M doc/manuals/chapters/running.adoc 3 files changed, 21 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg b/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg index 014fbbc..176867a 100644 --- a/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg +++ b/doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg @@ -21,7 +21,9 @@ asp asp-clnt-OsmoMSC-A-Iu 2905 0 m3ua ! where to reach the STP: remote-ip 127.0.0.5 -! local-ip 10.23.24.1 + !local-ip 10.23.24.1 + role asp + sctp-role client msc cs7-instance-a 0 cs7-instance-iu 0 diff --git a/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg b/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg index b4b0761..66adfdd 100644 --- a/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg +++ b/doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg @@ -20,10 +20,14 @@ point-code 0.23.1 asp asp-clnt-OsmoMSC-A 2905 0 m3ua remote-ip 127.0.0.5 + role asp + sctp-role client cs7 instance 1 point-code 0.23.2 asp asp-clnt-OsmoMSC-Iu 2905 0 m3ua remote-ip 127.0.0.6 + role asp + sctp-role client msc cs7-instance-a 0 cs7-instance-iu 1 diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index f8550ae..d6e734b 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -107,6 +107,7 @@ point-code 0.23.1 asp asp-clnt-OsmoMSC-A-Iu 2905 0 m3ua remote-ip 127.0.0.1 + role asp sctp-role client ---- @@ -118,9 +119,13 @@ cs7 instance 0 asp my-OsmoMSC-A 2905 0 m3ua remote-ip 10.23.42.1 + role asp + sctp-role client cs7 instance 1 asp my-OsmoMSC-Iu 2905 0 m3ua remote-ip 10.23.42.2 + role asp + sctp-role client msc cs7-instance-a 0 cs7-instance-iu 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4901ea309cd5975117480642d068df3ca2f73662 Gerrit-Change-Number: 33242 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: Write explicit role & sctp-role fields in ASP configurations
by laforge 08 Jun '23

08 Jun '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33242 ) Change subject: Write explicit role & sctp-role fields in ASP configurations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4901ea309cd5975117480642d068df3ca2f73662 Gerrit-Change-Number: 33242 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 18:55:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-smlc[master]: Write explicit role & sctp-role fields in ASP configurations
by laforge 08 Jun '23

08 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/33244 ) Change subject: Write explicit role & sctp-role fields in ASP configurations ...................................................................... Write explicit role & sctp-role fields in ASP configurations Change-Id: Idf7b2288e93edb408b644da759f844ac0ce1210b --- M doc/manuals/chapters/running.adoc 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 684866e..b54e2e3 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -74,6 +74,7 @@ point-code 1.23.6 asp asp-clnt-msc-0 2905 0 m3ua remote-ip 127.0.0.1 + role asp sctp-role client ---- -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/33244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Idf7b2288e93edb408b644da759f844ac0ce1210b Gerrit-Change-Number: 33244 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-smlc[master]: Write explicit role & sctp-role fields in ASP configurations
by laforge 08 Jun '23

08 Jun '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/33244 ) Change subject: Write explicit role & sctp-role fields in ASP configurations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/33244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Idf7b2288e93edb408b644da759f844ac0ce1210b Gerrit-Change-Number: 33244 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 18:54:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc-nat[master]: Write explicit role & sctp-role fields in ASP configurations
by laforge 08 Jun '23

08 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/33246 ) Change subject: Write explicit role & sctp-role fields in ASP configurations ...................................................................... Write explicit role & sctp-role fields in ASP configurations Change-Id: Ib186b59ce33b202a7adb6159c93f7db7b677d8ef --- M doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg b/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg index a82b451..ef6b1ae 100644 --- a/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg +++ b/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg @@ -3,6 +3,8 @@ asp asp-clnt-OsmoBSCNAT-CN 2905 0 m3ua remote-ip 127.0.0.1 local-ip 127.0.0.3 + role asp + sctp-role client sccp-address msc routing-indicator PC point-code 0.23.1 @@ -13,6 +15,8 @@ asp asp-clnt-OsmoBSCNAT-RAN 2905 0 m3ua remote-ip 127.0.0.2 local-ip 127.0.0.4 + role asp + sctp-role client bsc-nat cs7-instance-cn 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/33246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ib186b59ce33b202a7adb6159c93f7db7b677d8ef Gerrit-Change-Number: 33246 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc-nat[master]: Write explicit role & sctp-role fields in ASP configurations
by laforge 08 Jun '23

08 Jun '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/33246 ) Change subject: Write explicit role & sctp-role fields in ASP configurations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/33246 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ib186b59ce33b202a7adb6159c93f7db7b677d8ef Gerrit-Change-Number: 33246 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 18:53:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-sgsn[master]: Write explicit role & sctp-role fields in ASP configurations
by laforge 08 Jun '23

08 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/33240 ) Change subject: Write explicit role & sctp-role fields in ASP configurations ...................................................................... Write explicit role & sctp-role fields in ASP configurations Change-Id: I44e251ca2df02e4f1fdfc1492306ec25d0653ef6 --- M doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg M doc/manuals/chapters/configuration.adoc 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg b/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg index fd5a205..1cc4bde 100644 --- a/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg +++ b/doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg @@ -9,6 +9,8 @@ point-code 0.23.4 asp asp-clnt-OsmoSGSN-A 2905 0 m3ua remote-ip 172.18.8.200 ! where to reach the STP + role asp + sctp-role client as as-clnt-OsmoSGSN-A m3ua asp asp-clnt-OsmoSGSN-A routing-key 3 0.23.4 diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index d51dd77..d6ddcd3 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -422,6 +422,7 @@ point-code 0.23.4 asp asp-clnt-OsmoSGSN 2905 0 m3ua remote-ip 127.0.0.1 + role asp sctp-role client as as-clnt-OsmoSGSN m3ua asp asp-clnt-OsmoSGSN -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/33240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I44e251ca2df02e4f1fdfc1492306ec25d0653ef6 Gerrit-Change-Number: 33240 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-sgsn[master]: Write explicit role & sctp-role fields in ASP configurations
by laforge 08 Jun '23

08 Jun '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/33240 ) Change subject: Write explicit role & sctp-role fields in ASP configurations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/33240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I44e251ca2df02e4f1fdfc1492306ec25d0653ef6 Gerrit-Change-Number: 33240 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 18:53:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: tests: Update *.vty after libosmo-sccp VTY improvements
by pespin 08 Jun '23

08 Jun '23

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33238 ) Change subject: tests: Update *.vty after libosmo-sccp VTY improvements ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: This will start passing and will need to be merged once we merge https://gerrit.osmocom.org/c/libosmo-sccp/+/33237 Those tests were added recently afair, so no change requires in osmo-hnbgw-latest. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I316cd26ceb97f2ccfd1065d65177e7d3926625b0 Gerrit-Change-Number: 33238 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 08 Jun 2023 17:53:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in libosmo-sccp[master]: osmo_sccp_simple_client_on_ss7_id(): Always follow VTY config of ASP ...
by pespin 08 Jun '23

08 Jun '23

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33237 ) Change subject: osmo_sccp_simple_client_on_ss7_id(): Always follow VTY config of ASP if it was explicitly defined in VTY ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This may break some existing config file (those which has ASP named "asp asp-clnt-*" defined without explicitly setting them to role=asp & sctp-role=client). However, I deem this necessary since the previous state of things is totally confusing, where one value or the other is taken by default based on implementation details, which also ends up creating trouble to the user/dev. This change (always following same defaults) will also help if we want to ever get out of osmo_sccp_simple_client_on_ss7_id() in osmo-msc, osmo-bsc and osmo-hnbgw. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ie81987265118e48173211f88b27a006115dc62d4 Gerrit-Change-Number: 33237 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 08 Jun 2023 17:50:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0