June 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by pespin 08 Jun '23

08 Jun '23

Attention is currently required from: arehbein, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31533 ) Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 9: (2 comments) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/3a377072_536f8195 PS6, Line 990: pcu_sock_close(state); > I think this was not yet addressed? Not sure what you are talking about arehbein. pcu_sock_send() is not creating the sturct msgb, but the caller expects it to take ownsership of the object, hence it is the duty of pcu_sock_send() to make sure the object is always freed. Similary, osmo_wqueue_enqueue is expected to take ownsership of the message if it doesn't fail, that's what the documentation of the API states. Hence, it's pcu_sock_send() duty to free the object to avoid the leak. https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/10d00429_f8c74f74 PS6, Line 1106: rc = osmo_wqueue_enqueue(&state->upqueue, m); > Thanks for the reference, I'm now returning `-errno` just in case `write()` causes `errno` to be `EB […] No, that's wrong. write() returning -EBADF doesn't mean we should return it. -EBADF is a return code with a specific meaning the callback should return in case it frees the related object/ofd. I wouldn't return -errno here in all cases, but rather return specific errnos based on what's needed, to avoid unexpected consequences (eg -EBADF forwarded from write() to the calle of thi function). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 9 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 21:58:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by pespin 08 Jun '23

08 Jun '23

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31533 ) Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 9: (2 comments) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/195e4f26_9639d78d PS6, Line 990: pcu_sock_close(state); > Indeed, the API doc clearly states: […] I think this was not yet addressed? File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/16846a71_b552a6cd PS9, Line 1112: rc = write(bfd->fd, msgb_data(msg), msgb_length(msg)); you are dropping he errno==EAGAIN case here. Is it because returning -EAGAIN already makes the wqueue code re-add the message? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 9 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 21:50:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by arehbein 08 Jun '23

08 Jun '23

Attention is currently required from: laforge, fixeria, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31533 ) Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 9: (3 comments) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/cf3a2798_23dd8c05 PS6, Line 990: pcu_sock_close(state); > Indeed, the API doc clearly states: […] my thinking was, if `pcu_sock_send()` doesn't create the `struct msgb`, then it wouldn't have to delete it. But I suppose `pcu_sock_send()` would cause the message buffer deletion after it has been sent/the sending queue has been cleared, so that's why we add it here (?) https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/3361d224_e652fa2b PS6, Line 1093: struct msgb *m > I would keep the usual naming, i.e. `msg`. […] Done https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/47dc2de1_364a9a98 PS6, Line 1106: rc = osmo_wqueue_enqueue(&state->upqueue, m); > Yes, this is likely what pespin meant. […] Thanks for the reference, I'm now returning `-errno` just in case `write()` causes `errno` to be `EBADF`. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 9 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 21:43:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by arehbein 08 Jun '23

08 Jun '23

Attention is currently required from: arehbein, laforge, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 to look at the new patch set (#9). Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... common: Have PCU socket connection use osmo_wqueue Fixes memleak in case of connected PCU process being suspended without proper close on socket Related: OS#5774 Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 --- M include/osmo-bts/bts.h M src/common/pcu_sock.c 2 files changed, 47 insertions(+), 54 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/33/31533/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 9 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by arehbein 08 Jun '23

08 Jun '23

Attention is currently required from: arehbein, laforge, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 to look at the new patch set (#8). Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... common: Have PCU socket connection use osmo_wqueue Fixes memleak in case of connected PCU process being suspended without proper close on socket Related: OS#5774 Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 --- M include/osmo-bts/bts.h M src/common/pcu_sock.c 2 files changed, 47 insertions(+), 54 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/33/31533/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by arehbein 08 Jun '23

08 Jun '23

Attention is currently required from: arehbein, laforge, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 to look at the new patch set (#7). Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... common: Have PCU socket connection use osmo_wqueue Fixes memleak in case of connected PCU process being suspended without proper close on socket Related: OS#5774 Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 --- M include/osmo-bts/bts.h M src/common/pcu_sock.c 2 files changed, 55 insertions(+), 51 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/33/31533/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 7 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: README: rephrase initial section; add HPSIM; programmable vs. standard
by laforge 08 Jun '23

08 Jun '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33247 ) Change subject: README: rephrase initial section; add HPSIM; programmable vs. standard ...................................................................... README: rephrase initial section; add HPSIM; programmable vs. standard Change-Id: Ied7bce9fc4ebc9a71093ac41d9c1b8e67fe04d7e --- M README.md 1 file changed, 27 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/47/33247/1 diff --git a/README.md b/README.md index db13a52..86dc63d 100644 --- a/README.md +++ b/README.md @@ -1,16 +1,25 @@ -pySim - Read, Write and Browse Programmable SIM/USIM Cards -==================================================== +pySim - Read, Write and Browse Programmable SIM/USIM/ISIM/HPSIM Cards +===================================================================== -This repository contains Python programs that can be used -to read, program (write) and browse certain fields/parameters on so-called programmable -SIM/USIM cards. +This repository contains a number of Python programs that can be used +to read, program (write) and browse all fields/parameters/files on +SIM/USIM/ISIM/HPSIM cards used in 3GPP cellular networks from 2G to 5G. -Such SIM/USIM cards are special cards, which - unlike those issued by -regular commercial operators - come with the kind of keys that allow you -to write the files/fields that normally only an operator can program. +Note that the access control configuration of normal production cards +issue by operators will restrict significantly which files a normal +user can read, and particularly write to. + +The full functionality of pySim hence can only be used with on so-called +programmable SIM/USIM/ISIM/HPSIM cards. + +Such SIM/USIM/ISIM/HPSIM cards are special cards, which - unlike those +issued by regular commercial operators - come with the kind of keys that +allow you to write the files/fields that normally only an operator can +program. This is useful particularly if you are running your own cellular -network, and want to issue your own SIM/USIM cards for that network. +network, and want to configure your own SIM/USIM/ISIM/HPSIM cards for +that network. Homepage and Manual -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied7bce9fc4ebc9a71093ac41d9c1b8e67fe04d7e Gerrit-Change-Number: 33247 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[M] Change in pysim[master]: README: remove redundancy 'Manual' and 'Documentation
by laforge 08 Jun '23

08 Jun '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33248 ) Change subject: README: remove redundancy 'Manual' and 'Documentation ...................................................................... README: remove redundancy 'Manual' and 'Documentation Also, re-order sections oriented more towards the user (Docs first) Change-Id: I4fc76222a1c22685131cb6926721ce24f0373046 --- M README.md 1 file changed, 44 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/48/33248/1 diff --git a/README.md b/README.md index 86dc63d..2a89c9a 100644 --- a/README.md +++ b/README.md @@ -22,10 +22,40 @@ that network. -Homepage and Manual -------------------- +Homepage +-------- -Please visit the [official homepage](https://osmocom.org/projects/pysim/wiki) for usage instructions, manual and examples. The user manual can also be built locally from this source code by ``cd docs && make html latexpdf`` for HTML and PDF format, respectively. +Please visit the [official homepage](https://osmocom.org/projects/pysim/wiki) +for usage instructions, manual and examples. + + +Documentation +------------- + +The pySim user manual can be built from this very source code by means +of sphinx (with sphinxcontrib-napoleon and sphinx-argparse). See the +Makefile in the 'docs' directory. + +A pre-rendered HTML user manual of the current pySim 'git master' is +available from <https://downloads.osmocom.org/docs/latest/pysim/> and +a downloadable PDF version is published at +<https://downloads.osmocom.org/docs/latest/osmopysim-usermanual.pdf>. + +A slightly dated video presentation about pySim-shell can be found at +<https://media.ccc.de/v/osmodevcall-20210409-laforge-pysim-shell>. + + +pySim-shell vs. legacy tools +---------------------------- + +While you will find a lot of online resources still describing the use of +pySim-prog.py and pySim-read.py, those tools are considered legacy by +now and have by far been superseded by the much more capable +pySim-shell. We strongly encourage users to adopt pySim-shell, unless +they have very specific requirements like batch programming of large +quantities of cards, which is about the only remaining use case for the +legacy tools. + Git Repository -------------- @@ -111,32 +141,3 @@ We are using a gerrit-based patch review process explained at <https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit> - - -Documentation -------------- - -The pySim user manual can be built from this very source code by means -of sphinx (with sphinxcontrib-napoleon and sphinx-argparse). See the -Makefile in the 'docs' directory. - -A pre-rendered HTML user manual of the current pySim 'git master' is -available from <https://downloads.osmocom.org/docs/latest/pysim/> and -a downloadable PDF version is published at -<https://downloads.osmocom.org/docs/latest/osmopysim-usermanual.pdf>. - -A slightly dated video presentation about pySim-shell can be found at -<https://media.ccc.de/v/osmodevcall-20210409-laforge-pysim-shell>. - - -pySim-shell vs. legacy tools ----------------------------- - -While you will find a lot of online resources still describing the use of -pySim-prog.py and pySim-read.py, those tools are considered legacy by -now and have by far been superseded by the much more capable -pySim-shell. We strongly encourage users to adopt pySim-shell, unless -they have very specific requirements like batch programming of large -quantities of cards, which is about the only remaining use case for the -legacy tools. - -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33248 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4fc76222a1c22685131cb6926721ce24f0373046 Gerrit-Change-Number: 33248 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnbgw[master]: tests: Update *.vty after libosmo-sccp VTY improvements
by laforge 08 Jun '23

08 Jun '23

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33238 ) Change subject: tests: Update *.vty after libosmo-sccp VTY improvements ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I316cd26ceb97f2ccfd1065d65177e7d3926625b0 Gerrit-Change-Number: 33238 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 19:27:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Explicitly configure ASPs asp-clnt-* as role=asp & sctp-role=client
by laforge 08 Jun '23

08 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33236 ) Change subject: Explicitly configure ASPs asp-clnt-* as role=asp & sctp-role=client ...................................................................... Explicitly configure ASPs asp-clnt-* as role=asp & sctp-role=client Until recently, the asp-clnt-* ASPs, which have specific handling in osmo_sccp_simple_client_on_ss7_id(), were being always forcedly set to sctp-role CLIENT by code in that function. This prevented user of that API from explicitly configuring the ASP as "sctp-role server" through the VTY as the option would be overwritten silently. Now, the sctp-role from config is followed if the ASP is defined/configured through the VTY (not dynamically created at the time osmo_sccp_simple_client_on_ss7_id() is called). Since the default for a VTY-specified ASP is to be in "sctp-role server", the config files need to be updated to properly configure the ASP to be in "sctp-role client", which is the desired mode here. Same applies for "role", where the default is SG but it is actually used as "ASP" here. Change-Id: I4eb5b5f6b4b24df079b4c74e2a2e2ebb8769b0bd --- M bsc/osmo-bsc-sccplite.cfg M bsc/osmo-bsc-vamos.cfg M bsc/osmo-bsc.cfg M bts/osmo-bsc.cfg M msc/osmo-msc.cfg M sgsn/osmo-sgsn.cfg M sgsn/osmo-sgsn.sns.cfg M smlc/osmo-smlc.cfg 8 files changed, 42 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/bsc/osmo-bsc-sccplite.cfg b/bsc/osmo-bsc-sccplite.cfg index 4a3498b..05934ed 100644 --- a/bsc/osmo-bsc-sccplite.cfg +++ b/bsc/osmo-bsc-sccplite.cfg @@ -25,6 +25,8 @@ point-code 0.23.3 asp asp-clnt-msc-0 5000 0 ipa remote-ip 127.0.0.1 + role asp + sctp-role client as as-clnt-msc-0 ipa asp asp-clnt-msc-0 routing-key 0 0.23.3 diff --git a/bsc/osmo-bsc-vamos.cfg b/bsc/osmo-bsc-vamos.cfg index 4b0389f..73cafe7 100644 --- a/bsc/osmo-bsc-vamos.cfg +++ b/bsc/osmo-bsc-vamos.cfg @@ -49,6 +49,8 @@ cs7 instance 0 asp asp-clnt-msc-0 2905 1905 m3ua remote-ip 127.0.0.1 + role asp + sctp-role client sccp-address msc2 point-code 0.0.2 sccp-address msc3 diff --git a/bsc/osmo-bsc.cfg b/bsc/osmo-bsc.cfg index bb62f52..43f7833 100644 --- a/bsc/osmo-bsc.cfg +++ b/bsc/osmo-bsc.cfg @@ -49,6 +49,8 @@ cs7 instance 0 asp asp-clnt-msc-0 2905 1905 m3ua remote-ip 127.0.0.1 + role asp + sctp-role client sccp-address msc2 point-code 0.0.2 sccp-address msc3 diff --git a/bts/osmo-bsc.cfg b/bts/osmo-bsc.cfg index 8f3169b..967e265 100644 --- a/bts/osmo-bsc.cfg +++ b/bts/osmo-bsc.cfg @@ -40,6 +40,8 @@ cs7 instance 0 point-code 0.23.3 asp asp-clnt-msc-0 2905 0 m3ua + role asp + sctp-role client as as-clnt-msc-0 m3ua asp asp-clnt-msc-0 routing-key 2 0.23.3 diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg index 1adb0e9..a266ed4 100644 --- a/msc/osmo-msc.cfg +++ b/msc/osmo-msc.cfg @@ -42,6 +42,8 @@ point-code 0.23.1 asp asp-clnt-OsmoMSC-A 2905 0 m3ua remote-ip 127.0.0.1 + role asp + sctp-role client as as-clnt-OsmoMSC-A m3ua asp asp-clnt-OsmoMSC-A routing-key 3 0.23.1 diff --git a/sgsn/osmo-sgsn.cfg b/sgsn/osmo-sgsn.cfg index 7941007..b446f87 100644 --- a/sgsn/osmo-sgsn.cfg +++ b/sgsn/osmo-sgsn.cfg @@ -58,6 +58,8 @@ point-code 0.23.4 asp asp-clnt-OsmoSGSN-A 2905 0 m3ua remote-ip 127.0.0.200 + role asp + sctp-role client as as-clnt-OsmoSGSN-A m3ua asp asp-clnt-OsmoSGSN-A routing-key 3 0.23.4 diff --git a/sgsn/osmo-sgsn.sns.cfg b/sgsn/osmo-sgsn.sns.cfg index 988790a..5d09b1b 100644 --- a/sgsn/osmo-sgsn.sns.cfg +++ b/sgsn/osmo-sgsn.sns.cfg @@ -58,6 +58,8 @@ point-code 0.23.4 asp asp-clnt-OsmoSGSN-A 2905 0 m3ua remote-ip 127.0.0.200 + role asp + sctp-role client as as-clnt-OsmoSGSN-A m3ua asp asp-clnt-OsmoSGSN-A routing-key 3 0.23.4 diff --git a/smlc/osmo-smlc.cfg b/smlc/osmo-smlc.cfg index 3bba0b3..7da2163 100644 --- a/smlc/osmo-smlc.cfg +++ b/smlc/osmo-smlc.cfg @@ -21,7 +21,8 @@ local-ip fd02:db8:23::20 remote-ip 172.18.23.200 remote-ip fd02:db8:23::200 - + role asp + sctp-role client cells lac-ci 23 42 lat 23.23 lon 42.42 cgi 001 02 3 4 lat 5.678 lon 6.789 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4eb5b5f6b4b24df079b4c74e2a2e2ebb8769b0bd Gerrit-Change-Number: 33236 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0