June 2023 - gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: docs: Add section on pySim-trace to user manual
by laforge 09 Jun '23

09 Jun '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33251 ) Change subject: docs: Add section on pySim-trace to user manual ...................................................................... docs: Add section on pySim-trace to user manual Change-Id: I5edb222818f00e36ed5b067e0f8d5786f39ae887 --- M docs/index.rst A docs/trace.rst M pySim-trace.py 3 files changed, 91 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/51/33251/1 diff --git a/docs/index.rst b/docs/index.rst index 471802a..a46aee0 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -31,6 +31,7 @@ * a python :ref:`library<pySim library>` containing plenty of objects and methods that can be used for writing custom programs interfacing with SIM cards. * the [new] :ref:`interactive pySim-shell command line program<pySim-shell>` +* the [new] :ref:`pySim-trace APDU trace decoder<pySim-trace>` * the [legacy] :ref:`pySim-prog and pySim-read tools<Legacy tools>` .. toctree:: @@ -38,6 +39,7 @@ :caption: Contents: shell + trace legacy library diff --git a/docs/trace.rst b/docs/trace.rst new file mode 100644 index 0000000..637491a --- /dev/null +++ b/docs/trace.rst @@ -0,0 +1,64 @@ +pySim-trace +=========== + +pySim-trace is a utility for high-level decode of APDU protocol traces such as those obtained with +`Osmocom SIMtrace2 <https://osmocom.org/projects/simtrace2/wiki>`_ or `osmo-qcdiag <https://osmocom.org/projects/osmo-qcdiag/wiki>`_. + +pySim-trace leverages the existing knowledge of pySim-shell on anything related to SIM cards, +including the structure/encoding of the various files on SIM/USIM/ISIM/HPSIM cards, and applies this +to decoding protocol traces. This means that it shows not only the name of the command (like READ +BINARY), but actually understands what the currently selected file is, and how to decode the +contents of that file. + +pySim-trace also understands the parameters passed to commands and how to decode them, for example +of the AUTHENTICATE command within the USIM/ISIM/HPSIM application. + + +Demo +---- + +To get an idea how pySim-trace usage looks like, you can watch the relevant part of the 11/2022 +SIMtrace2 tutorial whose `recording is freely accessible <https://media.ccc.de/v/osmodevcall-20221019-laforge-simtrace2-tutorial#t=21…>`_. + + +Running pySim-trace +------------------- + +Running pySim-trace requires you to specify the *source* of the to-be-decoded APDUs. There are several +supported options, each with their own respective parameters (like a file name for PCAP decoding). + +See the detailed command line reference below for details. + +A typical execution of pySim-trace for doing live decodes of *GSMTAP (SIM APDU)* e.g. from SIMtrace2 or +osmo-qcdiag would look like this: + +:: + + ./pySim-trace.py gsmtap-udp + +This binds to the default UDP port 4729 (GSMTAP) on localhost (127.0.0.1), and decodes any APDUs received +there. + + + +pySim-trace command line reference +---------------------------------- + +.. argparse:: + :module: pySim-trace + :func: option_parser + :prog: pySim-trace.py + + +Constraints +----------- + +* In order to properly track the current location in the filesystem tree and other state, it is + important that the trace you're decoding includes all of the communication with the SIM, ideally + from the very start (power up). + +* pySim-trace currently only supports ETSI UICC (USIM/ISIM/HPSIM) and doesn't yet support legacy GSM + SIM. This is not a fundamental technical constraint, it's just simply that nobody got around + developing and testing that part. Contributions are most welcome. + + diff --git a/pySim-trace.py b/pySim-trace.py index 79069a6..bb1805c 100755 --- a/pySim-trace.py +++ b/pySim-trace.py @@ -114,36 +114,45 @@ #print(inst) self.format_capdu(inst) -option_parser = argparse.ArgumentParser(prog='pySim-trace', description='Osmocom pySim high-level SIM card trace decoder', +option_parser = argparse.ArgumentParser(description='Osmocom pySim high-level SIM card trace decoder', formatter_class=argparse.ArgumentDefaultsHelpFormatter) global_group = option_parser.add_argument_group('General Options') global_group.add_argument('--no-suppress-select', action='store_false', dest='suppress_select', - help="Don't suppress displaying SELECT APDUs") + help=""" + Don't suppress displaying SELECT APDUs. We normally suppress them as they just clutter up + the output without giving any useful information. Any subsequent READ/UPDATE/... operations + on the selected file will log the file name most recently SELECTed.""") global_group.add_argument('--no-suppress-status', action='store_false', dest='suppress_status', - help="Don't suppress displaying STATUS APDUs") + help=""" + Don't suppress displaying STATUS APDUs. We normally suppress them as they don't provide any + information that was not already received in resposne to the most recent SEELCT.""") subparsers = option_parser.add_subparsers(help='APDU Source', dest='source', required=True) -parser_gsmtap = subparsers.add_parser('gsmtap-udp', help='Live capture of GSMTAP-SIM on UDP port') +parser_gsmtap = subparsers.add_parser('gsmtap-udp', help=""" + Read APDUs from live capture by receiving GSMTAP-SIM packets on specified UDP port. + Use this for live capture from SIMtrace2 or osmo-qcdiag.""") parser_gsmtap.add_argument('-i', '--bind-ip', default='127.0.0.1', help='Local IP address to which to bind the UDP port') parser_gsmtap.add_argument('-p', '--bind-port', default=4729, help='Local UDP port') parser_gsmtap_pyshark_pcap = subparsers.add_parser('gsmtap-pyshark-pcap', help=""" - PCAP file containing GSMTAP (SIM APDU) communication; processed via pyshark.""") + Read APDUs from PCAP file containing GSMTAP (SIM APDU) communication; processed via pyshark. + Use this if you have recorded a PCAP file containing GSMTAP (SIM APDU) e.g. via tcpdump or + wireshark/tshark.""") parser_gsmtap_pyshark_pcap.add_argument('-f', '--pcap-file', required=True, help='Name of the PCAP[ng] file to be read') parser_rspro_pyshark_pcap = subparsers.add_parser('rspro-pyshark-pcap', help=""" - PCAP file containing RSPRO (osmo-remsim) communication; processed via pyshark. + Read APDUs from PCAP file containing RSPRO (osmo-remsim) communication; processed via pyshark. REQUIRES OSMOCOM PATCHED WIRESHARK!""") parser_rspro_pyshark_pcap.add_argument('-f', '--pcap-file', required=True, help='Name of the PCAP[ng] file to be read') parser_rspro_pyshark_live = subparsers.add_parser('rspro-pyshark-live', help=""" - Live capture of RSPRO (osmo-remsim) communication; processed via pyshark. + Read APDUs from live capture of RSPRO (osmo-remsim) communication; processed via pyshark. REQUIRES OSMOCOM PATCHED WIRESHARK!""") parser_rspro_pyshark_live.add_argument('-i', '--interface', required=True, help='Name of the network interface to capture on') -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5edb222818f00e36ed5b067e0f8d5786f39ae887 Gerrit-Change-Number: 33251 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: Add ".py" suffix to sphings-argparse generated docs
by laforge 09 Jun '23

09 Jun '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33250 ) Change subject: Add ".py" suffix to sphings-argparse generated docs ...................................................................... Add ".py" suffix to sphings-argparse generated docs This is important to produce the right command syntax when generating command line reference in the user manual. However, we shouldn't add this kludge to the individual programs, but only to the documentation using the :prog: syntax. Change-Id: I2ec7ab00c63d5d386f187e54755c71ffc2dce429 --- M docs/legacy.rst M docs/shell.rst M pySim-read.py M pySim-shell.py 4 files changed, 18 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/50/33250/1 diff --git a/docs/legacy.rst b/docs/legacy.rst index d93358f..0961d17 100644 --- a/docs/legacy.rst +++ b/docs/legacy.rst @@ -98,3 +98,4 @@ .. argparse:: :module: pySim-read :func: option_parser + :prog: pySim-read.py diff --git a/docs/shell.rst b/docs/shell.rst index e13d054..ef08fcf 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -35,6 +35,7 @@ .. argparse:: :module: pySim-shell :func: option_parser + :prog: pySim-shell.py Usage Examples -------------- diff --git a/pySim-read.py b/pySim-read.py index ddc193a..f80509c 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -40,8 +40,7 @@ from pySim.utils import format_xplmn_w_act, dec_st from pySim.utils import h2s, format_ePDGSelection -option_parser = argparse.ArgumentParser(prog='pySim-read', - description='Legacy tool for reading some parts of a SIM card', +option_parser = argparse.ArgumentParser(description='Legacy tool for reading some parts of a SIM card', formatter_class=argparse.ArgumentDefaultsHelpFormatter) argparse_add_reader_args(option_parser) diff --git a/pySim-shell.py b/pySim-shell.py index 3f0818a..c6782d4 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -949,7 +949,7 @@ -option_parser = argparse.ArgumentParser(prog='pySim-shell', description='interactive SIM card shell', +option_parser = argparse.ArgumentParser(description='interactive SIM card shell', formatter_class=argparse.ArgumentDefaultsHelpFormatter) argparse_add_reader_args(option_parser) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2ec7ab00c63d5d386f187e54755c71ffc2dce429 Gerrit-Change-Number: 33250 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by fixeria 09 Jun '23

09 Jun '23

Attention is currently required from: arehbein, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31533 ) Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 12: Code-Review+1 (2 comments) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/bf4e150a_673b1b74 PS6, Line 1106: rc = osmo_wqueue_enqueue(&state->upqueue, m); > Hope this is alright now. […] Ack File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/e69c5aab_f2d7aab3 PS12, Line 1117: if (errno == EAGAIN) > you could: "return errno == EAGAIN ? -EAGAIN : -1;" but fine anyway. This is just a matter of personal preferences, I am fine with the `if`. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 12 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jun 2023 09:24:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by pespin 09 Jun '23

09 Jun '23

Attention is currently required from: arehbein, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31533 ) Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 12: Code-Review+1 (1 comment) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/144278d4_5d1fab52 PS12, Line 1117: if (errno == EAGAIN) you could: "return errno == EAGAIN ? -EAGAIN : -1;" but fine anyway. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 12 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jun 2023 08:45:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: WIP: ASCI related BTS tests
by jolly 09 Jun '23

09 Jun '23

jolly has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33142 ) Change subject: WIP: ASCI related BTS tests ...................................................................... Abandoned This was accidentally in my branch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a93fa486a48957367d2c727cc0a8eea33d3bf11 Gerrit-Change-Number: 33142 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

1 0

[S] Change in pysim[master]: 31.102: Fix EF.Routing_Indicator for odd number of digits
by laforge 09 Jun '23

09 Jun '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33249 ) Change subject: 31.102: Fix EF.Routing_Indicator for odd number of digits ...................................................................... 31.102: Fix EF.Routing_Indicator for odd number of digits The routing indicator is BCD-encoded but has an arbitrary length of 1, 2, 3 or 4 digits. In order to support the odd lengths of 1 or 3, we must not pad on the byte level, but on the nibble level. This requires a slight extension of the Rpad() Adapter. Change-Id: I6c26dccdd570de7b7a4cd48338068e230340ec7c Fixes: OS#6054 --- M pySim/construct.py M pySim/ts_31_102.py 2 files changed, 28 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/49/33249/1 diff --git a/pySim/construct.py b/pySim/construct.py index 20a6946..ab44a63 100644 --- a/pySim/construct.py +++ b/pySim/construct.py @@ -66,26 +66,29 @@ class Rpad(Adapter): """ - Encoder appends padding bytes (b'\\xff') up to target size. - Decoder removes trailing padding bytes. + Encoder appends padding bytes (b'\\xff') or characters up to target size. + Decoder removes trailing padding bytes/characters. Parameters: subcon: Subconstruct as defined by construct library pattern: set padding pattern (default: b'\\xff') + num_per_byte: number of 'elements' per byte. E.g. for hex nibbles: 2 """ - def __init__(self, subcon, pattern=b'\xff'): + def __init__(self, subcon, pattern=b'\xff', num_per_byte=1): super().__init__(subcon) self.pattern = pattern + self.num_per_byte = num_per_byte def _decode(self, obj, context, path): return obj.rstrip(self.pattern) def _encode(self, obj, context, path): - if len(obj) > self.sizeof(): + target_size = self.sizeof() * self.num_per_byte + if len(obj) > target_size: raise SizeofError("Input ({}) exceeds target size ({})".format( - len(obj), self.sizeof())) - return obj + self.pattern * (self.sizeof() - len(obj)) + len(obj), target_size)) + return obj + self.pattern * (target_size - len(obj)) class MultiplyAdapter(Adapter): """ diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 81b671e..e7ae8f0 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -1089,7 +1089,8 @@ # responsibility of home network operator but BCD coding shall be used. If a network # operator decides to assign less than 4 digits to Routing Indicator, the remaining digits # shall be coded as "1111" to fill the 4 digits coding of Routing Indicator - self._construct = Struct('routing_indicator'/BcdAdapter(Rpad(Bytes(2))), 'rfu'/HexAdapter(Bytes(2))) + self._construct = Struct('routing_indicator'/Rpad(BcdAdapter(Bytes(2)), 'f', 2), + 'rfu'/HexAdapter(Bytes(2))) # TS 31.102 Section 4.4.11.13 class EF_TN3GPPSNN(TransparentEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6c26dccdd570de7b7a4cd48338068e230340ec7c Gerrit-Change-Number: 33249 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by arehbein 09 Jun '23

09 Jun '23

Attention is currently required from: laforge, pespin, fixeria. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31533 ) Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 12: (3 comments) File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/6cdaea42_6d2fda0e PS6, Line 990: pcu_sock_close(state); > Not sure what you are talking about arehbein. […] My bad, thought I had already fixed this https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/b7a2bcff_018f4e63 PS6, Line 1106: rc = osmo_wqueue_enqueue(&state->upqueue, m); > No, that's wrong. write() returning -EBADF doesn't mean we should return it. […] Hope this is alright now. I added a `return -1;` in case of other errors (previous code didn't return any other `errno` constants). `osmo_wqueue_bfd_cb` treats all other return values the same, however I would still rather return a `-1` just so the function itself returns negative values for all errors/looks more consistent that way File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/92ddcf1d_9fb0e15a PS9, Line 1112: rc = write(bfd->fd, msgb_data(msg), msgb_length(msg)); > you are dropping he errno==EAGAIN case here. […] Yes, fixeria referred me to `osmo_wqueue_bfd_cb()`, which checks the returned value for some negative `errno` constants; in case of `rc == -EAGAIN`, it takes care of the readding of the `struct msgb` -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 12 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 22:40:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by arehbein 09 Jun '23

09 Jun '23

Attention is currently required from: arehbein, laforge, fixeria. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 to look at the new patch set (#12). Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... common: Have PCU socket connection use osmo_wqueue Fixes memleak in case of connected PCU process being suspended without proper close on socket Related: OS#5774 Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 --- M include/osmo-bts/bts.h M src/common/pcu_sock.c 2 files changed, 50 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/33/31533/12 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 12 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by arehbein 09 Jun '23

09 Jun '23

Attention is currently required from: arehbein, laforge, fixeria. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 to look at the new patch set (#11). Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... common: Have PCU socket connection use osmo_wqueue Fixes memleak in case of connected PCU process being suspended without proper close on socket Related: OS#5774 Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 --- M include/osmo-bts/bts.h M src/common/pcu_sock.c 2 files changed, 51 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/33/31533/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 11 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bts[master]: common: Have PCU socket connection use osmo_wqueue
by arehbein 09 Jun '23

09 Jun '23

Attention is currently required from: arehbein, laforge, fixeria. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 to look at the new patch set (#10). Change subject: common: Have PCU socket connection use osmo_wqueue ...................................................................... common: Have PCU socket connection use osmo_wqueue Fixes memleak in case of connected PCU process being suspended without proper close on socket Related: OS#5774 Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 --- M include/osmo-bts/bts.h M src/common/pcu_sock.c 2 files changed, 48 insertions(+), 54 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/33/31533/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1 Gerrit-Change-Number: 31533 Gerrit-PatchSet: 10 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0