June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf
by pespin 14 Jun '23

14 Jun '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33307 ) Change subject: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I thought about TODO-RELEASE, but it already has: […] Yes I forgot adding, it I'll resubmit. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0f142e7af180136e8dac142672d38d75a76ef123 Gerrit-Change-Number: 33307 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:10:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf
by pespin 14 Jun '23

14 Jun '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33305 ) Change subject: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf ...................................................................... Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf Depends: osmo-mgw.git Change-Id Iba0853ed099a32cf1dde78c17e1b34343db41cfc Change-Id: I9d342d2eff7b57b0c542ff0c1c579f708451637c --- M TODO-RELEASE M src/osmo-bsc/osmo_bsc_main.c 2 files changed, 12 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 690e9ea..4699dbd 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -14,4 +14,4 @@ libosmo-abis >1.4.0 osmo_ortp.h: add RTP_PT_CSDATA libosmo-sccp >1.7.0 osmo_sccp_{get,set}_priv() libosmocore >1.8.0 GSM48_IE_CIP_MODE_SET_HO and GSM48_IE_SYNC_IND_HO -libosmo-mgcp-client > 1.11.0 mgcp_client_pool_empty() +libosmo-mgcp-client > 1.11.0 mgcp_client_pool_empty(), mgcp_client_conf_alloc() \ No newline at end of file diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index f3f9cd2..c4b5780 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -912,9 +912,8 @@ exit(1); } - bsc_gsmnet->mgw.conf = talloc_zero(bsc_gsmnet, struct mgcp_client_conf); + bsc_gsmnet->mgw.conf = mgcp_client_conf_alloc(bsc_gsmnet); bsc_gsmnet->mgw.mgw_pool = mgcp_client_pool_alloc(bsc_gsmnet); - mgcp_client_conf_init(bsc_gsmnet->mgw.conf); bts_init(); libosmo_abis_init(tall_bsc_ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9d342d2eff7b57b0c542ff0c1c579f708451637c Gerrit-Change-Number: 33305 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-msc[master]: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf
by osmith 14 Jun '23

14 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33306 ) Change subject: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I382046bba67646a7365d9290d604b97c9d886e02 Gerrit-Change-Number: 33306 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:09:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf
by pespin 14 Jun '23

14 Jun '23

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/33306 to look at the new patch set (#2). Change subject: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf ...................................................................... Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf Depends: osmo-mgw.git Change-Id Iba0853ed099a32cf1dde78c17e1b34343db41cfc Change-Id: I382046bba67646a7365d9290d604b97c9d886e02 --- M TODO-RELEASE M include/osmocom/msc/gsm_data.h M src/libmsc/msc_vty.c M src/osmo-msc/msc_main.c M tests/msc_vlr/msc_vlr_tests.c 5 files changed, 19 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/06/33306/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I382046bba67646a7365d9290d604b97c9d886e02 Gerrit-Change-Number: 33306 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-hnbgw[master]: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf
by osmith 14 Jun '23

14 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33307 ) Change subject: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0f142e7af180136e8dac142672d38d75a76ef123 Gerrit-Change-Number: 33307 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:09:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf
by pespin 14 Jun '23

14 Jun '23

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33307 to look at the new patch set (#2). Change subject: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf ...................................................................... Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf Depends: osmo-mgw.git Change-Id Iba0853ed099a32cf1dde78c17e1b34343db41cfc Change-Id: I0f142e7af180136e8dac142672d38d75a76ef123 --- M TODO-RELEASE M src/osmo-hnbgw/hnbgw.c 2 files changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/07/33307/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0f142e7af180136e8dac142672d38d75a76ef123 Gerrit-Change-Number: 33307 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf
by osmith 14 Jun '23

14 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33305 ) Change subject: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33305 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9d342d2eff7b57b0c542ff0c1c579f708451637c Gerrit-Change-Number: 33305 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:08:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf
by osmith 14 Jun '23

14 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33306 ) Change subject: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I382046bba67646a7365d9290d604b97c9d886e02 Gerrit-Change-Number: 33306 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:05:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: tests: Update *.vty after libosmo-sccp VTY improvements
by pespin 14 Jun '23

14 Jun '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33238 ) Change subject: tests: Update *.vty after libosmo-sccp VTY improvements ...................................................................... tests: Update *.vty after libosmo-sccp VTY improvements After recent change, libosmo-sccp is always printing the "role" config. Depends: libosmo-sccp.git Change-Id Ie81987265118e48173211f88b27a006115dc62d4 Change-Id: I316cd26ceb97f2ccfd1065d65177e7d3926625b0 --- M doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg M tests/config/defaults.vty M tests/config/legacy.vty M tests/config/one_cs7.vty M tests/config/one_cs7_with_addrs.vty M tests/config/one_cs7_with_iucs_addr.vty M tests/config/one_cs7_with_iups_addr.vty M tests/config/two_cs7.vty M tests/config/two_cs7_with_addrs.vty 9 files changed, 23 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg index daf0668..601c02e 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg @@ -2,6 +2,8 @@ point-code 0.3.0 asp asp-clnt-hnbgw-0 2905 0 m3ua remote-ip 127.0.0.1 + role asp + sctp-role client sccp-address my-msc point-code 1.2.3 sccp-address my-sgsn diff --git a/tests/config/defaults.vty b/tests/config/defaults.vty index 35119b1..4f685f8 100644 --- a/tests/config/defaults.vty +++ b/tests/config/defaults.vty @@ -8,6 +8,7 @@ asp asp-clnt-msc-0 2905 0 m3ua local-ip localhost remote-ip localhost + role asp sctp-role client as as-clnt-msc-0 m3ua asp asp-clnt-msc-0 diff --git a/tests/config/legacy.vty b/tests/config/legacy.vty index 4df44a5..2a8b88d 100644 --- a/tests/config/legacy.vty +++ b/tests/config/legacy.vty @@ -7,6 +7,7 @@ asp asp-clnt-msc-0 2905 0 m3ua local-ip localhost remote-ip localhost + role asp sctp-role client as as-clnt-msc-0 m3ua asp asp-clnt-msc-0 diff --git a/tests/config/one_cs7.vty b/tests/config/one_cs7.vty index 7196ef8..0ec8818 100644 --- a/tests/config/one_cs7.vty +++ b/tests/config/one_cs7.vty @@ -6,6 +6,7 @@ asp asp-clnt-msc-0 2905 0 m3ua local-ip localhost remote-ip localhost + role asp sctp-role client as as-clnt-msc-0 m3ua asp asp-clnt-msc-0 diff --git a/tests/config/one_cs7_with_addrs.vty b/tests/config/one_cs7_with_addrs.vty index 4df44a5..2a8b88d 100644 --- a/tests/config/one_cs7_with_addrs.vty +++ b/tests/config/one_cs7_with_addrs.vty @@ -7,6 +7,7 @@ asp asp-clnt-msc-0 2905 0 m3ua local-ip localhost remote-ip localhost + role asp sctp-role client as as-clnt-msc-0 m3ua asp asp-clnt-msc-0 diff --git a/tests/config/one_cs7_with_iucs_addr.vty b/tests/config/one_cs7_with_iucs_addr.vty index f9ee384..bc7b396 100644 --- a/tests/config/one_cs7_with_iucs_addr.vty +++ b/tests/config/one_cs7_with_iucs_addr.vty @@ -6,6 +6,7 @@ asp asp-clnt-msc-0 2905 0 m3ua local-ip localhost remote-ip localhost + role asp sctp-role client as as-clnt-msc-0 m3ua asp asp-clnt-msc-0 diff --git a/tests/config/one_cs7_with_iups_addr.vty b/tests/config/one_cs7_with_iups_addr.vty index 7d66615..b8e1f19 100644 --- a/tests/config/one_cs7_with_iups_addr.vty +++ b/tests/config/one_cs7_with_iups_addr.vty @@ -6,6 +6,7 @@ asp asp-clnt-msc-0 2905 0 m3ua local-ip localhost remote-ip localhost + role asp sctp-role client as as-clnt-msc-0 m3ua asp asp-clnt-msc-0 diff --git a/tests/config/two_cs7.vty b/tests/config/two_cs7.vty index 3d337fa..010cdd3 100644 --- a/tests/config/two_cs7.vty +++ b/tests/config/two_cs7.vty @@ -7,6 +7,7 @@ asp asp-clnt-msc-0 2905 0 m3ua local-ip localhost remote-ip localhost + role asp sctp-role client as as-clnt-msc-0 m3ua asp asp-clnt-msc-0 diff --git a/tests/config/two_cs7_with_addrs.vty b/tests/config/two_cs7_with_addrs.vty index 0fb4b76..08871aa 100644 --- a/tests/config/two_cs7_with_addrs.vty +++ b/tests/config/two_cs7_with_addrs.vty @@ -7,6 +7,7 @@ asp asp-clnt-msc-0 2905 0 m3ua local-ip localhost remote-ip localhost + role asp sctp-role client as as-clnt-msc-0 m3ua asp asp-clnt-msc-0 @@ -19,6 +20,7 @@ asp asp-clnt-sgsn-0 2905 0 m3ua local-ip localhost remote-ip localhost + role asp sctp-role client as as-clnt-sgsn-0 m3ua asp asp-clnt-sgsn-0 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I316cd26ceb97f2ccfd1065d65177e7d3926625b0 Gerrit-Change-Number: 33238 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnbgw[master]: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf
by osmith 14 Jun '23

14 Jun '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33307 ) Change subject: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I thought about TODO-RELEASE, but it already has: libosmo-mgcp-client > 1.11.0 mgcp_client_pool_empty() -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0f142e7af180136e8dac142672d38d75a76ef123 Gerrit-Change-Number: 33307 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:01:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0