lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

June 2023

  • 1 participants
  • 2480 discussions
[M] Change in osmo-gsm-manuals[master]: mgwpool: Document keepalive feature
by pespin 14 Jun '23

14 Jun '23
Attention is currently required from: osmith, laforge, dexter. Hello osmith, Jenkins Builder, laforge, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 to look at the new patch set (#2). Change subject: mgwpool: Document keepalive feature ...................................................................... mgwpool: Document keepalive feature Related: SYS#6481 Change-Id: I2cb4e2098b71b386278eb6026271a6d786a34c2a --- M common/chapters/mgwpool.adoc 1 file changed, 76 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/10/33310/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I2cb4e2098b71b386278eb6026271a6d786a34c2a Gerrit-Change-Number: 33310 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
[M] Change in osmo-gsm-manuals[master]: mgwpool: Document keepalive feature
by pespin 14 Jun '23

14 Jun '23
Attention is currently required from: osmith, laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 ) Change subject: mgwpool: Document keepalive feature ...................................................................... Patch Set 1: (2 comments) File common/chapters/mgwpool.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/4aa6fb02_84ca… PS1, Line 190: Pool > pool what's the problem with pool? https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/4a8e8056_3c28… PS1, Line 190: > break the lines, consistent to the rest of the document? Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I2cb4e2098b71b386278eb6026271a6d786a34c2a Gerrit-Change-Number: 33310 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:24:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-mgw[master]: mgw: Allow auditing speciall 'null' endpoint
by osmith 14 Jun '23

14 Jun '23
Attention is currently required from: laforge, pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33312 ) Change subject: mgw: Allow auditing speciall 'null' endpoint ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia409b16e9211e6261e2e0f21288544289d6f3733 Gerrit-Change-Number: 33312 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:20:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-gsm-manuals[master]: mgwpool: Document keepalive feature
by pespin 14 Jun '23

14 Jun '23
Attention is currently required from: osmith, laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 ) Change subject: mgwpool: Document keepalive feature ...................................................................... Patch Set 1: (1 comment) File common/chapters/mgwpool.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/069d22e2_9c27… PS1, Line 211: NOTE: The `keepalive` feature is disabled by default, and must be explicitly configured in order to enable it. > (just curious, not related to review) why? Because older osmo-mgw versions don't support the "null" endpoint, and they should be configured explicitly using any specific endpoint in order to avoid errors showing up in the log file (the keepalive mechansim would work fine still though). I'd enable it by default after next osmocom CNI release. This way also we leave users willing it to test it further meanwhile, while not forcing it on everybody for now. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I2cb4e2098b71b386278eb6026271a6d786a34c2a Gerrit-Change-Number: 33310 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:19:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotific...
by fixeria 14 Jun '23

14 Jun '23
Attention is currently required from: laforge, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 ) Change subject: RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotification ...................................................................... Patch Set 4: (5 comments) File library/RLCMAC_CSN1_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/334b8a07_81b7… PS1, Line 1030: variant (utran_target_cell) "PRESENCE(arfcn_bsic_presence = '1'B, utran_target_cell_presence = '0'B)" > Is this what you have in mind? I think this is what Pau meant, yes. And I have a proposal: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33314 Feel free to squash this fixup into your patch if you agree with it. File library/RLCMAC_CSN1_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/c06e0fe5_97fb… PS2, Line 948: uint3_t bandwith optional, > > 'bandwith' may be misspelled - perhaps 'bandwidth'? […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/74b8b409_4eb7… PS2, Line 951: variant (bandwith) "PRESENCE(bandwith_presence = '1'B)" > > 'bandwith' may be misspelled - perhaps 'bandwidth'? […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/7965514e_6d0a… PS2, Line 956: uint3_t bandwith optional, > > 'bandwith' may be misspelled - perhaps 'bandwidth'? […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/3b025da9_792f… PS2, Line 960: variant (bandwith) "PRESENCE(bandwith_presence = '1'B)" > > 'bandwith' may be misspelled - perhaps 'bandwidth'? […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e1c63c06fb89111765df187a93db563e77c3fc4 Gerrit-Change-Number: 32995 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:18:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: fixup! RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChange...
by fixeria 14 Jun '23

14 Jun '23
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33314 ) Change subject: fixup! RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotification ...................................................................... fixup! RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotification Change-Id: I86102d3850c83bc29076bd13574547ea9dd12071 --- M library/RLCMAC_CSN1_Templates.ttcn M library/RLCMAC_CSN1_Types.ttcn 2 files changed, 54 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/33314/1 diff --git a/library/RLCMAC_CSN1_Templates.ttcn b/library/RLCMAC_CSN1_Templates.ttcn index 34abb73..000709d 100644 --- a/library/RLCMAC_CSN1_Templates.ttcn +++ b/library/RLCMAC_CSN1_Templates.ttcn @@ -162,11 +162,13 @@ is_dl_tfi := false, tfi := tfi }, - arfcn_bsic_presence := '0'B, - utran_target_cell_presence := omit, - arfcn := arfcn, - bsic := bsic, - utran_target_cell := omit, + u := { + u0 := { + tag := '0'B, + arfcn := arfcn, + bsic := bsic + } + }, ba_psi3_presence := '0'B, ba_used := '0'B, psi3_change_mark := omit, diff --git a/library/RLCMAC_CSN1_Types.ttcn b/library/RLCMAC_CSN1_Types.ttcn index 23ae94c..7e1eaae 100644 --- a/library/RLCMAC_CSN1_Types.ttcn +++ b/library/RLCMAC_CSN1_Types.ttcn @@ -1015,16 +1015,47 @@ variant (utran_ba_used) "PRESENCE(utran_ba_used_presence = '1'B)" }; + private type record PktCellChgNotifyU0 { + BIT1 tag ('0'B), + uint10_t arfcn, + uint6_t bsic + } with { variant "" }; + private type record PktCellChgNotifyU10 { + BIT2 tag ('10'B), + UtranTargetCell utran_target_cell + } with { variant "" }; + private type record PktCellChgNotifyU110 { + BIT3 tag ('110'B), + BIT1 arfcn_bsic_presence, + uint10_t arfcn optional, + uint6_t bsic optional, + BIT1 utran_target_cell_presence, + UtranTargetCell utran_target_cell optional, + /* TODO: { 0 | 1 E-UTRAN Target Cell } */ + BIT1 eutran_target_cell_presence ('0'B), + /* TODO: { 0 | 1 E-UTRAN CCN Measurement Report } */ + BIT1 eutran_ccn_meas_rep_presence ('0'B) + } with { + variant (arfcn) "PRESENCE(arfcn_bsic_presence = '1'B)" + variant (bsic) "PRESENCE(arfcn_bsic_presence = '1'B)" + variant (utran_target_cell) "PRESENCE(utran_target_cell_presence = '1'B)" + }; + private type union PktCellChgNotifyUnion { + PktCellChgNotifyU0 u0, + PktCellChgNotifyU10 u10, /* Rel-6 additions */ + PktCellChgNotifyU110 u110 /* Rel-8 additions */ + /* TODO: PktCellChgNotifyU1110 Rel-9 additions */ + /* TODO: Message escape : { 1111 } bit (*) = <no string> > */ + } with { + variant "TAG(u0, tag = '0'B; + u10, tag = '10'B; + u110, tag = '110'B)" + }; + /* 11.2.3a Packet Cell Change Notification, message body */ type record PacketCellChangeNotification { GlobalTfi gtfi, - /* TODO: support 3g/4g in these bits */ - BIT1 arfcn_bsic_presence, - BIT1 utran_target_cell_presence optional, /* Rel-6 addition */ - uint10_t arfcn optional, - uint6_t bsic optional, - UtranTargetCell utran_target_cell optional, /* Rel-6 addition */ - /* TODO: Rel-8 addition */ + PktCellChgNotifyUnion u, BIT1 ba_psi3_presence, BIT1 ba_used optional, BIT2 psi3_change_mark optional, @@ -1034,13 +1065,6 @@ /* Rel-Additions (Matrioshka) */ PktCellChgNotifAdditions rel_additions optional } with { - variant (arfcn) "PRESENCE(arfcn_bsic_presence = '0'B)" - variant (bsic) "PRESENCE(arfcn_bsic_presence = '0'B)" - - /* Rel-6 addition */ - variant (utran_target_cell_presence) "PRESENCE(arfcn_bsic_presence = '1'B)" - variant (utran_target_cell) "PRESENCE(arfcn_bsic_presence = '1'B, utran_target_cell_presence = '0'B)" - variant (ba_used) "PRESENCE(ba_psi3_presence = '0'B)" variant (psi3_change_mark) "PRESENCE(ba_psi3_presence = '1'B)" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I86102d3850c83bc29076bd13574547ea9dd12071 Gerrit-Change-Number: 33314 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotific...
by fixeria 14 Jun '23

14 Jun '23
Attention is currently required from: fixeria, pespin, dexter. fixeria has uploaded a new patch set (#4) to the change originally created by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 ) Change subject: RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotification ...................................................................... RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotification The PacketCellChangeNotification type currently lacks the release 6 additions. Those basically add 3G compatibility to the PacketCellChangeNotification message type. Spec reference: 3gpp TS 44.060 11.2.3a Related: OS#6044 Change-Id: I4e1c63c06fb89111765df187a93db563e77c3fc4 --- M library/RLCMAC_CSN1_Templates.ttcn M library/RLCMAC_CSN1_Types.ttcn 2 files changed, 91 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/32995/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e1c63c06fb89111765df187a93db563e77c3fc4 Gerrit-Change-Number: 32995 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
[M] Change in osmo-mgw[master]: mgcp-client: Move some static functions further above
by osmith 14 Jun '23

14 Jun '23
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33311 ) Change subject: mgcp-client: Move some static functions further above ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3a00d8c47ec773390d9626364c4c75ca579f1508 Gerrit-Change-Number: 33311 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:15:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-gsm-manuals[master]: mgwpool: Document keepalive feature
by osmith 14 Jun '23

14 Jun '23
Attention is currently required from: laforge, pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 ) Change subject: mgwpool: Document keepalive feature ...................................................................... Patch Set 1: (4 comments) Patchset: PS1: LGTM besides line breaks File common/chapters/mgwpool.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/d5c43a0d_ac71… PS1, Line 190: break the lines, consistent to the rest of the document? https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/fdc0a719_22ca… PS1, Line 190: Pool pool https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/bf82a9de_5314… PS1, Line 211: NOTE: The `keepalive` feature is disabled by default, and must be explicitly configured in order to enable it. (just curious, not related to review) why? -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I2cb4e2098b71b386278eb6026271a6d786a34c2a Gerrit-Change-Number: 33310 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:14:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotific...
by Jenkins Builder 14 Jun '23

14 Jun '23
Attention is currently required from: fixeria, pespin, dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 ) Change subject: RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotification ...................................................................... Patch Set 3: (4 comments) File library/RLCMAC_CSN1_Types.ttcn: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8284): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/714620d6_2ce4… PS3, Line 948: uint3_t bandwith optional, 'bandwith' may be misspelled - perhaps 'bandwidth'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8284): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/6ad36f8b_1c70… PS3, Line 951: variant (bandwith) "PRESENCE(bandwith_presence = '1'B)" 'bandwith' may be misspelled - perhaps 'bandwidth'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8284): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/4d574721_1ee6… PS3, Line 956: uint3_t bandwith optional, 'bandwith' may be misspelled - perhaps 'bandwidth'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8284): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/68526617_1539… PS3, Line 960: variant (bandwith) "PRESENCE(bandwith_presence = '1'B)" 'bandwith' may be misspelled - perhaps 'bandwidth'? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e1c63c06fb89111765df187a93db563e77c3fc4 Gerrit-Change-Number: 32995 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jun 2023 12:12:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 122
  • 123
  • 124
  • 125
  • 126
  • 127
  • 128
  • ...
  • 248
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.