Attention is currently required from: osmith, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310 )
Change subject: mgwpool: Document keepalive feature
......................................................................
Patch Set 2:
(1 comment)
File common/chapters/mgwpool.adoc:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310/comment/de9f36b6_43de…
PS1, Line 190: Pool
> elsewhere in the document it is MGW pool with lowercase p. Not that important.
I wrote it with cap letter since I was referring to the feature, not just some/any pool.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/33310
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I2cb4e2098b71b386278eb6026271a6d786a34c2a
Gerrit-Change-Number: 33310
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Jun 2023 13:40:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/33315 )
Change subject: hnb-test.c: Update to libosmocore osmo_auth_gen_vec2
......................................................................
hnb-test.c: Update to libosmocore osmo_auth_gen_vec2
libosmogsm has recently deprecated the use of osmo_auth_gen_vec
and the osmo_sub_auth_data structure in favor of newer versions
of this API. Let's migrate to it
Change-Id: I8646caf14783833c4ebea041339c3056e4ac2dea
Depends: libosmocore.git Ie775fedba4a3fa12314c0f7c8a369662ef6a40df
---
M TODO-RELEASE
M tests/hnb-test.c
2 files changed, 17 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/15/33315/1
diff --git a/TODO-RELEASE b/TODO-RELEASE
index d0852fc..00cb753 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,3 +7,4 @@
# If any interfaces have been added since the last public release: c:r:a + 1.
# If any interfaces have been removed or changed since the last public release: c:r:0.
#library what description / commit summary line
+libosmogsm update version dependency depend on libosmogsm >= Change-Id Ie775fedba4a3fa12314c0f7c8a369662ef6a40df
diff --git a/tests/hnb-test.c b/tests/hnb-test.c
index de75186..bfccf5a 100644
--- a/tests/hnb-test.c
+++ b/tests/hnb-test.c
@@ -340,7 +340,7 @@
/* Generate SRES from *HARDCODED* Ki for Iuh testing */
struct osmo_auth_vector vec;
/* Ki 000102030405060708090a0b0c0d0e0f */
- struct osmo_sub_auth_data auth = {
+ struct osmo_sub_auth_data2 auth = {
.type = OSMO_AUTH_TYPE_GSM,
.algo = OSMO_AUTH_ALG_COMP128v1,
.u.gsm.ki = {
@@ -351,7 +351,7 @@
};
memset(&vec, 0, sizeof(vec));
- osmo_auth_gen_vec(&vec, &auth, ar->rand);
+ osmo_auth_gen_vec2(&vec, &auth, ar->rand);
printf("seq %d rand %s",
seq, osmo_hexdump(ar->rand, sizeof(ar->rand)));
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/33315
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I8646caf14783833c4ebea041339c3056e4ac2dea
Gerrit-Change-Number: 33315
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33097 )
Change subject: Port to new libosmogsm 'struct osmo_sub_auth_data2'
......................................................................
Patch Set 3:
(2 comments)
File include/osmocom/hlr/db.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/cb81afa1_f4b73297
PS2, Line 124: /* Like struct osmo_sub_auth_data2, but the keys are in hexdump representation.
> intentional rename? is sub_auth_data_str also used for osmo_sub_auth_data2?
yes. Since after this patch the code is now only using sub_auth_data2, there is no usage of osmo_sub_auth_data left, and hence the comment would refer to an unused struct type if it's not changed here.
File src/db_hlr.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/96f03b91_4e930295
PS2, Line 289: if (!osmo_is_hexstr(aud->u.umts.k, 32, 64, true)) {
> (this patch intends no change of length, right?)
you are correct, this belongs into Ibbde68484c904507a15c35cbfdf88cd47d0c7039
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33097
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I3207c7bfb73e9ff5471e5c26b66639549e4d48a2
Gerrit-Change-Number: 33097
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Jun 2023 13:04:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, fixeria, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33098 )
Change subject: db: extend database schema to support 256bit K and/or OP[c] values
......................................................................
Patch Set 4:
(4 comments)
File src/db.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/33098/comment/45910aef_7cf57744
PS4, Line 550: 6
> Another approach to ensure the correct version is printed is the logging might be: […]
Done
File src/hlr_vty_subscr.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/33098/comment/25dd023a_2052f46b
PS4, Line 479: * below for real 3G AKA algorithms. */
> (120 line width)
I don't think its *mandatory* that we use that line length. We just permit it up to 120? Also, 118 is cutting it really close. Most classic 80-character line-wraps are IMHO done at 72, for example. But I changed it .
https://gerrit.osmocom.org/c/osmo-hlr/+/33098/comment/92675ee7_bf696abe
PS4, Line 510: *maxlen_opc = MILENAGE_KEY_LEN;
> will there ever be minlen_opc < maxlen_opc?
we don't know what future 3GPP algorithms come up with. TS 33.102 doesn't state any constraint for OP/OPc value length, only for K/RAND/SQN/AK/AMF/CK/IK/RES.
For TUAK, TOP[c] is fixed at 32 bytes, for MILENAGE its fixed at 16 bytes.
It was easy enough to prepare the function for situations where it may not be a fixed single valid length value.
https://gerrit.osmocom.org/c/osmo-hlr/+/33098/comment/18f963ba_84930936
PS4, Line 703: vty_out(vty, "%% Unknown auth algorithm: '%s'%s", "xor", VTY_NEWLINE);
> this change looks non-related?
indeed. no idea how this happeend. I guess some rebase artefact.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33098
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ibbde68484c904507a15c35cbfdf88cd47d0c7039
Gerrit-Change-Number: 33098
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Jun 2023 13:03:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, laforge, pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hlr/+/33098
to look at the new patch set (#5).
Change subject: db: extend database schema to support 256bit K and/or OP[c] values
......................................................................
db: extend database schema to support 256bit K and/or OP[c] values
Other UMTS AKA algorithms than MILENAGE (notably TUAK) support K sizes
of up to 256bit, or mandate a OP/OPc size of 256 bit.
Let's extend our database schema to accommodate such larger sizes.
Change-Id: Ibbde68484c904507a15c35cbfdf88cd47d0c7039
---
M sql/hlr.sql
M src/ctrl.c
M src/db.c
M src/db_hlr.c
M src/hlr_vty_subscr.c
M tests/db_upgrade/db_upgrade_test.ok
M tests/test_subscriber.vty
7 files changed, 96 insertions(+), 31 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/98/33098/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33098
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ibbde68484c904507a15c35cbfdf88cd47d0c7039
Gerrit-Change-Number: 33098
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge.
Hello Jenkins Builder, neels, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hlr/+/33097
to look at the new patch set (#3).
Change subject: Port to new libosmogsm 'struct osmo_sub_auth_data2'
......................................................................
Port to new libosmogsm 'struct osmo_sub_auth_data2'
libosmogsm has recently introdcued a 'struct osmo_sub_auth_data2' as
successor to 'struct osmo_sub_auth_data', together with updated
osmo_auth_gen_vec2/osmo_auth_gen_vec_auts2 API.
The rationale of this new API is to enable
* support for AKA algorithms which use K and/or OP[c] values of 256bit
(instead of the classic 128bit)
* support for RES length sizes of 4 and 16 bytes (instead of the classic
8 bytes)
This commit just jumps over to the new API without adding any related
functionality to osmo-hlr. The latter is left for subsequent commits.
Change-Id: I3207c7bfb73e9ff5471e5c26b66639549e4d48a2
Depends: libosmocore.git Ie775fedba4a3fa12314c0f7c8a369662ef6a40df
---
M TODO-RELEASE
M include/osmocom/hlr/auc.h
M include/osmocom/hlr/db.h
M src/auc.c
M src/ctrl.c
M src/db_auc.c
M src/hlr.c
M src/hlr_vty_subscr.c
M tests/auc/auc_test.c
M tests/auc/gen_ts_55_205_test_sets/func_template.c
M tests/db/db_test.c
M tests/db/db_test.err
12 files changed, 191 insertions(+), 134 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/97/33097/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33097
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I3207c7bfb73e9ff5471e5c26b66639549e4d48a2
Gerrit-Change-Number: 33097
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33314 )
Change subject: fixup! RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotification
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I guess this should be merged in the previous commit?
ack.
> the fixup was probably not intended for the subject line, but rebase -i?
I submitted it for dexter, so that he can cherry-pick it and squash into his patch.
This one should be abandoned after squashing.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33314
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I86102d3850c83bc29076bd13574547ea9dd12071
Gerrit-Change-Number: 33314
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 14 Jun 2023 12:54:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment