Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32432 )
Change subject: jobs/master,gerrit: use PFCP var for osmo-hnbgw
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32432
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I4a4e25e0c179c0d408c3728a28eb75bbfa086f48
Gerrit-Change-Number: 32432
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Apr 2023 11:40:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 )
Change subject: contrib/jenkins.sh: add PFCP variable
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> it may be the one set by jenkins, but it's not really the default set of flags we want/do build with […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Iacc6a0267d4896d0149f5e00d77951cdfc281e4e
Gerrit-Change-Number: 32430
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Apr 2023 11:40:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmocom-bb/+/32427
to look at the new patch set (#2).
Change subject: layer23: Decouple SIM events from MMR events
......................................................................
layer23: Decouple SIM events from MMR events
let the specific app handle the events generated from the
subscriber/SIM.
All the MMR specific code can for now stay in mobile/ while SIM support
can be in common/ without violating layers (common/ calling functions in
mobile/).
Change-Id: I473887e0fd9338d76a69a9774145a04575f14b64
---
M src/host/layer23/include/osmocom/bb/common/osmocom_data.h
M src/host/layer23/src/common/subscriber.c
M src/host/layer23/src/mobile/app_mobile.c
3 files changed, 91 insertions(+), 53 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/27/32427/2
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32427
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I473887e0fd9338d76a69a9774145a04575f14b64
Gerrit-Change-Number: 32427
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32431 )
Change subject: layer23: Call telnet_exit() during app exit if VTY support is enabled
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32431
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ic8540c73b1b13134e11f254beb6a16f7e4452317
Gerrit-Change-Number: 32431
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Apr 2023 11:37:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 )
Change subject: contrib/jenkins.sh: add PFCP variable
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> The variable is always set by jenkins. I'd rather leave it as-is, as it's the same logic used in e. […]
it may be the one set by jenkins, but it's not really the default set of flags we want/do build with. I'd expect if I run "./jenkins.sh" myself I'd run the most usual set of flags.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Iacc6a0267d4896d0149f5e00d77951cdfc281e4e
Gerrit-Change-Number: 32430
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Apr 2023 11:35:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32434 )
Change subject: publish-manuals-for-tags: enable IU/PFCP VTY cmds
......................................................................
Patch Set 2:
(1 comment)
File scripts/manuals/publish-manuals-for-tags.sh:
https://gerrit.osmocom.org/c/osmo-ci/+/32434/comment/c1ab5568_c36cb159
PS1, Line 220: osmo-hnbgw)
> imho this should be the defaults, so no need to do this here.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32434
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I9685857348e3b38f13acc1429c7a49fb9e5d92f3
Gerrit-Change-Number: 32434
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Apr 2023 11:27:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment