April 2023 - gerrit-log - lists.osmocom.org

[L] Change in libosmo-abis[master]: e1d: reconnect to osmo-e1d after connection loss

by dexter

Attention is currently required from: laforge, keith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32374 ) Change subject: e1d: reconnect to osmo-e1d after connection loss ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > I don't have the full picture nor the time right now (on holidays) to investigate fully. […] I think for the Keith's specific application it would be better to use the DAHDI driver. I wasn't aware of that this would be the preferred solution for applications that use libosmo-abis. In its current state the API requires the API user to keep track of the file descriptors and close them if necessary. I would say its probably the better option to merge this patch as it is. It is definitely an improvement and we can split it off later if we really need to. As far as I can see osmo-e1d-pipe is currently the only other application that uses osmo-e1d directly through its proto_clnt.h API. e1d-ts-pipe.c:ts_fd_cb() would exit if there is a problem accessing a file descriptor of the TS, so this would at least not hang with 100% CPU usage. I wonder if there is other software like this. The manual suggests that an application should go via libosmo-abis. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iaf4d42c2f009b1d7666e319fabdeb2598aa0b338 Gerrit-Change-Number: 32374 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 25 Apr 2023 12:26:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: keith <keith(a)rhizomatica.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: modem: Set on tun the IP address received during PDP Ctx Act...

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32414 ) Change subject: layer23: modem: Set on tun the IP address received during PDP Ctx Act Accept ...................................................................... Patch Set 1: (2 comments) File src/host/layer23/src/modem/sm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32414/comment/740fa658_836b5a11 PS1, Line 70: get_value_string(gsm48_gsm_cause_names, sm_prim->smreg.pdp_act_cnf.rej.cause)); missing return? https://gerrit.osmocom.org/c/osmocom-bb/+/32414/comment/2718c898_f033a960 PS1, Line 86: [FIXME: IPv6 not yet supported! with this you mean elsewhere in the osmocom-bb code, I guess? just asking to be sure because you do set the v6 address below -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I39c27caeff0ccd08d8d8b5fcba5a1d69238d53ca Gerrit-Change-Number: 32414 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 12:12:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-bsc[master]: ctrl: Add cell reselection offset control

by matanp

Attention is currently required from: pespin. matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32425 ) Change subject: ctrl: Add cell reselection offset control ...................................................................... Patch Set 2: (3 comments) File src/osmo-bsc/bts_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/30f41571_073afd98 PS1, Line 721: cmd->reply = talloc_asprintf(cmd, "%u", bts->si_common.cell_ro_sel_par.cell_resel_off*2); > space between " * " Ack https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/12882b27_aa6fe0af PS1, Line 723: cmd->reply = "OOM."; > I think we never put a dot in replies? Will be removed. I copied this line from `get_bts_rf_states` I will make another PR that removes the dot from there too https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/75d10cfb_ee9a147e PS1, Line 734: bts->si_common.cell_ro_sel_par.cell_resel_off = atoi(cmd->value)/2; > space between " / " Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I159bbe14e71dbf1e1add60b57b0b2e03d3146682 Gerrit-Change-Number: 32425 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 12:01:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-bsc[master]: ctrl: Add cell reselection offset control

by matanp

Attention is currently required from: matanp. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/32425 to look at the new patch set (#2). Change subject: ctrl: Add cell reselection offset control ...................................................................... ctrl: Add cell reselection offset control Change-Id: I159bbe14e71dbf1e1add60b57b0b2e03d3146682 --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 53 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/25/32425/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I159bbe14e71dbf1e1add60b57b0b2e03d3146682 Gerrit-Change-Number: 32425 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: Use GSM23003_IMEI(SV)_NUM_DIGITS from libosmocore

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32437 ) Change subject: layer23: Use GSM23003_IMEI(SV)_NUM_DIGITS from libosmocore ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I12a96043947c0f5366f550944a4df5edd2fd2c9d Gerrit-Change-Number: 32437 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 11:59:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: Use OSMO_IMSI_BUF_SIZE from libosmocore

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32436 ) Change subject: layer23: Use OSMO_IMSI_BUF_SIZE from libosmocore ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/32436/comment/366cd0c7_38942382 PS3, Line 8: I'd mention here that GSM_IMSI_LENGTH was 16, and OSMO_IMSI_BUF_SIZE is 17: ``` include/osmocom/gsm/protocol/gsm_23_003.h:#define GSM23003_IMSI_MAX_DIGITS 15 include/osmocom/gsm/protocol/gsm_23_003.h:#define OSMO_IMSI_BUF_SIZE (GSM23003_IMSI_MAX_DIGITS+2) ``` File src/host/layer23/src/common/subscriber.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32436/comment/fc0090d4_0729e360 PS3, Line 232: strlen(imsi) - 1 > OSMO_IMSI_BUF_SIZE - 1 is this still correct? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I295444bb3b75ed236ea4af5563d9a9c9e590cab7 Gerrit-Change-Number: 32436 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 11:57:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: Use GSM_RESERVED_TMSI from libosmocore everywhere

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32435 ) Change subject: layer23: Use GSM_RESERVED_TMSI from libosmocore everywhere ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib9483b8ae4067994aef523291733ae706ffabe7a Gerrit-Change-Number: 32435 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 11:53:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: Decouple SIM events from MMR events

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32427 ) Change subject: layer23: Decouple SIM events from MMR events ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I473887e0fd9338d76a69a9774145a04575f14b64 Gerrit-Change-Number: 32427 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 11:52:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-ci[master]: publish-manuals-for-tags: enable IU/PFCP VTY cmds

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32434 ) Change subject: publish-manuals-for-tags: enable IU/PFCP VTY cmds ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: patchset 3 is the same as 1, as discussed in chat. --enable-pfcp and --enable-iu are not the default in configure.ac. I misunderstood you and thought you wanted me to add it per default for all calls to ./configure for all projects. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9685857348e3b38f13acc1429c7a49fb9e5d92f3 Gerrit-Change-Number: 32434 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 11:49:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-ci[master]: publish-manuals-for-tags: enable IU/PFCP VTY cmds

by osmith

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/32434 to look at the new patch set (#3). Change subject: publish-manuals-for-tags: enable IU/PFCP VTY cmds ...................................................................... publish-manuals-for-tags: enable IU/PFCP VTY cmds Enable configure options to build manuals with all VTY commands in the script that builds manuals for tagged releases. Related: OS#6013 Change-Id: I9685857348e3b38f13acc1429c7a49fb9e5d92f3 --- M scripts/manuals/publish-manuals-for-tags.sh 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/34/32434/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9685857348e3b38f13acc1429c7a49fb9e5d92f3 Gerrit-Change-Number: 32434 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023