April 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: e1d: fix logic to detect if a timeslot is in use

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/32402 to look at the new patch set (#2). Change subject: e1d: fix logic to detect if a timeslot is in use ...................................................................... e1d: fix logic to detect if a timeslot is in use When we check bfd->fd, we also treat 0 as "not in use". This is not correct since 0 is a valid file descriptor (STDIN). Since we reliably initialize the file descriptor numbers to -1 on startup we can fix this. So let's treat all positive file descriptor numbers, including zero as an open timeslot. Change-Id: I67bc5ca25620ff96441391798f761144570c8306 Related: OS#5983 --- M src/input/e1d.c 1 file changed, 23 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/02/32402/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I67bc5ca25620ff96441391798f761144570c8306 Gerrit-Change-Number: 32402 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: modem: Set on tun the IP address received during PDP Ctx Act...

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32414 ) Change subject: layer23: modem: Set on tun the IP address received during PDP Ctx Act Accept ...................................................................... Patch Set 1: (2 comments) File src/host/layer23/src/modem/sm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32414/comment/81d3a787_3d430a92 PS1, Line 70: get_value_string(gsm48_gsm_cause_names, sm_prim->smreg.pdp_act_cnf.rej.cause)); > missing return? Ack https://gerrit.osmocom.org/c/osmocom-bb/+/32414/comment/76b15acc_f5fd687a PS1, Line 86: [FIXME: IPv6 not yet supported! > with this you mean elsewhere in the osmocom-bb code, I guess? just asking to be sure because you do […] IPv6 it's a bit more complex than just setting the IP address, since the address provided here is a locallink one only used to start SLACC procedure, which is something that will be left for later for sure, at least until we have IPv4 fully working. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I39c27caeff0ccd08d8d8b5fcba5a1d69238d53ca Gerrit-Change-Number: 32414 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 12:41:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-bsc[master]: ctrl: Add cell reselection offset control

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32425 ) Change subject: ctrl: Add cell reselection offset control ...................................................................... ctrl: Add cell reselection offset control Change-Id: I159bbe14e71dbf1e1add60b57b0b2e03d3146682 --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 53 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 4b4b1fb..f19a7e2 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -694,6 +694,49 @@ /* TODO: si2quater neighbor management: add EARFCN */ /* TODO: si2quater neighbor management: add UARFCN */ +static int verify_bts_cell_reselection_offset(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + const int cell_reselection_offset = atoi(value); + + if (cell_reselection_offset < 0 || cell_reselection_offset > 126) { + cmd->reply = "Value is out of range"; + return 1; + } else if (cell_reselection_offset % 2 != 0) { + cmd->reply = "Value must be even"; + return 1; + } + + return 0; +} + +static int get_bts_cell_reselection_offset(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + + if (!bts->si_common.cell_ro_sel_par.present) { + cmd->reply = "0"; + return CTRL_CMD_REPLY; + } + + cmd->reply = talloc_asprintf(cmd, "%u", bts->si_common.cell_ro_sel_par.cell_resel_off * 2); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + + return CTRL_CMD_REPLY; +} + +static int set_bts_cell_reselection_offset(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + bts->si_common.cell_ro_sel_par.present = 1; + bts->si_common.cell_ro_sel_par.cell_resel_off = atoi(cmd->value) / 2; + return CTRL_CMD_REPLY; +} + +CTRL_CMD_DEFINE(bts_cell_reselection_offset, "cell-reselection-offset"); + int bsc_bts_ctrl_cmds_install(void) { int rc = 0; @@ -716,6 +759,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_mode); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_del_earfcn); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_del_uarfcn); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_cell_reselection_offset); rc |= neighbor_ident_ctrl_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I159bbe14e71dbf1e1add60b57b0b2e03d3146682 Gerrit-Change-Number: 32425 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[M] Change in osmo-bsc[master]: ctrl: Add cell reselection offset control

by pespin

Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32425 ) Change subject: ctrl: Add cell reselection offset control ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I159bbe14e71dbf1e1add60b57b0b2e03d3146682 Gerrit-Change-Number: 32425 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 12:39:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Fix typo triggering assert on T3310 timeout

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32438 ) Change subject: gmm: Fix typo triggering assert on T3310 timeout ...................................................................... gmm: Fix typo triggering assert on T3310 timeout Change-Id: Iee803dcfa9e629852aac6246b403e7614245a0b9 --- M src/gmm/gmm_ms_fsm.c 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gmm/gmm_ms_fsm.c b/src/gmm/gmm_ms_fsm.c index 902a86f..93dd397 100644 --- a/src/gmm/gmm_ms_fsm.c +++ b/src/gmm/gmm_ms_fsm.c @@ -50,8 +50,8 @@ OSMO_ASSERT(ctx->fi->state == GPRS_GMM_MS_ST_REGISTERED_INITIATED); - /* Rearm T3110 */ - OSMO_ASSERT(ctx->fi->T == 3110); + /* Rearm T3310 */ + OSMO_ASSERT(ctx->fi->T == 3310); val_sec = osmo_tdef_get(g_gmm_ctx->T_defs, ctx->fi->T, OSMO_TDEF_S, -1); osmo_timer_schedule(&ctx->fi->timer, val_sec, 0); return gprs_gmm_tx_att_req(ctx->gmme, -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iee803dcfa9e629852aac6246b403e7614245a0b9 Gerrit-Change-Number: 32438 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in osmo-ci[master]: publish-manuals-for-tags: enable IU/PFCP VTY cmds

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32434 ) Change subject: publish-manuals-for-tags: enable IU/PFCP VTY cmds ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9685857348e3b38f13acc1429c7a49fb9e5d92f3 Gerrit-Change-Number: 32434 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 12:38:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: contrib/jenkins.sh: add PFCP variable

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 ) Change subject: contrib/jenkins.sh: add PFCP variable ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iacc6a0267d4896d0149f5e00d77951cdfc281e4e Gerrit-Change-Number: 32430 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 12:37:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Fix typo triggering assert on T3310 timeout

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32438 ) Change subject: gmm: Fix typo triggering assert on T3310 timeout ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I just hit this one, +2 myself since it's trivial and clear. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iee803dcfa9e629852aac6246b403e7614245a0b9 Gerrit-Change-Number: 32438 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 25 Apr 2023 12:36:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Fix typo triggering assert on T3310 timeout

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32438 ) Change subject: gmm: Fix typo triggering assert on T3310 timeout ...................................................................... gmm: Fix typo triggering assert on T3310 timeout Change-Id: Iee803dcfa9e629852aac6246b403e7614245a0b9 --- M src/gmm/gmm_ms_fsm.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/38/32438/1 diff --git a/src/gmm/gmm_ms_fsm.c b/src/gmm/gmm_ms_fsm.c index 902a86f..93dd397 100644 --- a/src/gmm/gmm_ms_fsm.c +++ b/src/gmm/gmm_ms_fsm.c @@ -50,8 +50,8 @@ OSMO_ASSERT(ctx->fi->state == GPRS_GMM_MS_ST_REGISTERED_INITIATED); - /* Rearm T3110 */ - OSMO_ASSERT(ctx->fi->T == 3110); + /* Rearm T3310 */ + OSMO_ASSERT(ctx->fi->T == 3310); val_sec = osmo_tdef_get(g_gmm_ctx->T_defs, ctx->fi->T, OSMO_TDEF_S, -1); osmo_timer_schedule(&ctx->fi->timer, val_sec, 0); return gprs_gmm_tx_att_req(ctx->gmme, -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iee803dcfa9e629852aac6246b403e7614245a0b9 Gerrit-Change-Number: 32438 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in libosmo-abis[master]: e1_input: add new driver callback function: line_create

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32400 ) Change subject: e1_input: add new driver callback function: line_create ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > where is this callback being set and used btw? It is used in a follow up patch (I2de8fccad56279748ed9cc035aebf4e2d3935172). Pre-initialize the file descriptors in the osmo-e1d driver with -1. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I404fa23e9b8a952be84e9716889c0dbbbc665d22 Gerrit-Change-Number: 32400 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 12:29:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023