April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: publish-manuals-for-tags: enable IU/PFCP VTY cmds

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/32434 ) Change subject: publish-manuals-for-tags: enable IU/PFCP VTY cmds ...................................................................... publish-manuals-for-tags: enable IU/PFCP VTY cmds Enable configure options to build manuals with all VTY commands in the script that builds manuals for tagged releases. Related: OS#6013 Change-Id: I9685857348e3b38f13acc1429c7a49fb9e5d92f3 --- M scripts/manuals/publish-manuals-for-tags.sh 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/34/32434/1 diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index b40b602..99e117c 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -213,6 +213,19 @@ fi } +# Additional configure options to use, so manuals include all VTY commands +# $1: repo name +get_configure_opts_from_repo_name() { + case "$1" in + osmo-hnbgw) + echo "--enable-pfcp" + ;; + osmo-msc|osmo-sgsn) + echo "--enable-iu" + ;; + esac +} + # $1: docs dir get_repo_name_from_docs_dir() { case "$1" in @@ -323,6 +336,7 @@ build_publish_manuals() { local repo="$1" local tag="$2" + local configure_opts="--enable-manuals $(get_configure_opts_from_repo_name "$repo")" echo "$LOG_PREFIX Building manuals" if ! docker run \ @@ -361,7 +375,7 @@ ;; *) su build -c \"autoreconf -fi\" - su build -c \"./configure --enable-manuals\" + su build -c \"./configure $configure_opts\" su build -c \"make -j$(nproc)\" ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9685857348e3b38f13acc1429c7a49fb9e5d92f3 Gerrit-Change-Number: 32434 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/master,gerrit: build manuals with IU

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/32433 ) Change subject: jobs/master,gerrit: build manuals with IU ...................................................................... jobs/master,gerrit: build manuals with IU Build the manuals with --enable-iu for osmo-msc and osmo-sgsn, so we don't miss IU-related VTY commands in the manuals. As of writing, osmo-sgsn includes cs7-instance-iu only if building with --enable-iu. osmo-msc includes it regardless of the build flag (and returns an error if trying to use the command if built without IU support). Build the manuals with --enable-iu for both for consistency, and just in case we decide to change this behavior / add more commands. Related: OS#6013 Change-Id: Ib9c47796b582add90ef72376b4c0368a29d89b15 --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 27 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/33/32433/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 537e335..ff933bc 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -242,8 +242,8 @@ a2_name: WITH_MANUALS a2: !!python/tuple ["1", "0"] combination_filter: > - (IU == "--enable-iu" && WITH_MANUALS == "0") || - (IU == "--disable-iu" && WITH_MANUALS == "1") + (IU == "--enable-iu" && WITH_MANUALS == "1") || + (IU == "--disable-iu" && WITH_MANUALS == "0") cmd: | {docker_run_ccache} \ -e IU="$IU" \ @@ -293,8 +293,8 @@ a2_name: WITH_MANUALS a2: !!python/tuple ["1", "0"] combination_filter: > - (IU == "--enable-iu" && WITH_MANUALS == "0") || - (IU == "--disable-iu" && WITH_MANUALS == "1") + (IU == "--enable-iu" && WITH_MANUALS == "1") || + (IU == "--disable-iu" && WITH_MANUALS == "0") cmd: | {docker_run_ccache} \ -e IU="$IU" \ diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 0953c0d..eac33b6 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -350,8 +350,8 @@ a2_name: WITH_MANUALS a2: !!python/tuple ["1", "0"] combination_filter: > - (IU == "--enable-iu" && WITH_MANUALS == "0") || - (IU == "--disable-iu" && WITH_MANUALS == "1") + (IU == "--enable-iu" && WITH_MANUALS == "1") || + (IU == "--disable-iu" && WITH_MANUALS == "0") cmd: | {docker_run_ccache} \ -e IU="$IU" \ @@ -395,8 +395,8 @@ a2_name: WITH_MANUALS a2: !!python/tuple ["1", "0"] combination_filter: > - (IU == "--enable-iu" && WITH_MANUALS == "0") || - (IU == "--disable-iu" && WITH_MANUALS == "1") + (IU == "--enable-iu" && WITH_MANUALS == "1") || + (IU == "--disable-iu" && WITH_MANUALS == "0") cmd: | {docker_run_ccache} \ -e IU="$IU" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib9c47796b582add90ef72376b4c0368a29d89b15 Gerrit-Change-Number: 32433 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: Call telnet_exit() during app exit if VTY support is enabled

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32431 ) Change subject: layer23: Call telnet_exit() during app exit if VTY support is enabled ...................................................................... layer23: Call telnet_exit() during app exit if VTY support is enabled Change-Id: Ic8540c73b1b13134e11f254beb6a16f7e4452317 --- M src/host/layer23/src/common/main.c M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/main.c 3 files changed, 18 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/31/32431/1 diff --git a/src/host/layer23/src/common/main.c b/src/host/layer23/src/common/main.c index 567b2e0..a4b9441 100644 --- a/src/host/layer23/src/common/main.c +++ b/src/host/layer23/src/common/main.c @@ -186,6 +186,9 @@ if (l23_app_exit) rc = l23_app_exit(); + if (l23_app_info.opt_supported & L23_OPT_VTY) + telnet_exit(); + if (rc != -EBUSY) exit (0); } diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c index d91425b..119e9e4 100644 --- a/src/host/layer23/src/mobile/app_mobile.c +++ b/src/host/layer23/src/mobile/app_mobile.c @@ -481,8 +481,6 @@ osmo_gps_close(); - telnet_exit(); - return 0; } diff --git a/src/host/layer23/src/mobile/main.c b/src/host/layer23/src/mobile/main.c index 11ffd95..71a16c1 100644 --- a/src/host/layer23/src/mobile/main.c +++ b/src/host/layer23/src/mobile/main.c @@ -339,7 +339,12 @@ osmo_select_main(0); } - l23_app_exit(); + if (l23_app_exit) + rc = l23_app_exit(); + + if (l23_app_info.opt_supported & L23_OPT_VTY) + telnet_exit(); + log_fini(); talloc_free(config_file); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic8540c73b1b13134e11f254beb6a16f7e4452317 Gerrit-Change-Number: 32431 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: contrib/jenkins.sh: add PFCP variable

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 ) Change subject: contrib/jenkins.sh: add PFCP variable ...................................................................... contrib/jenkins.sh: add PFCP variable Related: OS#6013 Change-Id: Iacc6a0267d4896d0149f5e00d77951cdfc281e4e --- M contrib/jenkins.sh 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/30/32430/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 98291b4..e0e4f2d 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -2,6 +2,7 @@ # jenkins build helper script for osmo-hnbgw. This is how we build on jenkins.osmocom.org # # environment variables: +# * PFCP: configure PFCP support (values: "--enable-pfcp", "--disable-pfcp") # * WITH_MANUALS: build manual PDFs if set to "1" # * PUBLISH: upload manuals after building if set to "1" (ignored without WITH_MANUALS = "1") # @@ -33,13 +34,15 @@ osmo-build-dep.sh libosmo-abis osmo-build-dep.sh libosmo-netif osmo-build-dep.sh libosmo-sccp -osmo-build-dep.sh libosmo-pfcp osmo-build-dep.sh libasn1c osmo-build-dep.sh osmo-iuh osmo-build-dep.sh osmo-mgw # Additional configure options and depends -CONFIG="" +CONFIG="$PFCP " +if [ "$PFCP" = "--enable-pfcp" ]; then + osmo-build-dep.sh libosmo-pfcp +fi if [ "$WITH_MANUALS" = "1" ]; then CONFIG="--enable-manuals" fi -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iacc6a0267d4896d0149f5e00d77951cdfc281e4e Gerrit-Change-Number: 32430 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: Unregister registered callbacks upon app exit

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32428 ) Change subject: layer23: modem: Unregister registered callbacks upon app exit ...................................................................... layer23: modem: Unregister registered callbacks upon app exit Change-Id: I5a641fa3dadb6ea7346b25a20215896ab32eb805 --- M src/host/layer23/src/modem/app_modem.c 1 file changed, 19 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/28/32428/1 diff --git a/src/host/layer23/src/modem/app_modem.c b/src/host/layer23/src/modem/app_modem.c index 211621e..c24a6e6 100644 --- a/src/host/layer23/src/modem/app_modem.c +++ b/src/host/layer23/src/modem/app_modem.c @@ -114,7 +114,7 @@ memset(&app_data, 0x00, sizeof(app_data)); } -static int signal_cb(unsigned int subsys, unsigned int signal, +static int global_signal_cb(unsigned int subsys, unsigned int signal, void *handler_data, void *signal_data) { struct osmocom_ms *ms; @@ -151,11 +151,19 @@ return 0; } +/* global exit */ +static int _modem_exit(void) +{ + osmo_signal_unregister_handler(SS_GLOBAL, &global_signal_cb, NULL); + return 0; +} + int l23_app_init(void) { int rc; l23_app_start = _modem_start; + l23_app_exit = _modem_exit; log_set_category_filter(osmo_stderr_target, DLGLOBAL, 1, LOGL_DEBUG); log_set_category_filter(osmo_stderr_target, DLCSN1, 1, LOGL_DEBUG); @@ -189,7 +197,7 @@ return rc; } - osmo_signal_register_handler(SS_L1CTL, &signal_cb, NULL); + osmo_signal_register_handler(SS_L1CTL, &global_signal_cb, NULL); lapdm_channel_set_l3(&app_data.ms->lapdm_channel, &modem_grr_rslms_cb, app_data.ms); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5a641fa3dadb6ea7346b25a20215896ab32eb805 Gerrit-Change-Number: 32428 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: mobile: Mark several functions static

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32429 ) Change subject: layer23: mobile: Mark several functions static ...................................................................... layer23: mobile: Mark several functions static Change-Id: Ifdeef9373b903d14fb2f4ec4caa1bf8c42b45aa1 --- M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/main.c 2 files changed, 15 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/29/32429/1 diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c index 1fdb275..d91425b 100644 --- a/src/host/layer23/src/mobile/app_mobile.c +++ b/src/host/layer23/src/mobile/app_mobile.c @@ -92,7 +92,7 @@ } /* SIM becomes ATTACHED/DETACHED, or answers a request */ -int mobile_l23_subscr_signal_cb(unsigned int subsys, unsigned int signal, +static int mobile_l23_subscr_signal_cb(unsigned int subsys, unsigned int signal, void *handler_data, void *signal_data) { struct msgb *nmsg; @@ -135,7 +135,7 @@ } /* run ms instance, if layer1 is available */ -int mobile_signal_cb(unsigned int subsys, unsigned int signal, +static int mobile_signal_cb(unsigned int subsys, unsigned int signal, void *handler_data, void *signal_data) { struct osmocom_ms *ms; @@ -412,7 +412,7 @@ } /* handle global shutdown */ -int global_signal_cb(unsigned int subsys, unsigned int signal, +static int global_signal_cb(unsigned int subsys, unsigned int signal, void *handler_data, void *signal_data) { struct osmocom_ms *ms, *ms2; @@ -437,7 +437,7 @@ } /* global work handler */ -int _mobile_app_work(void) +static int _mobile_app_work(void) { struct osmocom_ms *ms, *ms2; int work = 0; @@ -472,7 +472,7 @@ } /* global exit */ -int _mobile_app_exit(void) +static int _mobile_app_exit(void) { osmo_signal_unregister_handler(SS_L23_SUBSCR, &mobile_l23_subscr_signal_cb, NULL); osmo_signal_unregister_handler(SS_L1CTL, &gsm322_l1_signal, NULL); @@ -487,7 +487,7 @@ } -int _mobile_app_start(void) +static int _mobile_app_start(void) { int rc; diff --git a/src/host/layer23/src/mobile/main.c b/src/host/layer23/src/mobile/main.c index eca082a..11ffd95 100644 --- a/src/host/layer23/src/mobile/main.c +++ b/src/host/layer23/src/mobile/main.c @@ -64,8 +64,6 @@ int (*l23_app_exit)(void) = NULL; int mobile_delete(struct osmocom_ms *ms, int force); -int mobile_signal_cb(unsigned int subsys, unsigned int signal, - void *handler_data, void *signal_data); int mobile_work(struct osmocom_ms *ms); int mobile_exit(struct osmocom_ms *ms, int force); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifdeef9373b903d14fb2f4ec4caa1bf8c42b45aa1 Gerrit-Change-Number: 32429 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: Decouple SIM events from MMR events

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32427 ) Change subject: layer23: Decouple SIM events from MMR events ...................................................................... layer23: Decouple SIM events from MMR events let the specific app handle the events generated from the subscriber/SIM. All the MMR specific code can for now stay in mobile/ while SIM support can be in common/ without violating layers (common/ calling functions in mobile/). Change-Id: I473887e0fd9338d76a69a9774145a04575f14b64 --- M src/host/layer23/include/osmocom/bb/common/osmocom_data.h M src/host/layer23/src/common/subscriber.c M src/host/layer23/src/mobile/app_mobile.c 3 files changed, 82 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/27/32427/1 diff --git a/src/host/layer23/include/osmocom/bb/common/osmocom_data.h b/src/host/layer23/include/osmocom/bb/common/osmocom_data.h index 600c412..3e5c13a 100644 --- a/src/host/layer23/include/osmocom/bb/common/osmocom_data.h +++ b/src/host/layer23/include/osmocom/bb/common/osmocom_data.h @@ -11,6 +11,7 @@ SS_L1CTL, SS_GLOBAL, SS_L23_VTY, + SS_L23_SUBSCR, }; enum osmobb_l1ctl_sig { @@ -34,6 +35,12 @@ S_L23_VTY_MS_STOP, }; +enum osmobb_l23_subscriber { + S_L23_SUBSCR_SIM_ATTACHED, + S_L23_SUBSCR_SIM_DETACHED, + S_L23_SUBSCR_SIM_AUTH_RESP, +}; + struct osmobb_l23_vty_sig_data { struct vty *vty; union { @@ -49,6 +56,11 @@ }; }; +struct osmobb_l23_subscr_sim_auth_resp_sig_data { + struct osmocom_ms *ms; + uint8_t sres[4]; +}; + struct osmobb_fbsb_res { struct osmocom_ms *ms; int8_t snr; diff --git a/src/host/layer23/src/common/subscriber.c b/src/host/layer23/src/common/subscriber.c index e3f5a8c..d80515d 100644 --- a/src/host/layer23/src/common/subscriber.c +++ b/src/host/layer23/src/common/subscriber.c @@ -139,7 +139,6 @@ { struct gsm_settings *set = &ms->settings; struct gsm_subscriber *subscr = &ms->subscr; - struct msgb *nmsg; if (subscr->sim_valid) { LOGP(DMM, LOGL_ERROR, "Cannot insert card, until current card " @@ -192,11 +191,7 @@ LOGP(DMM, LOGL_INFO, "-> Test card attached\n"); /* insert card */ - nmsg = gsm48_mmr_msgb_alloc(GSM48_MMR_REG_REQ); - if (!nmsg) - return -ENOMEM; - gsm48_mmr_downmsg(ms, nmsg); - + osmo_signal_dispatch(SS_L23_SUBSCR, S_L23_SUBSCR_SIM_ATTACHED, ms); return 0; } @@ -556,11 +551,7 @@ LOGP(DMM, LOGL_INFO, "-> SIM card not registered\n"); /* insert card */ - nmsg = gsm48_mmr_msgb_alloc(GSM48_MMR_REG_REQ); - if (!nmsg) - return -ENOMEM; - gsm48_mmr_downmsg(ms, nmsg); - + osmo_signal_dispatch(SS_L23_SUBSCR, S_L23_SUBSCR_SIM_ATTACHED, ms); return 0; } @@ -593,7 +584,6 @@ uint16_t payload_len = msg->len - sizeof(*sh); int rc; struct subscr_sim_file *sf = &subscr_sim_files[subscr->sim_file_index]; - struct msgb *nmsg; /* error handling */ if (sh->job_type == SIM_JOB_ERROR) { @@ -642,10 +632,7 @@ /* detach simcard */ subscr->sim_valid = 0; - nmsg = gsm48_mmr_msgb_alloc(GSM48_MMR_NREG_REQ); - if (!nmsg) - return; - gsm48_mmr_downmsg(ms, nmsg); + osmo_signal_dispatch(SS_L23_SUBSCR, S_L23_SUBSCR_SIM_DETACHED, ms); } msgb_free(msg); @@ -966,10 +953,10 @@ struct sim_hdr *sh = (struct sim_hdr *) msg->data; uint8_t *payload = msg->data + sizeof(*sh); uint16_t payload_len = msg->len - sizeof(*sh); - struct msgb *nmsg; struct sim_hdr *nsh; - struct gsm48_mm_event *nmme; uint8_t *data; + struct osmobb_l23_subscr_sim_auth_resp_sig_data sd; + struct msgb *nmsg; /* error handling */ if (sh->job_type == SIM_JOB_ERROR) { @@ -1005,13 +992,9 @@ sim_job(ms, nmsg); /* return signed response */ - nmsg = gsm48_mmevent_msgb_alloc(GSM48_MM_EVENT_AUTH_RESPONSE); - if (!nmsg) - return; - nmme = (struct gsm48_mm_event *) nmsg->data; - memcpy(nmme->sres, payload, 4); - gsm48_mmevent_msg(ms, nmsg); - + sd.ms = ms; + memcpy(sd.sres, payload, 4); + osmo_signal_dispatch(SS_L23_SUBSCR, S_L23_SUBSCR_SIM_AUTH_RESP, &sd); msgb_free(msg); } @@ -1023,7 +1006,6 @@ int gsm_subscr_remove(struct osmocom_ms *ms) { struct gsm_subscriber *subscr = &ms->subscr; - struct msgb *nmsg; if (!subscr->sim_valid) { LOGP(DMM, LOGL_ERROR, "Cannot remove card, no card present\n"); @@ -1031,10 +1013,7 @@ } /* remove card */ - nmsg = gsm48_mmr_msgb_alloc(GSM48_MMR_NREG_REQ); - if (!nmsg) - return -ENOMEM; - gsm48_mmr_downmsg(ms, nmsg); + osmo_signal_dispatch(SS_L23_SUBSCR, S_L23_SUBSCR_SIM_DETACHED, ms); return 0; } @@ -1245,7 +1224,6 @@ int gsm_subscr_sapcard(struct osmocom_ms *ms) { struct gsm_subscriber *subscr = &ms->subscr; - struct msgb *nmsg; int rc; if (subscr->sim_valid) { @@ -1273,10 +1251,7 @@ /* Detach SIM */ subscr->sim_valid = 0; - nmsg = gsm48_mmr_msgb_alloc(GSM48_MMR_NREG_REQ); - if (!nmsg) - return -ENOMEM; - gsm48_mmr_downmsg(ms, nmsg); + osmo_signal_dispatch(SS_L23_SUBSCR, S_L23_SUBSCR_SIM_DETACHED, ms); return rc; } diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c index 8befc80..1fdb275 100644 --- a/src/host/layer23/src/mobile/app_mobile.c +++ b/src/host/layer23/src/mobile/app_mobile.c @@ -91,6 +91,49 @@ return work; } +/* SIM becomes ATTACHED/DETACHED, or answers a request */ +int mobile_l23_subscr_signal_cb(unsigned int subsys, unsigned int signal, + void *handler_data, void *signal_data) +{ + struct msgb *nmsg; + struct gsm48_mm_event *nmme; + struct osmocom_ms *ms; + struct osmobb_l23_subscr_sim_auth_resp_sig_data *sim_auth_resp; + + OSMO_ASSERT(subsys == SS_L23_SUBSCR); + + switch (signal) { + case S_L23_SUBSCR_SIM_ATTACHED: + ms = signal_data; + nmsg = gsm48_mmr_msgb_alloc(GSM48_MMR_REG_REQ); + if (!nmsg) + return -ENOMEM; + gsm48_mmr_downmsg(ms, nmsg); + break; + case S_L23_SUBSCR_SIM_DETACHED: + ms = signal_data; + nmsg = gsm48_mmr_msgb_alloc(GSM48_MMR_NREG_REQ); + if (!nmsg) + return 0; + gsm48_mmr_downmsg(ms, nmsg); + break; + case S_L23_SUBSCR_SIM_AUTH_RESP: + sim_auth_resp = signal_data; + ms = sim_auth_resp->ms; + nmsg = gsm48_mmevent_msgb_alloc(GSM48_MM_EVENT_AUTH_RESPONSE); + if (!nmsg) + return 0; + nmme = (struct gsm48_mm_event *) nmsg->data; + memcpy(nmme->sres, sim_auth_resp->sres, 4); + gsm48_mmevent_msg(ms, nmsg); + break; + default: + OSMO_ASSERT(0); + } + + return 0; +} + /* run ms instance, if layer1 is available */ int mobile_signal_cb(unsigned int subsys, unsigned int signal, void *handler_data, void *signal_data) @@ -431,6 +474,7 @@ /* global exit */ int _mobile_app_exit(void) { + osmo_signal_unregister_handler(SS_L23_SUBSCR, &mobile_l23_subscr_signal_cb, NULL); osmo_signal_unregister_handler(SS_L1CTL, &gsm322_l1_signal, NULL); osmo_signal_unregister_handler(SS_L1CTL, &mobile_signal_cb, NULL); osmo_signal_unregister_handler(SS_GLOBAL, &global_signal_cb, NULL); @@ -481,6 +525,7 @@ osmo_signal_register_handler(SS_GLOBAL, &global_signal_cb, NULL); osmo_signal_register_handler(SS_L1CTL, &mobile_signal_cb, NULL); osmo_signal_register_handler(SS_L1CTL, &gsm322_l1_signal, NULL); + osmo_signal_register_handler(SS_L23_SUBSCR, &mobile_l23_subscr_signal_cb, NULL); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I473887e0fd9338d76a69a9774145a04575f14b64 Gerrit-Change-Number: 32427 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: er_ccu_l1_if: use one ccu_desr per timeslot

by dexter

Attention is currently required from: laforge, pespin, keith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32423 ) Change subject: er_ccu_l1_if: use one ccu_desr per timeslot ...................................................................... Patch Set 1: (1 comment) File src/ericsson-rbs/er_ccu_descr.h: https://gerrit.osmocom.org/c/osmo-pcu/+/32423/comment/3b2cba2e_d4588c90 PS1, Line 52: 8 > that's num of TS per TRX. […] I am also not so happy with this. I was searching for a define constant, but I couldn't fine one. In osmo-bsc.git in bts_trx.h we have a #define TRX_NR_TS 8, we could move that to libosmocore and use it where ever possible. We also might rename it to OSMO_TRX_NR_TS then. Would that be an option? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I09a51f34ce0edef79a797c4686c7b1d27c376e49 Gerrit-Change-Number: 32423 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 25 Apr 2023 09:56:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-bsc[master]: ctrl: Add cell reselection offset control

by pespin

Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32425 ) Change subject: ctrl: Add cell reselection offset control ...................................................................... Patch Set 1: (3 comments) File src/osmo-bsc/bts_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/9086eba3_fda01b39 PS1, Line 721: cmd->reply = talloc_asprintf(cmd, "%u", bts->si_common.cell_ro_sel_par.cell_resel_off*2); space between " * " https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/891acfd6_c9923118 PS1, Line 723: cmd->reply = "OOM."; I think we never put a dot in replies? https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/13cba5bf_1d004edd PS1, Line 734: bts->si_common.cell_ro_sel_par.cell_resel_off = atoi(cmd->value)/2; space between " / " -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I159bbe14e71dbf1e1add60b57b0b2e03d3146682 Gerrit-Change-Number: 32425 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 09:49:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if_phy: fix API function names

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32426 ) Change subject: pcu_l1_if_phy: fix API function names ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I395a60b2fba39bac4facec78989bac20f0cef0d3 Gerrit-Change-Number: 32426 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 09:47:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023