April 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sccp[master]: SCCP: implement variable limit on Optional Data (CR,CC,CREF,RLSD)

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32361 ) Change subject: SCCP: implement variable limit on Optional Data (CR,CC,CREF,RLSD) ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: If35697234796af8943691b2de62218e7dc93a08c Gerrit-Change-Number: 32361 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 08:31:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-bsc[master]: ctrl: Add cell reselection offset control

by fixeria

Attention is currently required from: matanp. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32425 ) Change subject: ctrl: Add cell reselection offset control ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I159bbe14e71dbf1e1add60b57b0b2e03d3146682 Gerrit-Change-Number: 32425 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 08:15:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if_phy: fix API function names

by dexter

dexter has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/32426 ) Change subject: pcu_l1_if_phy: fix API function names ...................................................................... pcu_l1_if_phy: fix API function names The functions l1if_open_pdch and l1if_close_pdch have a misleading naming since what they actually do is opening and closing the TRX since they return and accept a context (obj) that is valid for a whole TRX. This also explains why the other functions accept a timeslot as parameter in addition to the context. Let's rename those functions so that it is clear what they do. Change-Id: I395a60b2fba39bac4facec78989bac20f0cef0d3 --- M src/ericsson-rbs/er_ccu_l1_if.c M src/osmo-bts-litecell15/lc15_l1_if.c M src/osmo-bts-oc2g/oc2g_l1_if.c M src/osmo-bts-sysmo/sysmo_l1_if.c M src/pcu_l1_if_phy.h 5 files changed, 26 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/26/32426/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I395a60b2fba39bac4facec78989bac20f0cef0d3 Gerrit-Change-Number: 32426 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if_phy: fix API function names

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32426 ) Change subject: pcu_l1_if_phy: fix API function names ...................................................................... pcu_l1_if_phy: fix API function names The functions l1if_open_pdch and l1if_close_pdch have a misleading naming since what they actually do is opening and closing the TRX since they return and accept a context (obj) that is valid for a whole TRX. This also explains why the other functions accept a timeslot as parameter in addition to the context. Let's rename those functions so that it is clear what they do. Change-Id: I395a60b2fba39bac4facec78989bac20f0cef0d3 --- M src/ericsson-rbs/er_ccu_l1_if.c M src/osmo-bts-litecell15/lc15_l1_if.c M src/osmo-bts-oc2g/oc2g_l1_if.c M src/osmo-bts-sysmo/sysmo_l1_if.c M src/pcu_l1_if_phy.h 5 files changed, 26 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/26/32426/1 diff --git a/src/ericsson-rbs/er_ccu_l1_if.c b/src/ericsson-rbs/er_ccu_l1_if.c index babf625..dd7c9d1 100644 --- a/src/ericsson-rbs/er_ccu_l1_if.c +++ b/src/ericsson-rbs/er_ccu_l1_if.c @@ -452,7 +452,7 @@ return 0; } -void *l1if_open_pdch(uint8_t bts_nr, uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap) +void *l1if_open_trx(uint8_t bts_nr, uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap) { struct er_trx_descr *trx_descr; unsigned int i; @@ -475,7 +475,7 @@ return trx_descr; } -int l1if_close_pdch(void *obj) +int l1if_close_trx(void *obj) { struct er_trx_descr *trx_descr = obj; unsigned int i; diff --git a/src/osmo-bts-litecell15/lc15_l1_if.c b/src/osmo-bts-litecell15/lc15_l1_if.c index dce9e53..3b8b21b 100644 --- a/src/osmo-bts-litecell15/lc15_l1_if.c +++ b/src/osmo-bts-litecell15/lc15_l1_if.c @@ -367,7 +367,7 @@ return 0; } -void *l1if_open_pdch(uint8_t bts_nr, uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap) +void *l1if_open_trx(uint8_t bts_nr, uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap) { struct lc15l1_hdl *fl1h; int rc; @@ -396,7 +396,7 @@ return fl1h; } -int l1if_close_pdch(void *obj) +int l1if_close_trx(void *obj) { struct lc15l1_hdl *fl1h = obj; if (fl1h) diff --git a/src/osmo-bts-oc2g/oc2g_l1_if.c b/src/osmo-bts-oc2g/oc2g_l1_if.c index 93b4654..2c9da72 100644 --- a/src/osmo-bts-oc2g/oc2g_l1_if.c +++ b/src/osmo-bts-oc2g/oc2g_l1_if.c @@ -372,7 +372,7 @@ return 0; } -void *l1if_open_pdch(uint8_t bts_nr, uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap) +void *l1if_open_trx(uint8_t bts_nr, uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap) { struct oc2gl1_hdl *fl1h; int rc; @@ -401,7 +401,7 @@ return fl1h; } -int l1if_close_pdch(void *obj) +int l1if_close_trx(void *obj) { struct oc2gl1_hdl *fl1h = obj; if (fl1h) diff --git a/src/osmo-bts-sysmo/sysmo_l1_if.c b/src/osmo-bts-sysmo/sysmo_l1_if.c index 99ccf9a..e97b9bd 100644 --- a/src/osmo-bts-sysmo/sysmo_l1_if.c +++ b/src/osmo-bts-sysmo/sysmo_l1_if.c @@ -352,7 +352,7 @@ return 0; } -void *l1if_open_pdch(uint8_t bts_nr, uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap) +void *l1if_open_trx(uint8_t bts_nr, uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap) { struct femtol1_hdl *fl1h; int rc; @@ -378,7 +378,7 @@ return fl1h; } -int l1if_close_pdch(void *obj) +int l1if_close_trx(void *obj) { struct femtol1_hdl *fl1h = obj; if (fl1h) diff --git a/src/pcu_l1_if_phy.h b/src/pcu_l1_if_phy.h index 7eba5cc..08b7d23 100644 --- a/src/pcu_l1_if_phy.h +++ b/src/pcu_l1_if_phy.h @@ -4,9 +4,9 @@ #include <osmocom/core/gsmtap_util.h> int l1if_init(void); -void *l1if_open_pdch(uint8_t bts_nr, uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap); +void *l1if_open_trx(uint8_t bts_nr, uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap); int l1if_connect_pdch(void *obj, uint8_t ts); int l1if_pdch_req(void *obj, uint8_t ts, int is_ptcch, uint32_t fn, uint16_t arfcn, uint8_t block_nr, uint8_t *data, uint8_t len); int l1if_disconnect_pdch(void *obj, uint8_t ts); -int l1if_close_pdch(void *obj); +int l1if_close_trx(void *obj); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I395a60b2fba39bac4facec78989bac20f0cef0d3 Gerrit-Change-Number: 32426 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: wait longer for PFCP Assoc

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32424 ) Change subject: hnbgw: wait longer for PFCP Assoc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4b9af224e2346a4735f3d4e01b234acf56c5f3ff Gerrit-Change-Number: 32424 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 07:30:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-bsc[master]: ctrl: Add cell reselection offset control

by matanp

matanp has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32425 ) Change subject: ctrl: Add cell reselection offset control ...................................................................... ctrl: Add cell reselection offset control Change-Id: I159bbe14e71dbf1e1add60b57b0b2e03d3146682 --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 53 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/25/32425/1 diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 4b4b1fb..492c0a1 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -694,6 +694,49 @@ /* TODO: si2quater neighbor management: add EARFCN */ /* TODO: si2quater neighbor management: add UARFCN */ +static int verify_bts_cell_reselection_offset(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + const int cell_reselection_offset = atoi(value); + + if (cell_reselection_offset < 0 || cell_reselection_offset > 126) { + cmd->reply = "Value is out of range"; + return 1; + } else if (cell_reselection_offset % 2 != 0) { + cmd->reply = "Value must be even"; + return 1; + } + + return 0; +} + +static int get_bts_cell_reselection_offset(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + + if (!bts->si_common.cell_ro_sel_par.present) { + cmd->reply = "0"; + return CTRL_CMD_REPLY; + } + + cmd->reply = talloc_asprintf(cmd, "%u", bts->si_common.cell_ro_sel_par.cell_resel_off*2); + if (!cmd->reply) { + cmd->reply = "OOM."; + return CTRL_CMD_ERROR; + } + + return CTRL_CMD_REPLY; +} + +static int set_bts_cell_reselection_offset(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + bts->si_common.cell_ro_sel_par.present = 1; + bts->si_common.cell_ro_sel_par.cell_resel_off = atoi(cmd->value)/2; + return CTRL_CMD_REPLY; +} + +CTRL_CMD_DEFINE(bts_cell_reselection_offset, "cell-reselection-offset"); + int bsc_bts_ctrl_cmds_install(void) { int rc = 0; @@ -716,6 +759,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_mode); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_del_earfcn); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_del_uarfcn); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_cell_reselection_offset); rc |= neighbor_ident_ctrl_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I159bbe14e71dbf1e1add60b57b0b2e03d3146682 Gerrit-Change-Number: 32425 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: wait longer for PFCP Assoc

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32424 ) Change subject: hnbgw: wait longer for PFCP Assoc ...................................................................... hnbgw: wait longer for PFCP Assoc Since I introduced stricter timeouts on PFCP messages in hnbgw: add f_pfcp_expect() commit 6bbfe057afe6f23e2f325789a3dcac81065ab952 Change-Id I2117475b695d486b1204d61e5bb21120a6187354 the HNBGW tests with PFCP support fail often: The Assoc Setup resending timeout (X26) is configured to 5 seconds, and the timeout to wait for this is also 5 seconds. Every once in a while they happen to miss, causing a test failure. Increase the initial Assoc Setup Req timeout to 15 seconds to avoid sporadic failures. Change-Id: I4b9af224e2346a4735f3d4e01b234acf56c5f3ff --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 25 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/32424/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 1c0b121..e9693fe 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1292,10 +1292,10 @@ } } -private function f_pfcp_expect(template (present) PDU_PFCP exp_rx) runs on ConnHdlr return PDU_PFCP +private function f_pfcp_expect(template (present) PDU_PFCP exp_rx, float wait_time := 5.0) runs on ConnHdlr return PDU_PFCP { var PDU_PFCP rx; - timer T := 5.0; + timer T := wait_time; T.start; alt { [] PFCP.receive(exp_rx) -> value rx { @@ -1325,7 +1325,7 @@ var PDU_PFCP m; var Node_ID upf_node_id := valueof(ts_PFCP_Node_ID_fqdn("\07osmocom\03org")); - m := f_pfcp_expect(tr_PFCP_Assoc_Setup_Req()) + m := f_pfcp_expect(tr_PFCP_Assoc_Setup_Req(), wait_time := 15.0); PFCP.send(ts_PFCP_Assoc_Setup_Resp(m.sequence_number, upf_node_id, ts_PFCP_Cause(REQUEST_ACCEPTED), 1234)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4b9af224e2346a4735f3d4e01b234acf56c5f3ff Gerrit-Change-Number: 32424 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: er_ccu_l1_if: use one ccu_desr per timeslot

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32423 ) Change subject: er_ccu_l1_if: use one ccu_desr per timeslot ...................................................................... er_ccu_l1_if: use one ccu_desr per timeslot At the moment only allocate one CCU descriptor and use it as context for the whole TRX. This is fine when running with one PDCH only but as soon as multiple PDCHs are used the CCU descriptor gets messed up. Let's fix this by introducing a TRX descriptor that contains an array of 8 CCU descriptors, one for each timeslot. Change-Id: I09a51f34ce0edef79a797c4686c7b1d27c376e49 --- M src/ericsson-rbs/er_ccu_descr.h M src/ericsson-rbs/er_ccu_l1_if.c 2 files changed, 60 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/23/32423/1 diff --git a/src/ericsson-rbs/er_ccu_descr.h b/src/ericsson-rbs/er_ccu_descr.h index 0b56cc0..0935416 100644 --- a/src/ericsson-rbs/er_ccu_descr.h +++ b/src/ericsson-rbs/er_ccu_descr.h @@ -47,3 +47,7 @@ }; + +struct er_trx_descr { + struct er_ccu_descr ccu_descr[8]; +}; diff --git a/src/ericsson-rbs/er_ccu_l1_if.c b/src/ericsson-rbs/er_ccu_l1_if.c index b7dd102..babf625 100644 --- a/src/ericsson-rbs/er_ccu_l1_if.c +++ b/src/ericsson-rbs/er_ccu_l1_if.c @@ -372,18 +372,22 @@ int l1if_pdch_req(void *obj, uint8_t ts, int is_ptcch, uint32_t fn, uint16_t arfcn, uint8_t block_nr, uint8_t *data, uint8_t len) { - struct er_ccu_descr *ccu_descr = obj; + struct er_trx_descr *trx_descr = obj; + struct er_ccu_descr *ccu_descr; struct er_gprs_trau_frame trau_frame; ubit_t trau_frame_encoded[ER_GPRS_TRAU_FRAME_LEN_64K]; struct gprs_rlcmac_bts *bts; int rc; /* Make sure that the CCU is synchronized and connected. */ - if (!ccu_descr) { - LOGP(DL1IF, LOGL_ERROR, "PCU-DATA-IND: PDCH(ts=%u, arfcn=%u) no CCU context, tossing MAC block...\n", + if (!trx_descr) { + LOGP(DL1IF, LOGL_ERROR, "PCU-DATA-IND: PDCH(ts=%u, arfcn=%u) no TRX context, tossing MAC block...\n", ts, arfcn); return -EINVAL; } + + ccu_descr = &trx_descr->ccu_descr[ts]; + if (!ccu_descr->link.ccu_connected) { LOGPL1IF(ccu_descr, LOGL_NOTICE, "PCU-DATA-IND", "CCU not connected, tossing MAC block...\n"); return -EINVAL; @@ -450,46 +454,56 @@ void *l1if_open_pdch(uint8_t bts_nr, uint8_t trx_no, uint32_t hlayer1, struct gsmtap_inst *gsmtap) { - struct er_ccu_descr *ccu_descr; + struct er_trx_descr *trx_descr; + unsigned int i; /* Note: We do not have enough information to really open anything at - * this point. We will just create the CCU context. */ + * this point. We will just create the TRX context and fill it wit basic + * CCU context (one for each TS) */ - ccu_descr = talloc_zero(tall_pcu_ctx, struct er_ccu_descr); - OSMO_ASSERT(ccu_descr); - ccu_descr->er_ccu_rx_cb = er_ccu_rx_cb; - ccu_descr->er_ccu_empty_cb = er_ccu_empty_cb; - ccu_descr->pcu.trx_no = trx_no; - ccu_descr->pcu.bts_nr = bts_nr; + trx_descr = talloc_zero(tall_pcu_ctx, struct er_trx_descr); + OSMO_ASSERT(trx_descr); - return ccu_descr; + for (i = 0; i < ARRAY_SIZE(trx_descr->ccu_descr); i++) { + trx_descr->ccu_descr[i].er_ccu_rx_cb = er_ccu_rx_cb; + trx_descr->ccu_descr[i].er_ccu_empty_cb = er_ccu_empty_cb; + trx_descr->ccu_descr[i].pcu.trx_no = trx_no; + trx_descr->ccu_descr[i].pcu.bts_nr = bts_nr; + trx_descr->ccu_descr[i].pcu.ts = i; + } + + return trx_descr; } int l1if_close_pdch(void *obj) { - struct er_ccu_descr *ccu_descr = obj; + struct er_trx_descr *trx_descr = obj; + unsigned int i; - if (!ccu_descr) { - LOGP(DL1IF, LOGL_ERROR, "PCU-DATA-IND: no CCU context, cannot close unknown PDCH...\n"); + if (!trx_descr) { + LOGP(DL1IF, LOGL_ERROR, "PCU-DATA-IND: no TRX context, cannot close unknown TRX...\n"); return -EINVAL; } - er_ccu_if_close(ccu_descr); - talloc_free(ccu_descr); + for (i = 0; i < ARRAY_SIZE(trx_descr->ccu_descr); i++) + er_ccu_if_close(&trx_descr->ccu_descr[i]); + + talloc_free(trx_descr); return 0; } int l1if_connect_pdch(void *obj, uint8_t ts) { - struct er_ccu_descr *ccu_descr = obj; + struct er_trx_descr *trx_descr = obj; + struct er_ccu_descr *ccu_descr; int rc; - if (!ccu_descr) { - LOGP(DL1IF, LOGL_ERROR, "SETUP: PDCH(ts=%u) no CCU context, PDCH never opened before?\n", ts); + if (!trx_descr) { + LOGP(DL1IF, LOGL_ERROR, "SETUP: PDCH(ts=%u) no CCU context, TRX never opened before?\n", ts); return -EINVAL; } - ccu_descr->pcu.ts = ts; + ccu_descr = &trx_descr->ccu_descr[ts]; rc = pcu_l1if_get_e1_ccu_conn_pars(&ccu_descr->e1_conn_pars, ccu_descr->pcu.bts_nr, ccu_descr->pcu.trx_no, ccu_descr->pcu.ts); @@ -507,13 +521,16 @@ int l1if_disconnect_pdch(void *obj, uint8_t ts) { - struct er_ccu_descr *ccu_descr = obj; + struct er_trx_descr *trx_descr = obj; + struct er_ccu_descr *ccu_descr; - if (!ccu_descr) { - LOGP(DL1IF, LOGL_ERROR, "SETUP: PDCH(ts=%u) no CCU context, PDCH never opened before?\n", ts); + if (!trx_descr) { + LOGP(DL1IF, LOGL_ERROR, "SETUP: PDCH(ts=%u) no TRX context, TRX never opened before?\n", ts); return -EINVAL; } + ccu_descr = &trx_descr->ccu_descr[ts]; + er_ccu_if_close(ccu_descr); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I09a51f34ce0edef79a797c4686c7b1d27c376e49 Gerrit-Change-Number: 32423 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: Fail VTY command if attching test SIM card fails

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32422 to look at the new patch set (#2). Change subject: mobile: Fail VTY command if attching test SIM card fails ...................................................................... mobile: Fail VTY command if attching test SIM card fails Change-Id: Ie5a395de6c926f13ce9324b93da0e348da5438d1 --- M src/host/layer23/src/mobile/vty_interface.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/22/32422/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie5a395de6c926f13ce9324b93da0e348da5438d1 Gerrit-Change-Number: 32422 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: Fail VTY command if attching test SIM card fails

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32422 ) Change subject: mobile: Fail VTY command if attching test SIM card fails ...................................................................... mobile: Fail VTY command if attching test SIM card fails Change-Id: Ie5a395de6c926f13ce9324b93da0e348da5438d1 --- M src/host/layer23/src/mobile/vty_interface.c 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/22/32422/1 diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index 57d02e6..6a42209 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -484,7 +484,11 @@ if (argc >= 5) tmsi = strtoul(argv[4], NULL, 16); - gsm_subscr_testcard(ms, mcc, mnc, lac, tmsi, attached); + rc = gsm_subscr_testcard(ms, mcc, mnc, lac, tmsi, attached); + if (rc < 0) { + vty_out(vty, "Attach test SIM card failed: %d%s", rc, VTY_NEWLINE); + return CMD_WARNING; + } return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie5a395de6c926f13ce9324b93da0e348da5438d1 Gerrit-Change-Number: 32422 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023