April 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: gmm: Append 'P-TMSI type' IE to GPRS Attach Req when needed

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32493 to look at the new patch set (#2). Change subject: gmm: Append 'P-TMSI type' IE to GPRS Attach Req when needed ...................................................................... gmm: Append 'P-TMSI type' IE to GPRS Attach Req when needed Depends: libosmocore.git Change-Id Ief4e03785f01f07c8d97b33bbb55c89a863baccc Change-Id: I79d8f2dae356fc25467553955f43fffb2661ab47 --- M src/gmm/gmm_pdu.c M tests/gmm/gmm_prim_test.ok 2 files changed, 21 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/93/32493/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I79d8f2dae356fc25467553955f43fffb2661ab47 Gerrit-Change-Number: 32493 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: Move out of alloc_algo code modifying the data model

by fixeria

Attention is currently required from: pespin, fixeria. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32399 ) Change subject: Move out of alloc_algo code modifying the data model ...................................................................... Patch Set 9: Code-Review+2 (1 comment) File src/tbf_ul.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/97714b4b_dd2271eb PS8, Line 720: %u > Not needed, because it is guaranteed to be unsigned by the check above (slot allocated) plus it woul […] Well, what's guaranteed above is that the timeslot is set in the slotmask, i.e. assigned. There can still be a bug somewhere in the code assigning USFs, this is why I brought this up. Not critical though. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20 Gerrit-Change-Number: 32399 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:33:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: modem: VTY: fix invalid IMSI, use 001010000000000

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32505 ) Change subject: modem: VTY: fix invalid IMSI, use 001010000000000 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This can be dropped, this is configured in VTY with https://gerrit.osmocom.org/c/osmocom-bb/+/32442. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id373993fa0dac950338d8d3e48dc8492f22f9d98 Gerrit-Change-Number: 32505 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:31:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: Move out of alloc_algo code modifying the data model

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32399 ) Change subject: Move out of alloc_algo code modifying the data model ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20 Gerrit-Change-Number: 32399 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:31:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libosmo-gprs[master]: sm: Fill gmmsm.establish_req.attach_with_imsi

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32491 ) Change subject: sm: Fill gmmsm.establish_req.attach_with_imsi ...................................................................... sm: Fill gmmsm.establish_req.attach_with_imsi Change-Id: Ie4fbadc1c3a32375ccae84a4d54366d59ab7fe2f --- M src/sm/sm.c 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sm/sm.c b/src/sm/sm.c index 0f39708..4fa35df 100644 --- a/src/sm/sm.c +++ b/src/sm/sm.c @@ -26,6 +26,7 @@ #include <osmocom/core/talloc.h> #include <osmocom/core/tdef.h> #include <osmocom/gsm/protocol/gsm_04_08_gprs.h> +#include <osmocom/gsm/gsm48.h> #include <osmocom/gprs/sndcp/sndcp_prim.h> @@ -190,6 +191,7 @@ gmm_prim_tx = osmo_gprs_gmm_prim_alloc_gmmsm_establish_req(sme->sess_id); gmm_prim_tx->gmmsm.establish_req.attach_type = OSMO_GPRS_GMM_ATTACH_TYPE_GPRS; + gmm_prim_tx->gmmsm.establish_req.attach_with_imsi = (ms->gmm.ptmsi == GSM_RESERVED_TMSI); gmm_prim_tx->gmmsm.establish_req.ptmsi = ms->gmm.ptmsi; OSMO_STRLCPY_ARRAY(gmm_prim_tx->gmmsm.establish_req.imsi, ms->gmm.imsi); OSMO_STRLCPY_ARRAY(gmm_prim_tx->gmmsm.establish_req.imei, ms->gmm.imei); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie4fbadc1c3a32375ccae84a4d54366d59ab7fe2f Gerrit-Change-Number: 32491 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: Move out of alloc_algo code modifying the data model

by pespin

Attention is currently required from: osmith, fixeria. Hello osmith, Jenkins Builder, fixeria, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32399 to look at the new patch set (#9). Change subject: Move out of alloc_algo code modifying the data model ...................................................................... Move out of alloc_algo code modifying the data model This way the alloc_algo() becomes idempotent, simplifying implementation of new alloc_algos as well as rolling back if allocation fails (for instance because some resource is exhausted at the time). For now the code applying the results is moved to tbf::alloc_algo(), but it will eventually get out of tbf code, so that the MS object is responsible for running it. As a result, there's no even need to create TBF object before trying to allocate resources, which will help furher in rollback operations described above. Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20 --- M src/alloc_algo.cpp M src/alloc_algo.h M src/gprs_pcu.h M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_dl.h M src/tbf_ul.cpp M src/tbf_ul.h M tests/tbf/TbfTest.err M tests/ulc/PdchUlcTest.cpp 11 files changed, 396 insertions(+), 375 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/99/32399/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20 Gerrit-Change-Number: 32399 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: Move out of alloc_algo code modifying the data model

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32399 ) Change subject: Move out of alloc_algo code modifying the data model ...................................................................... Patch Set 8: (3 comments) File src/alloc_algo.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/da659a14_c29af8ff PS8, Line 761: memset(res->usf, -1, sizeof(res->usf)); > Are you sure this is correct? `sizeof(res->usf)` is not 8 in this case, but `sizeof(int) * 8`. […] Done https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/32dc6a6b_b47ed6d9 PS8, Line 800: res->usf > `&res->usf[0]` would be cleaner here, otherwise it looks like you're passing a USF value, but then y […] Done https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/fa563ca1_06abbfb9 PS8, Line 863: struct alloc_resources_res *res) > coemstic: alignment Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20 Gerrit-Change-Number: 32399 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:28:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: Move out of alloc_algo code modifying the data model

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32399 ) Change subject: Move out of alloc_algo code modifying the data model ...................................................................... Patch Set 8: (1 comment) File src/tbf_ul.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/669233eb_d19e1992 PS8, Line 720: %u > `%d` because it's int? Not needed, because it is guaranteed to be unsigned by the check above (slot allocated) plus it would assert below. We don't really expect a negative value here. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20 Gerrit-Change-Number: 32399 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:27:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: l1gprs: reorder #includes, add missing <stdbool.h>

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32503 ) Change subject: l1gprs: reorder #includes, add missing <stdbool.h> ...................................................................... l1gprs: reorder #includes, add missing <stdbool.h> Change-Id: I6fe3b5d85c79a28bc116155c75f7ccd012007f56 Related: OS#5500 --- M include/l1gprs.h 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/l1gprs.h b/include/l1gprs.h index dbeaf2c..bbd654d 100644 --- a/include/l1gprs.h +++ b/include/l1gprs.h @@ -1,8 +1,9 @@ #pragma once -#include <osmocom/core/linuxlist.h> - #include <stdint.h> +#include <stdbool.h> + +#include <osmocom/core/linuxlist.h> struct l1gprs_state; struct msgb; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6fe3b5d85c79a28bc116155c75f7ccd012007f56 Gerrit-Change-Number: 32503 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: virt_phy: fix memleaks in l1ctl_rx_gprs_ul_block_req()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32501 ) Change subject: virt_phy: fix memleaks in l1ctl_rx_gprs_ul_block_req() ...................................................................... virt_phy: fix memleaks in l1ctl_rx_gprs_ul_block_req() Change-Id: If29ff1e9cc052576102094d870bf1710da562463 Related: OS#5500 --- M src/host/virt_phy/src/virt_prim_pdch.c 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/virt_phy/src/virt_prim_pdch.c b/src/host/virt_phy/src/virt_prim_pdch.c index 7125a70..2cb3efd 100644 --- a/src/host/virt_phy/src/virt_prim_pdch.c +++ b/src/host/virt_phy/src/virt_prim_pdch.c @@ -56,12 +56,15 @@ if (OSMO_UNLIKELY(ms->gprs == NULL)) { LOGPMS(DL1P, LOGL_ERROR, ms, "l1gprs is not initialized\n"); + msgb_free(msg); return; } msg->l1h = (void *)l1h->data; - if (l1gprs_handle_ul_block_req(ms->gprs, &req, msg) != 0) + if (l1gprs_handle_ul_block_req(ms->gprs, &req, msg) != 0) { + msgb_free(msg); return; + } msg->l2h = (void *)&req.data[0]; fn_sched = sched_fn_ul(ms->state.current_time, @@ -70,7 +73,7 @@ LOGPMS(DL1P, LOGL_ERROR, ms, "GPRS UL BLOCK.req: fn_sched(%u) != fn_req(%u)\n", fn_sched, req.hdr.fn); - /* FIXME: return; */ + /* FIXME: msgb_free(msg); return; */ } virt_l1_sched_schedule(ms, msg, fn_sched, req.hdr.tn, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If29ff1e9cc052576102094d870bf1710da562463 Gerrit-Change-Number: 32501 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023