April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: layer23: mobile: Mark several functions static

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32429 ) Change subject: layer23: mobile: Mark several functions static ...................................................................... Patch Set 4: (2 comments) File src/host/layer23/src/mobile/app_mobile.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32429/comment/e757e7f2_18de6365 PS3, Line 138: static int mobile_signal_cb(unsigned int subsys, unsigned int signal, > alignment Done https://gerrit.osmocom.org/c/osmocom-bb/+/32429/comment/299df47b_a711a015 PS3, Line 415: static int global_signal_cb(unsigned int subsys, unsigned int signal, > alignment Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifdeef9373b903d14fb2f4ec4caa1bf8c42b45aa1 Gerrit-Change-Number: 32429 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:54:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: Unregister registered callbacks upon app exit

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32428 ) Change subject: layer23: modem: Unregister registered callbacks upon app exit ...................................................................... Patch Set 4: (1 comment) File src/host/layer23/src/modem/app_modem.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32428/comment/338343ea_a0476bcd PS3, Line 117: static int global_signal_cb(unsigned int subsys, unsigned int signal, > please fix alignment Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5a641fa3dadb6ea7346b25a20215896ab32eb805 Gerrit-Change-Number: 32428 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:54:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: Unregister registered callbacks upon app exit

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32428 ) Change subject: layer23: modem: Unregister registered callbacks upon app exit ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/32428/comment/b3343486_975f7347 PS3, Line 7: layer23: modem: Unregister registered callbacks upon app exit > what's missing in the commit message is why doing this is necessary It's just a good practice to delete all resources allocated during startup. The main aim here is to keep resemblance to what the mobile app is doing, so that they can slowly be merged and some functionalities from the mobile app can be added to the modem app, like shutting down the MS without killing the process eventually. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5a641fa3dadb6ea7346b25a20215896ab32eb805 Gerrit-Change-Number: 32428 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:54:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: mobile: Mark several functions static

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32429 to look at the new patch set (#4). Change subject: layer23: mobile: Mark several functions static ...................................................................... layer23: mobile: Mark several functions static Change-Id: Ifdeef9373b903d14fb2f4ec4caa1bf8c42b45aa1 --- M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/main.c 2 files changed, 17 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/29/32429/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifdeef9373b903d14fb2f4ec4caa1bf8c42b45aa1 Gerrit-Change-Number: 32429 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: Move 'show {subscriber,support}' to common/'

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32440 to look at the new patch set (#4). Change subject: layer23: Move 'show {subscriber,support}' to common/' ...................................................................... layer23: Move 'show {subscriber,support}' to common/' Those modules are aready in common/, so they can be added to the shared VTY interface to introspect MS objects. Change-Id: Ie4d85bbb1d0af8894683589d8b936f9884f79be9 --- M src/host/layer23/include/osmocom/bb/common/vty.h M src/host/layer23/src/common/vty.c M src/host/layer23/src/mobile/vty_interface.c 3 files changed, 87 insertions(+), 73 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/40/32440/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32440 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie4d85bbb1d0af8894683589d8b936f9884f79be9 Gerrit-Change-Number: 32440 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: Unregister registered callbacks upon app exit

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32428 to look at the new patch set (#4). Change subject: layer23: modem: Unregister registered callbacks upon app exit ...................................................................... layer23: modem: Unregister registered callbacks upon app exit Change-Id: I5a641fa3dadb6ea7346b25a20215896ab32eb805 --- M src/host/layer23/src/modem/app_modem.c 1 file changed, 20 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/28/32428/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5a641fa3dadb6ea7346b25a20215896ab32eb805 Gerrit-Change-Number: 32428 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: Use subscriber information and events to trigger GMMREG Attach

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32442 to look at the new patch set (#7). Change subject: layer23: Use subscriber information and events to trigger GMMREG Attach ...................................................................... layer23: Use subscriber information and events to trigger GMMREG Attach Change-Id: I1c7cc120ff4098c0b845e13a6e5e5db8b7e18376 --- M src/host/layer23/include/osmocom/bb/modem/gmm.h M src/host/layer23/include/osmocom/bb/modem/sm.h M src/host/layer23/src/modem/app_modem.c M src/host/layer23/src/modem/gmm.c M src/host/layer23/src/modem/sm.c M src/host/layer23/src/modem/vty.c 6 files changed, 161 insertions(+), 65 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/42/32442/7 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1c7cc120ff4098c0b845e13a6e5e5db8b7e18376 Gerrit-Change-Number: 32442 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: Forward GMM primitives up to SM layer

by pespin

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32484 to look at the new patch set (#6). Change subject: layer23: modem: Forward GMM primitives up to SM layer ...................................................................... layer23: modem: Forward GMM primitives up to SM layer Change-Id: I5c5416775ccce4a1cbc70c8f6ba4fc25ace12d6f --- M src/host/layer23/src/modem/gmm.c 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/84/32484/6 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5c5416775ccce4a1cbc70c8f6ba4fc25ace12d6f Gerrit-Change-Number: 32484 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Provide allocated P-TMSI in GMMREG-ATTACH.cnf

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32495 ) Change subject: gmm: Provide allocated P-TMSI in GMMREG-ATTACH.cnf ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I95000ccfb9b4d24804ce916976d26aec8e51c749 Gerrit-Change-Number: 32495 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:44:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Append 'P-TMSI type' IE to GPRS Attach Req when needed

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32493 ) Change subject: gmm: Append 'P-TMSI type' IE to GPRS Attach Req when needed ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I79d8f2dae356fc25467553955f43fffb2661ab47 Gerrit-Change-Number: 32493 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:42:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023