Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32428 )
Change subject: layer23: modem: Unregister registered callbacks upon app exit
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmocom-bb/+/32428/comment/dd0edcdf_25b6b17a
PS3, Line 7: layer23: modem: Unregister registered callbacks upon app exit
> It's just a good practice to delete all resources allocated during startup. […]
Ok, can you add this to the commit message please?
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32428
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5a641fa3dadb6ea7346b25a20215896ab32eb805
Gerrit-Change-Number: 32428
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Apr 2023 12:11:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32403 )
(
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: Move resource allocation outside of tbf allocation
......................................................................
Move resource allocation outside of tbf allocation
This patch finally decouples TBF allocation from resource allocation.
This will allow in the future reserving resources without having to
require a TBF object to exist.
Change-Id: I2856c946cb62d6e5372a1099b60e5f3456eb8fd4
---
M src/gprs_ms.c
M src/tbf.cpp
M src/tbf.h
M src/tbf_dl.cpp
M src/tbf_dl.h
M src/tbf_ul.cpp
M src/tbf_ul.h
M tests/Makefile.am
M tests/alloc/AllocTest.cpp
M tests/alloc/AllocTest.err
M tests/app_info/AppInfoTest.cpp
M tests/app_info/AppInfoTest.err
M tests/tbf/TbfTest.cpp
M tests/tbf/TbfTest.err
M tests/types/TypesTest.cpp
M tests/types/TypesTest.err
M tests/ulc/PdchUlcTest.cpp
M tests/ulc/PdchUlcTest.err
18 files changed, 25,215 insertions(+), 1,476 deletions(-)
Approvals:
osmith: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32403
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2856c946cb62d6e5372a1099b60e5f3456eb8fd4
Gerrit-Change-Number: 32403
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged