April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: virt_phy: fix bogous TDMA Fn check in l1ctl_rx_gprs_ul_block_req()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32502 ) Change subject: virt_phy: fix bogous TDMA Fn check in l1ctl_rx_gprs_ul_block_req() ...................................................................... virt_phy: fix bogous TDMA Fn check in l1ctl_rx_gprs_ul_block_req() sched_fn_ul() does not support RSL_CHAN_OSMO_PDCH, so it would always return the current time, which in most cases is not the correct time for scheduling a block. Actually, we don't really need this function because the Tx Fn is provided to us by the upper layers - just use it. Change-Id: Ieb2c819db1ef9377680866989cbb754fac5e45bd Related: OS#5500 --- M src/host/virt_phy/src/virt_prim_pdch.c 1 file changed, 16 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/virt_phy/src/virt_prim_pdch.c b/src/host/virt_phy/src/virt_prim_pdch.c index 2cb3efd..65551d3 100644 --- a/src/host/virt_phy/src/virt_prim_pdch.c +++ b/src/host/virt_phy/src/virt_prim_pdch.c @@ -52,7 +52,6 @@ { const struct l1ctl_hdr *l1h = (struct l1ctl_hdr *)msg->data; struct l1gprs_prim_ul_block_req req; - uint32_t fn_sched; if (OSMO_UNLIKELY(ms->gprs == NULL)) { LOGPMS(DL1P, LOGL_ERROR, ms, "l1gprs is not initialized\n"); @@ -67,16 +66,7 @@ } msg->l2h = (void *)&req.data[0]; - fn_sched = sched_fn_ul(ms->state.current_time, - RSL_CHAN_OSMO_PDCH | req.hdr.tn, 0x00); - if (OSMO_UNLIKELY(fn_sched != req.hdr.fn)) { - LOGPMS(DL1P, LOGL_ERROR, ms, - "GPRS UL BLOCK.req: fn_sched(%u) != fn_req(%u)\n", - fn_sched, req.hdr.fn); - /* FIXME: msgb_free(msg); return; */ - } - - virt_l1_sched_schedule(ms, msg, fn_sched, req.hdr.tn, + virt_l1_sched_schedule(ms, msg, req.hdr.fn, req.hdr.tn, &gsmtapl1_tx_to_virt_um_inst); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ieb2c819db1ef9377680866989cbb754fac5e45bd Gerrit-Change-Number: 32502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: modem: VTY: fix invalid IMSI, use 001010000000000

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32505 ) Change subject: modem: VTY: fix invalid IMSI, use 001010000000000 ...................................................................... modem: VTY: fix invalid IMSI, use 001010000000000 Change-Id: Id373993fa0dac950338d8d3e48dc8492f22f9d98 Fixes: 7b8cc36ad "layer23: modem: fill imsi & imei in vty 'test gmm attach'" Fixes: a89939a68 "modem: initial SM layer support through libosmo-gprs-sm" --- M src/host/layer23/src/modem/vty.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/05/32505/1 diff --git a/src/host/layer23/src/modem/vty.c b/src/host/layer23/src/modem/vty.c index a23ae73..082a0eb 100644 --- a/src/host/layer23/src/modem/vty.c +++ b/src/host/layer23/src/modem/vty.c @@ -165,7 +165,7 @@ { struct osmo_gprs_gmm_prim *gmm_prim; const uint32_t tlli = 0xe1c5d364; - const char *imsi = "1234567890"; + const char *imsi = "001010000000000"; const char *imei = "42342342342342"; const char *imeisv = "4234234234234275"; struct osmocom_ms *ms; @@ -232,7 +232,7 @@ uint8_t qos[OSMO_GPRS_SM_QOS_MAXLEN] = {0}; uint8_t pco[OSMO_GPRS_SM_QOS_MAXLEN] = {0}; uint32_t ptmsi = 0x00000000; - char *imsi = "1234567890"; + char *imsi = "001010000000000"; char *imei = "42342342342342"; char *imeisv = "4234234234234275"; enum osmo_gprs_sm_pdp_addr_ietf_type pdp_addr_ietf_type; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id373993fa0dac950338d8d3e48dc8492f22f9d98 Gerrit-Change-Number: 32505 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in libosmo-gprs[master]: debian: set compat level to 10

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32449 ) Change subject: debian: set compat level to 10 ...................................................................... debian: set compat level to 10 Related: OS#5958 Change-Id: Icfdbea7cbe4681cd3b286471032fd6dd7226888f --- M debian/control 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/control b/debian/control index 283ee26..f5f7c9c 100644 --- a/debian/control +++ b/debian/control @@ -2,7 +2,7 @@ Maintainer: Osmocom team <openbsc(a)lists.osmocom.org> Section: libs Priority: optional -Build-Depends: debhelper (>= 9), +Build-Depends: debhelper (>= 10), dh-autoreconf, pkg-config, autoconf, -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32449 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Icfdbea7cbe4681cd3b286471032fd6dd7226888f Gerrit-Change-Number: 32449 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: virt_phy: fix bogous TDMA Fn check in l1ctl_rx_gprs_ul_block_req()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32502 ) Change subject: virt_phy: fix bogous TDMA Fn check in l1ctl_rx_gprs_ul_block_req() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ieb2c819db1ef9377680866989cbb754fac5e45bd Gerrit-Change-Number: 32502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:12:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: virt_phy: fix memleaks in l1ctl_rx_gprs_ul_block_req()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32501 ) Change subject: virt_phy: fix memleaks in l1ctl_rx_gprs_ul_block_req() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If29ff1e9cc052576102094d870bf1710da562463 Gerrit-Change-Number: 32501 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:12:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libosmo-pfcp[master]: debian: make consistent

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/32451 ) Change subject: debian: make consistent ...................................................................... debian: make consistent * Make maintainer consistent * Space in debhelper line Related: OS#5958 Change-Id: I6ee4aace6bf7c246338408c41f790189d75d5488 --- M debian/control 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/debian/control b/debian/control index 898d32d..5d81ae0 100644 --- a/debian/control +++ b/debian/control @@ -1,8 +1,8 @@ Source: libosmo-pfcp Section: libs Priority: optional -Maintainer: Osmocom team <osmocom-net-gprs(a)lists.osmocom.org> -Build-Depends: debhelper (>=10), +Maintainer: Osmocom team <openbsc(a)lists.osmocom.org> +Build-Depends: debhelper (>= 10), dh-autoreconf, autotools-dev, autoconf, -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/32451 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I6ee4aace6bf7c246338408c41f790189d75d5488 Gerrit-Change-Number: 32451 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in libosmo-gprs[master]: debian: set compat level to 10

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32449 ) Change subject: debian: set compat level to 10 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32449 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Icfdbea7cbe4681cd3b286471032fd6dd7226888f Gerrit-Change-Number: 32449 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:11:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libosmo-pfcp[master]: debian: make consistent

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/32451 ) Change subject: debian: make consistent ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/32451 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I6ee4aace6bf7c246338408c41f790189d75d5488 Gerrit-Change-Number: 32451 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:11:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libosmo-abis[master]: e1d: initialize file descriptor numbers to -1 on startup

by pespin

Attention is currently required from: laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32401 ) Change subject: e1d: initialize file descriptor numbers to -1 on startup ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2de8fccad56279748ed9cc035aebf4e2d3935172 Gerrit-Change-Number: 32401 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 11:10:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: l1gprs: reorder #includes, add missing <stdbool.h>

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32503 ) Change subject: l1gprs: reorder #includes, add missing <stdbool.h> ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6fe3b5d85c79a28bc116155c75f7ccd012007f56 Gerrit-Change-Number: 32503 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 10:56:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023