April 2023 - gerrit-log - lists.osmocom.org

[S] Change in simtrace2[master]: debian: set compat level to 10

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/32482 ) Change subject: debian: set compat level to 10 ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/32482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I49fcc4fe9d3e795f8c3514d35ff3e2beca2917d1 Gerrit-Change-Number: 32482 Gerrit-PatchSet: 8 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 26 Apr 2023 09:35:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in simtrace2[master]: debian/rules: remove override_dh_autoreconf

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/32500 ) Change subject: debian/rules: remove override_dh_autoreconf ...................................................................... debian/rules: remove override_dh_autoreconf The Makefile already runs autoreconf -fi in the "utils" target: utils: (cd host && \ autoreconf -fi && \ ./configure --prefix=/usr --disable-werror && \ make) The override is not useful, as it leads to debhelper running autoreconf as well, but without running ./configure and make in the host directory afterwards. So autoreconf just runs twice. I've also considered to change debian/rules to only run the "fw" target, and not the "utils" target of the Makefile. But that only makes it more complex, as debhelper would then need to run make twice, once in the root directory (as "make fw"), and once in the host directory. We would need to add several lines to debian/rules to do effectively the same thing. Make this change now, as "cd host && dh_autoreconf" doesn't work with debhelper compat level v10 anymore (--sourcedir could be used instead, but as mentioned above, it's not useful). Related: OS#5958 Change-Id: I12f379b4ec2de6adc86557d89319ab1d04ed5e73 --- M debian/rules 1 file changed, 33 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/00/32500/1 diff --git a/debian/rules b/debian/rules index 2c615db..9d1fa4b 100755 --- a/debian/rules +++ b/debian/rules @@ -14,6 +14,3 @@ %: dh $@ - -override_dh_autoreconf: - cd host && dh_autoreconf -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/32500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I12f379b4ec2de6adc86557d89319ab1d04ed5e73 Gerrit-Change-Number: 32500 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/gerrit: disable endianness check for osmo-ci

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/32499 ) Change subject: jobs/gerrit: disable endianness check for osmo-ci ...................................................................... jobs/gerrit: disable endianness check for osmo-ci Change-Id: Ib9a2ed2ce02a171f0bdca56728f8cdabf8f4cd1f --- M jobs/gerrit-verifications.yml 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/99/32499/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 94f6698..bdc0ea7 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -208,6 +208,7 @@ - osmo-ci: pipeline_build: false pipeline_binpkgs: false + pipeline_endianness: false - osmo-ggsn: a1_name: GTP -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib9a2ed2ce02a171f0bdca56728f8cdabf8f4cd1f Gerrit-Change-Number: 32499 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/master,gerrit: use PFCP var for osmo-hnbgw

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32432 ) Change subject: jobs/master,gerrit: use PFCP var for osmo-hnbgw ...................................................................... Patch Set 2: (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/32432/comment/12a99cf9_44237516 PS1, Line 380: (PFCP == "--disable-pfcp" && WITH_MANUALS == "0") > (IMHO it should be consistent with WITH_MANUALS, i.e. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4a4e25e0c179c0d408c3728a28eb75bbfa086f48 Gerrit-Change-Number: 32432 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 08:23:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/master,gerrit: use PFCP var for osmo-hnbgw

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/32432 to look at the new patch set (#2). Change subject: jobs/master,gerrit: use PFCP var for osmo-hnbgw ...................................................................... jobs/master,gerrit: use PFCP var for osmo-hnbgw Build osmo-hnbgw with and without PFCP. Build the manuals with PFCP, so it includes the additional VTY commands. Related: OS#6013 Change-Id: I4a4e25e0c179c0d408c3728a28eb75bbfa086f48 --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 42 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/32/32432/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4a4e25e0c179c0d408c3728a28eb75bbfa086f48 Gerrit-Change-Number: 32432 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: contrib/jenkins.sh: add PFCP variable

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 ) Change subject: contrib/jenkins.sh: add PFCP variable ...................................................................... Patch Set 3: (2 comments) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430/comment/d2f59a2d_caf29c18 PS2, Line 9: PFCP=${PFCP:-"--enable-pfcp"} > IMHO it should rather be consistent with 'WITH_MANUALS': […] Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430/comment/78f50568_ddcebf42 PS2, Line 48: = > += here so that WITH_MANUALS == 1 does not lose the --enable-pfcp again oh good catch! fixed -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iacc6a0267d4896d0149f5e00d77951cdfc281e4e Gerrit-Change-Number: 32430 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 08:17:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: contrib/jenkins.sh: add PFCP variable

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 to look at the new patch set (#3). Change subject: contrib/jenkins.sh: add PFCP variable ...................................................................... contrib/jenkins.sh: add PFCP variable Related: OS#6013 Change-Id: Iacc6a0267d4896d0149f5e00d77951cdfc281e4e --- M contrib/jenkins.sh 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/30/32430/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iacc6a0267d4896d0149f5e00d77951cdfc281e4e Gerrit-Change-Number: 32430 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in libosmo-abis[master]: e1d: initialize file descriptor numbers to -1 on startup

by Jenkins Builder

Attention is currently required from: laforge, dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32401 ) Change subject: e1d: initialize file descriptor numbers to -1 on startup ...................................................................... Patch Set 3: (2 comments) File src/input/e1d.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6471): https://gerrit.osmocom.org/c/libosmo-abis/+/32401/comment/3d35ed49_ae045291 PS3, Line 526: for (ts=1; ts<line->num_ts; ts++) { spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6471): https://gerrit.osmocom.org/c/libosmo-abis/+/32401/comment/a80fa09c_09bd10de PS3, Line 526: for (ts=1; ts<line->num_ts; ts++) { spaces required around that '<' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32401 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2de8fccad56279748ed9cc035aebf4e2d3935172 Gerrit-Change-Number: 32401 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 08:09:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libosmo-abis[master]: e1_input: add new driver callback function: line_create

by dexter

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/32400 to look at the new patch set (#3). Change subject: e1_input: add new driver callback function: line_create ...................................................................... e1_input: add new driver callback function: line_create When a line is created using e1inp_line_create, then the line data structures are initialized and the line is registered in the line list. struct e1inp_line also contains driver specific sub structs that, depending on the driver, might also need some initialization. At the moment is no way to do that, so lets add a line_create callback that, when populated by the driver, is executed on line creation. Related: OS#5983 Change-Id: I404fa23e9b8a952be84e9716889c0dbbbc665d22 --- M include/osmocom/abis/e1_input.h M src/e1_input.c 2 files changed, 29 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/00/32400/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I404fa23e9b8a952be84e9716889c0dbbbc665d22 Gerrit-Change-Number: 32400 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in libosmo-abis[master]: e1_input: add new driver callback function: line_create

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32400 ) Change subject: e1_input: add new driver callback function: line_create ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > My comments were not addressed. Thanks for the heads up. That slipped through. File include/osmocom/abis/e1_input.h: https://gerrit.osmocom.org/c/libosmo-abis/+/32400/comment/e3757a1c_3a8ab89e PS1, Line 185: int (*line_create)(struct e1inp_line *line); > This breaks ABI compat. Better put it at the end to minimize chaos. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I404fa23e9b8a952be84e9716889c0dbbbc665d22 Gerrit-Change-Number: 32400 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 08:08:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023