April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: bsc: Add missing tests in expected-results.xml
by pespin 03 Apr '23

03 Apr '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32192 ) Change subject: bsc: Add missing tests in expected-results.xml ...................................................................... bsc: Add missing tests in expected-results.xml Change-Id: I09d503f6d61d4f4d09d83357dd1b79315803584c --- M bsc/expected-results.xml 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/32192/1 diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml index 223800b..a9ce59b 100644 --- a/bsc/expected-results.xml +++ b/bsc/expected-results.xml @@ -105,7 +105,9 @@ <testcase classname='BSC_Tests' name='TC_assignment_sdcch_exhausted_req_signalling' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_assignment_sdcch_exhausted_req_signalling_tch_forbidden' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_assignment_sdcch_exhausted_req_voice_tch_forbidden' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_assignment_codec_hr_osmux_on' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_assignment_osmux' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_assignment_osmux_cn' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_assignment_osmux_bts' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_rll_est_ind_inact_lchan' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_rll_est_ind_inval_sapi1' time='MASKED'/> @@ -140,6 +142,7 @@ <testcase classname='BSC_Tests' name='TC_paging_resp_unsol' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_paging_500req' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_paging_450req_no_paging_load_ind' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_paging_imsi_nochan_ci_resp_invalid_mi' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_rsl_drop_counter' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_rsl_unknown_unit_id' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_oml_unknown_unit_id' time='MASKED'/> @@ -178,6 +181,8 @@ <testcase classname='BSC_Tests' name='TC_ho_in_fail_msc_clears_after_ho_detect' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_in_fail_no_detect' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_in_fail_no_detect2' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_ho_in_fail_mgw_mdcx_timeout' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_ho_in_fail_ipa_crcx_timeout' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_into_this_bsc_sccp_cr_without_bssap' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_neighbor_config_1' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_neighbor_config_2' time='MASKED'/> @@ -218,6 +223,7 @@ <testcase classname='BSC_Tests' name='TC_late_conn_fail' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_stats_conn_fail' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_assignment_emerg_setup_allow' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_assignment_emerg_setup_allow_imei' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_assignment_emerg_setup_deny_msc' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_assignment_emerg_setup_deny_bts' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_emerg_premption' time='MASKED'/> @@ -253,6 +259,13 @@ <testcase classname='BSC_Tests' name='TC_ratectr_all_available_allocated_dyn' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_cm_serv_rej' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_lost_sdcch_during_assignment' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_chan_alloc_algo_ascending' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_chan_alloc_algo_descending' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_chan_alloc_algo_ass_dynamic' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_mgwpool_all_used' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_mgwpool_blocked_not_used' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_mgwpool_pin_bts' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_ho_meas_rep_multi_band' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_out_of_this_bsc' time='MASKED'/> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_gcr_only' time='MASKED'/> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_gcr_bway_connect' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I09d503f6d61d4f4d09d83357dd1b79315803584c Gerrit-Change-Number: 32192 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bts[master]: logging: Introduce LOGPLCGT()
by pespin 03 Apr '23

03 Apr '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32112 ) Change subject: logging: Introduce LOGPLCGT() ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4bf3363f92acdf67d8e7333e30ac2209e31cb287 Gerrit-Change-Number: 32112 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 03 Apr 2023 13:52:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: logging: Introduce LOGPLCGT()
by fixeria 03 Apr '23

03 Apr '23

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32112 ) Change subject: logging: Introduce LOGPLCGT() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4bf3363f92acdf67d8e7333e30ac2209e31cb287 Gerrit-Change-Number: 32112 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Apr 2023 13:35:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: tests: $(BUILT_SOURCES) is not defined, depend on osmo-bts-virtual
by fixeria 03 Apr '23

03 Apr '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32117 ) Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-bts-virtual ...................................................................... tests: $(BUILT_SOURCES) is not defined, depend on osmo-bts-virtual Change-Id: I4ace06e115a2689bde9afd9f99ecee99d796360b --- M tests/Makefile.am 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/Makefile.am b/tests/Makefile.am index a1d04a7..100c5d4 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -32,10 +32,10 @@ DISTCLEANFILES = atconfig if ENABLE_EXT_TESTS -python-tests: $(BUILT_SOURCES) +python-tests: $(MAKE) vty-test else -python-tests: $(BUILT_SOURCES) +python-tests: echo "Not running python-based tests (determined at configure-time)" endif @@ -45,7 +45,7 @@ # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: # make vty-test U=-u -vty-test: +vty-test: $(top_builddir)/src/osmo-bts-virtual/osmo-bts-virtual osmo_verify_transcript_vty.py -v \ -n OsmoBTS -p 4241 \ -r "$(top_builddir)/src/osmo-bts-virtual/osmo-bts-virtual --vty-test -c $(top_srcdir)/doc/examples/virtual/osmo-bts-virtual.cfg" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4ace06e115a2689bde9afd9f99ecee99d796360b Gerrit-Change-Number: 32117 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bts[master]: tests: $(BUILT_SOURCES) is not defined, depend on osmo-bts-virtual
by fixeria 03 Apr '23

03 Apr '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32117 ) Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-bts-virtual ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Other patches identical to this one have been merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4ace06e115a2689bde9afd9f99ecee99d796360b Gerrit-Change-Number: 32117 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Apr 2023 13:33:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-sgsn[master]: tests: $(BUILT_SOURCES) is not defined, depend on osmo-sgsn
by fixeria 03 Apr '23

03 Apr '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/32130 ) Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-sgsn ...................................................................... tests: $(BUILT_SOURCES) is not defined, depend on osmo-sgsn Change-Id: I4f9e99ed3673bb51fa5f7d374c35c3c92735eacb --- M tests/Makefile.am 1 file changed, 14 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index c3dc695..2c07ac9 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -42,15 +42,15 @@ $(NULL) if ENABLE_EXT_TESTS -python-tests: $(BUILT_SOURCES) +python-tests: $(MAKE) vty-test $(MAKE) ctrl-python-test else -python-tests: $(BUILT_SOURCES) +python-tests: echo "Not running python-based tests (determined at configure-time)" endif -vty-python-test: $(BUILT_SOURCES) +vty-python-test: $(top_builddir)/src/sgsn/osmo-sgsn osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v @@ -59,7 +59,7 @@ # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: # make vty-transcript-test U=-u -vty-transcript-test: +vty-transcript-test: $(top_builddir)/src/sgsn/osmo-sgsn osmo_verify_transcript_vty.py -v \ -n OsmoSGSN -p 4245 \ -r "$(top_builddir)/src/sgsn/osmo-sgsn -c $(top_srcdir)/doc/examples/osmo-sgsn/osmo-sgsn.cfg" \ @@ -71,7 +71,7 @@ $(MAKE) vty-python-test $(MAKE) vty-transcript-test -ctrl-python-test: $(BUILT_SOURCES) +ctrl-python-test: $(top_builddir)/src/sgsn/osmo-sgsn $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v rm -f $(top_builddir)/gsn_restart $(top_builddir)/gtphub_restart_count -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/32130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4f9e99ed3673bb51fa5f7d374c35c3c92735eacb Gerrit-Change-Number: 32130 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-sgsn[master]: tests: $(BUILT_SOURCES) is not defined, depend on osmo-sgsn
by fixeria 03 Apr '23

03 Apr '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/32130 ) Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-sgsn ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Other patches identical to this one have been merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/32130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4f9e99ed3673bb51fa5f7d374c35c3c92735eacb Gerrit-Change-Number: 32130 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Apr 2023 13:32:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: codec: add SID classification functions per GSM 06.31 & 06.81
by fixeria 03 Apr '23

03 Apr '23

Attention is currently required from: falconia. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32183 ) Change subject: codec: add SID classification functions per GSM 06.31 & 06.81 ...................................................................... Patch Set 1: (1 comment) File include/osmocom/codec/codec.h: https://gerrit.osmocom.org/c/libosmocore/+/32183/comment/674a1e71_55885cad PS1, Line 85: etsi_sid_class I know it's not strictly followed here in this file, but generally it's a good idea to prepend `osmo_` prefix to all new symbols, including enums and their items. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie91a52c6f04689082d8004311517d8ce0c544916 Gerrit-Change-Number: 32183 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 03 Apr 2023 13:29:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmo-abis[master]: osmo_rtp2trau() for FR & EFR: set SP=0 in DL if the frame is a SID
by fixeria 03 Apr '23

03 Apr '23

Attention is currently required from: falconia. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32079 ) Change subject: osmo_rtp2trau() for FR & EFR: set SP=0 in DL if the frame is a SID ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I371f8072c0afedbd1b065efecfed3734fb6d31ab Gerrit-Change-Number: 32079 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 03 Apr 2023 13:26:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-abis[master]: osmo_rtp2trau() for FR & EFR: correctly handle the no-data case
by fixeria 03 Apr '23

03 Apr '23

Attention is currently required from: falconia, neels, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32078 ) Change subject: osmo_rtp2trau() for FR & EFR: correctly handle the no-data case ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/trau/trau_rtp_conv.c: https://gerrit.osmocom.org/c/libosmo-abis/+/32078/comment/832cb72c_8304c966 PS1, Line 282: } else if (data_len == 0) { : /* C1 .. C5: idle speech */ : tf->c_bits[0] = 0; : tf->c_bits[1] = 1; : tf->c_bits[2] = 1; : tf->c_bits[3] = 1; : tf->c_bits[4] = 0; > > if (UL) { […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7f21e2210bba9ef87f1af515a001a0cfc1c0a1d8 Gerrit-Change-Number: 32078 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 03 Apr 2023 13:25:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0