April 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-gprs[master]: sm: Parse PDP address in rx PDP Ctx Accept
by pespin 14 Apr '23

14 Apr '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32315 ) Change subject: sm: Parse PDP address in rx PDP Ctx Accept ...................................................................... sm: Parse PDP address in rx PDP Ctx Accept Related: OS#5501 Change-Id: Ic41edc14445f0f5d4ef20bb30b53d66fb56435de --- M include/osmocom/gprs/sm/sm_pdu.h M include/osmocom/gprs/sm/sm_prim.h M src/sm/sm.c M src/sm/sm_pdu.c 4 files changed, 118 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/osmocom/gprs/sm/sm_pdu.h b/include/osmocom/gprs/sm/sm_pdu.h index 50e3ae9..d144f6e 100644 --- a/include/osmocom/gprs/sm/sm_pdu.h +++ b/include/osmocom/gprs/sm/sm_pdu.h @@ -2,8 +2,11 @@ #pragma once #include <osmocom/core/msgb.h> +#include <osmocom/core/socket.h> #include <osmocom/gsm/tlv.h> +#include <osmocom/gprs/sm/sm.h> + struct gprs_gmm_entity; #define GPRS_SM_ALLOC_SIZE 2048 @@ -15,3 +18,8 @@ int gprs_sm_build_act_pdp_ctx_req(struct gprs_sm_entity *sme, struct msgb *msg); +int gprs_sm_pdp_addr_dec(const struct gprs_sm_pdp_addr *pdp_addr, + uint16_t pdp_addr_len, + enum osmo_gprs_sm_pdp_addr_ietf_type *pdp_addr_ietf_type, + struct osmo_sockaddr *osa4, + struct osmo_sockaddr *osa6); diff --git a/include/osmocom/gprs/sm/sm_prim.h b/include/osmocom/gprs/sm/sm_prim.h index 575ea80..4f16ae4 100644 --- a/include/osmocom/gprs/sm/sm_prim.h +++ b/include/osmocom/gprs/sm/sm_prim.h @@ -79,7 +79,9 @@ uint8_t pco_len; union { struct { - struct osmo_sockaddr pdp_addr; + enum osmo_gprs_sm_pdp_addr_ietf_type pdp_addr_ietf_type; + struct osmo_sockaddr pdp_addr_v4; + struct osmo_sockaddr pdp_addr_v6; uint8_t qos[OSMO_GPRS_SM_QOS_MAXLEN]; uint8_t qos_len; } acc; diff --git a/src/sm/sm.c b/src/sm/sm.c index b3d65da..d760ae6 100644 --- a/src/sm/sm.c +++ b/src/sm/sm.c @@ -208,8 +208,13 @@ sm_prim_tx->smreg.ms_id = sme->ms->ms_id; sm_prim_tx->smreg.pdp_act_cnf.accepted = (cause != 0); sm_prim_tx->smreg.pdp_act_cnf.nsapi = sme->nsapi; - if (!sm_prim_tx->smreg.pdp_act_cnf.accepted) + if (sm_prim_tx->smreg.pdp_act_cnf.accepted) { + sm_prim_tx->smreg.pdp_act_cnf.acc.pdp_addr_ietf_type = sme->pdp_addr_ietf_type; + memcpy(&sm_prim_tx->smreg.pdp_act_cnf.acc.pdp_addr_v4, &sme->pdp_addr_v4, sizeof(sme->pdp_addr_v4)); + memcpy(&sm_prim_tx->smreg.pdp_act_cnf.acc.pdp_addr_v6, &sme->pdp_addr_v6, sizeof(sme->pdp_addr_v6)); + } else { sm_prim_tx->smreg.pdp_act_cnf.rej.cause = cause; + } rc = gprs_sm_prim_call_up_cb(sm_prim_tx); return rc; @@ -289,16 +294,28 @@ radio_prio = *ofs++; - rc = gprs_sm_tlv_parse(&tp, ofs, len - (ofs - (uint8_t *)gh)); - if (rc < 0) { - LOGSME(sme, LOGL_ERROR, "Rx SM Activate PDP Context Accept: failed to parse TLVs %d\n", rc); - goto rejected; - } - (void)llc_sapi; (void)qos; (void)radio_prio; + if (len > ofs - (uint8_t *)gh) { + rc = gprs_sm_tlv_parse(&tp, ofs, len - (ofs - (uint8_t *)gh)); + if (rc < 0) { + LOGSME(sme, LOGL_ERROR, "Rx SM Activate PDP Context Accept: failed to parse TLVs %d\n", rc); + goto rejected; + } + + if (TLVP_PRESENT(&tp, GSM48_IE_GSM_PDP_ADDR)) { + rc = gprs_sm_pdp_addr_dec( + (const struct gprs_sm_pdp_addr *)TLVP_VAL(&tp, GSM48_IE_GSM_PDP_ADDR), + TLVP_LEN(&tp, GSM48_IE_GSM_PDP_ADDR), + &sme->pdp_addr_ietf_type, + &sme->pdp_addr_v4, &sme->pdp_addr_v6); + if (rc < 0) + goto rejected; + } + } + rc = osmo_fsm_inst_dispatch(sme->ms_fsm.fi, GPRS_SM_MS_EV_RX_ACT_PDP_CTX_ACC, NULL); if (rc < 0) goto rejected; diff --git a/src/sm/sm_pdu.c b/src/sm/sm_pdu.c index 3498a9c..e866a33 100644 --- a/src/sm/sm_pdu.c +++ b/src/sm/sm_pdu.c @@ -24,6 +24,7 @@ #include <osmocom/core/msgb.h> #include <osmocom/core/bitvec.h> #include <osmocom/core/endian.h> +#include <osmocom/core/socket.h> #include <osmocom/gsm/tlv.h> #include <osmocom/gsm/protocol/gsm_04_08.h> #include <osmocom/gsm/protocol/gsm_04_08_gprs.h> @@ -80,6 +81,78 @@ } } +int gprs_sm_pdp_addr_dec(const struct gprs_sm_pdp_addr *pdp_addr, + uint16_t pdp_addr_len, + enum osmo_gprs_sm_pdp_addr_ietf_type *pdp_addr_ietf_type, + struct osmo_sockaddr *osa4, + struct osmo_sockaddr *osa6) +{ + + OSMO_ASSERT(pdp_addr); + OSMO_ASSERT(pdp_addr_ietf_type); + OSMO_ASSERT(osa4); + OSMO_ASSERT(osa6); + + memset(osa4, 0, sizeof(*osa4)); + memset(osa6, 0, sizeof(*osa6)); + osa4->u.sa.sa_family = AF_UNSPEC; + osa6->u.sa.sa_family = AF_UNSPEC; + + switch (pdp_addr->organization) { + case GPRS_SM_PDP_ADDR_ORG_IETF: + break; + case GPRS_SM_PDP_ADDR_ORG_ETSI: + default: + LOGSM(LOGL_INFO, "Unsupported PDP address organization %u\n", pdp_addr->organization); + return -EINVAL; + } + + pdp_addr_len -= 2; + switch (pdp_addr->type) { + case OSMO_GPRS_SM_PDP_ADDR_IETF_IPV4: + if (pdp_addr_len == sizeof(pdp_addr->addr)) { + osa4->u.sa.sa_family = AF_INET; + osa4->u.sin.sin_addr.s_addr = pdp_addr->addr; + } else if (pdp_addr_len != 0) { + LOGSM(LOGL_INFO, "Wrong IPv4 PDP address length %u\n", pdp_addr_len); + return -EINVAL; + } + break; + case OSMO_GPRS_SM_PDP_ADDR_IETF_IPV6: + if (pdp_addr_len == sizeof(pdp_addr->addr6)) { + osa6->u.sa.sa_family = AF_INET6; + memcpy(osa6->u.sin6.sin6_addr.s6_addr, pdp_addr->addr6, sizeof(pdp_addr->addr6)); + } else if (pdp_addr_len != 0) { + LOGSM(LOGL_INFO, "Wrong IPv6 PDP address length %u\n", pdp_addr_len); + return -EINVAL; + } + break; + case OSMO_GPRS_SM_PDP_ADDR_IETF_IPV4V6: + if (pdp_addr_len == sizeof(pdp_addr->addr)) { + osa4->u.sa.sa_family = AF_INET; + osa4->u.sin.sin_addr.s_addr = pdp_addr->both.addr; + } else if (pdp_addr_len == sizeof(pdp_addr->both.addr6)) { + osa6->u.sa.sa_family = AF_INET6; + memcpy(osa6->u.sin6.sin6_addr.s6_addr, pdp_addr->both.addr6, sizeof(pdp_addr->both.addr6)); + } else if (pdp_addr_len == sizeof(pdp_addr->both)) { + osa4->u.sa.sa_family = AF_INET; + osa4->u.sin.sin_addr.s_addr = pdp_addr->both.addr; + osa6->u.sa.sa_family = AF_INET6; + memcpy(osa6->u.sin6.sin6_addr.s6_addr, pdp_addr->both.addr6, sizeof(pdp_addr->both.addr6)); + } else if (pdp_addr_len != 0) { + LOGSM(LOGL_INFO, "Wrong IPv4v6 PDP address length %u\n", pdp_addr_len); + return -EINVAL; + } + break; + default: + LOGSM(LOGL_INFO, "No IPv4 or IPv6\n"); + return -EINVAL; + } + *pdp_addr_ietf_type = pdp_addr->type; + + return 0; +} + /* Chapter 9.4.1: Attach request */ int gprs_sm_build_act_pdp_ctx_req(struct gprs_sm_entity *sme, struct msgb *msg) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32315 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic41edc14445f0f5d4ef20bb30b53d66fb56435de Gerrit-Change-Number: 32315 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-gprs[master]: sm: Handle PCO in rx PDP Ctx Accept
by pespin 14 Apr '23

14 Apr '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32317 ) Change subject: sm: Handle PCO in rx PDP Ctx Accept ...................................................................... sm: Handle PCO in rx PDP Ctx Accept Related: OS#5501 Change-Id: I15ff08cbefb463c8785a138406921563941e7e7d --- M src/sm/sm.c 1 file changed, 25 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/sm/sm.c b/src/sm/sm.c index c57ef3f..0f39708 100644 --- a/src/sm/sm.c +++ b/src/sm/sm.c @@ -208,6 +208,10 @@ sm_prim_tx->smreg.ms_id = sme->ms->ms_id; sm_prim_tx->smreg.pdp_act_cnf.accepted = (cause != 0); sm_prim_tx->smreg.pdp_act_cnf.nsapi = sme->nsapi; + sm_prim_tx->smreg.pdp_act_cnf.pco_len = sme->pco_len; + if (sme->pco_len) + memcpy(sm_prim_tx->smreg.pdp_act_cnf.pco, &sme->pco, sme->pco_len); + if (sm_prim_tx->smreg.pdp_act_cnf.accepted) { sm_prim_tx->smreg.pdp_act_cnf.acc.pdp_addr_ietf_type = sme->pdp_addr_ietf_type; memcpy(&sm_prim_tx->smreg.pdp_act_cnf.acc.pdp_addr_v4, &sme->pdp_addr_v4, sizeof(sme->pdp_addr_v4)); @@ -319,6 +323,17 @@ if (rc < 0) goto rejected; } + + if (TLVP_PRESENT(&tp, GSM48_IE_GSM_PROTO_CONF_OPT)) { + if (TLVP_LEN(&tp, GSM48_IE_GSM_PROTO_CONF_OPT) > ARRAY_SIZE(sme->pco)) { + LOGSME(sme, LOGL_ERROR, + "Rx SM Activate PDP Context Accept: PCO size too big! %u\n", qos_len); + goto rejected; + } + sme->pco_len = TLVP_LEN(&tp, GSM48_IE_GSM_PROTO_CONF_OPT); + if (sme->pco_len) + memcpy(sme->pco, TLVP_VAL(&tp, GSM48_IE_GSM_PROTO_CONF_OPT), sme->pco_len); + } } rc = osmo_fsm_inst_dispatch(sme->ms_fsm.fi, GPRS_SM_MS_EV_RX_ACT_PDP_CTX_ACC, NULL); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I15ff08cbefb463c8785a138406921563941e7e7d Gerrit-Change-Number: 32317 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-gprs[master]: sm: Handle radio_prio,qos,llc_sapi in rx PDP Ctx Accept
by pespin 14 Apr '23

14 Apr '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32316 ) Change subject: sm: Handle radio_prio,qos,llc_sapi in rx PDP Ctx Accept ...................................................................... sm: Handle radio_prio,qos,llc_sapi in rx PDP Ctx Accept Related: OS#5501 Change-Id: Icbd9ba82b6d8cbcfcaf5a80ddc801139c409c585 --- M include/osmocom/gprs/sm/sm_prim.h M include/osmocom/gprs/sm/sm_private.h M src/sm/sm.c 3 files changed, 26 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/osmocom/gprs/sm/sm_prim.h b/include/osmocom/gprs/sm/sm_prim.h index 4f16ae4..86a36d2 100644 --- a/include/osmocom/gprs/sm/sm_prim.h +++ b/include/osmocom/gprs/sm/sm_prim.h @@ -82,6 +82,7 @@ enum osmo_gprs_sm_pdp_addr_ietf_type pdp_addr_ietf_type; struct osmo_sockaddr pdp_addr_v4; struct osmo_sockaddr pdp_addr_v6; + uint8_t radio_prio; /* TS 24.008 10.5.7.2 */ uint8_t qos[OSMO_GPRS_SM_QOS_MAXLEN]; uint8_t qos_len; } acc; diff --git a/include/osmocom/gprs/sm/sm_private.h b/include/osmocom/gprs/sm/sm_private.h index 751123f..163014e 100644 --- a/include/osmocom/gprs/sm/sm_private.h +++ b/include/osmocom/gprs/sm/sm_private.h @@ -103,6 +103,7 @@ struct osmo_sockaddr pdp_addr_v4; struct osmo_sockaddr pdp_addr_v6; + uint8_t radio_prio; /* TS 24.008 10.5.7.2 */ uint8_t qos[OSMO_GPRS_SM_QOS_MAXLEN]; uint8_t qos_len; diff --git a/src/sm/sm.c b/src/sm/sm.c index d760ae6..c57ef3f 100644 --- a/src/sm/sm.c +++ b/src/sm/sm.c @@ -212,6 +212,10 @@ sm_prim_tx->smreg.pdp_act_cnf.acc.pdp_addr_ietf_type = sme->pdp_addr_ietf_type; memcpy(&sm_prim_tx->smreg.pdp_act_cnf.acc.pdp_addr_v4, &sme->pdp_addr_v4, sizeof(sme->pdp_addr_v4)); memcpy(&sm_prim_tx->smreg.pdp_act_cnf.acc.pdp_addr_v6, &sme->pdp_addr_v6, sizeof(sme->pdp_addr_v6)); + sm_prim_tx->smreg.pdp_act_cnf.acc.radio_prio = sme->radio_prio; + sm_prim_tx->smreg.pdp_act_cnf.acc.qos_len = sme->qos_len; + if (sme->qos_len) + memcpy(sm_prim_tx->smreg.pdp_act_cnf.acc.qos, &sme->qos, sme->qos_len); } else { sm_prim_tx->smreg.pdp_act_cnf.rej.cause = cause; } @@ -269,10 +273,8 @@ { struct tlv_parsed tp; int rc; - uint8_t radio_prio, llc_sapi; uint8_t *ofs = (uint8_t *)gh; uint8_t qos_len; - uint8_t *qos; ofs += sizeof(*gh); //uint8_t transaction_id = gsm48_hdr_trans_id(gh); @@ -281,22 +283,25 @@ if (len < (ofs + 2) - (uint8_t *)gh) goto tooshort; - llc_sapi = *ofs++; + sme->llc_sapi = *ofs++; qos_len = *ofs++; + if (qos_len > ARRAY_SIZE(sme->qos)) { + LOGSME(sme, LOGL_ERROR, + "Rx SM Activate PDP Context Accept: QoS size too big! %u\n", qos_len); + goto rejected; + } + if (len < (ofs + qos_len) - (uint8_t *)gh) goto tooshort; - qos = ofs; + memcpy(sme->qos, ofs, qos_len); + ofs += qos_len; if (len < (ofs + 1) - (uint8_t *)gh) goto tooshort; - radio_prio = *ofs++; - - (void)llc_sapi; - (void)qos; - (void)radio_prio; + sme->radio_prio = *ofs++; if (len > ofs - (uint8_t *)gh) { rc = gprs_sm_tlv_parse(&tp, ofs, len - (ofs - (uint8_t *)gh)); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32316 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Icbd9ba82b6d8cbcfcaf5a80ddc801139c409c585 Gerrit-Change-Number: 32316 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[L] Change in libosmo-gprs[master]: sndcp: Test MS vs NET paths separately and implement missing prims fo...
by pespin 14 Apr '23

14 Apr '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32312 ) Change subject: sndcp: Test MS vs NET paths separately and implement missing prims for MS ...................................................................... sndcp: Test MS vs NET paths separately and implement missing prims for MS Related: OS#5502 Change-Id: Iebce37a50917b13c23de1528469d66c310ced7f2 --- M include/osmocom/gprs/sndcp/sndcp.h M include/osmocom/gprs/sndcp/sndcp_private.h M src/sndcp/sndcp.c M src/sndcp/sndcp_prim.c M tests/sndcp/slhc_test.c M tests/sndcp/sndcp_prim_test.c M tests/sndcp/sndcp_prim_test.err M tests/sndcp/sndcp_prim_test.ok M tests/sndcp/sndcp_xid_test.c 9 files changed, 395 insertions(+), 150 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/osmocom/gprs/sndcp/sndcp.h b/include/osmocom/gprs/sndcp/sndcp.h index d9492a3..8acf93f 100644 --- a/include/osmocom/gprs/sndcp/sndcp.h +++ b/include/osmocom/gprs/sndcp/sndcp.h @@ -5,7 +5,13 @@ #include <stdint.h> #include <stddef.h> -int osmo_gprs_sndcp_init(void); +enum osmo_gprs_sndcp_location { + OSMO_GPRS_SNDCP_LOCATION_UNSET, + OSMO_GPRS_SNDCP_LOCATION_MS, + OSMO_GPRS_SNDCP_LOCATION_NET, +}; + +int osmo_gprs_sndcp_init(enum osmo_gprs_sndcp_location location); enum osmo_gprs_sndcp_log_cat { OSMO_GPRS_SNDCP_LOGC_SNDCP, diff --git a/include/osmocom/gprs/sndcp/sndcp_private.h b/include/osmocom/gprs/sndcp/sndcp_private.h index 6f4da3b..dcbde67 100644 --- a/include/osmocom/gprs/sndcp/sndcp_private.h +++ b/include/osmocom/gprs/sndcp/sndcp_private.h @@ -83,6 +83,7 @@ }; struct gprs_sndcp_ctx { + enum osmo_gprs_sndcp_location location; osmo_gprs_sndcp_prim_up_cb sndcp_up_cb; void *sndcp_up_cb_user_data; @@ -157,6 +158,10 @@ /* The defragmentation queue */ struct gprs_sndcp_defrag_state defrag; + /* Whether we have an XID Request in transit which was originated by upper layers (TS 24.007 C.6): */ + bool xid_req_in_transit_orig_snsm_activate_ind; /* origin = SNSM-ACTIVATE.ind */ + bool xid_req_in_transit_orig_sn_xid_req; /* origin = SN-XID.req */ + /* Copy of the XID fields array we have sent with the last * originated XID-Request. NULL if not existing (and l3xid_req_len = 0) */ uint8_t *l3xid_req; @@ -196,16 +201,22 @@ /* sndcp_prim.c: */ struct osmo_gprs_sndcp_prim *gprs_sndcp_prim_alloc_sn_unitdata_ind(uint32_t tlli, uint8_t sapi, uint8_t nsapi, uint8_t *npdu, size_t npdu_len); struct osmo_gprs_sndcp_prim *gprs_sndcp_prim_alloc_sn_xid_ind(uint32_t tlli, uint8_t sapi, uint8_t nsapi); +struct osmo_gprs_sndcp_prim *gprs_sndcp_prim_alloc_sn_xid_cnf(uint32_t tlli, uint8_t sapi, uint8_t nsapi); struct osmo_gprs_sndcp_prim *gprs_sndcp_prim_alloc_snsm_activate_rsp(uint32_t tlli, uint8_t nsapi); int gprs_sndcp_prim_call_up_cb(struct osmo_gprs_sndcp_prim *sndcp_prim); int gprs_sndcp_prim_call_down_cb(struct osmo_gprs_llc_prim *llc_prim); +int gprs_sndcp_prim_call_snsm_cb(struct osmo_gprs_sndcp_prim *sndcp_prim); /* sndcp.c: */ struct gprs_sndcp_mgmt_entity *gprs_sndcp_snme_alloc(uint32_t tlli); struct gprs_sndcp_mgmt_entity *gprs_sndcp_snme_find_by_tlli(uint32_t tlli); struct gprs_sndcp_entity *gprs_sndcp_sne_alloc(struct gprs_sndcp_mgmt_entity *snme, uint8_t llc_sapi, uint8_t nsapi); void gprs_sndcp_sne_free(struct gprs_sndcp_entity *sne); +struct gprs_sndcp_entity *gprs_sndcp_sne_by_dlci(uint32_t tlli, uint8_t llc_sapi); struct gprs_sndcp_entity *gprs_sndcp_sne_by_dlci_nsapi(uint32_t tlli, uint8_t llc_sapi, uint8_t nsapi); +int gprs_sndcp_sne_submit_llc_ll_establish_req(struct gprs_sndcp_entity *sne); +int gprs_sndcp_sne_submit_llc_ll_xid_req(struct gprs_sndcp_entity *sne); +int gprs_sndcp_sne_submit_snsm_activate_rsp(struct gprs_sndcp_entity *sne); int gprs_sndcp_sne_handle_llc_ll_unitdata_ind(struct gprs_sndcp_entity *sne, struct sndcp_common_hdr *sch, uint16_t len); int gprs_sndcp_snme_handle_llc_ll_xid_ind(struct gprs_sndcp_mgmt_entity *snme, uint32_t sapi, uint8_t *l3params, unsigned int l3params_len); diff --git a/src/sndcp/sndcp.c b/src/sndcp/sndcp.c index 6041ecd..4b54be3 100644 --- a/src/sndcp/sndcp.c +++ b/src/sndcp/sndcp.c @@ -34,12 +34,13 @@ struct gprs_sndcp_ctx *g_sndcp_ctx; -int osmo_gprs_sndcp_init(void) +int osmo_gprs_sndcp_init(enum osmo_gprs_sndcp_location location) { if (g_sndcp_ctx) talloc_free(g_sndcp_ctx); g_sndcp_ctx = talloc_zero(NULL, struct gprs_sndcp_ctx); + g_sndcp_ctx->location = location; INIT_LLIST_HEAD(&g_sndcp_ctx->snme_list); return 0; } @@ -142,6 +143,27 @@ talloc_free(sne); } +struct gprs_sndcp_entity *gprs_sndcp_sne_by_dlci(uint32_t tlli, uint8_t llc_sapi) +{ + struct gprs_sndcp_mgmt_entity *snme = gprs_sndcp_snme_find_by_tlli(tlli); + struct gprs_sndcp_entity *sne; + unsigned int i; + + if (!snme) + return NULL; + + for (i = 0; i < ARRAY_SIZE(snme->sne); i++) { + sne = snme->sne[i]; + if (!sne) + continue; + if (sne->llc_sapi != llc_sapi) + continue; + return sne; + } + + return NULL; +} + struct gprs_sndcp_entity *gprs_sndcp_sne_by_dlci_nsapi(uint32_t tlli, uint8_t llc_sapi, uint8_t nsapi) { struct gprs_sndcp_mgmt_entity *snme = gprs_sndcp_snme_find_by_tlli(tlli); @@ -156,6 +178,52 @@ return sne; } +int gprs_sndcp_sne_submit_llc_ll_establish_req(struct gprs_sndcp_entity *sne) +{ + struct osmo_gprs_llc_prim *llc_prim_tx; + int rc; + + llc_prim_tx = osmo_gprs_llc_prim_alloc_ll_establish_req(sne->snme->tlli, sne->llc_sapi, + sne->l3xid_req, sne->l3xid_req_len); + OSMO_ASSERT(llc_prim_tx); + rc = gprs_sndcp_prim_call_down_cb(llc_prim_tx); + return rc; +} + +int gprs_sndcp_sne_submit_llc_ll_xid_req(struct gprs_sndcp_entity *sne) +{ + struct osmo_gprs_llc_prim *llc_prim_tx; + int rc; + + llc_prim_tx = osmo_gprs_llc_prim_alloc_ll_xid_req(sne->snme->tlli, sne->llc_sapi, + sne->l3xid_req, sne->l3xid_req_len); + OSMO_ASSERT(llc_prim_tx); + rc = gprs_sndcp_prim_call_down_cb(llc_prim_tx); + return rc; +} + +int gprs_sndcp_sne_submit_sn_xid_cnf(struct gprs_sndcp_entity *sne) +{ + struct osmo_gprs_sndcp_prim *sndcp_prim_tx; + int rc; + + sndcp_prim_tx = gprs_sndcp_prim_alloc_sn_xid_cnf(sne->snme->tlli, sne->llc_sapi, sne->nsapi); + OSMO_ASSERT(sndcp_prim_tx); + rc = gprs_sndcp_prim_call_up_cb(sndcp_prim_tx); + return rc; +} + +int gprs_sndcp_sne_submit_snsm_activate_rsp(struct gprs_sndcp_entity *sne) +{ + struct osmo_gprs_sndcp_prim *sndcp_prim_tx; + int rc; + + sndcp_prim_tx = gprs_sndcp_prim_alloc_snsm_activate_rsp(sne->snme->tlli, sne->nsapi); + OSMO_ASSERT(sndcp_prim_tx); + rc = gprs_sndcp_prim_call_snsm_cb(sndcp_prim_tx); + return rc; +} + /* Check if any compression parameters are set in the sgsn configuration */ static inline int any_pcomp_or_dcomp_active(const struct gprs_sndcp_ctx *sgsn) { @@ -695,7 +763,6 @@ { int rc; uint8_t l3params[1024]; - struct osmo_gprs_llc_prim *llc_prim_tx; /* Wipe off all compression entities and their states to * get rid of possible leftovers from a previous session */ @@ -714,12 +781,9 @@ talloc_free(sne->l3xid_req); sne->l3xid_req = NULL; } + sne->xid_req_in_transit_orig_sn_xid_req = true; - llc_prim_tx = osmo_gprs_llc_prim_alloc_ll_xid_req(sne->snme->tlli, sne->llc_sapi, - sne->l3xid_req, sne->l3xid_req_len); - OSMO_ASSERT(llc_prim_tx); - rc = gprs_sndcp_prim_call_down_cb(llc_prim_tx); - + rc = gprs_sndcp_sne_submit_llc_ll_xid_req(sne); return rc; } @@ -1020,8 +1084,6 @@ if (sne_i->llc_sapi != sapi) continue; LOGSNE(sne_i, LOGL_DEBUG, "LL-XID.cnf: Found SNE SAPI=%u\n", sapi); - if (!sne_i->l3xid_req || sne_i->l3xid_req_len == 0) - continue; sne = sne_i; break; } @@ -1030,38 +1092,56 @@ return -EINVAL; } - /* Parse SNDCP-CID XID-Field */ - comp_fields_req = gprs_sndcp_parse_xid(NULL, sne, sne->l3xid_req, sne->l3xid_req_len, NULL); - if (!comp_fields_req) - return -EINVAL; + if (sne->l3xid_req && sne->l3xid_req_len > 0) { + /* Parse SNDCP-CID XID-Field */ + comp_fields_req = gprs_sndcp_parse_xid(NULL, sne, sne->l3xid_req, sne->l3xid_req_len, NULL); + if (!comp_fields_req) + return -EINVAL; - /* Parse SNDCP-CID XID-Field */ - comp_fields_conf = gprs_sndcp_parse_xid(NULL, sne, l3params, l3params_len, comp_fields_req); - if (!comp_fields_conf) { - talloc_free(comp_fields_req); - return -EINVAL; - } - - LOGSNDCP(LOGL_DEBUG, "LL-XID.cnf response comp_fields:\n"); - gprs_sndcp_dump_comp_fields(comp_fields_conf, LOGL_DEBUG); - - /* Handle compression entities */ - llist_for_each_entry(comp_field, comp_fields_conf, list) { - compclass = gprs_sndcp_get_compression_class(comp_field); - if (compclass == SNDCP_XID_PROTOCOL_COMPRESSION) - rc = gprs_sndcp_snme_handle_pcomp_entities(snme, sapi, comp_field); - else if (compclass == SNDCP_XID_DATA_COMPRESSION) - rc = gprs_sndcp_snme_handle_dcomp_entities(snme, sapi, comp_field); - else { - gprs_sndcp_comp_delete(snme->comp.proto, comp_field->entity); - gprs_sndcp_comp_delete(snme->comp.data, comp_field->entity); - rc = 0; + /* Parse SNDCP-CID XID-Field */ + comp_fields_conf = gprs_sndcp_parse_xid(NULL, sne, l3params, l3params_len, comp_fields_req); + if (!comp_fields_conf) { + talloc_free(comp_fields_req); + return -EINVAL; } - if (rc < 0) - break; + + LOGSNDCP(LOGL_DEBUG, "LL-XID.cnf response comp_fields:\n"); + gprs_sndcp_dump_comp_fields(comp_fields_conf, LOGL_DEBUG); + + /* Handle compression entities */ + llist_for_each_entry(comp_field, comp_fields_conf, list) { + compclass = gprs_sndcp_get_compression_class(comp_field); + if (compclass == SNDCP_XID_PROTOCOL_COMPRESSION) + rc = gprs_sndcp_snme_handle_pcomp_entities(snme, sapi, comp_field); + else if (compclass == SNDCP_XID_DATA_COMPRESSION) + rc = gprs_sndcp_snme_handle_dcomp_entities(snme, sapi, comp_field); + else { + gprs_sndcp_comp_delete(snme->comp.proto, comp_field->entity); + gprs_sndcp_comp_delete(snme->comp.data, comp_field->entity); + rc = 0; + } + if (rc < 0) + break; + } + + talloc_free(comp_fields_req); + talloc_free(comp_fields_conf); } - talloc_free(comp_fields_req); - talloc_free(comp_fields_conf); + /* Originated by SNSM-ACTIVATE.ind: */ + if (sne->xid_req_in_transit_orig_snsm_activate_ind) { + sne->xid_req_in_transit_orig_snsm_activate_ind = false; + rc = gprs_sndcp_sne_submit_snsm_activate_rsp(sne); + } + /* Originated by SN-XID.req: */ + if (sne->xid_req_in_transit_orig_sn_xid_req) { + sne->xid_req_in_transit_orig_sn_xid_req = false; + rc = gprs_sndcp_sne_submit_sn_xid_cnf(sne); + } + + /* TODO: + * gprs_sndcp_prim_alloc_sn_xid_cnf() SN-XID-CNF if SN-XID-REQ pending + * gprs_sndcp_prim_alloc_snsm_activate_rsp() SNSM-ACTIVATE-RSP if SNSM-ACTIVATE-IND pending + */ return rc; } diff --git a/src/sndcp/sndcp_prim.c b/src/sndcp/sndcp_prim.c index bc22c9c..b9b5041 100644 --- a/src/sndcp/sndcp_prim.c +++ b/src/sndcp/sndcp_prim.c @@ -206,7 +206,7 @@ return sndcp_prim; } -/* 5.1.1.5 SN-XID.indication */ +/* 5.1.1.6 SN-XID.indication */ struct osmo_gprs_sndcp_prim *gprs_sndcp_prim_alloc_sn_xid_ind(uint32_t tlli, uint8_t sapi, uint8_t nsapi) { struct osmo_gprs_sndcp_prim *sndcp_prim; @@ -228,6 +228,17 @@ return sndcp_prim; } +/* 5.1.1.8 SN-XID.confirmation */ +struct osmo_gprs_sndcp_prim *gprs_sndcp_prim_alloc_sn_xid_cnf(uint32_t tlli, uint8_t sapi, uint8_t nsapi) +{ + struct osmo_gprs_sndcp_prim *sndcp_prim; + sndcp_prim = sndcp_prim_sn_alloc(OSMO_GPRS_SNDCP_SN_XID, PRIM_OP_CONFIRM, 0); + sndcp_prim->sn.tlli = tlli; + sndcp_prim->sn.sapi = sapi; + sndcp_prim->sn.xid_ind.nsapi = nsapi; + return sndcp_prim; +} + /*** SN SM ***/ static inline struct osmo_gprs_sndcp_prim *sndcp_prim_snsm_alloc(enum osmo_gprs_sndcp_snsm_prim_type type, @@ -456,6 +467,23 @@ return rc; } +static int gprs_sndcp_prim_handle_llc_ll_establish_cnf(struct osmo_gprs_llc_prim *llc_prim) +{ + int rc; + struct gprs_sndcp_entity *sne; + + sne = gprs_sndcp_sne_by_dlci(llc_prim->ll.tlli, llc_prim->ll.sapi); + if (!sne) { + LOGSNDCP(LOGL_ERROR, "Message for non-existing SNDCP Entity " + "(TLLI=%08x, SAPI=%u)\n", + llc_prim->ll.tlli, llc_prim->ll.sapi); + return -EIO; + } + + rc = gprs_sndcp_sne_submit_snsm_activate_rsp(sne); + return rc; +} + static int gprs_sndcp_prim_handle_llc_ll_xid_ind(struct osmo_gprs_llc_prim *llc_prim) { int rc; @@ -500,6 +528,9 @@ case OSMO_PRIM(OSMO_GPRS_LLC_LL_UNITDATA, PRIM_OP_INDICATION): rc = gprs_sndcp_prim_handle_llc_ll_unitdata_ind(llc_prim); break; + case OSMO_PRIM(OSMO_GPRS_LLC_LL_ESTABLISH, PRIM_OP_CONFIRM): + rc = gprs_sndcp_prim_handle_llc_ll_establish_cnf(llc_prim); + break; case OSMO_PRIM(OSMO_GPRS_LLC_LL_XID, PRIM_OP_INDICATION): rc = gprs_sndcp_prim_handle_llc_ll_xid_ind(llc_prim); break; @@ -528,6 +559,7 @@ break; default: rc = gprs_sndcp_prim_handle_llc_ll_unsupported(llc_prim); + rc = 1; } /* Special return value '1' means: do not free */ @@ -561,6 +593,7 @@ uint8_t sapi = sndcp_prim->snsm.activate_ind.sapi; uint8_t nsapi = sndcp_prim->snsm.activate_ind.nsapi; struct gprs_sndcp_mgmt_entity *snme; + struct gprs_sndcp_entity *sne; LOGSNDCP(LOGL_INFO, "SNSM-ACTIVATE.ind (TLLI=%08x, SAPI=%u, NSAPI=%u)\n", tlli, sapi, nsapi); @@ -568,23 +601,36 @@ snme = gprs_sndcp_snme_find_by_tlli(tlli); if (!snme) { snme = gprs_sndcp_snme_alloc(tlli); - } else if (gprs_sndcp_snme_get_sne(snme, nsapi)) { - LOGSNDCP(LOGL_ERROR, "Trying to ACTIVATE already-existing entity " - "(TLLI=%08x, SAPI=%u, NSAPI=%u)\n", - tlli, sapi, nsapi); - return -EEXIST; + if (!snme) { + LOGSNDCP(LOGL_ERROR, "Out of memory during ACTIVATE\n"); + return -ENOMEM; + } } - if (!snme) { - LOGSNDCP(LOGL_ERROR, "Out of memory during ACTIVATE\n"); - return -ENOMEM; + if (!(sne = gprs_sndcp_snme_get_sne(snme, nsapi))) { + sne = gprs_sndcp_sne_alloc(snme, sapi, nsapi); + if (!sne) { + LOGSNME(snme, LOGL_ERROR, "Out of memory during ACTIVATE\n"); + return -ENOMEM; + } } - if (!gprs_sndcp_sne_alloc(snme, sapi, nsapi)) { - LOGSNDCP(LOGL_ERROR, "Out of memory during ACTIVATE\n"); - return -ENOMEM; - } + /* Nothing to do below if we are not MS. In NET mode, we wait for + * LL-ESTABLISH-IND or LL-XID-IND. */ + if (g_sndcp_ctx->location != OSMO_GPRS_SNDCP_LOCATION_MS) + return 0; + /* TODO: when supporting and using LLC ABM mode, flow should go through + * LL-ESTABLISH.req, as per TS 24.007 C.6 "No LLC link exists yet, + * establish a link and exchange XID" + * + * rc = gprs_sndcp_sne_submit_llc_ll_establish_req(sne); + * return rc; + */ + + /* TS 24.007 C.6 "LLC link exists already, only XID exchange" */ + sne->xid_req_in_transit_orig_snsm_activate_ind = true; + rc = gprs_sndcp_sne_submit_llc_ll_xid_req(sne); return rc; } diff --git a/tests/sndcp/slhc_test.c b/tests/sndcp/slhc_test.c index fdebb5b..31126ad 100644 --- a/tests/sndcp/slhc_test.c +++ b/tests/sndcp/slhc_test.c @@ -262,7 +262,7 @@ log_ctx = talloc_named_const(ctx, 0, "log"); osmo_init_logging2(log_ctx, &info); - rc = osmo_gprs_sndcp_init(); + rc = osmo_gprs_sndcp_init(OSMO_GPRS_SNDCP_LOCATION_MS); OSMO_ASSERT(rc == 0); osmo_gprs_sndcp_set_log_cat(OSMO_GPRS_SNDCP_LOGC_SNDCP, DSNDCP); osmo_gprs_sndcp_set_log_cat(OSMO_GPRS_SNDCP_LOGC_SLHC, DSLHC); diff --git a/tests/sndcp/sndcp_prim_test.c b/tests/sndcp/sndcp_prim_test.c index b1f29ef..cf29ec0 100644 --- a/tests/sndcp/sndcp_prim_test.c +++ b/tests/sndcp/sndcp_prim_test.c @@ -93,7 +93,15 @@ OSMO_ASSERT(0); } - printf("%s(): Rx %s\n", __func__, npdu_name); + switch (OSMO_PRIM_HDR(&sndcp_prim->oph)) { + case OSMO_PRIM(OSMO_GPRS_SNDCP_SNSM_ACTIVATE, PRIM_OP_RESPONSE): + printf("%s(): Rx %s\n", __func__, npdu_name); + break; + default: + printf("%s(): Unexpected Rx %s\n", __func__, npdu_name); + OSMO_ASSERT(0); + } + return 0; } @@ -113,7 +121,7 @@ 0x01, 0x05, 0x00, 0x06, 0x00, 0x07, 0x01, 0x07, 0x00, 0x08, 0x01, 0x08, 0x80, 0x00, 0x04, 0x12, 0x00, 0x40, 0x07 }; -static void test_sndcp_prim(void) +static void test_sndcp_prim_net(void) { struct osmo_gprs_sndcp_prim *sndcp_prim; struct osmo_gprs_llc_prim *llc_prim; @@ -124,32 +132,21 @@ int rc; printf("==== %s() [start] ====\n", __func__); - rc = osmo_gprs_sndcp_init(); + rc = osmo_gprs_sndcp_init(OSMO_GPRS_SNDCP_LOCATION_NET); OSMO_ASSERT(rc == 0); osmo_gprs_sndcp_prim_set_up_cb(test_sndcp_prim_up_cb, NULL); osmo_gprs_sndcp_prim_set_down_cb(test_sndcp_prim_down_cb, NULL); osmo_gprs_sndcp_prim_set_snsm_cb(test_sndcp_prim_snsm_cb, NULL); - /* SNSM-ACTIVATE.Ind: */ + /* SNSM-ACTIVATE.Ind, internally submits LL-XID.Req (it would submit + * LL-ESTABLISH.Req in ABM mode if we supported it): */ sndcp_prim = osmo_gprs_sndcp_prim_alloc_snsm_activate_ind(tlli, nsapi, ll_sapi); OSMO_ASSERT(sndcp_prim); rc = osmo_gprs_sndcp_prim_dispatch_snsm(sndcp_prim); OSMO_ASSERT(rc == 0); - /* Submit SN-XID.Req, triggers rx of LL-XID.Req: */ - sndcp_prim = osmo_gprs_sndcp_prim_alloc_sn_xid_req(tlli, ll_sapi, nsapi); - OSMO_ASSERT(sndcp_prim); - sndcp_prim->sn.xid_req.pcomp_rfc1144.active = true; - sndcp_prim->sn.xid_req.pcomp_rfc1144.s01 = 7; - rc = osmo_gprs_sndcp_prim_upper_down(sndcp_prim); - OSMO_ASSERT(rc == 0); - - /* Submit LL-XID.Cnf, triggers rx of LL-XID.cnf */ - llc_prim = gprs_llc_prim_alloc_ll_xid_cnf(tlli, ll_sapi, (uint8_t *)sndcp_xid, sizeof(sndcp_xid)); - OSMO_ASSERT(llc_prim); - rc = osmo_gprs_sndcp_prim_lower_up(llc_prim); - OSMO_ASSERT(rc == 0); + /* Id we supported and use ABM: Submit LL-ESTABLISH.Ind, triggers rx of LL-ESTABLISH.Rsp */ /* Submit LL-XID.Ind, triggers rx of SN-XID.Ind: */ llc_prim = gprs_llc_prim_alloc_ll_xid_ind(tlli, ll_sapi, (uint8_t *)sndcp_xid, sizeof(sndcp_xid)); @@ -177,7 +174,84 @@ /* TODO: SN-XID REQ / IND / RESP / CONF - * TODO: Other primitivbes coming from LLC layer + * TODO: Other primitives coming from LLC layer + */ + + /* SNSM-DEACTIVATE.Ind: */ + sndcp_prim = osmo_gprs_sndcp_prim_alloc_snsm_deactivate_ind(tlli, nsapi); + OSMO_ASSERT(sndcp_prim); + rc = osmo_gprs_sndcp_prim_dispatch_snsm(sndcp_prim); + OSMO_ASSERT(rc == 0); + + printf("==== %s() [end] ====\n", __func__); +} + +static void test_sndcp_prim_ms(void) +{ + struct osmo_gprs_sndcp_prim *sndcp_prim; + struct osmo_gprs_llc_prim *llc_prim; + const uint32_t tlli = 0xe1c5d364; + const enum osmo_gprs_llc_sapi ll_sapi = OSMO_GPRS_LLC_SAPI_SNDCP3; + const uint8_t nsapi = 0x05; + uint8_t sndcp_data[1024]; + int rc; + printf("==== %s() [start] ====\n", __func__); + + rc = osmo_gprs_sndcp_init(OSMO_GPRS_SNDCP_LOCATION_MS); + OSMO_ASSERT(rc == 0); + + osmo_gprs_sndcp_prim_set_up_cb(test_sndcp_prim_up_cb, NULL); + osmo_gprs_sndcp_prim_set_down_cb(test_sndcp_prim_down_cb, NULL); + osmo_gprs_sndcp_prim_set_snsm_cb(test_sndcp_prim_snsm_cb, NULL); + + /* SNSM-ACTIVATE.Ind, internally submits LL-XID.Req (it would submit + * LL-ESTABLISH.Req in ABM mode if we supported it): */ + sndcp_prim = osmo_gprs_sndcp_prim_alloc_snsm_activate_ind(tlli, nsapi, ll_sapi); + OSMO_ASSERT(sndcp_prim); + rc = osmo_gprs_sndcp_prim_dispatch_snsm(sndcp_prim); + OSMO_ASSERT(rc == 0); + + /* Id we supported and use ABM: Submit LL-ESTABLISH.Cnf, triggers rx of SNSM-ACTIVATE.Rsp */ + //llc_prim = gprs_llc_prim_alloc_ll_establish_cnf(tlli, ll_sapi, (uint8_t *)sndcp_xid, sizeof(sndcp_xid)); + //OSMO_ASSERT(llc_prim); + //rc = osmo_gprs_sndcp_prim_lower_up(llc_prim); + //OSMO_ASSERT(rc == 0); + + /* Network answers XID req, Submit LL-XID.Cnf, triggers rx of SNSM-ACTIVATE-RSP */ + llc_prim = gprs_llc_prim_alloc_ll_xid_cnf(tlli, ll_sapi, (uint8_t *)sndcp_xid, sizeof(sndcp_xid)); + OSMO_ASSERT(llc_prim); + rc = osmo_gprs_sndcp_prim_lower_up(llc_prim); + OSMO_ASSERT(rc == 0); + + /* Submit SN-XID.Req from upper layers, triggers rx of LL-XID.Req: */ + sndcp_prim = osmo_gprs_sndcp_prim_alloc_sn_xid_req(tlli, ll_sapi, nsapi); + OSMO_ASSERT(sndcp_prim); + sndcp_prim->sn.xid_req.pcomp_rfc1144.active = true; + sndcp_prim->sn.xid_req.pcomp_rfc1144.s01 = 7; + rc = osmo_gprs_sndcp_prim_upper_down(sndcp_prim); + OSMO_ASSERT(rc == 0); + + /* Submit LL-XID.Cnf, triggers rx of SN-XID.cnf */ + llc_prim = gprs_llc_prim_alloc_ll_xid_cnf(tlli, ll_sapi, (uint8_t *)sndcp_xid, sizeof(sndcp_xid)); + OSMO_ASSERT(llc_prim); + rc = osmo_gprs_sndcp_prim_lower_up(llc_prim); + OSMO_ASSERT(rc == 0); + + OSMO_ASSERT(osmo_hexparse(sndcp_data_hex, sndcp_data, sizeof(sndcp_data)) > 0); + llc_prim = gprs_llc_prim_alloc_ll_unitdata_ind(tlli, ll_sapi, (uint8_t *)sndcp_data, sizeof(sndcp_data)); + OSMO_ASSERT(llc_prim); + rc = osmo_gprs_sndcp_prim_lower_up(llc_prim); + OSMO_ASSERT(rc == 0); + + char ndpu_data[] = "some-npdu-data-like-an-ip-pkt"; + sndcp_prim = osmo_gprs_sndcp_prim_alloc_sn_unitdata_req(tlli, ll_sapi, nsapi, (uint8_t *)ndpu_data, sizeof(ndpu_data)); + OSMO_ASSERT(sndcp_prim); + rc = osmo_gprs_sndcp_prim_upper_down(sndcp_prim); + OSMO_ASSERT(rc == 0); + + + /* TODO: SN-XID REQ / IND / RESP / CONF + * TODO: Other primitives coming from LLC layer */ /* SNSM-DEACTIVATE.Ind: */ @@ -208,7 +282,8 @@ log_set_print_level(osmo_stderr_target, 1); log_set_use_color(osmo_stderr_target, 0); - test_sndcp_prim(); + test_sndcp_prim_net(); + test_sndcp_prim_ms(); talloc_free(tall_ctx); } diff --git a/tests/sndcp/sndcp_prim_test.err b/tests/sndcp/sndcp_prim_test.err index f27486d..d61a18a 100644 --- a/tests/sndcp/sndcp_prim_test.err +++ b/tests/sndcp/sndcp_prim_test.err @@ -1,79 +1,5 @@ DLGLOBAL INFO Rx from SNDCP SM sublayer: SNSM-ACTIVATE.indication DLGLOBAL INFO SNSM-ACTIVATE.ind (TLLI=e1c5d364, SAPI=3, NSAPI=5) -DLGLOBAL INFO Rx from upper layers: SN-XID.request -DLGLOBAL DEBUG SNE(e1c5d364,SNDCP3,5) SN-XID.req comp_fields: -DLGLOBAL DEBUG SNDCP-XID: -DLGLOBAL DEBUG struct gprs_sndcp_comp_field { -DLGLOBAL DEBUG entity=0; -DLGLOBAL DEBUG algo=0; -DLGLOBAL DEBUG comp_len=2; -DLGLOBAL DEBUG comp[0]=1; -DLGLOBAL DEBUG comp[1]=2; -DLGLOBAL DEBUG gprs_sndcp_pcomp_rfc1144_params { -DLGLOBAL DEBUG nsapi_len=1; -DLGLOBAL DEBUG nsapi[0]=5; -DLGLOBAL DEBUG s01=7; -DLGLOBAL DEBUG } -DLGLOBAL DEBUG } -DLGLOBAL INFO Rx from lower layers: LL-XID.confirm -DLGLOBAL DEBUG SNE(e1c5d364,SNDCP3,5) LL-XID.cnf: Found SNE SAPI=3 -DLGLOBAL DEBUG LL-XID.cnf response comp_fields: -DLGLOBAL DEBUG SNDCP-XID: -DLGLOBAL DEBUG struct gprs_sndcp_comp_field { -DLGLOBAL DEBUG entity=0; -DLGLOBAL DEBUG algo=0; -DLGLOBAL DEBUG comp_len=2; -DLGLOBAL DEBUG comp[0]=1; -DLGLOBAL DEBUG comp[1]=2; -DLGLOBAL DEBUG gprs_sndcp_pcomp_rfc1144_params { -DLGLOBAL DEBUG nsapi_len=1; -DLGLOBAL DEBUG nsapi[0]=6; -DLGLOBAL DEBUG s01=7; -DLGLOBAL DEBUG } -DLGLOBAL DEBUG } -DLGLOBAL DEBUG SNDCP-XID: -DLGLOBAL DEBUG struct gprs_sndcp_comp_field { -DLGLOBAL DEBUG entity=2; -DLGLOBAL DEBUG algo=2; -DLGLOBAL DEBUG comp_len=2; -DLGLOBAL DEBUG comp[0]=8; -DLGLOBAL DEBUG comp[1]=9; -DLGLOBAL DEBUG gprs_sndcp_pcomp_rohc_params { -DLGLOBAL DEBUG nsapi_len=11; -DLGLOBAL DEBUG nsapi[0]=5; -DLGLOBAL DEBUG nsapi[1]=6; -DLGLOBAL DEBUG nsapi[2]=7; -DLGLOBAL DEBUG nsapi[3]=8; -DLGLOBAL DEBUG nsapi[4]=9; -DLGLOBAL DEBUG nsapi[5]=10; -DLGLOBAL DEBUG nsapi[6]=11; -DLGLOBAL DEBUG nsapi[7]=12; -DLGLOBAL DEBUG nsapi[8]=13; -DLGLOBAL DEBUG nsapi[9]=14; -DLGLOBAL DEBUG nsapi[10]=15; -DLGLOBAL DEBUG max_cid=15; -DLGLOBAL DEBUG max_header=168; -DLGLOBAL DEBUG profile_len=16; -DLGLOBAL DEBUG profile[0]=0000; -DLGLOBAL DEBUG profile[1]=0001; -DLGLOBAL DEBUG profile[2]=0101; -DLGLOBAL DEBUG profile[3]=0002; -DLGLOBAL DEBUG profile[4]=0102; -DLGLOBAL DEBUG profile[5]=0003; -DLGLOBAL DEBUG profile[6]=0103; -DLGLOBAL DEBUG profile[7]=0004; -DLGLOBAL DEBUG profile[8]=0104; -DLGLOBAL DEBUG profile[9]=0005; -DLGLOBAL DEBUG profile[10]=0105; -DLGLOBAL DEBUG profile[11]=0006; -DLGLOBAL DEBUG profile[12]=0007; -DLGLOBAL DEBUG profile[13]=0107; -DLGLOBAL DEBUG profile[14]=0008; -DLGLOBAL DEBUG profile[15]=0108; -DLGLOBAL DEBUG } -DLGLOBAL DEBUG } -DLGLOBAL DEBUG SNME(e1c5d364) Rejecting RFC1144 header compression... -DLGLOBAL DEBUG SNME(e1c5d364) Rejecting ROHC header compression... DLGLOBAL INFO Rx from lower layers: LL-XID.indication DLGLOBAL DEBUG SNE(e1c5d364,SNDCP3,5) LL-XID.ind: Found SNE SAPI=3 DLGLOBAL DEBUG SNME(e1c5d364) LL-XID.cnf requested comp_fields: @@ -185,3 +111,87 @@ DLGLOBAL DEBUG SNE(e1c5d364,SNDCP3,5) free() DLGLOBAL DEBUG SNME(e1c5d364) No SNDCP Entities left activate, freeing SNME DLGLOBAL DEBUG SNME(e1c5d364) free() +DLGLOBAL INFO Rx from SNDCP SM sublayer: SNSM-ACTIVATE.indication +DLGLOBAL INFO SNSM-ACTIVATE.ind (TLLI=e1c5d364, SAPI=3, NSAPI=5) +DLGLOBAL INFO Rx from lower layers: LL-XID.confirm +DLGLOBAL DEBUG SNE(e1c5d364,SNDCP3,5) LL-XID.cnf: Found SNE SAPI=3 +DLGLOBAL INFO Rx from upper layers: SN-XID.request +DLGLOBAL DEBUG SNE(e1c5d364,SNDCP3,5) SN-XID.req comp_fields: +DLGLOBAL DEBUG SNDCP-XID: +DLGLOBAL DEBUG struct gprs_sndcp_comp_field { +DLGLOBAL DEBUG entity=0; +DLGLOBAL DEBUG algo=0; +DLGLOBAL DEBUG comp_len=2; +DLGLOBAL DEBUG comp[0]=1; +DLGLOBAL DEBUG comp[1]=2; +DLGLOBAL DEBUG gprs_sndcp_pcomp_rfc1144_params { +DLGLOBAL DEBUG nsapi_len=1; +DLGLOBAL DEBUG nsapi[0]=5; +DLGLOBAL DEBUG s01=7; +DLGLOBAL DEBUG } +DLGLOBAL DEBUG } +DLGLOBAL INFO Rx from lower layers: LL-XID.confirm +DLGLOBAL DEBUG SNE(e1c5d364,SNDCP3,5) LL-XID.cnf: Found SNE SAPI=3 +DLGLOBAL DEBUG LL-XID.cnf response comp_fields: +DLGLOBAL DEBUG SNDCP-XID: +DLGLOBAL DEBUG struct gprs_sndcp_comp_field { +DLGLOBAL DEBUG entity=0; +DLGLOBAL DEBUG algo=0; +DLGLOBAL DEBUG comp_len=2; +DLGLOBAL DEBUG comp[0]=1; +DLGLOBAL DEBUG comp[1]=2; +DLGLOBAL DEBUG gprs_sndcp_pcomp_rfc1144_params { +DLGLOBAL DEBUG nsapi_len=1; +DLGLOBAL DEBUG nsapi[0]=6; +DLGLOBAL DEBUG s01=7; +DLGLOBAL DEBUG } +DLGLOBAL DEBUG } +DLGLOBAL DEBUG SNDCP-XID: +DLGLOBAL DEBUG struct gprs_sndcp_comp_field { +DLGLOBAL DEBUG entity=2; +DLGLOBAL DEBUG algo=2; +DLGLOBAL DEBUG comp_len=2; +DLGLOBAL DEBUG comp[0]=8; +DLGLOBAL DEBUG comp[1]=9; +DLGLOBAL DEBUG gprs_sndcp_pcomp_rohc_params { +DLGLOBAL DEBUG nsapi_len=11; +DLGLOBAL DEBUG nsapi[0]=5; +DLGLOBAL DEBUG nsapi[1]=6; +DLGLOBAL DEBUG nsapi[2]=7; +DLGLOBAL DEBUG nsapi[3]=8; +DLGLOBAL DEBUG nsapi[4]=9; +DLGLOBAL DEBUG nsapi[5]=10; +DLGLOBAL DEBUG nsapi[6]=11; +DLGLOBAL DEBUG nsapi[7]=12; +DLGLOBAL DEBUG nsapi[8]=13; +DLGLOBAL DEBUG nsapi[9]=14; +DLGLOBAL DEBUG nsapi[10]=15; +DLGLOBAL DEBUG max_cid=15; +DLGLOBAL DEBUG max_header=168; +DLGLOBAL DEBUG profile_len=16; +DLGLOBAL DEBUG profile[0]=0000; +DLGLOBAL DEBUG profile[1]=0001; +DLGLOBAL DEBUG profile[2]=0101; +DLGLOBAL DEBUG profile[3]=0002; +DLGLOBAL DEBUG profile[4]=0102; +DLGLOBAL DEBUG profile[5]=0003; +DLGLOBAL DEBUG profile[6]=0103; +DLGLOBAL DEBUG profile[7]=0004; +DLGLOBAL DEBUG profile[8]=0104; +DLGLOBAL DEBUG profile[9]=0005; +DLGLOBAL DEBUG profile[10]=0105; +DLGLOBAL DEBUG profile[11]=0006; +DLGLOBAL DEBUG profile[12]=0007; +DLGLOBAL DEBUG profile[13]=0107; +DLGLOBAL DEBUG profile[14]=0008; +DLGLOBAL DEBUG profile[15]=0108; +DLGLOBAL DEBUG } +DLGLOBAL DEBUG } +DLGLOBAL DEBUG SNME(e1c5d364) Rejecting RFC1144 header compression... +DLGLOBAL DEBUG SNME(e1c5d364) Rejecting ROHC header compression... +DLGLOBAL INFO Rx from lower layers: LL-UNITDATA.indication +DLGLOBAL INFO Rx from upper layers: SN-UNITDATA.request +DLGLOBAL INFO Rx from SNDCP SM sublayer: SNSM-DEACTIVATE.indication +DLGLOBAL DEBUG SNE(e1c5d364,SNDCP3,5) free() +DLGLOBAL DEBUG SNME(e1c5d364) No SNDCP Entities left activate, freeing SNME +DLGLOBAL DEBUG SNME(e1c5d364) free() diff --git a/tests/sndcp/sndcp_prim_test.ok b/tests/sndcp/sndcp_prim_test.ok index 4a635fc..621aea7 100644 --- a/tests/sndcp/sndcp_prim_test.ok +++ b/tests/sndcp/sndcp_prim_test.ok @@ -1,7 +1,14 @@ -==== test_sndcp_prim() [start] ==== -test_sndcp_prim_down_cb(): Rx LL-XID.request +==== test_sndcp_prim_net() [start] ==== test_sndcp_prim_up_cb(): Rx SN-XID.indication test_sndcp_prim_down_cb(): Rx LL-XID.response test_sndcp_prim_up_cb(): Rx SN-UNITDATA.indication TLLI=0xe1c5d364 SAPI=SNDCP3 NSAPI=5 NPDU=[75 22 fa 7c ff d9 56 ba 86 c7 2a f3 d2 1d ce bc 88 3a 8e b6 24 7d de 26 6a 58 de 29 be 96 d2 40 94 7f 9f 4d f5 9c 61 d4 19 e9 9a 58 75 21 21 a9 fd 1f d7 96 90 a7 3f fe 5b 59 f0 e7 c1 52 2c aa a1 39 b6 c5 fd 68 2e fc f4 c0 10 9b 7a 64 9d ae 3a ff a3 0f b0 56 7d 4b 52 33 74 13 67 44 6a ce 62 45 ea cb 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ] test_sndcp_prim_down_cb(): Rx LL-UNITDATA.request TLLI=0xe1c5d364 SAPI=SNDCP3 L3=[65 00 00 00 73 6f 6d 65 2d 6e 70 64 75 2d 64 61 74 61 2d 6c 69 6b 65 2d 61 6e 2d 69 70 2d 70 6b 74 00 ] -==== test_sndcp_prim() [end] ==== +==== test_sndcp_prim_net() [end] ==== +==== test_sndcp_prim_ms() [start] ==== +test_sndcp_prim_down_cb(): Rx LL-XID.request +test_sndcp_prim_snsm_cb(): Rx SNSM-ACTIVATE.response +test_sndcp_prim_down_cb(): Rx LL-XID.request +test_sndcp_prim_up_cb(): Rx SN-XID.confirm +test_sndcp_prim_up_cb(): Rx SN-UNITDATA.indication TLLI=0xe1c5d364 SAPI=SNDCP3 NSAPI=5 NPDU=[75 22 fa 7c ff d9 56 ba 86 c7 2a f3 d2 1d ce bc 88 3a 8e b6 24 7d de 26 6a 58 de 29 be 96 d2 40 94 7f 9f 4d f5 9c 61 d4 19 e9 9a 58 75 21 21 a9 fd 1f d7 96 90 a7 3f fe 5b 59 f0 e7 c1 52 2c aa a1 39 b6 c5 fd 68 2e fc f4 c0 10 9b 7a 64 9d ae 3a ff a3 0f b0 56 7d 4b 52 33 74 13 67 44 6a ce 62 45 ea cb 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ] +test_sndcp_prim_down_cb(): Rx LL-UNITDATA.request TLLI=0xe1c5d364 SAPI=SNDCP3 L3=[65 00 00 00 73 6f 6d 65 2d 6e 70 64 75 2d 64 61 74 61 2d 6c 69 6b 65 2d 61 6e 2d 69 70 2d 70 6b 74 00 ] +==== test_sndcp_prim_ms() [end] ==== diff --git a/tests/sndcp/sndcp_xid_test.c b/tests/sndcp/sndcp_xid_test.c index 8016dd0..63a479a 100644 --- a/tests/sndcp/sndcp_xid_test.c +++ b/tests/sndcp/sndcp_xid_test.c @@ -270,7 +270,7 @@ log_ctx = talloc_named_const(xid_ctx, 0, "log"); osmo_init_logging2(log_ctx, &info); - rc = osmo_gprs_sndcp_init(); + rc = osmo_gprs_sndcp_init(OSMO_GPRS_SNDCP_LOCATION_MS); OSMO_ASSERT(rc == 0); osmo_gprs_sndcp_set_log_cat(OSMO_GPRS_SNDCP_LOGC_SNDCP, DSNDCP); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iebce37a50917b13c23de1528469d66c310ced7f2 Gerrit-Change-Number: 32312 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-gprs[master]: sm: Handle PCO in rx PDP Ctx Accept
by pespin 14 Apr '23

14 Apr '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32317 ) Change subject: sm: Handle PCO in rx PDP Ctx Accept ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I15ff08cbefb463c8785a138406921563941e7e7d Gerrit-Change-Number: 32317 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 16:54:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: sm: Handle radio_prio,qos,llc_sapi in rx PDP Ctx Accept
by pespin 14 Apr '23

14 Apr '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32316 ) Change subject: sm: Handle radio_prio,qos,llc_sapi in rx PDP Ctx Accept ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32316 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Icbd9ba82b6d8cbcfcaf5a80ddc801139c409c585 Gerrit-Change-Number: 32316 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 16:54:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-gprs[master]: sm: Parse PDP address in rx PDP Ctx Accept
by pespin 14 Apr '23

14 Apr '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32315 ) Change subject: sm: Parse PDP address in rx PDP Ctx Accept ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32315 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic41edc14445f0f5d4ef20bb30b53d66fb56435de Gerrit-Change-Number: 32315 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 16:54:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in libosmo-gprs[master]: sndcp: Test MS vs NET paths separately and implement missing prims fo...
by pespin 14 Apr '23

14 Apr '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32312 ) Change subject: sndcp: Test MS vs NET paths separately and implement missing prims for MS ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iebce37a50917b13c23de1528469d66c310ced7f2 Gerrit-Change-Number: 32312 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 16:53:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-gprs[master]: sm: Start using SNSM SAP
by pespin 14 Apr '23

14 Apr '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32295 ) Change subject: sm: Start using SNSM SAP ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic5525bfa92e2591757d999610c0d59849d022d8d Gerrit-Change-Number: 32295 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 16:53:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: sm: Fix swapped endianness in struct gprs_sm_pdp_addr
by pespin 14 Apr '23

14 Apr '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32314 ) Change subject: sm: Fix swapped endianness in struct gprs_sm_pdp_addr ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Icd72bbe6d297bc583097c68d3cf86a616fabd36d Gerrit-Change-Number: 32314 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Apr 2023 16:53:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0