April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: ms: Fix unsafe iterating freeing items in list

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32547 ) Change subject: ms: Fix unsafe iterating freeing items in list ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I35cba6d617b3356515769405c7d05ba28cd5132b Gerrit-Change-Number: 32547 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Apr 2023 13:23:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libusrp[master]: debian/rules: don't build in parallel

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libusrp/+/32545 ) Change subject: debian/rules: don't build in parallel ...................................................................... debian/rules: don't build in parallel With upgrading the debhelper compat level to v10, parallel building was enabled by default. But this doesn't work reliably with libusrp, so disable it. On OBS, out of 18 builds, two failed. Related: OS#3970 Change-Id: Ic23778320a44ec6ee2fef499216eb8a0c52603d2 --- M debian/rules 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: osmith: Verified fixeria: Looks good to me, approved diff --git a/debian/rules b/debian/rules index c00c435..3ad8a03 100755 --- a/debian/rules +++ b/debian/rules @@ -9,8 +9,9 @@ #export DH_VERBOSE=1 +# --no-parallel: OS#3970 %: - dh $@ --with autoreconf --fail-missing + dh $@ --with autoreconf --fail-missing --no-parallel override_dh_auto_configure: dh_auto_configure -- --enable-doxygen -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/32545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Ic23778320a44ec6ee2fef499216eb8a0c52603d2 Gerrit-Change-Number: 32545 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in libusrp[master]: Cosmetic: contrib/jenkins.sh: fix typo

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libusrp/+/32544 ) Change subject: Cosmetic: contrib/jenkins.sh: fix typo ...................................................................... Cosmetic: contrib/jenkins.sh: fix typo Change-Id: Ic0459bd5585fbcf3af785dfda167811a07107edb --- M contrib/jenkins.sh 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: osmith: Verified fixeria: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7a7e782..5360a6b 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -4,6 +4,6 @@ autoreconf --install --force ./configure -$MAKE # Parallel make fails ocsasionally, see OS#3970. +$MAKE # Parallel make fails occasionally, see OS#3970. $MAKE distcheck $MAKE maintainer-clean -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/32544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Ic0459bd5585fbcf3af785dfda167811a07107edb Gerrit-Change-Number: 32544 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: cosmetic: ms: fix formatting of function comment

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32548 ) Change subject: cosmetic: ms: fix formatting of function comment ...................................................................... cosmetic: ms: fix formatting of function comment Change-Id: I717c0ebd6e9af5388e94482842f5638777758b32 --- M src/gprs_ms.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/48/32548/1 diff --git a/src/gprs_ms.c b/src/gprs_ms.c index d9e52ea..0b062c1 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -395,7 +395,8 @@ } /* Cleans up old MS being merged into a new one. Should be called with a -ms_ref() taken to avoid use-after-free. */ + * ms_ref() taken to avoid use-after-free. + */ static void ms_reset(struct GprsMs *ms) { LOGPMS(ms, DMS, LOGL_INFO, "Clearing MS object\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I717c0ebd6e9af5388e94482842f5638777758b32 Gerrit-Change-Number: 32548 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: ms: Fix unsafe iterating freeing items in list

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32547 ) Change subject: ms: Fix unsafe iterating freeing items in list ...................................................................... ms: Fix unsafe iterating freeing items in list Change-Id: I35cba6d617b3356515769405c7d05ba28cd5132b --- M src/gprs_ms.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/47/32547/1 diff --git a/src/gprs_ms.c b/src/gprs_ms.c index 4cab8e4..d9e52ea 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -409,7 +409,7 @@ if (tbf && !tbf_timers_pending(tbf, T_MAX)) tbf_free(tbf); - llist_for_each_entry(pos, &ms->old_tbfs, list) { + while ((pos = llist_first_entry_or_null(&ms->old_tbfs, struct llist_item, list))) { tbf = (struct gprs_rlcmac_tbf *)pos->entry; if (!tbf_timers_pending(tbf, T_MAX)) tbf_free(tbf); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I35cba6d617b3356515769405c7d05ba28cd5132b Gerrit-Change-Number: 32547 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: ms: Mark ms_reset() as static

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32546 ) Change subject: ms: Mark ms_reset() as static ...................................................................... ms: Mark ms_reset() as static Change-Id: Idc42be62f9911b7e2fad3dade884e72e5c2965f4 --- M src/gprs_ms.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/46/32546/1 diff --git a/src/gprs_ms.c b/src/gprs_ms.c index 739bbcd..4cab8e4 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -396,7 +396,7 @@ /* Cleans up old MS being merged into a new one. Should be called with a ms_ref() taken to avoid use-after-free. */ -void ms_reset(struct GprsMs *ms) +static void ms_reset(struct GprsMs *ms) { LOGPMS(ms, DMS, LOGL_INFO, "Clearing MS object\n"); struct llist_item *pos; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Idc42be62f9911b7e2fad3dade884e72e5c2965f4 Gerrit-Change-Number: 32546 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmo-bts[master]: common: Remove unused function gsm_objclass2nmstate()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32074 ) ( 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: common: Remove unused function gsm_objclass2nmstate() ...................................................................... common: Remove unused function gsm_objclass2nmstate() Change-Id: Ia538e3f3d416408f69f9d8e6c8c746eddd9f005a --- M src/common/oml.c 1 file changed, 9 insertions(+), 14 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/common/oml.c b/src/common/oml.c index 4df5372..db95747 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -1781,20 +1781,6 @@ return mo; } -/* obtain the gsm_nm_state data structure for a given object instance */ -struct gsm_nm_state * -gsm_objclass2nmstate(struct gsm_bts *bts, uint8_t obj_class, - const struct abis_om_obj_inst *obj_inst) -{ - struct gsm_abis_mo *mo; - - mo = gsm_objclass2mo(bts, obj_class, obj_inst); - if (!mo) - return NULL; - - return &mo->nm_state; -} - /* obtain the in-memory data structure of a given object instance */ void * gsm_objclass2obj(struct gsm_bts *bts, uint8_t obj_class, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia538e3f3d416408f69f9d8e6c8c746eddd9f005a Gerrit-Change-Number: 32074 Gerrit-PatchSet: 7 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[M] Change in osmo-bsc[master]: bts: st_op_enabled_on_enter(): resume C0 power reduction

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32540 ) Change subject: bts: st_op_enabled_on_enter(): resume C0 power reduction ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic3f8a2ab0ffd049a8ed84361a3a588c1e1b23ac6 Gerrit-Change-Number: 32540 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Apr 2023 11:52:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libusrp[master]: debian/rules: don't build in parallel

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libusrp/+/32545 ) Change subject: debian/rules: don't build in parallel ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/32545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Ic23778320a44ec6ee2fef499216eb8a0c52603d2 Gerrit-Change-Number: 32545 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Apr 2023 11:08:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libusrp[master]: Cosmetic: contrib/jenkins.sh: fix typo

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libusrp/+/32544 ) Change subject: Cosmetic: contrib/jenkins.sh: fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/32544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Ic0459bd5585fbcf3af785dfda167811a07107edb Gerrit-Change-Number: 32544 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 28 Apr 2023 11:08:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023