March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-gsm-manuals[master]: common/chapters: http -> https
by laforge 23 Mar '23

23 Mar '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32009 ) Change subject: common/chapters: http -> https ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Idf88e6141aad37d731a1955ad8b30f956c44a417 Gerrit-Change-Number: 32009 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 08:55:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: chapters/preface: Thank NLnet and WaveMobile
by laforge 23 Mar '23

23 Mar '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32008 ) Change subject: chapters/preface: Thank NLnet and WaveMobile ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32008 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ib887489fce522981df298594931100b9e553c291 Gerrit-Change-Number: 32008 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 08:55:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: chapters/logging: Expand documentation on GSMTAP logging
by laforge 23 Mar '23

23 Mar '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32007 ) Change subject: chapters/logging: Expand documentation on GSMTAP logging ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File common/chapters/logging.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32007/comment/bca2a68a_0382… PS2, Line 247: open the socket at the GSMTAP port and discard anything arriving at it. > Maybe also explain that in remote IP addresses in the local system we try to open the port to avoid […] that depends on the code in question (whether it calls gsmtap*add_sink). Not sure we do that for logging. Which is the case for vty-based logging, but not for a program that might call log_target_create_gsmtap() directly, without the VTY (some small utility without VTY might do that). -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32007 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I9d7a15fd81bb0f3bc89b97ebfd35e9efc48c94e2 Gerrit-Change-Number: 32007 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 08:55:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in osmo-ci[master]: jobs/osmocom-release-manuals: add new job
by laforge 23 Mar '23

23 Mar '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32016 ) Change subject: jobs/osmocom-release-manuals: add new job ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32016 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0ecb238660553c3c857e1b310873eca8a8d09dab Gerrit-Change-Number: 32016 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 08:52:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-sgsn[master]: gmm: Ciphering Key Sequence Number IE has half octet tag
by laforge 23 Mar '23

23 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/32015 ) Change subject: gmm: Ciphering Key Sequence Number IE has half octet tag ...................................................................... gmm: Ciphering Key Sequence Number IE has half octet tag As per 3GPP TS 24.008: * 10.5.1.2 Ciphering Key Sequence Number * Table 9.4.9/TS 24.00 The IE is so far being encoded manually, hence why it worked fine until now. Change-Id: Ic220113f30377a14cbe3550a04cd04f3caef49cf --- M src/sgsn/gprs_gmm.c 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 5bf66c3..547edbb 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -70,7 +70,7 @@ static const struct tlv_definition gsm48_gmm_att_tlvdef = { .def = { - [GSM48_IE_GMM_CIPH_CKSN] = { TLV_TYPE_FIXED, 1 }, + [GSM48_IE_GMM_CIPH_CKSN] = { TLV_TYPE_SINGLE_TV, 1 }, [GSM48_IE_GMM_TIMER_READY] = { TLV_TYPE_TV, 1 }, [GSM48_IE_GMM_ALLOC_PTMSI] = { TLV_TYPE_TLV, 0 }, [GSM48_IE_GMM_PTMSI_SIG] = { TLV_TYPE_FIXED, 3 }, -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/32015 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic220113f30377a14cbe3550a04cd04f3caef49cf Gerrit-Change-Number: 32015 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-sgsn[master]: gmm: Ciphering Key Sequence Number IE has half octet tag
by laforge 23 Mar '23

23 Mar '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/32015 ) Change subject: gmm: Ciphering Key Sequence Number IE has half octet tag ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/32015 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic220113f30377a14cbe3550a04cd04f3caef49cf Gerrit-Change-Number: 32015 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 08:52:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: ansible: hosts: replace invalid char minus ("-") in host group names
by laforge 23 Mar '23

23 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30918 ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ansible: hosts: replace invalid char minus ("-") in host group names ...................................................................... ansible: hosts: replace invalid char minus ("-") in host group names Change-Id: I0c13ce4edb7f57c7ff77141b5511080bba639ec0 --- M ansible/README.md M ansible/hosts M ansible/setup-gsm-tester.yml M ansible/setup-jenkins-slave.yml M ansible/setup-obs-worker.yml 5 files changed, 18 insertions(+), 9 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ansible/README.md b/ansible/README.md index e5d146c..9085c74 100644 --- a/ansible/README.md +++ b/ansible/README.md @@ -33,4 +33,4 @@ # how to make slaves log-in to registry.osmocom.org: -`ansible jenkins-slaves -u root -a "su - osmocom-build -c 'docker login -u jenkins-slave -p PASSWD https://registry.osmocom.org/'"` +`ansible jenkins_slaves -u root -a "su - osmocom-build -c 'docker login -u jenkins_slave -p PASSWD https://registry.osmocom.org/'"` diff --git a/ansible/hosts b/ansible/hosts index 0551d44..b62ef82 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -1,12 +1,12 @@ -[gsm-tester] +[gsm_tester] osmo-gsm-tester-rnd ansible_host=10.9.25.101 osmo-gsm-tester-prod ansible_host=10.9.25.107 -[coverity-slaves] +[coverity_slaves] build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13 build3-deb11build-ansible ansible_host=2a01:4f8:212:3762::1:3 -[jenkins-slaves] +[jenkins_slaves] build2-deb10build-ansible ansible_host=2a01:4f8:10b:2ad9::1:10 osmocom_jenkins_slave_fstrim=True build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13 osmocom_jenkins_slave_fstrim=True build3-deb11build-ansible ansible_host=2a01:4f8:212:3762::1:3 osmocom_jenkins_slave_fstrim=True @@ -20,7 +20,7 @@ [simtester] simtest ansible_host=10.9.25.80 -[obs-workers] +[obs_workers] build3-obsworker1 ansible_host=2a01:4f8:212:3762::1:2 obs_worker_instances=8 obs_worker_jobs=8 lx2-1-obs-aarch64-1 ansible_host=2a02:8106:13:1e34:4e9:e7ff:fe97:fe92 obs_worker_instances=1 obs_worker_jobs=4 diff --git a/ansible/setup-gsm-tester.yml b/ansible/setup-gsm-tester.yml index 9d27256..526b621 100644 --- a/ansible/setup-gsm-tester.yml +++ b/ansible/setup-gsm-tester.yml @@ -1,6 +1,6 @@ --- - name: setup osmo-gsm-tester apu - hosts: gsm-tester + hosts: gsm_tester user: root tasks: - name: install common utilities diff --git a/ansible/setup-jenkins-slave.yml b/ansible/setup-jenkins-slave.yml index 7eac8b7..5813b40 100644 --- a/ansible/setup-jenkins-slave.yml +++ b/ansible/setup-jenkins-slave.yml @@ -1,6 +1,6 @@ --- - name: setup jenkins slaves - hosts: jenkins-slaves + hosts: jenkins_slaves user: root vars_files: - "vars/{{ ansible_facts['os_family'] }}-{{ ansible_facts['distribution_major_version']}}.yml" @@ -47,7 +47,7 @@ - name: ntpd - name: setup coverity slaves - hosts: coverity-slaves + hosts: coverity_slaves user: root roles: - name: install-coverity diff --git a/ansible/setup-obs-worker.yml b/ansible/setup-obs-worker.yml index c742a19..b79e1a5 100644 --- a/ansible/setup-obs-worker.yml +++ b/ansible/setup-obs-worker.yml @@ -1,6 +1,6 @@ --- - name: setup OBS worker - hosts: obs-workers + hosts: obs_workers user: root vars_files: - "vars/{{ ansible_facts['os_family'] }}-{{ ansible_facts['distribution_major_version']}}.yml" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0c13ce4edb7f57c7ff77141b5511080bba639ec0 Gerrit-Change-Number: 30918 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: ansible: install-poky-sdk: add tag poky to the apt install task
by laforge 23 Mar '23

23 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30915 ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ansible: install-poky-sdk: add tag poky to the apt install task ...................................................................... ansible: install-poky-sdk: add tag poky to the apt install task Change-Id: Id8e433a789aff8df241687f1f109a161e725a29a --- M ansible/roles/install-poky-sdk/tasks/main.yml 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/ansible/roles/install-poky-sdk/tasks/main.yml b/ansible/roles/install-poky-sdk/tasks/main.yml index 7c1e9a9..57d0137 100644 --- a/ansible/roles/install-poky-sdk/tasks/main.yml +++ b/ansible/roles/install-poky-sdk/tasks/main.yml @@ -8,6 +8,7 @@ - tar cache_valid_time: 3600 update_cache: yes + tags: [poky] - name: check if poky needs to be installed stat: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id8e433a789aff8df241687f1f109a161e725a29a Gerrit-Change-Number: 30915 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: ansible: install-coverity: add missing tag coverity
by laforge 23 Mar '23

23 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30916 ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ansible: install-coverity: add missing tag coverity ...................................................................... ansible: install-coverity: add missing tag coverity Change-Id: I86be4c72ad3bce070ddf7f8270492b6cf8ea826e --- M ansible/roles/install-coverity/tasks/main.yml 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/ansible/roles/install-coverity/tasks/main.yml b/ansible/roles/install-coverity/tasks/main.yml index 4047fb8..6192c27 100644 --- a/ansible/roles/install-coverity/tasks/main.yml +++ b/ansible/roles/install-coverity/tasks/main.yml @@ -3,6 +3,7 @@ apt: name: - curl + tags: [coverity] - name: copy coverity installer copy: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I86be4c72ad3bce070ddf7f8270492b6cf8ea826e Gerrit-Change-Number: 30916 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ci[master]: ansible: install-coverity: ensure it's not installed twice
by laforge 23 Mar '23

23 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30917 ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ansible: install-coverity: ensure it's not installed twice ...................................................................... ansible: install-coverity: ensure it's not installed twice Check if the coverity path already exists. Even this wouldn't detect if the coverity has been only installed half way. Related: OS#5801 Change-Id: I95549983bb6bd47e04eb37c73afe5409637f87d3 --- M ansible/roles/install-coverity/tasks/main.yml 1 file changed, 48 insertions(+), 30 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ansible/roles/install-coverity/tasks/main.yml b/ansible/roles/install-coverity/tasks/main.yml index 6192c27..246fa36 100644 --- a/ansible/roles/install-coverity/tasks/main.yml +++ b/ansible/roles/install-coverity/tasks/main.yml @@ -5,39 +5,44 @@ - curl tags: [coverity] -- name: copy coverity installer - copy: - src: "{{ coverity_installer_file }}" - dest: "/tmp/{{ coverity_installer_file }}" - mode: 0750 - register: coverity_copy - ignore_errors: yes +- name: check if coverity needs to be installed + stat: + path: "/opt/coverity/{{ coverity_version }}/" + register: coverity_stat tags: [coverity] -- name: create /opt/coverity/{{ coverity_version }}/ - file: - path: /opt/coverity/{{ coverity_version }}/ - state: directory - when: coverity_copy.failed == False +- name: install coverity if required + when: coverity_stat.stat.exists == False tags: [coverity] + block: + - name: copy coverity installer + copy: + src: "{{ coverity_installer_file }}" + dest: "/tmp/{{ coverity_installer_file }}" + mode: 0750 + register: coverity_copy + ignore_errors: yes -- name: unpack coverity - unarchive: - src: "/tmp/{{ coverity_installer_file }}" - dest: /opt/coverity/{{ coverity_version }} - remote_src: yes - when: coverity_copy.failed == False - tags: [coverity] + - name: create /opt/coverity/{{ coverity_version }}/ + file: + path: /opt/coverity/{{ coverity_version }}/ + state: directory + when: coverity_copy.failed == False -- name: create link /opt/coverity/current - shell: ln -sf /opt/coverity/{{ coverity_version }}/* /opt/coverity/current - args: - warn: false - when: coverity_copy.failed == False - tags: [coverity] + - name: unpack coverity + unarchive: + src: "/tmp/{{ coverity_installer_file }}" + dest: /opt/coverity/{{ coverity_version }} + remote_src: yes + when: coverity_copy.failed == False -- name: "Please download {{ coverity_installer_file }} to your ansible directory to allow ansible to install coverity" - debug: - msg: "Ansible can not find {{ coverity_installer_file }}" - when: coverity_copy.failed - tags: [coverity] + - name: create link /opt/coverity/current + shell: ln -sf /opt/coverity/{{ coverity_version }}/* /opt/coverity/current + args: + warn: false + when: coverity_copy.failed == False + + - name: "Please download {{ coverity_installer_file }} to your ansible directory to allow ansible to install coverity" + debug: + msg: "Ansible can not find {{ coverity_installer_file }}" + when: coverity_copy.failed -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I95549983bb6bd47e04eb37c73afe5409637f87d3 Gerrit-Change-Number: 30917 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0