March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: rlcmac: Release pending polls in pdch_ul when freeing tbf
by pespin 23 Mar '23

23 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32020 ) Change subject: rlcmac: Release pending polls in pdch_ul when freeing tbf ...................................................................... rlcmac: Release pending polls in pdch_ul when freeing tbf Otherwise the events are eventually sheduled and they point to an already freed TBF. Change-Id: I2b39ca8e79125eb2f496a92259c09c050e1f369b --- M src/rlcmac/tbf.c 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/rlcmac/tbf.c b/src/rlcmac/tbf.c index c18ad83..524740d 100644 --- a/src/rlcmac/tbf.c +++ b/src/rlcmac/tbf.c @@ -27,6 +27,7 @@ #include <osmocom/gprs/rlcmac/tbf_ul.h> #include <osmocom/gprs/rlcmac/gre.h> #include <osmocom/gprs/rlcmac/rlcmac_enc.h> +#include <osmocom/gprs/rlcmac/pdch_ul_controller.h> void gprs_rlcmac_tbf_constructor(struct gprs_rlcmac_tbf *tbf, enum gprs_rlcmac_tbf_direction direction, @@ -38,7 +39,9 @@ void gprs_rlcmac_tbf_destructor(struct gprs_rlcmac_tbf *tbf) { - + unsigned int i; + for (i = 0; i < ARRAY_SIZE(g_ctx->sched.ulc); i++) + gprs_rlcmac_pdch_ulc_release_tbf(g_ctx->sched.ulc[i], tbf); } void gprs_rlcmac_tbf_free(struct gprs_rlcmac_tbf *tbf) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2b39ca8e79125eb2f496a92259c09c050e1f369b Gerrit-Change-Number: 32020 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[XL] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Attach
by pespin 23 Mar '23

23 Mar '23

Attention is currently required from: Hoernchen, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 ) Change subject: gmm: Initial implementation of GPRS Attach ...................................................................... Patch Set 1: (12 comments) File include/osmocom/gprs/gmm/gmm_pdu.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/3b3744f7_686e7dae PS1, Line 16: tlv_definition > You should include `<osmocom/gsm/tlv.h>` defining this struct. Ack https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/a64c2952_60e95285 PS1, Line 32: uint8_t sres[4], > Why not a const pointer? Ack File libosmo-gprs-gmm.pc.in: https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/36094b3d_ec293ba4 PS1, Line 9: libosmo-gprs-llc > btw, why is this needed? because of header files? Because gmm_prim uses the llc_prim for the LLGMM API, and it uses the struct defintiions and functions to allocate the primitives. That doesn't mean it forcefully needs the entire LLC stack in libosmo-gprs-llc to function though, since the app is the one forwarding the primitives. File src/gmm/gmm_pdu.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/25ad325b_0148c103 PS1, Line 31: struct gprs_gmm_ms_net_cap { > Run `struct_endianess.py`. Ack https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/8477c5c3_f8aaa1e1 PS1, Line 142: 23 > `GSM_MAC_BLOCK_LEN`? yeah, but this is all temporary to have some base upon to work with. https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/e9254ab7_4361010a PS1, Line 147: rc = bitvec_unhex(&bv, "171933432b37159ef98879cba28c6621e72688b198879c00"); > Makes sense to add a TODO here, since you're hard-coding the payload. yeah, but this is all temporary to have some base upon to work with. https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/9b2fa138_09e2e8b8 PS1, Line 172: msgb_put_u8(msg, sizeof(ms_net_cap_def)); > Use `msgb_lv_put()`. I'll check. https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/a1b3e56f_5585003d PS1, Line 274: GSM_MI_TYPE_TMSI > `GSM_MI_TYPE_IMEI`! Ack https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/de7981c6_5d1aa5b7 PS1, Line 312: (void)imeisv_requested; > What is this for? IDK, I yet have to discover, that's why it's TODO :D but it shows up in the specs in the messages. if you mean the (void) thing, it's to avoid having the "empty if clause" or alike warning. This is left here so that in the future we can quickly find out where to use it once we read the related specs. File src/gmm/gmm_prim.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/751b4541_e51ea1da PS1, Line 107: gmm_llc_down_cb_dummy > `__func__` I don't really expect this to change but ok. https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/6b1e5bf5_b97f17bf PS1, Line 467: rc = gprs_gmm_prim_handle_unsupported(gmm_prim); > This case can fall-through to default, but not critical. I did this on purpose since it's really the only primitive we expect to have here, so the final logic is already in place. https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/a0943413_c28c7cac PS1, Line 589: llc_prim > Why would anybody pass you NULL pointer here? Just curious. >Why would anybody pass you NULL pointer here? Just curious. You can apply this question to literally any ASSERT checking a null pointer in the whole history of code. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I212053b3a3f27ef7d63503c3d5ef08453b2d2056 Gerrit-Change-Number: 32021 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 10:29:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: layer23: modem: Test GMM layer through VTY
by fixeria 23 Mar '23

23 Mar '23

Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32022 ) Change subject: layer23: modem: Test GMM layer through VTY ...................................................................... Patch Set 1: (4 comments) File src/host/layer23/src/modem/gmm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32022/comment/1347d5bf_d716b6d3 PS1, Line 92: rc = 1; Just do `return 1` straight away, `rc` is not really needed? File src/host/layer23/src/modem/llc.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32022/comment/24734b73_b147cf7a PS1, Line 62: rc = osmo_gprs_gmm_prim_llc_lower_up(llc_prim); Same here, you're assigning `rc` but then unconditionally overwriting it? File src/host/layer23/src/modem/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32022/comment/45e41c85_a16afbaf PS1, Line 159: LLC_CMDG_DESC copy-paste, you should add `GMM_CMDG_DESC`. https://gerrit.osmocom.org/c/osmocom-bb/+/32022/comment/cc9ce62f_2d56432c PS1, Line 161: "Hard-coded GMM Attach Request (SAPI=GMM, TLLI=0xe1c5d364)\n") Something is wrong here, what part of the command this docstring corresponds to? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba0663075468670a29aceafe5196cae3cab050eb Gerrit-Change-Number: 32022 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 09:30:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: chapters/preface: Thank NLnet and WaveMobile
by laforge 23 Mar '23

23 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32008 ) Change subject: chapters/preface: Thank NLnet and WaveMobile ...................................................................... chapters/preface: Thank NLnet and WaveMobile Change-Id: Ib887489fce522981df298594931100b9e553c291 --- M common/chapters/preface.adoc 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/common/chapters/preface.adoc b/common/chapters/preface.adoc index 272f84a..b9a32d6 100644 --- a/common/chapters/preface.adoc +++ b/common/chapters/preface.adoc @@ -79,6 +79,10 @@ * Jan Luebbe, Stefan Schmidt, Daniel Willmann, Pablo Neira, Nico Golde, Kevin Redon, Ingo Albrecht, Alexander Huemer, Alexander Chemeris, Max Suraev, Tobias Engel, Jacob Erlbeck, Ivan Kluchnikov +* NLnet Foundation, for providing funding for a number of individual work items + within the Osmocom universe, such as LTE support in OsmoCBC or GPRS/EGPRS + support for Ericsson RBS6000. +* WaveMobile Ltd, for many years of sponsoring. May the source be with you! -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32008 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ib887489fce522981df298594931100b9e553c291 Gerrit-Change-Number: 32008 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-gsm-manuals[master]: common/chapters: http -> https
by laforge 23 Mar '23

23 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32009 ) Change subject: common/chapters: http -> https ...................................................................... common/chapters: http -> https Change-Id: Idf88e6141aad37d731a1955ad8b30f956c44a417 --- M common/chapters/osmux/osmux.adoc M common/chapters/preface.adoc 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/common/chapters/osmux/osmux.adoc b/common/chapters/osmux/osmux.adoc index a727e2e..6862d9c 100644 --- a/common/chapters/osmux/osmux.adoc +++ b/common/chapters/osmux/osmux.adoc @@ -9,7 +9,7 @@ reduction. Full reference document for the osmux protocol can be found here: -http://ftp.osmocom.org/docs/latest/osmux-reference.pdf +https://ftp.osmocom.org/docs/latest/osmux-reference.pdf In Osmocom satellite based GSM networks, the satellite link is envisioned to be in between the BSS and the core network, that is, between the BSC and the MSC diff --git a/common/chapters/preface.adoc b/common/chapters/preface.adoc index b9a32d6..7dad998 100644 --- a/common/chapters/preface.adoc +++ b/common/chapters/preface.adoc @@ -293,7 +293,7 @@ If you don't have a support package / contract, you have the option of using the resources put together by the Osmocom community -at http://projects.osmocom.org/, checking out the wiki and +at https://projects.osmocom.org/, checking out the wiki and the mailing-list for community-based assistance. Please always remember, though: The community has no obligation to help you, and you should address your requests politely to them. The information (and -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Idf88e6141aad37d731a1955ad8b30f956c44a417 Gerrit-Change-Number: 32009 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-gsm-manuals[master]: chapters/logging: Expand documentation on GSMTAP logging
by laforge 23 Mar '23

23 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32007 ) Change subject: chapters/logging: Expand documentation on GSMTAP logging ...................................................................... chapters/logging: Expand documentation on GSMTAP logging Change-Id: I9d7a15fd81bb0f3bc89b97ebfd35e9efc48c94e2 --- M common/chapters/logging.adoc 1 file changed, 28 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/common/chapters/logging.adoc b/common/chapters/logging.adoc index a832ca4..0b31211 100644 --- a/common/chapters/logging.adoc +++ b/common/chapters/logging.adoc @@ -200,9 +200,16 @@ ==== Logging via gsmtap -When debugging complex issues it's handy to be able to reconstruct exact chain of events. This is enabled by using GSMTAP -log output where frames sent/received over the air are intersperced with the log lines. It also simplifies the bug handling -as users don't have to provide separate .pcap and .log files anymore - everything will be inside self-contained packet dump. +GSMTAP is normally a pseudo-header format that enables the IP-transport of GSM (or other telecom) protocols +that are not normally transported over IP. For example, the most common situation is to enable GSMTAP in +OsmoBTS or OsmoPCU to provide GSM-Um air interface capture files over IP, so they can be analyzed in +wireshark. + +GSMTAP logging is now a method how Osmocom software can also encapsulate its own log output in GSMTAP frames. +We're not trying to re-invent rsyslog here, but this is very handy When debugging complex issues. It enables +the reader of the pcap file containing GSMTAP logging together with other protocol traces to reconstruct exact +chain of events. A single pcap file can then contain both the log output of any number of Osmocom programs in +the same timeline of the messages on various interfaces in and out of said Osmocom programs. It's configured as follows: ---- @@ -230,6 +237,15 @@ OsmoBSC(config-log)# logging level force-all fatal ---- +NOTE: Every time you generate GSMTAP messages and send it to a unicast (non-broadcast/multicast) IP address, +please make sure that the destination IP address actually has a socket open on the specified port, or drops +the packets in its packet filter. If unicast GSMTAP messages arrive at a closed destination UDP port, the +operating system will likely generate ICMP port unreachable messages. Those ICMP messages in turn will, when +arriving at the source (the host on which you run the Osmocom software sending GSMTAP), suppress generation +of further GSMTAP messages for some time, resulting in incomplete files. In case of doubt, either send GSMTAP +to multicast IP addresses, or run something like `nc -l -u -p 4729 > /dev/null` on the destination host to +open the socket at the GSMTAP port and discard anything arriving at it. + ==== Logging to a file As opposed to Logging to the VTY, logging to files is persistent and -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32007 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I9d7a15fd81bb0f3bc89b97ebfd35e9efc48c94e2 Gerrit-Change-Number: 32007 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-gsm-manuals[master]: chapters/spectrum: Extend disclaimer to Osmocom authors
by laforge 23 Mar '23

23 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32011 ) Change subject: chapters/spectrum: Extend disclaimer to Osmocom authors ...................................................................... chapters/spectrum: Extend disclaimer to Osmocom authors Change-Id: I22dc5bde7a8d48c1a7dc876343ee66954afc2f8d --- M common/chapters/spectrum.adoc 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/common/chapters/spectrum.adoc b/common/chapters/spectrum.adoc index 25e474e..5a6286f 100644 --- a/common/chapters/spectrum.adoc +++ b/common/chapters/spectrum.adoc @@ -14,8 +14,8 @@ operator of the interfered network, but is punishable as a crime under most jurisdictions. -sysmocom disclaims any responsibility for illegal / unlicensed use of -its products. +sysmocom and/or the authors of the Osmocom software disclaim any +responsibility for illegal / unlicensed use of its products. === Regulatory authorities by country -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I22dc5bde7a8d48c1a7dc876343ee66954afc2f8d Gerrit-Change-Number: 32011 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-gsm-manuals[master]: preface: indicate where to ask for commercial support
by laforge 23 Mar '23

23 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32010 ) Change subject: preface: indicate where to ask for commercial support ...................................................................... preface: indicate where to ask for commercial support Change-Id: I386d9bd31afe363677f23751d9ffe99f14800484 --- M common/chapters/preface.adoc 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/common/chapters/preface.adoc b/common/chapters/preface.adoc index 7dad998..f102aea 100644 --- a/common/chapters/preface.adoc +++ b/common/chapters/preface.adoc @@ -300,3 +300,8 @@ software) provided at osmocom.org is put together by volunteers for free. Treat them like a friend whom you're asking for help, not like a supplier from whom you have bought a service. + +If you would like to obtain professional/commercial support on Osmocom +CNI, you can always reach out to sales(a)sysmocom.de to discuss your +support needs. Purchasing support from sysmocom helps to cover the +ongoing maintenance of the Osmocom CNI software stack. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I386d9bd31afe363677f23751d9ffe99f14800484 Gerrit-Change-Number: 32010 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-gsm-manuals[master]: chapters/spectrum: Extend disclaimer to Osmocom authors
by laforge 23 Mar '23

23 Mar '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32011 ) Change subject: chapters/spectrum: Extend disclaimer to Osmocom authors ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I22dc5bde7a8d48c1a7dc876343ee66954afc2f8d Gerrit-Change-Number: 32011 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 08:55:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: preface: indicate where to ask for commercial support
by laforge 23 Mar '23

23 Mar '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32010 ) Change subject: preface: indicate where to ask for commercial support ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I386d9bd31afe363677f23751d9ffe99f14800484 Gerrit-Change-Number: 32010 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 08:55:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0