March 2023 - gerrit-log - lists.osmocom.org

[XL] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Attach
by pespin 23 Mar '23

23 Mar '23

Attention is currently required from: Hoernchen, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 ) Change subject: gmm: Initial implementation of GPRS Attach ...................................................................... Patch Set 5: (1 comment) File libosmo-gprs-gmm.pc.in: https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/c437b5f6_a2e704e3 PS1, Line 9: libosmo-gprs-llc > So then the debian package also needs to depend on libosmo-gprs-llc.so? […] AFAIU that's done automatically through ${shlibs:Depends}. Can you otherwise point me how should I be adding it? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I212053b3a3f27ef7d63503c3d5ef08453b2d2056 Gerrit-Change-Number: 32021 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 13:31:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: bts-trx: Avoid pushing interf_meas for disabled TRX
by pespin 23 Mar '23

23 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32028 ) Change subject: bts-trx: Avoid pushing interf_meas for disabled TRX ...................................................................... bts-trx: Avoid pushing interf_meas for disabled TRX It makes no sense to push interference meas results for those TRX since they are disabled, unused and hence won't be reported in RSL RF Res Ind. Related: SYS#6370 Change-Id: Ie3fd80970585cb30808b0644568dbc8936a57721 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 382ddae..e7ed5ea 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -124,6 +124,11 @@ unsigned int tn, ln; llist_for_each_entry(trx, &bts->trx_list, list) { + /* Skip pushing interf_meas for disabled TRX */ + if (trx->mo.nm_state.operational != NM_OPSTATE_ENABLED || + trx->bb_transc.mo.nm_state.operational != NM_OPSTATE_ENABLED) + continue; + for (tn = 0; tn < ARRAY_SIZE(trx->ts); tn++) { const struct gsm_bts_trx_ts *ts = &trx->ts[tn]; for (ln = 0; ln < ARRAY_SIZE(ts->lchan); ln++) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie3fd80970585cb30808b0644568dbc8936a57721 Gerrit-Change-Number: 32028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bts[master]: bts-trx: Avoid pushing interf_meas for disabled TRX
by pespin 23 Mar '23

23 Mar '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32028 ) Change subject: bts-trx: Avoid pushing interf_meas for disabled TRX ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie3fd80970585cb30808b0644568dbc8936a57721 Gerrit-Change-Number: 32028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 23 Mar 2023 13:27:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Attach
by fixeria 23 Mar '23

23 Mar '23

Attention is currently required from: Hoernchen, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 ) Change subject: gmm: Initial implementation of GPRS Attach ...................................................................... Patch Set 5: (4 comments) File libosmo-gprs-gmm.pc.in: https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/109936e6_cae89e4c PS1, Line 9: libosmo-gprs-llc > Because gmm_prim uses the llc_prim for the LLGMM API, and it uses the struct defintiions and functio […] So then the debian package also needs to depend on libosmo-gprs-llc.so? I don't see this being done. File src/gmm/gmm_pdu.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/1f98a9a7_ac44d750 PS1, Line 142: 23 > yeah, but this is all temporary to have some base upon to work with. Done https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/26184476_daa3e16c PS1, Line 147: rc = bitvec_unhex(&bv, "171933432b37159ef98879cba28c6621e72688b198879c00"); > yeah, but this is all temporary to have some base upon to work with. Done https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/9967e532_e8528607 PS1, Line 172: msgb_put_u8(msg, sizeof(ms_net_cap_def)); > I'll check. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I212053b3a3f27ef7d63503c3d5ef08453b2d2056 Gerrit-Change-Number: 32021 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 12:22:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-sip-connector[master]: sip: tweak log for release caused by status >= 300
by fixeria 23 Mar '23

23 Mar '23

Attention is currently required from: osmith, neels, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018 ) Change subject: sip: tweak log for release caused by status >= 300 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I64889d6ce174dc17d44d85aac12e7ee6e6b06164 Gerrit-Change-Number: 32018 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 23 Mar 2023 12:19:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: bts-trx: Avoid pushing interf_meas for disabled TRX
by osmith 23 Mar '23

23 Mar '23

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32028 ) Change subject: bts-trx: Avoid pushing interf_meas for disabled TRX ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie3fd80970585cb30808b0644568dbc8936a57721 Gerrit-Change-Number: 32028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 12:07:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-sip-connector[master]: sip: tweak log for release caused by status >= 300
by osmith 23 Mar '23

23 Mar '23

Attention is currently required from: neels, laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018 ) Change subject: sip: tweak log for release caused by status >= 300 ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > according to the spec >= 400 is an error. "300 <= x < 400" is a redirect. […] ack, patch updated -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I64889d6ce174dc17d44d85aac12e7ee6e6b06164 Gerrit-Change-Number: 32018 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 12:04:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-sip-connector[master]: sip: tweak log for release caused by status >= 300
by osmith 23 Mar '23

23 Mar '23

Attention is currently required from: osmith, neels, fixeria. Hello Jenkins Builder, neels, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018 to look at the new patch set (#2). Change subject: sip: tweak log for release caused by status >= 300 ...................................................................... sip: tweak log for release caused by status >= 300 Make it easier to spot when the sip server answers an invite with anything that would cause osmo-sip-connector to release the call. Related: SYS#6386 Change-Id: I64889d6ce174dc17d44d85aac12e7ee6e6b06164 --- M src/sip.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/18/32018/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I64889d6ce174dc17d44d85aac12e7ee6e6b06164 Gerrit-Change-Number: 32018 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmocore[master]: gsm0808: handle new enum gsm48_chan_mode speech/data values
by pespin 23 Mar '23

23 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32026 ) Change subject: gsm0808: handle new enum gsm48_chan_mode speech/data values ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I87d977228b1e039c2876941d1c6df1f69d1a54d4 Gerrit-Change-Number: 32026 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 11:51:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm_04_08: add more enum gsm48_chan_mode data values
by pespin 23 Mar '23

23 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32025 ) Change subject: gsm_04_08: add more enum gsm48_chan_mode data values ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia6b428e5b6aaecf151cbfa980b89eff6d0fe6006 Gerrit-Change-Number: 32025 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 11:50:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0