March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sccp[master]: fix sccp_scoc state S_WAIT_CONN_CONF out_state_mask
by neels 24 Mar '23

24 Mar '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32035 ) Change subject: fix sccp_scoc state S_WAIT_CONN_CONF out_state_mask ...................................................................... fix sccp_scoc state S_WAIT_CONN_CONF out_state_mask In sccp_scoc_states, allow the state transitions present in S_WAIT_CONN_CONF's event handler function scoc_fsm_wait_conn_conf(), and thus fix handling of N-DISCONNECT while waiting for SCCP Conn Confirm. Fixes this error: DLSCCP ERROR SCCP-SCOC(1016){WAIT_CONN_CONF}: transition to state IDLE not permitted! (sccp_scoc.c:1213) S_WAIT_CONN_CONF happens when the caller sends an N-DISCONNECT during S_CONN_PEND_OUT -- that means, while we are waiting for a CC from the peer, the caller ends the conn. SCCP-SCOC still waits for the CC first. When S_WAIT_CONN_CONF expires, the intended path is state change to S_IDLE, which then deallocates the connection. Allow this state transition from S_WAIT_CONN_CONF to S_IDLE. When S_WAIT_CONN_CONF receives a CC, the intended path is to send a RELRE and state change to S_DISCONN_PEND. Allow this state transition from S_WAIT_CONN_CONF to S_DISCONN_PEND. Change-Id: I8145e53124cabd76bd2cee159ab01306a1afaa27 --- M src/sccp_scoc.c 1 file changed, 31 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/35/32035/1 diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index db1db23..c929ed6 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -1468,6 +1468,8 @@ S(SCOC_E_CONN_TMR_EXP) | S(SCOC_E_RCOC_CREF_IND) | S(SCOC_E_RCOC_ROUT_FAIL_IND), + .out_state_mask = S(S_IDLE) | + S(S_DISCONN_PEND), }, }; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8145e53124cabd76bd2cee159ab01306a1afaa27 Gerrit-Change-Number: 32035 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmocore[master]: codec: add osmo_efr_check_sid() function
by falconia 24 Mar '23

24 Mar '23

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/32034 ) Change subject: codec: add osmo_efr_check_sid() function ...................................................................... codec: add osmo_efr_check_sid() function Previously existing code provides osmo_fr_check_sid() and osmo_hr_check_sid() functions for FR1 and HR1 codecs; these functions are used by various RTP-touching programs in the Osmocom CNI suite when they need to differentiate between speech and SID frames. However, there was no corresponding function of this form for EFR codec, with the result being that the same programs that handle speech vs SID distinction correctly for FR1 and HR1 fail to do so for EFR. The present change adds an osmo_efr_check_sid() function to libosmocodec that fully mirrors previously existing osmo_fr_check_sid() and osmo_hr_check_sid(), providing the first step toward more correct EFR handling in programs where a SID check may be needed. Change-Id: Iab9fb60028f4135375287bc42f5da7ca7838b5f0 --- M include/osmocom/codec/codec.h M src/codec/gsm660.c 2 files changed, 67 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/34/32034/1 diff --git a/include/osmocom/codec/codec.h b/include/osmocom/codec/codec.h index 58e3a29..65de20d 100644 --- a/include/osmocom/codec/codec.h +++ b/include/osmocom/codec/codec.h @@ -83,6 +83,7 @@ bool osmo_fr_check_sid(const uint8_t *rtp_payload, size_t payload_len); bool osmo_hr_check_sid(const uint8_t *rtp_payload, size_t payload_len); +bool osmo_efr_check_sid(const uint8_t *rtp_payload, size_t payload_len); int osmo_amr_rtp_enc(uint8_t *payload, uint8_t cmr, enum osmo_amr_type ft, enum osmo_amr_quality bfi); int osmo_amr_rtp_dec(const uint8_t *payload, int payload_len, uint8_t *cmr, diff --git a/src/codec/gsm660.c b/src/codec/gsm660.c index 34b10de..9511263 100644 --- a/src/codec/gsm660.c +++ b/src/codec/gsm660.c @@ -20,6 +20,10 @@ */ #include <stdint.h> +#include <stdbool.h> + +#include <osmocom/core/bitvec.h> +#include <osmocom/core/utils.h> #include <osmocom/codec/codec.h> /* GSM EFR - subjective importance bit ordering */ @@ -253,3 +257,42 @@ 243, /* 258 -> PULSE 4_9: b0 */ 246, /* 259 -> PULSE 4_10: b0 */ }; + +/*! Check whether RTP frame contains EFR SID code word according to + * TS 101 318 §5.3.2 + * \param[in] rtp_payload Buffer with RTP payload + * \param[in] payload_len Length of payload + * \returns true if code word is found, false otherwise + */ +bool osmo_efr_check_sid(const uint8_t *rtp_payload, size_t payload_len) +{ + struct bitvec bv; + uint16_t i; + static const uint8_t sid_code_word_bits[95] = { + /* bit numbers relative to "pure" EFR frame beginning, + * not counting the signature bits. */ + 45, 46, 48, 49, 50, 51, 52, 53, 54, 55, + 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, + 66, 67, 68, 94, 95, 96, 98, 99, 100, 101, + 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, + 112, 113, 114, 115, 116, 117, 118, 148, 149, 150, + 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, + 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, + 171, 196, 197, 198, 199, 200, 201, 202, 203, 204, + 205, 206, 207, 208, 209, 212, 213, 214, 215, 216, + 217, 218, 219, 220, 221 }; + + /* signature does not match Enhanced Full Rate SID */ + if ((rtp_payload[0] >> 4) != 0xC) + return false; + + bv.data = (uint8_t *) rtp_payload; + bv.data_len = payload_len; + + /* code word is all 1 at given bits */ + for (i = 0; i < ARRAY_SIZE(sid_code_word_bits); i++) + if (bitvec_get_bit_pos(&bv, sid_code_word_bits[i]+4) != ONE) + return false; + + return true; +} -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iab9fb60028f4135375287bc42f5da7ca7838b5f0 Gerrit-Change-Number: 32034 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bsc[master]: bts: bts: Explain Ericsson's interface switch (IS)
by keith 24 Mar '23

24 Mar '23

Attention is currently required from: dexter. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32029 ) Change subject: bts: bts: Explain Ericsson's interface switch (IS) ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: +1 for content, (with laforge's comments) I don't know what's going on with the Jenkins errors. File doc/manuals/chapters/bts.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/32029/comment/7710e6b5_55dc78bf PS1, Line 784: to the outside must be aligned to E1 timeslot boarders. borders. (with 'a' it is Gäste) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib6ebd7fdfe9063c0d8cacf53ffd27f6099d9038a Gerrit-Change-Number: 32029 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 00:59:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: doc: running: Describe how to configure a co-located PCU
by keith 24 Mar '23

24 Mar '23

Attention is currently required from: dexter. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32030 ) Change subject: doc: running: Describe how to configure a co-located PCU ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3af3cd8ef7099bb94f4cb25513e9dfdc5fcc1b5a Gerrit-Change-Number: 32030 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 00:38:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: rsl: rsl_handle_chan_mod_ie(): add missing GSM48_CMODE_* values
by laforge 23 Mar '23

23 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32027 ) Change subject: rsl: rsl_handle_chan_mod_ie(): add missing GSM48_CMODE_* values ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iec397f1ef4cb5ac1c48abf869f54e272ed0fbb55 Gerrit-Change-Number: 32027 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 22:19:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: examples: update erissson GPRS config files
by pespin 23 Mar '23

23 Mar '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32031 ) Change subject: examples: update erissson GPRS config files ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: agree with Harald -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifc538940fadca08d03a36bf6a28392f22640493d Gerrit-Change-Number: 32031 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 20:48:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: WIP: gsup: add message type for osmo-epdg CEIA interface
by laforge 23 Mar '23

23 Mar '23

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32033 ) Change subject: WIP: gsup: add message type for osmo-epdg CEIA interface ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6f7c20340c99f94b1326a8a7dc99c86cf6a0dbc3 Gerrit-Change-Number: 32033 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 23 Mar 2023 19:25:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: doc: bts-examples: discuss Ericsson RBS EGPRS configuration
by laforge 23 Mar '23

23 Mar '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32032 ) Change subject: doc: bts-examples: discuss Ericsson RBS EGPRS configuration ...................................................................... Patch Set 1: (2 comments) File doc/manuals/chapters/bts-examples.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/32032/comment/4ddebe6e_bcc2d800 PS1, Line 279: 2000 again, 2000/6000 also here in this patch. The DUG+RUS you're working with are RBS6000, for example. https://gerrit.osmocom.org/c/osmo-bsc/+/32032/comment/ed6746f3_f8d21343 PS1, Line 334: 10.9.1.153 IP address again. Maybe also add a call-out here and explain that this must point to the SGSN? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb5b4d9300b16b0fac48f33b5db81442ab25031 Gerrit-Change-Number: 32032 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 19:24:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: examples: update erissson GPRS config files
by laforge 23 Mar '23

23 Mar '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32031 ) Change subject: examples: update erissson GPRS config files ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg: https://gerrit.osmocom.org/c/osmo-bsc/+/32031/comment/49198def_798564a9 PS1, Line 60: 10.9.1.153 I suggest to put 127.0.0.1 here, assuming that the SGSN runs on the same machine as the BSC. That is more likely to work than some arbitrary IP address. File doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg: https://gerrit.osmocom.org/c/osmo-bsc/+/32031/comment/09faf88c_0abd86de PS1, Line 57: gprs nsvc 0 remote ip 10.9.1.153 I suggest to put 127.0.0.1 here, assuming that the SGSN runs on the same machine as the BSC. That is more likely to work than some arbitrary IP address. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifc538940fadca08d03a36bf6a28392f22640493d Gerrit-Change-Number: 32031 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 19:23:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: doc: running: Describe how to configure a co-located PCU
by laforge 23 Mar '23

23 Mar '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32030 ) Change subject: doc: running: Describe how to configure a co-located PCU ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3af3cd8ef7099bb94f4cb25513e9dfdc5fcc1b5a Gerrit-Change-Number: 32030 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Mar 2023 19:22:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0