March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: bts: bts: Explain Ericsson's interface switch (IS)
by dexter 24 Mar '23

24 Mar '23

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32029 ) Change subject: bts: bts: Explain Ericsson's interface switch (IS) ...................................................................... Patch Set 2: (1 comment) File doc/manuals/chapters/bts.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/32029/comment/99b1369f_e3e6e6b4 PS1, Line 652: 2000 > 2000 and 6000. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib6ebd7fdfe9063c0d8cacf53ffd27f6099d9038a Gerrit-Change-Number: 32029 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 24 Mar 2023 09:43:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: bts: bts: Explain Ericsson's interface switch (IS)
by dexter 24 Mar '23

24 Mar '23

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, keith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/32029 to look at the new patch set (#2). Change subject: bts: bts: Explain Ericsson's interface switch (IS) ...................................................................... bts: bts: Explain Ericsson's interface switch (IS) The built in interface switch in ericsson RBS base stations no where explained. From the example configuration files alone it is not possible to understand how the IS configuration works. Let's add a chapter that explains how the IS configuration works. Related: OS#5198 Change-Id: Ib6ebd7fdfe9063c0d8cacf53ffd27f6099d9038a --- M doc/manuals/chapters/bts-examples.adoc M doc/manuals/chapters/bts.adoc 2 files changed, 153 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/32029/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib6ebd7fdfe9063c0d8cacf53ffd27f6099d9038a Gerrit-Change-Number: 32029 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: examples: update erissson GPRS config files
by dexter 24 Mar '23

24 Mar '23

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/32031 to look at the new patch set (#2). Change subject: examples: update erissson GPRS config files ...................................................................... examples: update erissson GPRS config files The example config files that illustrate how to set up GPRS/EGPRS using a BSC co-located PCU do not have any of the general GPRS parameters set. Lets add a gprs prameter block to both of them. Related: OS#5198 Change-Id: Ifc538940fadca08d03a36bf6a28392f22640493d --- M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg 2 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/31/32031/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifc538940fadca08d03a36bf6a28392f22640493d Gerrit-Change-Number: 32031 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: examples: update erissson GPRS config files
by dexter 24 Mar '23

24 Mar '23

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32031 ) Change subject: examples: update erissson GPRS config files ...................................................................... Patch Set 2: (2 comments) File doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg: https://gerrit.osmocom.org/c/osmo-bsc/+/32031/comment/3130c6b8_c61754cb PS1, Line 60: 10.9.1.153 > I suggest to put 127.0.0.1 here, assuming that the SGSN runs on the same machine as the BSC. […] Done File doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg: https://gerrit.osmocom.org/c/osmo-bsc/+/32031/comment/cbdd908e_ff553743 PS1, Line 57: gprs nsvc 0 remote ip 10.9.1.153 > I suggest to put 127.0.0.1 here, assuming that the SGSN runs on the same machine as the BSC. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifc538940fadca08d03a36bf6a28392f22640493d Gerrit-Change-Number: 32031 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 24 Mar 2023 09:43:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: doc: bts-examples: discuss Ericsson RBS EGPRS configuration
by dexter 24 Mar '23

24 Mar '23

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32032 ) Change subject: doc: bts-examples: discuss Ericsson RBS EGPRS configuration ...................................................................... Patch Set 2: (2 comments) File doc/manuals/chapters/bts-examples.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/32032/comment/aa510afb_88ceee7f PS1, Line 279: 2000 > again, 2000/6000 also here in this patch. The DUG+RUS you're working with are RBS6000, for example. Done https://gerrit.osmocom.org/c/osmo-bsc/+/32032/comment/cac04dba_d3ca76e2 PS1, Line 334: 10.9.1.153 > IP address again. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb5b4d9300b16b0fac48f33b5db81442ab25031 Gerrit-Change-Number: 32032 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 24 Mar 2023 09:43:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: doc: bts-examples: discuss Ericsson RBS EGPRS configuration
by dexter 24 Mar '23

24 Mar '23

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/32032 to look at the new patch set (#2). Change subject: doc: bts-examples: discuss Ericsson RBS EGPRS configuration ...................................................................... doc: bts-examples: discuss Ericsson RBS EGPRS configuration Add a configuration file example to illustrate how exactly EGPRS is configured on ericsson RBS BTSs. Related: OS#5198 Change-Id: I2fb5b4d9300b16b0fac48f33b5db81442ab25031 --- M doc/manuals/chapters/bts-examples.adoc M doc/manuals/chapters/running.adoc 2 files changed, 148 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/32/32032/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb5b4d9300b16b0fac48f33b5db81442ab25031 Gerrit-Change-Number: 32032 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-mgw[master]: Revert "mgcp_codec: do not differentiate between oa and bwe when comp...
by laforge 24 Mar '23

24 Mar '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27391 ) Change subject: Revert "mgcp_codec: do not differentiate between oa and bwe when comparing codec" ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0b2854ef2397f38606fab3425be586a3d0ca27d1 Gerrit-Change-Number: 27391 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 09:33:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Attach
by laforge 24 Mar '23

24 Mar '23

Attention is currently required from: Hoernchen, pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 ) Change subject: gmm: Initial implementation of GPRS Attach ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I212053b3a3f27ef7d63503c3d5ef08453b2d2056 Gerrit-Change-Number: 32021 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 09:31:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: codec: add osmo_efr_check_sid() function
by laforge 24 Mar '23

24 Mar '23

Attention is currently required from: falconia. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32034 ) Change subject: codec: add osmo_efr_check_sid() function ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/codec/gsm660.c: https://gerrit.osmocom.org/c/libosmocore/+/32034/comment/42d93be7_d1771800 PS1, Line 271: static con not a request to change: just a question. Why use 'static' here? does it change anything? Wouldn't a 'const uint8_t' array always be put in rodata anyway, without any 'static'? https://gerrit.osmocom.org/c/libosmocore/+/32034/comment/c3648636_922999d3 PS1, Line 272: /* bit numbers relative to "pure" EFR frame beginning, : * not counting the signature bits. */ : 45, 46, 48, 49, 50, 51, 52, 53, 54, 55, : 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, : 66, 67, 68, 94, 95, 96, 98, 99, 100, 101, : 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, : 112, 113, 114, 115, 116, 117, 118, 148, 149, 150, : 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, : 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, : 171, 196, 197, 198, 199, 200, 201, 202, 203, 204, : 205, 206, 207, 208, 209, 212, 213, 214, 215, 216, : 217, 218, 219, 220, 221 }; one tab indent too much, at least it looks that way in gerrit -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iab9fb60028f4135375287bc42f5da7ca7838b5f0 Gerrit-Change-Number: 32034 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 24 Mar 2023 09:31:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: add f_rua_expect()
by laforge 24 Mar '23

24 Mar '23

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31765 ) Change subject: hnbgw: add f_rua_expect() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I29e6b7659ba53efee9f676197b502f79780ead7e Gerrit-Change-Number: 31765 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 09:28:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0