Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32045 )
Change subject: logging_vty.c: rename static function
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/vty/logging_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/32045/comment/d35f9ec3_19c02b09
PS1, Line 193: logging_prnt_timezone,
: logging_timezone_cmd,
this newly-introduced command follows the same naming pattern: it has _prnt_ in the name, but not in the actual vty command?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32045
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5a651e393bd438ea236659ed2c86188a8f9885d1
Gerrit-Change-Number: 32045
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 24 Mar 2023 09:26:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32043 )
Change subject: logging: add 'logging timezone (localtime|utc)'
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
I would probably have used a bool rather than an enum as I see no chance we ever want to deal with anythign else (that's what the /etc/localtime and glibc is for).
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32043
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7f868b47bf8f8dfcf85e735f490ae69b18111af4
Gerrit-Change-Number: 32043
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 24 Mar 2023 09:24:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32041 )
Change subject: [RFC] drop list of HNBAP UE Context
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I think this could have implications when we start to support things like SABP (Service Area Broadcast Protocol).
In 2G, the BSC not only sends a warning message as broadcast to all BTSs who broadcast it on the downlink CBCH - but the BSC also needs to send a copy of the message via every currently active dedicated channel (as the UE doesn't listen to CCCH/CBCH while it is on a dedicated channel).
I'm not 100% familiar with the 3G service area broadcast, but I would imagine a similar procedure being required here. In this case the HNBGW would need to iterate over all active Iu connections and send a message through each of them.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32041
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ida7eadf36abcf465ae40003725c49e8e321a28c9
Gerrit-Change-Number: 32041
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 24 Mar 2023 09:21:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32040 )
Change subject: vty: 'show ue': show which HNB the UE is registered on
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32040
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ife54a105a5a011678d6a03d0032c7622c3079a28
Gerrit-Change-Number: 32040
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 24 Mar 2023 09:18:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32036 )
Change subject: map_sccp: on timeout during WAIT_CC, send N-DISCONNECT to SCCP-SCOC
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
I'm actually wondering why we have such a state to begin with? Isn't it the job of the SCCP provider (libosmo-sigtran/SCOC) to be in CONN_PEND_OUT and eventueally either get a CC or release the connection via N-DISCONNECT.ind to the SCCP user on timeout?
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32036
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ie94fcee4e2507a55449050aab96307199aed99a2
Gerrit-Change-Number: 32036
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 24 Mar 2023 09:17:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment