March 2023 - gerrit-log - lists.osmocom.org

[XL] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Attach
by pespin 24 Mar '23

24 Mar '23

Attention is currently required from: Hoernchen, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 ) Change subject: gmm: Initial implementation of GPRS Attach ...................................................................... Patch Set 7: (1 comment) File libosmo-gprs-gmm.pc.in: https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/da3654ff_ea133c7f PS1, Line 9: libosmo-gprs-llc > I meant `$(top_builddir)/src/llc/libosmo-gprs-llc.la`, of course. src/gmm/Makefile.am: Done in v7 libosmo-gprs-gmm.pc.in: it was already there -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I212053b3a3f27ef7d63503c3d5ef08453b2d2056 Gerrit-Change-Number: 32021 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 11:58:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[XL] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Attach
by pespin 24 Mar '23

24 Mar '23

Attention is currently required from: Hoernchen, pespin. Hello Jenkins Builder, Hoernchen, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 to look at the new patch set (#7). Change subject: gmm: Initial implementation of GPRS Attach ...................................................................... gmm: Initial implementation of GPRS Attach This patch contains further work on several areas for the GMM layer, like fixes and improvements in existing primitives, initial FSM implementation, initial Tx and Rx of some GMM messages, etc. Related: OS#5501 Change-Id: I212053b3a3f27ef7d63503c3d5ef08453b2d2056 --- M include/osmocom/gprs/gmm/Makefile.am M include/osmocom/gprs/gmm/gmm.h A include/osmocom/gprs/gmm/gmm_ms_fsm.h A include/osmocom/gprs/gmm/gmm_pdu.h M include/osmocom/gprs/gmm/gmm_prim.h M include/osmocom/gprs/gmm/gmm_private.h M include/osmocom/gprs/rlcmac/rlcmac_prim.h M libosmo-gprs-gmm.pc.in M src/gmm/Makefile.am M src/gmm/gmm.c A src/gmm/gmm_ms_fsm.c A src/gmm/gmm_pdu.c M src/gmm/gmm_prim.c M src/gmm/misc.c M tests/gmm/Makefile.am M tests/gmm/gmm_prim_test.c M tests/gmm/gmm_prim_test.err M tests/gmm/gmm_prim_test.ok 18 files changed, 1,879 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/21/32021/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I212053b3a3f27ef7d63503c3d5ef08453b2d2056 Gerrit-Change-Number: 32021 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: doc: bts-examples: discuss Ericsson RBS EGPRS configuration
by laforge 24 Mar '23

24 Mar '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32032 ) Change subject: doc: bts-examples: discuss Ericsson RBS EGPRS configuration ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2fb5b4d9300b16b0fac48f33b5db81442ab25031 Gerrit-Change-Number: 32032 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 11:09:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: examples: update erissson GPRS config files
by laforge 24 Mar '23

24 Mar '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32031 ) Change subject: examples: update erissson GPRS config files ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifc538940fadca08d03a36bf6a28392f22640493d Gerrit-Change-Number: 32031 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 11:09:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: bts: bts: Explain Ericsson's interface switch (IS)
by laforge 24 Mar '23

24 Mar '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32029 ) Change subject: bts: bts: Explain Ericsson's interface switch (IS) ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib6ebd7fdfe9063c0d8cacf53ffd27f6099d9038a Gerrit-Change-Number: 32029 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 11:08:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: bts: bts: Explain Ericsson's interface switch (IS)
by laforge 24 Mar '23

24 Mar '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32029 ) Change subject: bts: bts: Explain Ericsson's interface switch (IS) ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > asciidoc: ERROR: bts.adoc: line 700: [tabledef-default] total width less than 100%: 45%,25%,25% […] this still does seem to fail even in the updated patch: asciidoc: ERROR: bts.adoc: line 700: [tabledef-default] total width less than 100%: 45%,25%,25% asciidoc: ERROR: bts.adoc: line 716: [tabledef-default] total width less than 100%: 45%,25%,25% asciidoc: ERROR: bts.adoc: line 751: [tabledef-default] total width less than 100%: 45%,25%,25% -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib6ebd7fdfe9063c0d8cacf53ffd27f6099d9038a Gerrit-Change-Number: 32029 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 11:08:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: doc: overview: put BTS and PCU on the same rank
by dexter 24 Mar '23

24 Mar '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32047 ) Change subject: doc: overview: put BTS and PCU on the same rank ...................................................................... doc: overview: put BTS and PCU on the same rank The manual so far describes how OsmoPCU is run in co-location with the BTS but Figure 1 shows the PCU next to the BSC. Lets put BTS and PCU on the same rank so that they appear next to each other. This reflects the reality better. Change-Id: Ifa170f3956b4629765a88ed62e877a204541d9ea --- M doc/manuals/chapters/overview.adoc 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/47/32047/1 diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc index 6ae6f7e..5b831d3 100644 --- a/doc/manuals/chapters/overview.adoc +++ b/doc/manuals/chapters/overview.adoc @@ -27,6 +27,7 @@ PCU->SGSN [label="Gb"] SGSN->GGSN [label="GTP"] PCU [color=red] + { rank=same BTS PCU } } ---- -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifa170f3956b4629765a88ed62e877a204541d9ea Gerrit-Change-Number: 32047 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[XL] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Attach
by fixeria 24 Mar '23

24 Mar '23

Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 ) Change subject: gmm: Initial implementation of GPRS Attach ...................................................................... Patch Set 6: (1 comment) File libosmo-gprs-gmm.pc.in: https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/dc3a5fba_685d3c0a PS1, Line 9: libosmo-gprs-llc > > AFAIU that's done automatically through ${shlibs:Depends}. […] I meant `$(top_builddir)/src/llc/libosmo-gprs-llc.la`, of course. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I212053b3a3f27ef7d63503c3d5ef08453b2d2056 Gerrit-Change-Number: 32021 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 09:57:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[XL] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Attach
by fixeria 24 Mar '23

24 Mar '23

Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 ) Change subject: gmm: Initial implementation of GPRS Attach ...................................................................... Patch Set 6: (1 comment) File libosmo-gprs-gmm.pc.in: https://gerrit.osmocom.org/c/libosmo-gprs/+/32021/comment/d4ab2a02_1f304602 PS1, Line 9: libosmo-gprs-llc > AFAIU that's done automatically through ${shlibs:Depends}. Ah, indeed. Too much magic happening automatically there... What I am still worried about is that you haven't updated the following files: * `src/gmm/Makefile.am` - add `$(top_builddir)/src/csn1/libosmo-gprs-llc.la` to `libosmo_gprs_gmm_la_LIBADD`. * `libosmo-gprs-gmm.pc.in` - add `libosmo-gprs-llc` to `Requires`. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I212053b3a3f27ef7d63503c3d5ef08453b2d2056 Gerrit-Change-Number: 32021 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Mar 2023 09:56:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: scripts/manuals: fix missing UserKnownHostsFile
by osmith 24 Mar '23

24 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/32046 ) Change subject: scripts/manuals: fix missing UserKnownHostsFile ...................................................................... scripts/manuals: fix missing UserKnownHostsFile Fix for: :: Listing files on server: /docs Host key verification failed. Related: OS#5902 Change-Id: I485e2268eec50f46ed0436d4b3a5cedfab20af96 --- M scripts/manuals/publish-manuals-for-tags.sh 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/46/32046/1 diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index 9d453b8..b40b602 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -385,6 +385,10 @@ } check_ssh_auth_sock + +# Get the UserKnownHostsFile for $SSH_COMMAND +clone_repo osmo-gsm-manuals master + get_server_ls "/docs" for docs_dir in $(cat "$TEMP"/ls_docs); do -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I485e2268eec50f46ed0436d4b3a5cedfab20af96 Gerrit-Change-Number: 32046 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0