March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: rlcmac/sched: use TDMA Fn macros from libosmogsm
by pespin 02 Mar '23

02 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31641 ) Change subject: rlcmac/sched: use TDMA Fn macros from libosmogsm ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I536a0d2ae9b5dabcd3976f5aeb15069bd03e6aa9 Gerrit-Change-Number: 31641 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Mar 2023 15:19:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: simplify storage of bsc_msc_data->audio_support
by pespin 02 Mar '23

02 Mar '23

Attention is currently required from: neels, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31609 ) Change subject: simplify storage of bsc_msc_data->audio_support ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31609/comment/a11ed9ba_58ac1ddd PS1, Line 2729: int > usually the compiler would tell me that it is a size_t... […] Did you try as suggested to simply use %zu and resubmit? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I625cedc4bb040d649fd6e1794ba468f4c6ad6adc Gerrit-Change-Number: 31609 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Mar 2023 15:18:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: rlcmac: ignore PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK
by pespin 02 Mar '23

02 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31640 ) Change subject: rlcmac: ignore PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: We should rather see what to do with them, and I bet simply ignoring them there is not the way to go, I need to check. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6a40e2795adc71b9312d39c96b01aba9a258da42 Gerrit-Change-Number: 31640 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Mar 2023 15:17:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: VTY,CTRL: add 'osmodyn' as alias for 'tch/f_tch/h_sdcch8_pdch'
by pespin 02 Mar '23

02 Mar '23

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31615 ) Change subject: VTY,CTRL: add 'osmodyn' as alias for 'tch/f_tch/h_sdcch8_pdch' ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I'd say we could at least introduce an underscore or a dash (osmo_dyn, osmo-dyn) or expand to osmoco […] OSMO/DYN? as in TCH/F -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I37719edd867c777d1ce944b8e2f1efffac38f00e Gerrit-Change-Number: 31615 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 02 Mar 2023 15:12:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: rlcmac/sched: use TDMA Fn macros from libosmogsm
by fixeria 02 Mar '23

02 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31641 ) Change subject: rlcmac/sched: use TDMA Fn macros from libosmogsm ...................................................................... rlcmac/sched: use TDMA Fn macros from libosmogsm Change-Id: I536a0d2ae9b5dabcd3976f5aeb15069bd03e6aa9 --- M src/rlcmac/sched.c 1 file changed, 12 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/41/31641/1 diff --git a/src/rlcmac/sched.c b/src/rlcmac/sched.c index b5c02cc..c2b981f 100644 --- a/src/rlcmac/sched.c +++ b/src/rlcmac/sched.c @@ -21,6 +21,7 @@ #include <osmocom/core/linuxlist.h> #include <osmocom/core/msgb.h> +#include <osmocom/gsm/gsm0502.h> #include <osmocom/gprs/rlcmac/rlcmac_private.h> #include <osmocom/gprs/rlcmac/sched.h> @@ -39,11 +40,6 @@ struct gprs_rlcmac_ul_tbf *ul_ass; }; -static inline uint32_t next_fn(uint32_t fn, uint32_t offset) -{ - return (fn + offset) % GSM_MAX_FN; -} - static inline bool fn_valid(uint32_t fn) { uint32_t f = fn % 13; @@ -62,10 +58,10 @@ OSMO_ASSERT(rrbp < ARRAY_SIZE(rrbp_list)); - poll_fn = next_fn(cur_fn, rrbp_list[rrbp]); + poll_fn = GSM_TDMA_FN_SUM(cur_fn, rrbp_list[rrbp]); if (!fn_valid(poll_fn)) { /* 17 -> 18, 21 -> 22: */ - poll_fn = next_fn(poll_fn, 1); + GSM_TDMA_FN_INC(poll_fn); OSMO_ASSERT(fn_valid(poll_fn)); } return poll_fn; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I536a0d2ae9b5dabcd3976f5aeb15069bd03e6aa9 Gerrit-Change-Number: 31641 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: bsc_vty.c: s/bsc/msc for commands under msc node
by neels 02 Mar '23

02 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31606 ) Change subject: bsc_vty.c: s/bsc/msc for commands under msc node ...................................................................... bsc_vty.c: s/bsc/msc for commands under msc node Change-Id: Id91a82ca8e2eb91b52836e024ccf925245886ae6 --- M src/osmo-bsc/bsc_vty.c 1 file changed, 27 insertions(+), 18 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index 0472a93..ce4f654 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -2640,8 +2640,8 @@ return CMD_SUCCESS; } -DEFUN_ATTR(cfg_net_bsc_ncc, - cfg_net_bsc_ncc_cmd, +DEFUN_ATTR(cfg_net_msc_ncc, + cfg_net_msc_ncc_cmd, "core-mobile-network-code <1-999>", "Use this network code for the core network\n" "MNC value\n", CMD_ATTR_IMMEDIATE) @@ -2659,8 +2659,8 @@ return CMD_SUCCESS; } -DEFUN_ATTR(cfg_net_bsc_mcc, - cfg_net_bsc_mcc_cmd, +DEFUN_ATTR(cfg_net_msc_mcc, + cfg_net_msc_mcc_cmd, "core-mobile-country-code <1-999>", "Use this country code for the core network\n" "MCC value\n", CMD_ATTR_IMMEDIATE) @@ -2675,8 +2675,8 @@ return CMD_SUCCESS; } -DEFUN_DEPRECATED(cfg_net_bsc_lac, - cfg_net_bsc_lac_cmd, +DEFUN_DEPRECATED(cfg_net_msc_lac, + cfg_net_msc_lac_cmd, "core-location-area-code <0-65535>", "Legacy configuration that no longer has any effect\n-\n") { @@ -2684,8 +2684,8 @@ return CMD_SUCCESS; } -DEFUN_DEPRECATED(cfg_net_bsc_ci, - cfg_net_bsc_ci_cmd, +DEFUN_DEPRECATED(cfg_net_msc_ci, + cfg_net_msc_ci_cmd, "core-cell-identity <0-65535>", "Legacy configuration that no longer has any effect\n-\n") { @@ -2693,8 +2693,8 @@ return CMD_SUCCESS; } -DEFUN_DEPRECATED(cfg_net_bsc_rtp_base, - cfg_net_bsc_rtp_base_cmd, +DEFUN_DEPRECATED(cfg_net_msc_rtp_base, + cfg_net_msc_rtp_base_cmd, "ip.access rtp-base <1-65000>", "deprecated\n" "deprecated, RTP is handled by the MGW\n" "deprecated\n") { @@ -2702,8 +2702,8 @@ return CMD_SUCCESS; } -DEFUN_USRATTR(cfg_net_bsc_codec_list, - cfg_net_bsc_codec_list_cmd, +DEFUN_USRATTR(cfg_net_msc_codec_list, + cfg_net_msc_codec_list_cmd, BSC_VTY_ATTR_NEW_LCHAN, "codec-list .LIST", "Set the allowed audio codecs and their order of preference\n" @@ -3615,12 +3615,12 @@ install_element(BSC_NODE, &cfg_bsc_bts_setup_ramping_step_interval_cmd); install_node(&msc_node, config_write_msc); - install_element(MSC_NODE, &cfg_net_bsc_ncc_cmd); - install_element(MSC_NODE, &cfg_net_bsc_mcc_cmd); - install_element(MSC_NODE, &cfg_net_bsc_lac_cmd); - install_element(MSC_NODE, &cfg_net_bsc_ci_cmd); - install_element(MSC_NODE, &cfg_net_bsc_rtp_base_cmd); - install_element(MSC_NODE, &cfg_net_bsc_codec_list_cmd); + install_element(MSC_NODE, &cfg_net_msc_ncc_cmd); + install_element(MSC_NODE, &cfg_net_msc_mcc_cmd); + install_element(MSC_NODE, &cfg_net_msc_lac_cmd); + install_element(MSC_NODE, &cfg_net_msc_ci_cmd); + install_element(MSC_NODE, &cfg_net_msc_rtp_base_cmd); + install_element(MSC_NODE, &cfg_net_msc_codec_list_cmd); install_element(MSC_NODE, &cfg_net_msc_dest_cmd); install_element(MSC_NODE, &cfg_net_msc_no_dest_cmd); install_element(MSC_NODE, &cfg_net_msc_welcome_ussd_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id91a82ca8e2eb91b52836e024ccf925245886ae6 Gerrit-Change-Number: 31606 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: cosmetic: use i++ instead of ++i in for loop
by neels 02 Mar '23

02 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31604 ) Change subject: cosmetic: use i++ instead of ++i in for loop ...................................................................... cosmetic: use i++ instead of ++i in for loop Change-Id: I9903e54e3eb59db9b9cd22e017bc81b9b86e01e9 --- M src/osmo-bsc/bsc_vty.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index a3ba143..fd08ff5 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -2713,7 +2713,7 @@ int i; /* check all given arguments first */ - for (i = 0; i < argc; ++i) { + for (i = 0; i < argc; i++) { /* check for hrX or frX */ if (strlen(argv[i]) != 3 || argv[i][1] != 'r' -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9903e54e3eb59db9b9cd22e017bc81b9b86e01e9 Gerrit-Change-Number: 31604 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: vty: improve doc for 'codec-list'
by neels 02 Mar '23

02 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31605 ) Change subject: vty: improve doc for 'codec-list' ...................................................................... vty: improve doc for 'codec-list' Change-Id: I33e6568997bcb1a9466e1e0c1b00718b703e2904 --- M src/osmo-bsc/bsc_vty.c M tests/msc.vty 2 files changed, 14 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index fd08ff5..0472a93 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -2706,8 +2706,9 @@ cfg_net_bsc_codec_list_cmd, BSC_VTY_ATTR_NEW_LCHAN, "codec-list .LIST", - "Set the allowed audio codecs\n" - "List of audio codecs, e.g. fr3 fr1 hr3\n") + "Set the allowed audio codecs and their order of preference\n" + "List of audio codecs in order of preference, e.g. 'codec-list fr3 fr2 fr1 hr3 hr1'." + " (fr3: AMR-FR, hr3: AMR-HR, fr2: GSM-EFR, fr1: GSM-FR, hr1: GSM-HR)\n") { struct bsc_msc_data *data = bsc_msc_data(vty); int i; diff --git a/tests/msc.vty b/tests/msc.vty index 555ea34..6edc846 100644 --- a/tests/msc.vty +++ b/tests/msc.vty @@ -4,9 +4,9 @@ OsmoBSC(config)# msc 0 OsmoBSC(config-msc)# codec-list? - codec-list Set the allowed audio codecs + codec-list Set the allowed audio codecs and their order of preference OsmoBSC(config-msc)# codec-list ? - LIST List of audio codecs, e.g. fr3 fr1 hr3 + LIST List of audio codecs in order of preference, e.g. 'codec-list fr3 fr2 fr1 hr3 hr1'. (fr3: AMR-FR, hr3: AMR-HR, fr2: GSM-EFR, fr1: GSM-FR, hr1: GSM-HR) OsmoBSC(config-msc)# # Default list -- should match the default in osmo_msc_data_alloc() OsmoBSC(config-msc)# show running-config -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I33e6568997bcb1a9466e1e0c1b00718b703e2904 Gerrit-Change-Number: 31605 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: vty: msc / codec-list: tweak error msg
by neels 02 Mar '23

02 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31608 ) Change subject: vty: msc / codec-list: tweak error msg ...................................................................... vty: msc / codec-list: tweak error msg Change-Id: I7ba508cceccb8a25db0936f756f3e4a28ec1333f --- M src/osmo-bsc/bsc_vty.c M tests/msc.vty 2 files changed, 10 insertions(+), 9 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index d0add0e..bba84e2 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -2752,7 +2752,7 @@ error: vty_out(vty, "Codec name must be hrX or frX. Was '%s'%s", argv[i], VTY_NEWLINE); - return CMD_ERR_INCOMPLETE; + return CMD_WARNING; } #define LEGACY_STR "This command has no effect, it is kept to support legacy config files\n" diff --git a/tests/msc.vty b/tests/msc.vty index 6edc846..56a3fe2 100644 --- a/tests/msc.vty +++ b/tests/msc.vty @@ -34,23 +34,15 @@ OsmoBSC(config-msc)# codec-list foo Codec name must be hrX or frX. Was 'foo' -% Command incomplete. -OsmoBSC(config-msc)# # ERROR: "Command incomplete" is not accurate OsmoBSC(config-msc)# codec-list fr10 Codec name must be hrX or frX. Was 'fr10' -% Command incomplete. -OsmoBSC(config-msc)# # ERROR: "Command incomplete" is not accurate OsmoBSC(config-msc)# codec-list hr10 Codec name must be hrX or frX. Was 'hr10' -% Command incomplete. -OsmoBSC(config-msc)# # ERROR: "Command incomplete" is not accurate OsmoBSC(config-msc)# codec-list FR1 Codec name must be hrX or frX. Was 'FR1' -% Command incomplete. -OsmoBSC(config-msc)# # ERROR: "Command incomplete" is not accurate OsmoBSC(config-msc)# # Ensure the codec-list with wrong args did not change the config OsmoBSC(config-msc)# show running-config -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7ba508cceccb8a25db0936f756f3e4a28ec1333f Gerrit-Change-Number: 31608 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: bsc_vty.c write_msc(): fix weird printf format
by neels 02 Mar '23

02 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31607 ) Change subject: bsc_vty.c write_msc(): fix weird printf format ...................................................................... bsc_vty.c write_msc(): fix weird printf format Change-Id: I856c2d620b89efcf3239186ef53c6941577dbccc --- M src/osmo-bsc/bsc_vty.c 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index ce4f654..d0add0e 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -2551,9 +2551,9 @@ vty_out(vty, " "); if (msc->audio_support[i]->hr) - vty_out(vty, "hr%.1u", msc->audio_support[i]->ver); + vty_out(vty, "hr%u", msc->audio_support[i]->ver); else - vty_out(vty, "fr%.1u", msc->audio_support[i]->ver); + vty_out(vty, "fr%u", msc->audio_support[i]->ver); } vty_out(vty, "%s", VTY_NEWLINE); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31607 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I856c2d620b89efcf3239186ef53c6941577dbccc Gerrit-Change-Number: 31607 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0