March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: tbf_ul: Fix contention_resolution check for 2phase access
by pespin 02 Mar '23

02 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31643 ) Change subject: tbf_ul: Fix contention_resolution check for 2phase access ...................................................................... tbf_ul: Fix contention_resolution check for 2phase access Change-Id: Ia20bcf99f4ece17b33048930ded50e703d7b7461 --- M src/rlcmac/tbf_ul.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/rlcmac/tbf_ul.c b/src/rlcmac/tbf_ul.c index 6d76155..7642832 100644 --- a/src/rlcmac/tbf_ul.c +++ b/src/rlcmac/tbf_ul.c @@ -104,7 +104,7 @@ * successful once we get out of GPRS_RLCMAC_TBF_UL_ST_WAIT_ASSIGN * (when we receive a Pkt Ul Ass, see TS 44.60 7.1.3.3) */ if (ul_tbf->ul_ass_fsm.ass_type == GPRS_RLCMAC_TBF_UL_ASS_TYPE_2PHASE) - return true; + return false; /* 1phase access: Check if we didn't yet send any data, or whether * either T3164 or T3166 are active: */ if (ul_tbf->ul_ass_fsm.ass_type == GPRS_RLCMAC_TBF_UL_ASS_TYPE_1PHASE) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ia20bcf99f4ece17b33048930ded50e703d7b7461 Gerrit-Change-Number: 31643 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-trx[master]: ms: adjust tx scaling for tx samples
by pespin 02 Mar '23

02 Mar '23

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/31642 ) Change subject: ms: adjust tx scaling for tx samples ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I75a2eba1f7f7b81249c06ce3fc9dfeee08878cb9 Gerrit-Change-Number: 31642 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Mar 2023 18:24:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: bsc_test.c: test FSM IDs that contain pchan names
by pespin 02 Mar '23

02 Mar '23

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31631 ) Change subject: bsc_test.c: test FSM IDs that contain pchan names ...................................................................... Patch Set 4: -Code-Review (1 comment) File tests/bsc/bsc_test.ok: https://gerrit.osmocom.org/c/osmo-bsc/+/31631/comment/8fa63503_0981a8dd PS3, Line 50: pchan=OSMODYN: > I prefer "osmodyn" for reasons [...], and hence i want to make all of it "osmodyn" everywhere. […] I personally prefer having "-" or "_" in it, I agree with Harald that "OSMODYN" looks difficult to understand. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If369f23fa140b9d7792f5a511815cbbd14b371e9 Gerrit-Change-Number: 31631 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 02 Mar 2023 18:23:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: simplify storage of bsc_msc_data->audio_support
by pespin 02 Mar '23

02 Mar '23

Attention is currently required from: neels, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31609 ) Change subject: simplify storage of bsc_msc_data->audio_support ...................................................................... Patch Set 3: (1 comment) File include/osmocom/bsc/bsc_msc_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31609/comment/8bd7f594_f6baafc5 PS1, Line 140: struct gsm_audio_support audio_support[16]; > sorry wrong place to respond but you get it MY concern regarding 13 vs 16 has not been answered afaict? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I625cedc4bb040d649fd6e1794ba468f4c6ad6adc Gerrit-Change-Number: 31609 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Mar 2023 18:20:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: tbf_ul: Fix contention_resolution check for 2phase access
by pespin 02 Mar '23

02 Mar '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31643 ) Change subject: tbf_ul: Fix contention_resolution check for 2phase access ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ia20bcf99f4ece17b33048930ded50e703d7b7461 Gerrit-Change-Number: 31643 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Mar 2023 18:16:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: tbf_ul: Fix contention_resolution check for 2phase access
by pespin 02 Mar '23

02 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31643 ) Change subject: tbf_ul: Fix contention_resolution check for 2phase access ...................................................................... tbf_ul: Fix contention_resolution check for 2phase access Change-Id: Ia20bcf99f4ece17b33048930ded50e703d7b7461 --- M src/rlcmac/tbf_ul.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/43/31643/1 diff --git a/src/rlcmac/tbf_ul.c b/src/rlcmac/tbf_ul.c index 6d76155..7642832 100644 --- a/src/rlcmac/tbf_ul.c +++ b/src/rlcmac/tbf_ul.c @@ -104,7 +104,7 @@ * successful once we get out of GPRS_RLCMAC_TBF_UL_ST_WAIT_ASSIGN * (when we receive a Pkt Ul Ass, see TS 44.60 7.1.3.3) */ if (ul_tbf->ul_ass_fsm.ass_type == GPRS_RLCMAC_TBF_UL_ASS_TYPE_2PHASE) - return true; + return false; /* 1phase access: Check if we didn't yet send any data, or whether * either T3164 or T3166 are active: */ if (ul_tbf->ul_ass_fsm.ass_type == GPRS_RLCMAC_TBF_UL_ASS_TYPE_1PHASE) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ia20bcf99f4ece17b33048930ded50e703d7b7461 Gerrit-Change-Number: 31643 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in libosmo-gprs[master]: rlcmac: dl_tbf: Improve logic requesting a new UL TBF
by pespin 02 Mar '23

02 Mar '23

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31576 to look at the new patch set (#2). Change subject: rlcmac: dl_tbf: Improve logic requesting a new UL TBF ...................................................................... rlcmac: dl_tbf: Improve logic requesting a new UL TBF Change-Id: I702872ba32a410bb5f09943af3cdadca482562db --- M include/osmocom/gprs/rlcmac/gre.h M include/osmocom/gprs/rlcmac/tbf_ul.h M include/osmocom/gprs/rlcmac/tbf_ul_ass_fsm.h M src/rlcmac/gre.c M src/rlcmac/rlcmac.c M src/rlcmac/rlcmac_enc.c M src/rlcmac/sched.c M src/rlcmac/tbf_ul.c M src/rlcmac/tbf_ul_ass_fsm.c M tests/rlcmac/rlcmac_prim_test.c M tests/rlcmac/rlcmac_prim_test.err M tests/rlcmac/rlcmac_prim_test.ok 12 files changed, 500 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/76/31576/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I702872ba32a410bb5f09943af3cdadca482562db Gerrit-Change-Number: 31576 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: VTY,CTRL: add 'osmodyn' as alias for 'tch/f_tch/h_sdcch8_pdch'
by neels 02 Mar '23

02 Mar '23

Attention is currently required from: laforge, fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31615 ) Change subject: VTY,CTRL: add 'osmodyn' as alias for 'tch/f_tch/h_sdcch8_pdch' ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > "osmodyn" is still my favorite, but here are more ideas: […] my favorite now seems to shift to dynamic/osmo -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I37719edd867c777d1ce944b8e2f1efffac38f00e Gerrit-Change-Number: 31615 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Mar 2023 17:32:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: VTY,CTRL: add 'osmodyn' as alias for 'tch/f_tch/h_sdcch8_pdch'
by neels 02 Mar '23

02 Mar '23

Attention is currently required from: laforge, fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31615 ) Change subject: VTY,CTRL: add 'osmodyn' as alias for 'tch/f_tch/h_sdcch8_pdch' ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > > My favorite of all suggestions is still "osmodyn" ... […] "osmodyn" is still my favorite, but here are more ideas: "dyn/osmo" and "dyn/ipa" "dyn/osmocom" "dyn/ipaccess" "dynamic/osmo" "dynamic/ipacc" -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I37719edd867c777d1ce944b8e2f1efffac38f00e Gerrit-Change-Number: 31615 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Mar 2023 17:25:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: adjust tx scaling for tx samples
by Hoernchen 02 Mar '23

02 Mar '23

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/31642 ) Change subject: ms: adjust tx scaling for tx samples ...................................................................... ms: adjust tx scaling for tx samples The "safe" scaling factor introduced in 7ac54b10d3373865cddd0f2e3821b0346cb9dd7c is too low and dates back to the beginning and the move from usrp1->uhd, but the modulator will exceed +-1 so "proper" scaling leads to overflows. Let's just do what osmotrx has been doing for many years... Change-Id: I75a2eba1f7f7b81249c06ce3fc9dfeee08878cb9 --- M Transceiver52M/ms/ms.cpp M Transceiver52M/ms/uhd_specific.h 2 files changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/42/31642/1 diff --git a/Transceiver52M/ms/ms.cpp b/Transceiver52M/ms/ms.cpp index 6f63a73..ec2c5f8 100644 --- a/Transceiver52M/ms/ms.cpp +++ b/Transceiver52M/ms/ms.cpp @@ -58,7 +58,7 @@ pthread_setschedparam(pthread_self(), SCHED_FIFO, &sch_params); auto burst = genRandAccessBurst(0, 4, 0); - scaleVector(*burst, t->txFullScale * 0.7); + scaleVector(*burst, t->txFullScale); // float -> int16 blade_sample_type burst_buf[burst->size()]; diff --git a/Transceiver52M/ms/uhd_specific.h b/Transceiver52M/ms/uhd_specific.h index edf7f79..8295a54 100644 --- a/Transceiver52M/ms/uhd_specific.h +++ b/Transceiver52M/ms/uhd_specific.h @@ -82,7 +82,7 @@ { delete[] one_pkt_buf; } - uhd_hw() : rxFullScale(32767), txFullScale(32767), rxtxdelay(-67) + uhd_hw() : rxFullScale(32767), txFullScale(32767 * 0.3), rxtxdelay(-67) { } -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I75a2eba1f7f7b81249c06ce3fc9dfeee08878cb9 Gerrit-Change-Number: 31642 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

1 0