neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31608 ) Change subject: vty: msc / codec-list: tweak error msg ...................................................................... vty: msc / codec-list: tweak error msg Change-Id: I7ba508cceccb8a25db0936f756f3e4a28ec1333f --- M src/osmo-bsc/bsc_vty.c M tests/msc.vty 2 files changed, 10 insertions(+), 9 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index d0add0e..bba84e2 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -2752,7 +2752,7 @@ error: vty_out(vty, "Codec name must be hrX or frX. Was '%s'%s", argv[i], VTY_NEWLINE); - return CMD_ERR_INCOMPLETE; + return CMD_WARNING; } #define LEGACY_STR "This command has no effect, it is kept to support legacy config files\n" diff --git a/tests/msc.vty b/tests/msc.vty index 6edc846..56a3fe2 100644 --- a/tests/msc.vty +++ b/tests/msc.vty @@ -34,23 +34,15 @@ OsmoBSC(config-msc)# codec-list foo Codec name must be hrX or frX. Was 'foo' -% Command incomplete. -OsmoBSC(config-msc)# # ERROR: "Command incomplete" is not accurate OsmoBSC(config-msc)# codec-list fr10 Codec name must be hrX or frX. Was 'fr10' -% Command incomplete. -OsmoBSC(config-msc)# # ERROR: "Command incomplete" is not accurate OsmoBSC(config-msc)# codec-list hr10 Codec name must be hrX or frX. Was 'hr10' -% Command incomplete. -OsmoBSC(config-msc)# # ERROR: "Command incomplete" is not accurate OsmoBSC(config-msc)# codec-list FR1 Codec name must be hrX or frX. Was 'FR1' -% Command incomplete. -OsmoBSC(config-msc)# # ERROR: "Command incomplete" is not accurate OsmoBSC(config-msc)# # Ensure the codec-list with wrong args did not change the config OsmoBSC(config-msc)# show running-config -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7ba508cceccb8a25db0936f756f3e4a28ec1333f Gerrit-Change-Number: 31608 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged