March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: tests: make 'vty-test' target depend on osmo-hnbgw binary
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32140 ) Change subject: tests: make 'vty-test' target depend on osmo-hnbgw binary ...................................................................... tests: make 'vty-test' target depend on osmo-hnbgw binary Change-Id: Iaaa1dd622fde460a250c11eb97cf0b25469e55c4 --- M tests/Makefile.am 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/40/32140/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index f9da51f..b9f0279 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -53,10 +53,11 @@ # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: # make vty-test U=-u -vty-test: +vty-test: $(top_builddir)/src/osmo-hnbgw/osmo-hnbgw osmo_verify_transcript_vty.py -v \ -n OsmoHNBGW -p 4261 \ - -r "$(top_builddir)/src/osmo-hnbgw/osmo-hnbgw -c $(top_srcdir)/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg" \ + -r "$(top_builddir)/src/osmo-hnbgw/osmo-hnbgw \ + -c $(top_srcdir)/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg" \ $(U) $(srcdir)/$(VTY_TEST) check-local: atconfig $(TESTSUITE) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iaaa1dd622fde460a250c11eb97cf0b25469e55c4 Gerrit-Change-Number: 32140 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: rtp continuous-streaming: fix BFI in the quality-suppressed case
by falconia 29 Mar '23

29 Mar '23

Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32128 ) Change subject: rtp continuous-streaming: fix BFI in the quality-suppressed case ...................................................................... Patch Set 2: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32128/comment/bd1f4032_f0bf924a PS1, Line 1661: send_ul_rtp_packet(lchan, fn, bfi, 0); > well if len = 0, then it makes no sense to access to buffer, so it shouldn't expect it to be non-nul […] I just double-checked to be absolutely sure: when OsMux is used, the call boils down to osmo_rtp_build() in libosmo-netif, and in the non-OsMux case it boils down to rtp_session_create_packet() in the external-dependency ortp library. Both functions are explicitly OK with zero-length RTP payloads (length argument to the function equals 0), and in both functions the memcpy() call for payload bytes is explicitly skipped in the zero-length case, thus the data pointer argument is never used. So we all good. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icee0f57be289a0592a0197469432a012d15f224c Gerrit-Change-Number: 32128 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Mar 2023 19:43:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-smlc[master]: tests: execute osmotest{vty,config}.py against osmo-smlc
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/32137 ) Change subject: tests: execute osmotest{vty,config}.py against osmo-smlc ...................................................................... tests: execute osmotest{vty,config}.py against osmo-smlc Change-Id: I61d970563a1902cce704d5c1a6adea9d8be438e4 --- M tests/Makefile.am 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/37/32137/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index d046d49..b2e1bee 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -37,9 +37,11 @@ $(NULL) if ENABLE_EXT_TESTS -python-tests: +python-tests: $(top_builddir)/src/osmo-smlc/osmo-smlc $(MAKE) vty-test $(MAKE) ctrl-test + osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v + osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v else python-tests: echo "Not running python-based tests (determined at configure-time)" -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/32137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I61d970563a1902cce704d5c1a6adea9d8be438e4 Gerrit-Change-Number: 32137 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-sccp[master]: osmoappdesc.py: also test doc/examples/osmo-stp-multihome.cfg
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32136 ) Change subject: osmoappdesc.py: also test doc/examples/osmo-stp-multihome.cfg ...................................................................... osmoappdesc.py: also test doc/examples/osmo-stp-multihome.cfg Change-Id: Ib6d0b0cdcfad165ad34d304069843c71f6eb06de --- M osmoappdesc.py 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/36/32136/1 diff --git a/osmoappdesc.py b/osmoappdesc.py index 6c1bafa..2fdce25 100644 --- a/osmoappdesc.py +++ b/osmoappdesc.py @@ -1,7 +1,8 @@ #!/usr/bin/env python3 app_configs = { - "osmo-stp": ["doc/examples/osmo-stp.cfg"], + "osmo-stp": ["doc/examples/osmo-stp.cfg", + "doc/examples/osmo-stp-multihome.cfg"], } apps = [(4239, "stp/osmo-stp", "OsmoSTP", "osmo-stp"), -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ib6d0b0cdcfad165ad34d304069843c71f6eb06de Gerrit-Change-Number: 32136 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-sccp[master]: tests: execute osmotest{vty,config}.py against osmo-stp
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32135 ) Change subject: tests: execute osmotest{vty,config}.py against osmo-stp ...................................................................... tests: execute osmotest{vty,config}.py against osmo-stp Change-Id: Idd57757f251dd1c4d1c74d275b4c5d8beff304e5 --- M tests/vty/Makefile.am 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/35/32135/1 diff --git a/tests/vty/Makefile.am b/tests/vty/Makefile.am index df5a64c..7f67d75 100644 --- a/tests/vty/Makefile.am +++ b/tests/vty/Makefile.am @@ -15,8 +15,10 @@ ss7_asp_vty_test_SOURCES = ss7_asp_vty_test.c if ENABLE_EXT_TESTS -ext-tests: +ext-tests: $(top_builddir)/stp/osmo-stp $(MAKE) vty-test + osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v + osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v else ext-tests: echo "Not running python-based external tests (determined at configure-time)" -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idd57757f251dd1c4d1c74d275b4c5d8beff304e5 Gerrit-Change-Number: 32135 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: tests: make VTY tests depend on the respective binaries
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/32134 ) Change subject: tests: make VTY tests depend on the respective binaries ...................................................................... tests: make VTY tests depend on the respective binaries Change-Id: I784fe3b5737b804f7b55da01d8beb619c57bafd6 --- M tests/Makefile.am 1 file changed, 16 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/34/32134/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index cd0fed9..6876df3 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -717,7 +717,7 @@ # make vty-test U=-u if ENABLE_GB -vty-test-ns2: +vty-test-ns2: $(top_builddir)/utils/osmo-ns-dummy $(MAKE) -C $(top_builddir)/utils osmo-ns-dummy osmo_verify_transcript_vty.py -v \ -p 42042 \ @@ -730,19 +730,21 @@ echo "Not running vty-test-ns2 because osmo-ns-dummy is not built (--disable-gb)" endif -vty-test-logging: +vty-test-logging: $(top_builddir)/tests/logging/logging_vty_test osmo_verify_transcript_vty.py -v \ -p 42042 \ -r "$(top_builddir)/tests/logging/logging_vty_test" \ $(U) $(srcdir)/logging/*.vty -vty-test-vty: +vty-test-vty: $(top_builddir)/tests/vty/vty_transcript_test osmo_verify_transcript_vty.py -v \ -p 42042 \ -r "$(top_builddir)/tests/vty/vty_transcript_test" \ $(U) $(srcdir)/vty/*.vty -vty-test-tdef: +vty-test-tdef: $(top_builddir)/tests/tdef/tdef_vty_config_root_test \ + $(top_builddir)/tests/tdef/tdef_vty_config_subnode_test \ + $(top_builddir)/tests/tdef/tdef_vty_dynamic_test osmo_verify_transcript_vty.py -v \ -p 42042 \ -r "$(top_builddir)/tests/tdef/tdef_vty_config_root_test" \ @@ -756,7 +758,7 @@ -r "$(top_builddir)/tests/tdef/tdef_vty_dynamic_test" \ $(U) $(srcdir)/tdef/tdef_vty_dynamic_test.vty -vty-test-stats: +vty-test-stats: $(top_builddir)/tests/stats/stats_vty_test osmo_verify_transcript_vty.py -v \ -p 42042 \ -r "$(top_builddir)/tests/stats/stats_vty_test" \ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32134 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I784fe3b5737b804f7b55da01d8beb619c57bafd6 Gerrit-Change-Number: 32134 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-smlc[master]: tests: $(BUILT_SOURCES) is not defined, depend on osmo-smlc
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/32133 ) Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-smlc ...................................................................... tests: $(BUILT_SOURCES) is not defined, depend on osmo-smlc Change-Id: I75a038b2730c7e0d4637db6dfb780839a49abc2e --- M tests/Makefile.am 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/33/32133/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 9487d3a..d046d49 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -37,11 +37,11 @@ $(NULL) if ENABLE_EXT_TESTS -python-tests: $(BUILT_SOURCES) +python-tests: $(MAKE) vty-test $(MAKE) ctrl-test else -python-tests: $(BUILT_SOURCES) +python-tests: echo "Not running python-based tests (determined at configure-time)" endif @@ -51,7 +51,7 @@ # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: # make vty-test U=-u -vty-test: +vty-test: $(top_builddir)/src/osmo-smlc/osmo-smlc osmo_verify_transcript_vty.py -v \ -n OsmoSMLC -p 4271 \ -r "$(top_builddir)/src/osmo-smlc/osmo-smlc -c $(top_srcdir)/tests/osmo-smlc.cfg" \ @@ -60,7 +60,7 @@ # To update the CTRL script from current application behavior, # pass -u to ctrl_script_runner.py by doing: # make ctrl-test U=-u -ctrl-test: +ctrl-test: $(top_builddir)/src/osmo-smlc/osmo-smlc -rm -f $(CTRL_TEST_DB) osmo_verify_transcript_ctrl.py -v \ -p 4272 \ -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/32133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I75a038b2730c7e0d4637db6dfb780839a49abc2e Gerrit-Change-Number: 32133 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: osmoappdesc.py: add more config files for testing
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32132 ) Change subject: osmoappdesc.py: add more config files for testing ...................................................................... osmoappdesc.py: add more config files for testing Change-Id: I9199f3e39c677dfd6e3936b9cf4897a070156b03 --- M osmoappdesc.py 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/32/32132/1 diff --git a/osmoappdesc.py b/osmoappdesc.py index 08c3252..4565a22 100644 --- a/osmoappdesc.py +++ b/osmoappdesc.py @@ -15,7 +15,10 @@ # along with this program. If not, see <http://www.gnu.org/licenses/> app_configs = { + # TODO: doc/examples/osmo-bsc/{ericsson,nokia,siemens} "osmo-bsc": ["doc/examples/osmo-bsc/osmo-bsc.cfg", + "doc/examples/osmo-bsc/osmo-bsc-minimal.cfg", + "doc/examples/osmo-bsc/osmo-bsc-4trx.cfg", "doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg"] } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32132 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9199f3e39c677dfd6e3936b9cf4897a070156b03 Gerrit-Change-Number: 32132 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-sip-connector[master]: tests: $(BUILT_SOURCES) is not defined, depend on osmo-sip-connector
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/32131 ) Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-sip-connector ...................................................................... tests: $(BUILT_SOURCES) is not defined, depend on osmo-sip-connector Change-Id: I3aeaace814a209dade5323f30a5a91e4a9d73595 --- M tests/Makefile.am 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/31/32131/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index a8e6738..c438469 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,9 +1,9 @@ if ENABLE_EXT_TESTS -python-tests: $(BUILT_SOURCES) +python-tests: $(top_builddir)/src/osmo-sip-connector osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v else -python-tests: $(BUILT_SOURCES) +python-tests: echo "Not running python-based tests (determined at configure-time)" endif -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/32131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I3aeaace814a209dade5323f30a5a91e4a9d73595 Gerrit-Change-Number: 32131 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: tests: $(BUILT_SOURCES) is not defined, depend on osmo-pcu
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/32129 ) Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-pcu ...................................................................... tests: $(BUILT_SOURCES) is not defined, depend on osmo-pcu Change-Id: I6620a524b393a0db6201930a1e2795a439785824 --- M tests/Makefile.am 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/29/32129/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6620a524b393a0db6201930a1e2795a439785824 Gerrit-Change-Number: 32129 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0