Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/32149
to look at the new patch set (#2).
Change subject: tests: demonstrate the problems of 'si2quater neighbor-list'
......................................................................
tests: demonstrate the problems of 'si2quater neighbor-list'
* osmo-bsc currently does not support adding multile EARFCNs
with different thresh/prio/qrxlv parameter values;
* adding an EARFCN which already exists creates a duplicate;
* adding an UARFCN which already exists fails;
* adding UARFCN=0 fails.
Change-Id: Iece6b9058f4eb06f8f2c19311de4f2eea01cfe82
Related: SYS#6401
---
M tests/si2quater_neighbor_list.vty
1 file changed, 55 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/49/32149/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32149
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iece6b9058f4eb06f8f2c19311de4f2eea01cfe82
Gerrit-Change-Number: 32149
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/32128
to look at the new patch set (#3).
Change subject: rtp continuous-streaming: fix BFI in the quality-suppressed case
......................................................................
rtp continuous-streaming: fix BFI in the quality-suppressed case
The check for (tch_ind->lqual_cb >= bts->min_qual_norm) in
l1sap_tch_ind() has the intent of suppressing valid-seeming
speech frame output from lower layers when the link quality is
too low; this check is particularly important for FR1 codec
where the intrinsic validity check is only a 3-bit CRC which has
1/8 probability of indicating "correct" when decoding radio noise
during DTXu silence.
However, this check is effectively defeated in the current
implementation of rtp continuous-streaming: the RTP packet being
output is the presumed-bogus speech frame from lower layers,
rather than the intended zero-length payload. Fix this bug.
Related: OS#5975
Change-Id: Icee0f57be289a0592a0197469432a012d15f224c
---
M src/common/l1sap.c
1 file changed, 25 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/28/32128/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32128
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icee0f57be289a0592a0197469432a012d15f224c
Gerrit-Change-Number: 32128
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/32110
to look at the new patch set (#3).
Change subject: common+trx: add rtp ecu-downstream vty option
......................................................................
common+trx: add rtp ecu-downstream vty option
Current osmo-bts-trx includes a provision for invoking ECUs from
libosmocodec in the UL path from the channel decoder to the RTP
output; no other models currently do likewise, but there is no
particular reason why this ECU invokation couldn't be moved into
model-independent code.
However, there are some network configurations in which this in-BTS
ECU invokation is undesirable, and the desire is to disable or
suppress it no matter which BTS model is used, rather than extend
the feature to BTS models which currently don't support it.
Usually the reason for wishing to suppress the ECU currently provided
by osmo-bts-trx is that another network element somewhere downstream
in RTP implements either a better ECU than what libosmocore provides
or a more complete Rx DTX handler of which the ECU is just one part.
The new rtp ecu-downstream vty option disables libosmocodec ECU
invokation in OsmoBTS. The intended usage model is that this option
will be used together with rtp continuous-streaming, but in the
strict sense the two options are orthogonal.
Related: OS#5975
Change-Id: I0acca9c6d7da966a623287563e0789db9e0fae8e
---
M include/osmo-bts/bts.h
M src/common/vty.c
M src/osmo-bts-trx/l1_if.c
M tests/osmo-bts.vty
4 files changed, 70 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/10/32110/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32110
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0acca9c6d7da966a623287563e0789db9e0fae8e
Gerrit-Change-Number: 32110
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/32150 )
Change subject: bts_earfcn_add(): do not add duplicate EARFCNs
......................................................................
bts_earfcn_add(): do not add duplicate EARFCNs
We don't want to have duplicate EARFCNs in the config file.
The desired behavior is modifying existing EARFCNs.
Change-Id: Ia2fd8bd86d9f093967c1b0b0135151d2d5386dc1
Related: SYS#6401
---
M src/osmo-bsc/system_information.c
M tests/si2quater_neighbor_list.vty
2 files changed, 21 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/32150/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32150
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia2fd8bd86d9f093967c1b0b0135151d2d5386dc1
Gerrit-Change-Number: 32150
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset
falconia has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32099 )
Change subject: rtp continuous-streaming: add themyscira-bfi option
......................................................................
Abandoned
The whole reason for inventing this non-standard RTP BFI packet format (as opposed to simply sending a zero-length payload, as implemented in the already-merged patch for rtp continuous-streaming) is to transport the TAF bit (in addition to the BFI condition) to the downstream entity (somewhere in the CN) that implements Rx DTX handlers for FR & EFR per GSM 06.31 and 06.81, respectively. However, I now realize that there is a much better way to implement this idea, and I will be preparing a new patch implementing my new idea a little later - after the other (less controversial) patches get sorted out.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32099
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib935efb1f7c9c8d919a4a0ea2bef244a47e5fb24
Gerrit-Change-Number: 32099
Gerrit-PatchSet: 4
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: abandon