March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: sysmo: emit empty RTP ticks during FACCH stealing on TCH/F
by falconia 29 Mar '23

29 Mar '23

Attention is currently required from: laforge. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32100 ) Change subject: sysmo: emit empty RTP ticks during FACCH stealing on TCH/F ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/32100/comment/37f07cb4_73cf881d PS2, Line 16: The case of TCH/H is still unhandled, and it may or may not be : possible to handle correctly, particularly for rtp always-output mode. : The fundamental difficulty is that in order to produce truly : undisrupted RTP timing, two BFI packets will need to be sent for : one FACCH, spaced 20 ms apart - but if the PHY only sends one : GsmL1_Sapi_FacchH message surrounded by a 40 ms time gap, then : we may be out of luck. > I am now preparing the next iteration of the full patch series, and the next version of the present […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I39d15faade28fb7d670493a99a0e0bdb654e2a4a Gerrit-Change-Number: 32100 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 29 Mar 2023 20:07:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnodeb[master]: build: remove $(COVERAGE_LDFLAGS) from osmo_hnodeb_LDADD
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/32143 ) Change subject: build: remove $(COVERAGE_LDFLAGS) from osmo_hnodeb_LDADD ...................................................................... build: remove $(COVERAGE_LDFLAGS) from osmo_hnodeb_LDADD Change-Id: Id088775f444640df863c346b225c1bae61725249 --- M src/osmo-hnodeb/Makefile.am 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/43/32143/1 diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 27987a1..0d2cf02 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -54,7 +54,6 @@ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMONETIF_LIBS) \ - $(COVERAGE_LDFLAGS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ $(LIBOSMOSIGTRAN_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/32143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id088775f444640df863c346b225c1bae61725249 Gerrit-Change-Number: 32143 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnodeb[master]: tests: make 'vty-test' target depend on the respective binary
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/32144 ) Change subject: tests: make 'vty-test' target depend on the respective binary ...................................................................... tests: make 'vty-test' target depend on the respective binary Change-Id: I53ff9a1659a0e25a6c3a5bc987dbae82d0312259 --- M tests/Makefile.am 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/44/32144/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index ed101ae..37aeda6 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -52,7 +52,7 @@ # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: # make vty-test U=-u -vty-test: +vty-test: $(top_builddir)/src/osmo-hnodeb/osmo-hnodeb osmo_verify_transcript_vty.py -v \ -n OsmoHNodeB -p 4273 \ -r "$(top_builddir)/src/osmo-hnodeb/osmo-hnodeb -c $(top_srcdir)/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/32144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I53ff9a1659a0e25a6c3a5bc987dbae82d0312259 Gerrit-Change-Number: 32144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnodeb[master]: tests: do not depend on undefined $(BUILT_SOURCES)
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/32145 ) Change subject: tests: do not depend on undefined $(BUILT_SOURCES) ...................................................................... tests: do not depend on undefined $(BUILT_SOURCES) Change-Id: I43c78aac0d23274d2a9bb01021cde0371c231be2 --- M tests/Makefile.am 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/45/32145/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 37aeda6..d2be48e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -34,7 +34,7 @@ $(NULL) if ENABLE_EXT_TESTS -python-tests: $(BUILT_SOURCES) +python-tests: echo "" # TODO: Enable once we have a VTY/CTRL interface: # $(MAKE) vty-test @@ -42,7 +42,7 @@ # osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v # $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v else -python-tests: $(BUILT_SOURCES) +python-tests: echo "Not running python-based tests (determined at configure-time)" endif -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/32145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I43c78aac0d23274d2a9bb01021cde0371c231be2 Gerrit-Change-Number: 32145 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnodeb[master]: tests: enable commented-out 'python-tests' target
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/32146 ) Change subject: tests: enable commented-out 'python-tests' target ...................................................................... tests: enable commented-out 'python-tests' target Change-Id: I76e24184aecafa8460d1da9419a424d9990730c5 --- M tests/Makefile.am 1 file changed, 14 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/46/32146/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index d2be48e..e7bb3f4 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -34,13 +34,11 @@ $(NULL) if ENABLE_EXT_TESTS -python-tests: - echo "" -# TODO: Enable once we have a VTY/CTRL interface: -# $(MAKE) vty-test -# osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v -# osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v -# $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v +python-tests: $(top_builddir)/src/osmo-hnodeb/osmo-hnodeb + $(MAKE) vty-test + osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v + osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v + $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v else python-tests: echo "Not running python-based tests (determined at configure-time)" -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/32146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I76e24184aecafa8460d1da9419a424d9990730c5 Gerrit-Change-Number: 32146 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bts[master]: TCH-IND interface: move link quality check into model code
by falconia 29 Mar '23

29 Mar '23

falconia has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32097 ) Change subject: TCH-IND interface: move link quality check into model code ...................................................................... Abandoned A different implementation of OS#5975 feature, one which does not need the present change as a prerequisite, has already been merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id95e48a578b7a8ce576862655abbe553c5b9a7bf Gerrit-Change-Number: 32097 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

1 0

[S] Change in osmo-hnbgw[master]: tests: do not depend on undefined $(BUILT_SOURCES)
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32141 ) Change subject: tests: do not depend on undefined $(BUILT_SOURCES) ...................................................................... tests: do not depend on undefined $(BUILT_SOURCES) Change-Id: I7536be8aa3f0ab39f183e00cf4382636038db4b7 --- M tests/Makefile.am 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/41/32141/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index b9f0279..806bfb1 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -35,7 +35,7 @@ $(NULL) if ENABLE_EXT_TESTS -python-tests: $(BUILT_SOURCES) +python-tests: echo "" # TODO: Enable once we have a VTY/CTRL interface: # $(MAKE) vty-test @@ -43,7 +43,7 @@ # osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v # $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v else -python-tests: $(BUILT_SOURCES) +python-tests: echo "Not running python-based tests (determined at configure-time)" endif -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7536be8aa3f0ab39f183e00cf4382636038db4b7 Gerrit-Change-Number: 32141 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnbgw[master]: tests: enable commented-out 'python-tests' target
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32142 ) Change subject: tests: enable commented-out 'python-tests' target ...................................................................... tests: enable commented-out 'python-tests' target Change-Id: I6d6a18f8aa6b0bd285afbcbcf0e65b5c8692d959 --- M tests/Makefile.am 1 file changed, 14 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/42/32142/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 806bfb1..e730416 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -35,13 +35,11 @@ $(NULL) if ENABLE_EXT_TESTS -python-tests: - echo "" -# TODO: Enable once we have a VTY/CTRL interface: -# $(MAKE) vty-test -# osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v -# osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v -# $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v +python-tests: $(top_builddir)/src/osmo-hnbgw/osmo-hnbgw + $(MAKE) vty-test + osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v + osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v + $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v else python-tests: echo "Not running python-based tests (determined at configure-time)" -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I6d6a18f8aa6b0bd285afbcbcf0e65b5c8692d959 Gerrit-Change-Number: 32142 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnbgw[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32139 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... tests: use -no-install libtool flag to avoid ./lt-* scripts This option should be used for any executables which are used only for testing, or for generating other files and are consequently never installed. By specifying this option, we are telling Libtool that the executable it links will only ever be executed from where it is built in the build tree. Libtool is usually able to considerably speed up the link process for such executables. Change-Id: Id5f88c331cf1dfd3f38120b4ef59ced9a563d4f0 --- M tests/ranap_rab_ass/Makefile.am 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/39/32139/1 diff --git a/tests/ranap_rab_ass/Makefile.am b/tests/ranap_rab_ass/Makefile.am index 1278ae8..918682c 100644 --- a/tests/ranap_rab_ass/Makefile.am +++ b/tests/ranap_rab_ass/Makefile.am @@ -15,6 +15,8 @@ $(COVERAGE_CFLAGS) \ $(NULL) +AM_LDFLAGS = -no-install + EXTRA_DIST = \ ranap_rab_ass_test.ok \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id5f88c331cf1dfd3f38120b4ef59ced9a563d4f0 Gerrit-Change-Number: 32139 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnbgw[master]: tests: use check_PROGRAMS for tests, not noinst_PROGRAMS
by fixeria 29 Mar '23

29 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32138 ) Change subject: tests: use check_PROGRAMS for tests, not noinst_PROGRAMS ...................................................................... tests: use check_PROGRAMS for tests, not noinst_PROGRAMS Change-Id: I616ed6920af98502424e4eab6cffde5d39d9698e --- M tests/ranap_rab_ass/Makefile.am 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/38/32138/1 diff --git a/tests/ranap_rab_ass/Makefile.am b/tests/ranap_rab_ass/Makefile.am index cdda8e3..1278ae8 100644 --- a/tests/ranap_rab_ass/Makefile.am +++ b/tests/ranap_rab_ass/Makefile.am @@ -19,7 +19,7 @@ ranap_rab_ass_test.ok \ $(NULL) -noinst_PROGRAMS = \ +check_PROGRAMS = \ ranap_rab_ass_test \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I616ed6920af98502424e4eab6cffde5d39d9698e Gerrit-Change-Number: 32138 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0