Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 )
Change subject: libosmo-pfcp.pc: move libosmogsm to Requires
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
oh, i see. so your unique_ids_test is a binary you build locally in this respository here. This binary is likely (of course?) not using pkg-config to determine the linker flags + libraries to link against.
pkg-config is what's used by other packages to obtain linker flags, compiler flags etc. for *installed* libraries
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I319173c1fab068dfe1361ae6cd02f729461d4cf8
Gerrit-Change-Number: 31760
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 09:41:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 )
Change subject: libosmo-pfcp.pc: move libosmogsm to Requires
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I would say this deserves a proper analysis rather than doing a work-around clearly against the pkg-config documentation and calling that a fix.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I319173c1fab068dfe1361ae6cd02f729461d4cf8
Gerrit-Change-Number: 31760
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 09:39:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment