March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: rlcmac: rlcmac_dec.c: Add missing headers
by laforge 09 Mar '23

09 Mar '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31752 ) Change subject: rlcmac: rlcmac_dec.c: Add missing headers ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31752 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie7fc1a8b101d8ee978a6a770ffe0190fb0de605a Gerrit-Change-Number: 31752 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:42:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in libosmo-gprs[master]: rlcmac: ul_tbf: Implement support for TBF Starting Time
by laforge 09 Mar '23

09 Mar '23

Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31751 ) Change subject: rlcmac: ul_tbf: Implement support for TBF Starting Time ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31751 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Id81f16743f2c464e01caf27ba2eb8c0fc715fe8a Gerrit-Change-Number: 31751 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:42:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-gprs[master]: rlcmac: Lower logging rx prim from lower layers
by laforge 09 Mar '23

09 Mar '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31733 ) Change subject: rlcmac: Lower logging rx prim from lower layers ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I0b13fa374003a7c48bc259a8c45227b86beca454 Gerrit-Change-Number: 31733 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:41:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: rlcmac: Ignore DATA.ind with len=0
by laforge 09 Mar '23

09 Mar '23

Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31732 ) Change subject: rlcmac: Ignore DATA.ind with len=0 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I342c7999261832a5d981e5831e428d2cbd82729e Gerrit-Change-Number: 31732 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:41:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: {rlcmac,llc,sndcp}: AM_LDFLAGS shall not contain *_LIBS
by fixeria 09 Mar '23

09 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31772 ) Change subject: {rlcmac,llc,sndcp}: AM_LDFLAGS shall not contain *_LIBS ...................................................................... {rlcmac,llc,sndcp}: AM_LDFLAGS shall not contain *_LIBS The LDFLAGS is for stuff like: '-Wl,--wrap=foo', '-version-info', '-no-undefined', '-no-install', etc. but not for libraries. Change-Id: Ib211c37419a8c6a0bdfc202f6f91b255cc8420e2 --- M src/llc/Makefile.am M src/rlcmac/Makefile.am M src/sndcp/Makefile.am 3 files changed, 12 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/72/31772/1 diff --git a/src/llc/Makefile.am b/src/llc/Makefile.am index 8d64231..1549c4c 100644 --- a/src/llc/Makefile.am +++ b/src/llc/Makefile.am @@ -14,11 +14,6 @@ $(LIBOSMOGSM_CFLAGS) \ $(NULL) -AM_LDFLAGS = \ - $(LIBOSMOCORE_LIBS) \ - $(LIBOSMOGSM_LIBS) \ - $(NULL) - lib_LTLIBRARIES = \ libosmo-gprs-llc.la \ $(NULL) diff --git a/src/rlcmac/Makefile.am b/src/rlcmac/Makefile.am index 9133df0..fdd6850 100644 --- a/src/rlcmac/Makefile.am +++ b/src/rlcmac/Makefile.am @@ -14,11 +14,6 @@ $(LIBOSMOCORE_CFLAGS) \ $(NULL) -AM_LDFLAGS = \ - $(LIBOSMOGSM_LIBS) \ - $(LIBOSMOCORE_LIBS) \ - $(NULL) - lib_LTLIBRARIES = \ libosmo-gprs-rlcmac.la \ $(NULL) diff --git a/src/sndcp/Makefile.am b/src/sndcp/Makefile.am index 26ca24f..ca72ecb 100644 --- a/src/sndcp/Makefile.am +++ b/src/sndcp/Makefile.am @@ -14,11 +14,6 @@ $(LIBOSMOGSM_CFLAGS) \ $(NULL) -AM_LDFLAGS = \ - $(LIBOSMOCORE_LIBS) \ - $(LIBOSMOGSM_LIBS) \ - $(NULL) - lib_LTLIBRARIES = \ libosmo-gprs-sndcp.la \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31772 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ib211c37419a8c6a0bdfc202f6f91b255cc8420e2 Gerrit-Change-Number: 31772 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS
by fixeria 09 Mar '23

09 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31773 ) Change subject: tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS ...................................................................... tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS The '-I' is a preprocessor flag, so it should be in AM_CPPFLAGS. Change-Id: Ic3e3dc75789850d2884d3e757f05ff01e136a5f4 --- M tests/llc/Makefile.am M tests/rlcmac/Makefile.am M tests/sndcp/Makefile.am 3 files changed, 23 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/73/31773/1 diff --git a/tests/llc/Makefile.am b/tests/llc/Makefile.am index ee57c5f..ca0ed1d 100644 --- a/tests/llc/Makefile.am +++ b/tests/llc/Makefile.am @@ -1,8 +1,11 @@ +AM_CPPFLAGS = \ + -I$(top_srcdir)/include/ \ + $(NULL) + AM_CFLAGS = \ -Wall \ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ - -I$(top_srcdir)/include/ \ $(NULL) AM_LDFLAGS = \ diff --git a/tests/rlcmac/Makefile.am b/tests/rlcmac/Makefile.am index 8d19656..9d1f5b0 100644 --- a/tests/rlcmac/Makefile.am +++ b/tests/rlcmac/Makefile.am @@ -1,8 +1,11 @@ +AM_CPPFLAGS = \ + -I$(top_srcdir)/include/ \ + $(NULL) + AM_CFLAGS = \ -Wall \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOCORE_CFLAGS) \ - -I$(top_srcdir)/include/ \ $(NULL) AM_LDFLAGS = \ diff --git a/tests/sndcp/Makefile.am b/tests/sndcp/Makefile.am index aff2abf..603388e 100644 --- a/tests/sndcp/Makefile.am +++ b/tests/sndcp/Makefile.am @@ -1,8 +1,11 @@ +AM_CPPFLAGS = \ + -I$(top_srcdir)/include/ \ + $(NULL) + AM_CFLAGS = \ -Wall \ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ - -I$(top_srcdir)/include/ \ $(NULL) AM_LDFLAGS = \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic3e3dc75789850d2884d3e757f05ff01e136a5f4 Gerrit-Change-Number: 31773 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: tests/llc: local libs must be first in *_LDADD
by fixeria 09 Mar '23

09 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31774 ) Change subject: tests/llc: local libs must be first in *_LDADD ...................................................................... tests/llc: local libs must be first in *_LDADD Otherwise the linker may pick system-installed libs instead. Change-Id: If5299340ad72407d01e728febf356a07a1d99681 --- M tests/llc/Makefile.am 1 file changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/74/31774/1 diff --git a/tests/llc/Makefile.am b/tests/llc/Makefile.am index ca0ed1d..341bf00 100644 --- a/tests/llc/Makefile.am +++ b/tests/llc/Makefile.am @@ -32,30 +32,30 @@ llc_test_SOURCES = llc_test.c llc_test_LDADD = \ + $(top_builddir)/src/llc/libosmo-gprs-llc.la \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ - $(top_builddir)/src/llc/libosmo-gprs-llc.la \ $(NULL) llc_prim_test_SOURCES = llc_prim_test.c llc_prim_test_LDADD = \ + $(top_builddir)/src/llc/libosmo-gprs-llc.la \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ - $(top_builddir)/src/llc/libosmo-gprs-llc.la \ $(NULL) pdu_codec_test_SOURCES = pdu_codec_test.c # libosmo-gprs-llc.a is used below to access non-exported private symbols used in the test: pdu_codec_test_LDADD = \ + $(top_builddir)/src/llc/.libs/libosmo-gprs-llc.a \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ - $(top_builddir)/src/llc/.libs/libosmo-gprs-llc.a \ $(NULL) xid_codec_test_SOURCES = xid_codec_test.c # libosmo-gprs-llc.a is used below to access non-exported private symbols used in the test: xid_codec_test_LDADD = \ + $(top_builddir)/src/llc/.libs/libosmo-gprs-llc.a \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ - $(top_builddir)/src/llc/.libs/libosmo-gprs-llc.a \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If5299340ad72407d01e728febf356a07a1d99681 Gerrit-Change-Number: 31774 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: vty: codec-list: fix error message
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31759 ) Change subject: vty: codec-list: fix error message ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I89460229f894bfa67c6939dc3825f1865378d918 Gerrit-Change-Number: 31759 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:41:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-pfcp[master]: libosmo-pfcp.pc: move libosmogsm to Requires
by laforge 09 Mar '23

09 Mar '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 ) Change subject: libosmo-pfcp.pc: move libosmogsm to Requires ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: oh, i see. so your unique_ids_test is a binary you build locally in this respository here. This binary is likely (of course?) not using pkg-config to determine the linker flags + libraries to link against. pkg-config is what's used by other packages to obtain linker flags, compiler flags etc. for *installed* libraries -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I319173c1fab068dfe1361ae6cd02f729461d4cf8 Gerrit-Change-Number: 31760 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:41:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-pfcp[master]: libosmo-pfcp.pc: move libosmogsm to Requires
by laforge 09 Mar '23

09 Mar '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 ) Change subject: libosmo-pfcp.pc: move libosmogsm to Requires ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I would say this deserves a proper analysis rather than doing a work-around clearly against the pkg-config documentation and calling that a fix. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I319173c1fab068dfe1361ae6cd02f729461d4cf8 Gerrit-Change-Number: 31760 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:39:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0