Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31756 )
Change subject: rlcmac: Log sched of PktCtrlAck requested by UL ASS poll
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/rlcmac/sched.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31756/comment/1fc5e61a_8bd11cb6
PS2, Line 207: (ts=%u,fn=%u,usf=%u)
this function alone seems to be using the same format string for printing at least four times now. Time for a proper LOGP macro?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31756
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I81ac177d7abdcd49d2b231ae059ec859b433dd03
Gerrit-Change-Number: 31756
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 09:44:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31755 )
Change subject: rlcmac: Move create_pkt_ctrl_ack() to tbf base class
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31755
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I767696b445842ebc32b35c320273b13f63076ca4
Gerrit-Change-Number: 31755
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 09:43:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31752 )
Change subject: rlcmac: rlcmac_dec.c: Add missing headers
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
nit-pick, since we've had this kind of wrong commit log message already several times: We are not adding a missing header [file] but we are addding a missing #include statement [to a header file]
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31752
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Ie7fc1a8b101d8ee978a6a770ffe0190fb0de605a
Gerrit-Change-Number: 31752
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 09:43:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment