March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libsmpp34[master]: binaries/Makefile.am: libraries shall not be in AM_LDFLAGS
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/31779 ) Change subject: binaries/Makefile.am: libraries shall not be in AM_LDFLAGS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/31779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I7258743969f5d3ac85dfb887ee1729cff8a910b6 Gerrit-Change-Number: 31779 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 10:03:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: tests/*/Makefile.am: -Wall is not a preprocessor flag
by fixeria 09 Mar '23

09 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31778 ) Change subject: tests/*/Makefile.am: -Wall is not a preprocessor flag ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Are you sure about that? […] So what the preprocessor is supposed to do with `-Wall`? We already have `-Wall` in CFLAGS, so it's actually given twice. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I1a143636dfc5d4ea85938472fd367ac88e3cc4ae Gerrit-Change-Number: 31778 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 10:00:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: rlcmac: Log sched of PktCtrlAck requested by UL ASS poll
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31756 ) Change subject: rlcmac: Log sched of PktCtrlAck requested by UL ASS poll ...................................................................... Patch Set 2: (1 comment) File src/rlcmac/sched.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/31756/comment/e4f4181a_5178ead6 PS2, Line 207: (ts=%u,fn=%u,usf=%u) > this function alone seems to be using the same format string for printing at least four times now. […] I expect this code to evolve a bit as I'm adding new features and we are fixing lower level scheduler stuff, so I wouldn't spend more time on that until later. Actually USF may not be really relevant there. Let's look at this later when the whole RTS.ind/DATA.ind is clear and set. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31756 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I81ac177d7abdcd49d2b231ae059ec859b433dd03 Gerrit-Change-Number: 31756 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:59:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: tests/Makefile.am: clean up AM_* variables
by fixeria 09 Mar '23

09 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/31776 ) Change subject: tests/Makefile.am: clean up AM_* variables ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > As I said I see nothing wrong with having -I in CPPFLAGS. Neither I see anything wrong: -I should be in CPPFLAGS and this is what this patch does :) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/31776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ice892f848e06b601e67b06a4e1e25c11fb7c4128 Gerrit-Change-Number: 31776 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:58:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: tests/*/Makefile.am: -Wall is not a preprocessor flag
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31778 ) Change subject: tests/*/Makefile.am: -Wall is not a preprocessor flag ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Are you sure about that? I don't really see a problem with having this in CPPFLAGS. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I1a143636dfc5d4ea85938472fd367ac88e3cc4ae Gerrit-Change-Number: 31778 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:58:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: {examples,stp}/Makefile.am: fix typo in $(COVERAGE_[C]FLAGS)
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31777 ) Change subject: {examples,stp}/Makefile.am: fix typo in $(COVERAGE_[C]FLAGS) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8dc7119765df97f44a6f2c5d6eecec847fcc46dc Gerrit-Change-Number: 31777 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:57:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: tests/Makefile.am: clean up AM_* variables
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/31776 ) Change subject: tests/Makefile.am: clean up AM_* variables ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: As I said I see nothing wrong with having -I in CPPFLAGS. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/31776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ice892f848e06b601e67b06a4e1e25c11fb7c4128 Gerrit-Change-Number: 31776 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:56:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: tests/Makefile.am: reorder libraries in LDADD
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/31775 ) Change subject: tests/Makefile.am: reorder libraries in LDADD ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File tests/Makefile.am: https://gerrit.osmocom.org/c/libosmo-netif/+/31775/comment/a4dd1d2e_8fa86ab4 PS1, Line 6: $(LIBOSMOCORE_LIBS) \ these two should be swapped so that GSM is before CORE, to have proper dependency chain. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/31775 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia639b1c5460ad9391d2c311b4978ca9374789f7a Gerrit-Change-Number: 31775 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:56:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: rlcmac: rlcmac_dec.c: Add missing headers
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31752 ) Change subject: rlcmac: rlcmac_dec.c: Add missing headers ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > nit-pick, since we've had this kind of wrong commit log message already several times: We are not a […] Yeah I agree it's wrong, but that doesn't mean I'm not being understood since I bet mot of us use that terminology to safe time :D -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31752 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie7fc1a8b101d8ee978a6a770ffe0190fb0de605a Gerrit-Change-Number: 31752 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:54:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: tests/llc: local libs must be first in *_LDADD
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31774 ) Change subject: tests/llc: local libs must be first in *_LDADD ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File tests/llc/Makefile.am: https://gerrit.osmocom.org/c/libosmo-gprs/+/31774/comment/d387eb60_0d462d74 PS1, Line 36: $(LIBOSMOCORE_LIBS) \ These should actually be swapped too actually, so that dependency chain is correct: first LIBOSMOGSM and afterwards LIBOSMOCORE. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If5299340ad72407d01e728febf356a07a1d99681 Gerrit-Change-Number: 31774 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:52:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0