March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hlr[master]: tests/*/Makefile.am: move -I to AM_CPPFLAGS
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31785 ) Change subject: tests/*/Makefile.am: move -I to AM_CPPFLAGS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Pau I saw your opinion, thanks, no need to post it again on each and every patch. I'm giving my opinion in order to find out what's the rationale behind this patch, whether it is really improving anyhow the situation. Also, I'm giving my opinion because I need to invest time to review all these patches. Given you are not interested to hear it or save my/your time, better find someone else who review them. That's the automake rule to generate the rules: %.o:%.c $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $< -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I654053e11b0cc824c198f68e4ff0a0fcb295efb0 Gerrit-Change-Number: 31785 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 11:05:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: pcu_sock: Submit all DATA.ind regardless of link quality
by osmith 09 Mar '23

09 Mar '23

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31731 ) Change subject: pcu_sock: Submit all DATA.ind regardless of link quality ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8f1856dd9061c1bfca8b15be30df7a51760231b0 Gerrit-Change-Number: 31731 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 11:03:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: src/Makefile.am: remove unneeded AM_LDFLAGS with LIBS
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31787 ) Change subject: src/Makefile.am: remove unneeded AM_LDFLAGS with LIBS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7895f037925e0e29f52e01636a0ba157cc324e5d Gerrit-Change-Number: 31787 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 10:58:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hlr[master]: tests/*/Makefile.am: move -I to AM_CPPFLAGS
by fixeria 09 Mar '23

09 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31785 ) Change subject: tests/*/Makefile.am: move -I to AM_CPPFLAGS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Pau I saw your opinion, thanks, no need to post it again on each and every patch. It's the matter of consistency (most project do have `-I` in `AM_CPPFLAGS`, with some exceptions I am fixing) and clarity: `AM_CPPFLAGS` is for preprocessor flags, `AM_CFLAGS` is for compiler flags. The fact that gcc combines both and allows to pass arguments in arbitrary order does not mean we should put stuff in wrong variables. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I654053e11b0cc824c198f68e4ff0a0fcb295efb0 Gerrit-Change-Number: 31785 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 10:58:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-hlr[master]: tests/*/Makefile.am: move -I to AM_CPPFLAGS
by fixeria 09 Mar '23

09 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31785 ) Change subject: tests/*/Makefile.am: move -I to AM_CPPFLAGS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This is the kind of patch I was saying makes no difference afaict. Pau I saw your opinion, thanks, no need to post it again on each and every patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I654053e11b0cc824c198f68e4ff0a0fcb295efb0 Gerrit-Change-Number: 31785 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 10:55:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: src/Makefile.am: remove unneeded AM_LDFLAGS with LIBS
by fixeria 09 Mar '23

09 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/31787 ) Change subject: src/Makefile.am: remove unneeded AM_LDFLAGS with LIBS ...................................................................... src/Makefile.am: remove unneeded AM_LDFLAGS with LIBS Change-Id: I7895f037925e0e29f52e01636a0ba157cc324e5d --- M src/Makefile.am 1 file changed, 9 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/87/31787/1 diff --git a/src/Makefile.am b/src/Makefile.am index e23ab10..746c80d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -13,12 +13,6 @@ $(COVERAGE_CFLAGS) \ $(NULL) -AM_LDFLAGS = \ - $(LIBOSMOCORE_LIBS) \ - $(LIBOSMOGSM_LIBS) \ - $(COVERAGE_LDFLAGS) \ - $(NULL) - # Libraries SUBDIRS = \ libvlr \ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7895f037925e0e29f52e01636a0ba157cc324e5d Gerrit-Change-Number: 31787 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-mgw[master]: */Makefile.am: libraries shall not be in AM_LDFLAGS
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31786 ) Change subject: */Makefile.am: libraries shall not be in AM_LDFLAGS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie9df855ee09b0761bd617fab58ca26450ac0c754 Gerrit-Change-Number: 31786 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 10:53:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hlr[master]: tests/auc/Makefile.am: put object files to LDADD
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31784 ) Change subject: tests/auc/Makefile.am: put object files to LDADD ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Iaefcfe7a8904841a29094fe40eb5850912544b4c Gerrit-Change-Number: 31784 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 10:53:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hlr[master]: tests/*/Makefile.am: move -I to AM_CPPFLAGS
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31785 ) Change subject: tests/*/Makefile.am: move -I to AM_CPPFLAGS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This is the kind of patch I was saying makes no difference afaict. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I654053e11b0cc824c198f68e4ff0a0fcb295efb0 Gerrit-Change-Number: 31785 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 10:52:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: */Makefile.am: libraries shall not be in AM_LDFLAGS
by fixeria 09 Mar '23

09 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31786 ) Change subject: */Makefile.am: libraries shall not be in AM_LDFLAGS ...................................................................... */Makefile.am: libraries shall not be in AM_LDFLAGS Change-Id: Ie9df855ee09b0761bd617fab58ca26450ac0c754 --- M src/Makefile.am M src/libosmo-mgcp-client/Makefile.am M src/libosmo-mgcp/Makefile.am 3 files changed, 15 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/86/31786/1 diff --git a/src/Makefile.am b/src/Makefile.am index f994f57..3effa9d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -13,12 +13,6 @@ $(COVERAGE_CFLAGS) \ $(NULL) -AM_LDFLAGS = \ - $(LIBOSMOCORE_LIBS) \ - $(LIBOSMOGSM_LIBS) \ - $(COVERAGE_LDFLAGS) \ - $(NULL) - # Libraries SUBDIRS = \ libosmo-mgcp-client \ diff --git a/src/libosmo-mgcp-client/Makefile.am b/src/libosmo-mgcp-client/Makefile.am index 36d6ca6..488c070 100644 --- a/src/libosmo-mgcp-client/Makefile.am +++ b/src/libosmo-mgcp-client/Makefile.am @@ -13,12 +13,6 @@ $(COVERAGE_CFLAGS) \ $(NULL) -AM_LDFLAGS = \ - $(LIBOSMOCORE_LIBS) \ - $(LIBOSMOVTY_LIBS) \ - $(COVERAGE_LDFLAGS) \ - $(NULL) - # This is not at all related to the release version, but a range of supported # API versions. Read TODO_RELEASE in the source tree's root! MGCP_CLIENT_LIBVERSION=11:0:0 @@ -36,7 +30,12 @@ $(NULL) libosmo_mgcp_client_la_LDFLAGS = \ - $(AM_LDFLAGS) \ -version-info $(MGCP_CLIENT_LIBVERSION) \ -no-undefined \ $(NULL) + +libosmo_mgcp_client_la_LIBADD = \ + $(LIBOSMOCORE_LIBS) \ + $(LIBOSMOVTY_LIBS) \ + $(COVERAGE_LDFLAGS) \ + $(NULL) diff --git a/src/libosmo-mgcp/Makefile.am b/src/libosmo-mgcp/Makefile.am index 309ae3f..8cffbe5 100644 --- a/src/libosmo-mgcp/Makefile.am +++ b/src/libosmo-mgcp/Makefile.am @@ -15,16 +15,6 @@ $(COVERAGE_CFLAGS) \ $(NULL) -AM_LDFLAGS = \ - $(LIBOSMOCORE_LIBS) \ - $(LIBOSMOGSM_LIBS) \ - $(LIBOSMOVTY_LIBS) \ - $(LIBOSMONETIF_LIBS) \ - $(LIBOSMOABIS_LIBS) \ - $(LIBOSMOTRAU_LIBS) \ - $(COVERAGE_LDFLAGS) \ - $(NULL) - noinst_LIBRARIES = \ libosmo-mgcp.a \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie9df855ee09b0761bd617fab58ca26450ac0c754 Gerrit-Change-Number: 31786 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0