Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31785 )
Change subject: tests/*/Makefile.am: move -I to AM_CPPFLAGS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Pau I saw your opinion, thanks, no need to post it again on each and every patch.
I'm giving my opinion in order to find out what's the rationale behind this patch, whether it is really improving anyhow the situation.
Also, I'm giving my opinion because I need to invest time to review all these patches. Given you are not interested to hear it or save my/your time, better find someone else who review them.
That's the automake rule to generate the rules:
%.o:%.c
$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31785
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I654053e11b0cc824c198f68e4ff0a0fcb295efb0
Gerrit-Change-Number: 31785
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 11:05:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31785 )
Change subject: tests/*/Makefile.am: move -I to AM_CPPFLAGS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Pau I saw your opinion, thanks, no need to post it again on each and every patch.
It's the matter of consistency (most project do have `-I` in `AM_CPPFLAGS`, with some exceptions I am fixing) and clarity: `AM_CPPFLAGS` is for preprocessor flags, `AM_CFLAGS` is for compiler flags. The fact that gcc combines both and allows to pass arguments in arbitrary order does not mean we should put stuff in wrong variables.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31785
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I654053e11b0cc824c198f68e4ff0a0fcb295efb0
Gerrit-Change-Number: 31785
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 10:58:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31785 )
Change subject: tests/*/Makefile.am: move -I to AM_CPPFLAGS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> This is the kind of patch I was saying makes no difference afaict.
Pau I saw your opinion, thanks, no need to post it again on each and every patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31785
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I654053e11b0cc824c198f68e4ff0a0fcb295efb0
Gerrit-Change-Number: 31785
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 10:55:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31786 )
Change subject: */Makefile.am: libraries shall not be in AM_LDFLAGS
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31786
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ie9df855ee09b0761bd617fab58ca26450ac0c754
Gerrit-Change-Number: 31786
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 10:53:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31784 )
Change subject: tests/auc/Makefile.am: put object files to LDADD
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31784
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Iaefcfe7a8904841a29094fe40eb5850912544b4c
Gerrit-Change-Number: 31784
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 10:53:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31785 )
Change subject: tests/*/Makefile.am: move -I to AM_CPPFLAGS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This is the kind of patch I was saying makes no difference afaict.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31785
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I654053e11b0cc824c198f68e4ff0a0fcb295efb0
Gerrit-Change-Number: 31785
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 10:52:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment