Attention is currently required from: dexter.
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31791
to look at the new patch set (#2).
Change subject: timeslot_fsm: Fixes I9ea0c53a5e68a51c781ef43bae71f947cdb95678
......................................................................
timeslot_fsm: Fixes I9ea0c53a5e68a51c781ef43bae71f947cdb95678
All non ericsson BTSs we support use a BTS co-located PCU, so we must
not depend on a PCU connection in those cases.
Related: OS#5943
Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad
---
M src/osmo-bsc/timeslot_fsm.c
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/91/31791/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31791
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad
Gerrit-Change-Number: 31791
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31792 )
Change subject: timeslot_fsm: fix PDCH activation
......................................................................
timeslot_fsm: fix PDCH activation
All non ericsson BTSs we support use a BTS co-located PCU, so we must
not depend on a PCU connection in those cases.
Related: OS#5943
Fixes Change: I9ea0c53a5e68a51c781ef43bae71f947cdb95678
Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad
Change-Id: I765fad841f8bf1166c5dd7a916fe1d577439533d
---
M src/osmo-bsc/timeslot_fsm.c
1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/31792/1
diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c
index 16d7360..aa5e0db 100644
--- a/src/osmo-bsc/timeslot_fsm.c
+++ b/src/osmo-bsc/timeslot_fsm.c
@@ -341,7 +341,7 @@
return;
}
- if (!pcu_connected(bts)) {
+ if (is_ericsson_bts(bts) && !pcu_connected(bts)) {
LOG_TS(ts, LOGL_DEBUG, "PCU not connected: not activating PDCH.\n");
return;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31792
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I765fad841f8bf1166c5dd7a916fe1d577439533d
Gerrit-Change-Number: 31792
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31791 )
Change subject: timeslot_fsm: fix PDCH activation
......................................................................
timeslot_fsm: fix PDCH activation
All non ericsson BTSs we support use a BTS co-located PCU, so we must
not depend on a PCU connection in those cases.
Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad
---
M src/osmo-bsc/timeslot_fsm.c
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/91/31791/1
diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c
index 16d7360..aa5e0db 100644
--- a/src/osmo-bsc/timeslot_fsm.c
+++ b/src/osmo-bsc/timeslot_fsm.c
@@ -341,7 +341,7 @@
return;
}
- if (!pcu_connected(bts)) {
+ if (is_ericsson_bts(bts) && !pcu_connected(bts)) {
LOG_TS(ts, LOGL_DEBUG, "PCU not connected: not activating PDCH.\n");
return;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31791
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad
Gerrit-Change-Number: 31791
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange