March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: timeslot_fsm: fix PDCH activation
by dexter 09 Mar '23

09 Mar '23

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31792 ) Change subject: timeslot_fsm: fix PDCH activation ...................................................................... Abandoned Duplicate -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I765fad841f8bf1166c5dd7a916fe1d577439533d Gerrit-Change-Number: 31792 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: abandon

1 0

[S] Change in osmo-bsc[master]: timeslot_fsm: Fixes I9ea0c53a5e68a51c781ef43bae71f947cdb95678
by osmith 09 Mar '23

09 Mar '23

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31791 ) Change subject: timeslot_fsm: Fixes I9ea0c53a5e68a51c781ef43bae71f947cdb95678 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad Gerrit-Change-Number: 31791 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 11:40:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: timeslot_fsm: Fixes I9ea0c53a5e68a51c781ef43bae71f947cdb95678
by dexter 09 Mar '23

09 Mar '23

Attention is currently required from: dexter. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31791 to look at the new patch set (#2). Change subject: timeslot_fsm: Fixes I9ea0c53a5e68a51c781ef43bae71f947cdb95678 ...................................................................... timeslot_fsm: Fixes I9ea0c53a5e68a51c781ef43bae71f947cdb95678 All non ericsson BTSs we support use a BTS co-located PCU, so we must not depend on a PCU connection in those cases. Related: OS#5943 Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad --- M src/osmo-bsc/timeslot_fsm.c 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/91/31791/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad Gerrit-Change-Number: 31791 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: timeslot_fsm: fix PDCH activation
by dexter 09 Mar '23

09 Mar '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31792 ) Change subject: timeslot_fsm: fix PDCH activation ...................................................................... timeslot_fsm: fix PDCH activation All non ericsson BTSs we support use a BTS co-located PCU, so we must not depend on a PCU connection in those cases. Related: OS#5943 Fixes Change: I9ea0c53a5e68a51c781ef43bae71f947cdb95678 Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad Change-Id: I765fad841f8bf1166c5dd7a916fe1d577439533d --- M src/osmo-bsc/timeslot_fsm.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/31792/1 diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c index 16d7360..aa5e0db 100644 --- a/src/osmo-bsc/timeslot_fsm.c +++ b/src/osmo-bsc/timeslot_fsm.c @@ -341,7 +341,7 @@ return; } - if (!pcu_connected(bts)) { + if (is_ericsson_bts(bts) && !pcu_connected(bts)) { LOG_TS(ts, LOGL_DEBUG, "PCU not connected: not activating PDCH.\n"); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I765fad841f8bf1166c5dd7a916fe1d577439533d Gerrit-Change-Number: 31792 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: timeslot_fsm: fix PDCH activation
by osmith 09 Mar '23

09 Mar '23

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31791 ) Change subject: timeslot_fsm: fix PDCH activation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad Gerrit-Change-Number: 31791 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 11:30:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: timeslot_fsm: fix PDCH activation
by dexter 09 Mar '23

09 Mar '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31791 ) Change subject: timeslot_fsm: fix PDCH activation ...................................................................... timeslot_fsm: fix PDCH activation All non ericsson BTSs we support use a BTS co-located PCU, so we must not depend on a PCU connection in those cases. Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad --- M src/osmo-bsc/timeslot_fsm.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/91/31791/1 diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c index 16d7360..aa5e0db 100644 --- a/src/osmo-bsc/timeslot_fsm.c +++ b/src/osmo-bsc/timeslot_fsm.c @@ -341,7 +341,7 @@ return; } - if (!pcu_connected(bts)) { + if (is_ericsson_bts(bts) && !pcu_connected(bts)) { LOG_TS(ts, LOGL_DEBUG, "PCU not connected: not activating PDCH.\n"); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad Gerrit-Change-Number: 31791 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-smlc[master]: Makefile.am: remove unneeded AM_LDFLAGS with LIBS
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/31790 ) Change subject: Makefile.am: remove unneeded AM_LDFLAGS with LIBS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/31790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ic6886d2e47c053fe39647bc9ec3be704c935bee5 Gerrit-Change-Number: 31790 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 11:10:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-smlc[master]: Makefile.am: remove unneeded AM_LDFLAGS with LIBS
by fixeria 09 Mar '23

09 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/31790 ) Change subject: Makefile.am: remove unneeded AM_LDFLAGS with LIBS ...................................................................... Makefile.am: remove unneeded AM_LDFLAGS with LIBS Change-Id: Ic6886d2e47c053fe39647bc9ec3be704c935bee5 --- M src/Makefile.am 1 file changed, 9 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/90/31790/1 diff --git a/src/Makefile.am b/src/Makefile.am index 26ff4d1..1cbccc6 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -14,12 +14,6 @@ $(COVERAGE_CFLAGS) \ $(NULL) -AM_LDFLAGS = \ - $(LIBOSMOCORE_LIBS) \ - $(LIBOSMOGSM_LIBS) \ - $(COVERAGE_LDFLAGS) \ - $(NULL) - SUBDIRS = \ osmo-smlc \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/31790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ic6886d2e47c053fe39647bc9ec3be704c935bee5 Gerrit-Change-Number: 31790 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-smlc[master]: Makefile.am: remove $(COVERAGE_LDFLAGS) from osmo_smlc_LDADD
by fixeria 09 Mar '23

09 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/31789 ) Change subject: Makefile.am: remove $(COVERAGE_LDFLAGS) from osmo_smlc_LDADD ...................................................................... Makefile.am: remove $(COVERAGE_LDFLAGS) from osmo_smlc_LDADD Change-Id: Ia7073d2baf4c758ebff167b6cf1b3ba9c1552821 --- M src/osmo-smlc/Makefile.am 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/89/31789/1 diff --git a/src/osmo-smlc/Makefile.am b/src/osmo-smlc/Makefile.am index 37fe042..585d1de 100644 --- a/src/osmo-smlc/Makefile.am +++ b/src/osmo-smlc/Makefile.am @@ -39,6 +39,5 @@ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(COVERAGE_LDFLAGS) \ $(LIBOSMOSIGTRAN_LIBS) \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/31789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ia7073d2baf4c758ebff167b6cf1b3ba9c1552821 Gerrit-Change-Number: 31789 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: {src,tests}/Makefile.am: libraries shall not be in AM_LDFLAGS
by fixeria 09 Mar '23

09 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31788 ) Change subject: {src,tests}/Makefile.am: libraries shall not be in AM_LDFLAGS ...................................................................... {src,tests}/Makefile.am: libraries shall not be in AM_LDFLAGS Change-Id: Ibd7eb55e2cfe7daed2f8a8d74c6a3ede6f29308f --- M src/Makefile.am M tests/Makefile.am 2 files changed, 32 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/88/31788/1 diff --git a/src/Makefile.am b/src/Makefile.am index e747d74..25d58c6 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -34,7 +34,6 @@ endif AM_CXXFLAGS = -Wall -AM_LDFLAGS = -lrt noinst_LTLIBRARIES = libgprs.la @@ -165,6 +164,7 @@ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOGSM_LIBS) \ + -lrt \ $(NULL) endif @@ -214,6 +214,7 @@ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOGSM_LIBS) \ + -lrt \ $(NULL) #MOSTLYCLEANFILES += testSource testDestination diff --git a/tests/Makefile.am b/tests/Makefile.am index 7c50969..df63dd1 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,5 +1,10 @@ AM_CPPFLAGS = $(STD_DEFINES_AND_INCLUDES) $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOGB_CFLAGS) $(LIBOSMOGSM_CFLAGS) -I$(top_srcdir)/src/ -I$(top_srcdir)/include/ -AM_LDFLAGS = -lrt -no-install +AM_LDFLAGS = -no-install + +LDADD = \ + $(LIBOSMOCORE_LIBS) \ + -lrt \ + $(NULL) check_PROGRAMS = \ rlcmac/RLCMACTest \ @@ -23,7 +28,7 @@ rlcmac_RLCMACTest_SOURCES = rlcmac/RLCMACTest.cpp rlcmac_RLCMACTest_LDADD = \ $(top_builddir)/src/libgprs.la \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) alloc_AllocTest_SOURCES = alloc/AllocTest.cpp @@ -32,7 +37,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) alloc_MslotTest_SOURCES = alloc/MslotTest.cpp @@ -41,7 +46,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) tbf_TbfTest_SOURCES = tbf/TbfTest.cpp @@ -50,7 +55,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) tbf_TbfTest_LDFLAGS = -Wl,--wrap=pcu_sock_send @@ -58,7 +63,7 @@ bitcomp_BitcompTest_LDADD = \ $(top_builddir)/src/libgprs.la \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) edge_EdgeTest_SOURCES = edge/EdgeTest.cpp @@ -67,7 +72,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) emu_pcu_emu_SOURCES = emu/pcu_emu.cpp emu/test_replay_gprs_attach.cpp \ @@ -78,7 +83,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) types_TypesTest_SOURCES = types/TypesTest.cpp @@ -87,7 +92,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) ms_MsTest_SOURCES = ms/MsTest.cpp @@ -96,7 +101,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) ms_MsTest_LDFLAGS = \ @@ -108,7 +113,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) llc_LlcTest_LDFLAGS = \ @@ -116,14 +121,14 @@ llist_LListTest_SOURCES = llist/LListTest.cpp llist_LListTest_LDADD = \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) codel_codel_test_SOURCES = codel/codel_test.c codel_codel_test_LDADD = \ $(top_builddir)/src/libgprs.la \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) fn_FnTest_SOURCES = fn/FnTest.cpp @@ -132,7 +137,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) app_info_AppInfoTest_SOURCES = app_info/AppInfoTest.cpp @@ -141,7 +146,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) ulc_PdchUlcTest_SOURCES = ulc/PdchUlcTest.cpp @@ -150,7 +155,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) # The `:;' works around a Bash 3.2 bug when the output is not writeable. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibd7eb55e2cfe7daed2f8a8d74c6a3ede6f29308f Gerrit-Change-Number: 31788 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0