March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31773 ) Change subject: tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think it's totally fine to have -I in CFLAGS. They main difference is that CPPFLAGS is included in both C++ and C files, while CFLAGS is only included in C files. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic3e3dc75789850d2884d3e757f05ff01e136a5f4 Gerrit-Change-Number: 31773 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:51:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: coding: clean up Makefile.am
by fixeria 09 Mar '23

09 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31780 ) Change subject: coding: clean up Makefile.am ...................................................................... coding: clean up Makefile.am * Remove talloc related stuff, it's not used directly * Remoave $(TALLOC_LIBS) from LDFLAGS - this is wrong * Add missing LIBOSMO{CORE,GSM,CODEC}_CFLAGS Change-Id: I18f0a65a47c37989f03928f99c4687bf8007d437 --- M src/coding/Makefile.am 1 file changed, 20 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/31780/1 diff --git a/src/coding/Makefile.am b/src/coding/Makefile.am index 905d684..7163093 100644 --- a/src/coding/Makefile.am +++ b/src/coding/Makefile.am @@ -8,11 +8,11 @@ -I"$(top_builddir)/include" \ -I"$(top_builddir)" \ $(NULL) -AM_CFLAGS = -Wall $(TALLOC_CFLAGS) - -if ENABLE_PSEUDOTALLOC -AM_CPPFLAGS += -I$(top_srcdir)/src/pseudotalloc -endif +AM_CFLAGS = -Wall \ + $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOGSM_CFLAGS) \ + $(LIBOSMOCODEC_CFLAGS) \ + $(NULL) lib_LTLIBRARIES = libosmocoding.la @@ -25,10 +25,9 @@ gsm0503_amr_dtx.c libosmocoding_la_LDFLAGS = \ $(LTLDFLAGS_OSMOCODING) \ - -version-info \ - $(LIBVERSION) \ + -version-info $(LIBVERSION) \ -no-undefined \ - $(TALLOC_LIBS) + $(NULL) libosmocoding_la_LIBADD = \ $(top_builddir)/src/core/libosmocore.la \ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I18f0a65a47c37989f03928f99c4687bf8007d437 Gerrit-Change-Number: 31780 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: {rlcmac,llc,sndcp}: AM_LDFLAGS shall not contain *_LIBS
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31772 ) Change subject: {rlcmac,llc,sndcp}: AM_LDFLAGS shall not contain *_LIBS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31772 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ib211c37419a8c6a0bdfc202f6f91b255cc8420e2 Gerrit-Change-Number: 31772 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:50:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-pfcp[master]: libosmo-pfcp.pc: move libosmogsm to Requires
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 ) Change subject: libosmo-pfcp.pc: move libosmogsm to Requires ...................................................................... Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I319173c1fab068dfe1361ae6cd02f729461d4cf8 Gerrit-Change-Number: 31760 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:49:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: ts_102_222: Implement support for RESIZE FILE for an EF
by laforge 09 Mar '23

09 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31715 ) Change subject: ts_102_222: Implement support for RESIZE FILE for an EF ...................................................................... ts_102_222: Implement support for RESIZE FILE for an EF This adds pySim-shell support for the RESIZE FILE command in order to change the size of linear fixed or transparent EF. Change-Id: I03fbb683e26231c75f345330ac5f914ac88bbe7a --- M docs/shell.rst M pySim/commands.py M pySim/ts_102_222.py 3 files changed, 44 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved; Verified Jenkins Builder: Verified diff --git a/docs/shell.rst b/docs/shell.rst index c1f37af..9ffbac3 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -650,6 +650,12 @@ :module: pySim.ts_102_222 :func: Ts102222Commands.createdf_parser +resize_ef +~~~~~~~~~ +.. argparse:: + :module: pySim.ts_102_222 + :func: Ts102222Commands.resize_ef_parser + ARA-M commands -------------- diff --git a/pySim/commands.py b/pySim/commands.py index fa0458a..d123e67 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -457,6 +457,10 @@ """Execute CREEATE FILE command as per TS 102 222 Section 6.3""" return self._tp.send_apdu_checksw(self.cla_byte + 'e00000%02x%s' % (len(payload)//2, payload)) + def resize_file(self, payload: Hexstr): + """Execute RESIZE FILE command as per TS 102 222 Section 6.10""" + return self._tp.send_apdu_checksw('80d40000%02x%s' % (len(payload)//2, payload)) + def delete_file(self, fid): """Execute DELETE FILE command as per TS 102 222 Section 6.4""" return self._tp.send_apdu_checksw(self.cla_byte + 'e4000002' + fid) diff --git a/pySim/ts_102_222.py b/pySim/ts_102_222.py index 4843c77..f8fdddb 100644 --- a/pySim/ts_102_222.py +++ b/pySim/ts_102_222.py @@ -206,3 +206,25 @@ (data, sw) = self._cmd.card._scc.create_file(b2h(fcp.to_tlv())) # the newly-created file is automatically selected but our runtime state knows nothing of it self._cmd.lchan.select_file(self._cmd.lchan.selected_file) + + resize_ef_parser = argparse.ArgumentParser() + resize_ef_parser.add_argument('NAME', type=str, help='Name or FID of file to be resized') + resize_ef_parser._action_groups.pop() + resize_ef_required = resize_ef_parser.add_argument_group('required arguments') + resize_ef_required.add_argument('--file-size', required=True, type=int, help='Size of file in octets') + + @cmd2.with_argparser(resize_ef_parser) + def do_resize_ef(self, opts): + """Resize an existing EF below the currently selected DF. Requires related privileges.""" + f = self._cmd.lchan.get_file_for_selectable(opts.NAME) + ies = [FileIdentifier(decoded=f.fid), + FileSize(decoded=opts.file_size)] + fcp = FcpTemplate(children=ies) + (data, sw) = self._cmd.card._scc.resize_file(b2h(fcp.to_tlv())) + # the resized file is automatically selected but our runtime state knows nothing of it + self._cmd.lchan.select_file(self._cmd.lchan.selected_file) + + def complete_resize_ef(self, text, line, begidx, endidx) -> List[str]: + """Command Line tab completion for RESIZE EF""" + index_dict = {1: self._cmd.lchan.selected_file.get_selectable_names()} + return self._cmd.index_based_complete(text, line, begidx, endidx, index_dict=index_dict) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I03fbb683e26231c75f345330ac5f914ac88bbe7a Gerrit-Change-Number: 31715 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: ts_102_222: Implement support for RESIZE FILE for an EF
by laforge 09 Mar '23

09 Mar '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31715 ) Change subject: ts_102_222: Implement support for RESIZE FILE for an EF ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I03fbb683e26231c75f345330ac5f914ac88bbe7a Gerrit-Change-Number: 31715 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:49:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: msc: detect RTP to CN failure in call tests
by laforge 09 Mar '23

09 Mar '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31711 ) Change subject: msc: detect RTP to CN failure in call tests ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ccf541360cc8440e664f0e29494b9ce7b6f8943 Gerrit-Change-Number: 31711 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:49:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libsmpp34[master]: binaries/Makefile.am: libraries shall not be in AM_LDFLAGS
by fixeria 09 Mar '23

09 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libsmpp34/+/31779 ) Change subject: binaries/Makefile.am: libraries shall not be in AM_LDFLAGS ...................................................................... binaries/Makefile.am: libraries shall not be in AM_LDFLAGS Change-Id: I7258743969f5d3ac85dfb887ee1729cff8a910b6 --- M binaries/Makefile.am 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/79/31779/1 diff --git a/binaries/Makefile.am b/binaries/Makefile.am index 9fd565e..71997b8 100644 --- a/binaries/Makefile.am +++ b/binaries/Makefile.am @@ -9,9 +9,8 @@ include $(top_srcdir)/test_apps/Makefile.am include $(top_srcdir)/src/Makefile.am -LDADD = libsmpp34.la +LDADD = libsmpp34.la -lrt -lpthread AM_CPPFLAGS = -D_REENTRANT -DBSD_COMP -D_POSIX_PTHREAD_SEMANTICS AM_CFLAGS = @CFLAGS@ -Wall -fPIC # -static INCLUDES = -I$(top_srcdir)/src -I$(top_srcdir) -AM_LDFLAGS = -lrt -lpthread OBJ_EXTRA_DIST = $(esme_EXTRA_DIST) -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/31779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I7258743969f5d3ac85dfb887ee1729cff8a910b6 Gerrit-Change-Number: 31779 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: osmo-hnbgw-with-pfcp.cfg: improve logging
by pespin 09 Mar '23

09 Mar '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31768 ) Change subject: osmo-hnbgw-with-pfcp.cfg: improve logging ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf4e8993f9d3b41f74145291940ca59947f9d171 Gerrit-Change-Number: 31768 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:48:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: TC_mt_t310: avoid sporadic failure from X2 timeout
by laforge 09 Mar '23

09 Mar '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31710 ) Change subject: msc: TC_mt_t310: avoid sporadic failure from X2 timeout ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic23cbca5775031dcb0ea1744454e20cda090701c Gerrit-Change-Number: 31710 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:47:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0