March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: utils/Makefile.am: do not overwrite AM_CFLAGS
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31845 ) Change subject: utils/Makefile.am: do not overwrite AM_CFLAGS ...................................................................... utils/Makefile.am: do not overwrite AM_CFLAGS * $(TALLOC_CFLAGS) is already present in AM_CFLAGS, * osmo-sim-test: do not redefine but append $(PCSC_CFLAGS). Change-Id: I7b9af3a1a9493a432af89198e291f4523388751e --- M utils/Makefile.am 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/utils/Makefile.am b/utils/Makefile.am index d81d0a6..c068ee2 100644 --- a/utils/Makefile.am +++ b/utils/Makefile.am @@ -18,13 +18,12 @@ osmo_config_merge_SOURCES = osmo-config-merge.c osmo_config_merge_LDADD = $(LDADD) $(TALLOC_LIBS) -osmo_config_merge_CFLAGS = $(TALLOC_CFLAGS) if ENABLE_PCSC noinst_PROGRAMS += osmo-sim-test osmo_sim_test_SOURCES = osmo-sim-test.c osmo_sim_test_LDADD = $(LDADD) $(top_builddir)/src/sim/libosmosim.la $(PCSC_LIBS) -osmo_sim_test_CFLAGS = $(PCSC_CFLAGS) +osmo_sim_test_CFLAGS = $(AM_CFLAGS) $(PCSC_CFLAGS) endif endif @@ -41,6 +40,5 @@ $(top_builddir)/src/vty/libosmovty.la \ $(top_builddir)/src/ctrl/libosmoctrl.la \ $(NULL) -osmo_ns_dummy_CFLAGS = $(TALLOC_CFLAGS) endif endif -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31845 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7b9af3a1a9493a432af89198e291f4523388751e Gerrit-Change-Number: 31845 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: coding: clean up Makefile.am
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31780 ) Change subject: coding: clean up Makefile.am ...................................................................... coding: clean up Makefile.am * Remove TALLOC_{CFLAGS,LIBS} - talloc is not used directly * Keep conditional ENABLE_PSEUDOTALLOC for embedded builds Change-Id: I18f0a65a47c37989f03928f99c4687bf8007d437 --- M src/coding/Makefile.am 1 file changed, 15 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/coding/Makefile.am b/src/coding/Makefile.am index 905d684..bb7bde2 100644 --- a/src/coding/Makefile.am +++ b/src/coding/Makefile.am @@ -8,7 +8,7 @@ -I"$(top_builddir)/include" \ -I"$(top_builddir)" \ $(NULL) -AM_CFLAGS = -Wall $(TALLOC_CFLAGS) +AM_CFLAGS = -Wall if ENABLE_PSEUDOTALLOC AM_CPPFLAGS += -I$(top_srcdir)/src/pseudotalloc @@ -25,10 +25,9 @@ gsm0503_amr_dtx.c libosmocoding_la_LDFLAGS = \ $(LTLDFLAGS_OSMOCODING) \ - -version-info \ - $(LIBVERSION) \ + -version-info $(LIBVERSION) \ -no-undefined \ - $(TALLOC_LIBS) + $(NULL) libosmocoding_la_LIBADD = \ $(top_builddir)/src/core/libosmocore.la \ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I18f0a65a47c37989f03928f99c4687bf8007d437 Gerrit-Change-Number: 31780 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: utils/osmo-stat-dummy/Makefile.am: drop empty variables
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31846 ) Change subject: utils/osmo-stat-dummy/Makefile.am: drop empty variables ...................................................................... utils/osmo-stat-dummy/Makefile.am: drop empty variables Change-Id: I1b9497900b0eebd77fd226f52a9050cdbd9e6cdc --- M utils/osmo-stat-dummy/Makefile.am 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/utils/osmo-stat-dummy/Makefile.am b/utils/osmo-stat-dummy/Makefile.am index f1faa3d..0232736 100644 --- a/utils/osmo-stat-dummy/Makefile.am +++ b/utils/osmo-stat-dummy/Makefile.am @@ -1,10 +1,10 @@ if ENABLE_UTILITIES noinst_PROGRAMS = osmo-stat-dummy osmo_stat_dummy_SOURCES = osmo-stat-dummy.c -osmo_stat_dummy_LDADD = $(LDADD) $(TALLOC_LIBS) \ +osmo_stat_dummy_LDADD = $(TALLOC_LIBS) \ $(top_builddir)/src/vty/libosmovty.la \ $(top_builddir)/src/ctrl/libosmoctrl.la \ $(top_builddir)/src/core/libosmocore.la -osmo_stat_dummy_CFLAGS = -Wall $(TALLOC_CFLAGS) $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMOCTRL_CFLAGS) +osmo_stat_dummy_CFLAGS = -Wall $(TALLOC_CFLAGS) osmo_stat_dummy_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include endif -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1b9497900b0eebd77fd226f52a9050cdbd9e6cdc Gerrit-Change-Number: 31846 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: sccp: Introduce APIs to get/set osmo_sccp_instance priv data pointer
by pespin 13 Mar '23

13 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31865 ) Change subject: sccp: Introduce APIs to get/set osmo_sccp_instance priv data pointer ...................................................................... sccp: Introduce APIs to get/set osmo_sccp_instance priv data pointer The field already exists in the struct, but it's not really used anywhere internally yet (and was not available externally). Let's make it available to users of the API, similar to osmo_sccp_user_{get,set}_priv(). This way apps can easily store per-sccp-instance state. Change-Id: I5643e6b14590b1478b3c8dabc8a7a619f5505409 --- M include/osmocom/sigtran/sccp_sap.h M src/sccp_user.c 2 files changed, 26 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/include/osmocom/sigtran/sccp_sap.h b/include/osmocom/sigtran/sccp_sap.h index 607c358..4bcdd38 100644 --- a/include/osmocom/sigtran/sccp_sap.h +++ b/include/osmocom/sigtran/sccp_sap.h @@ -293,6 +293,8 @@ void osmo_sccp_instance_destroy(struct osmo_sccp_instance *inst); struct osmo_ss7_instance *osmo_sccp_get_ss7(const struct osmo_sccp_instance *sccp); struct osmo_sccp_instance *osmo_sccp_get_sccp(const struct osmo_sccp_user *scu); +void osmo_sccp_set_priv(struct osmo_sccp_instance *sccp, void *priv); +void *osmo_sccp_get_priv(struct osmo_sccp_instance *sccp); void osmo_sccp_user_unbind(struct osmo_sccp_user *scu); void osmo_sccp_user_set_priv(struct osmo_sccp_user *scu, void *priv); diff --git a/src/sccp_user.c b/src/sccp_user.c index 64e2d31..e619c90 100644 --- a/src/sccp_user.c +++ b/src/sccp_user.c @@ -264,6 +264,16 @@ talloc_free(inst); } +void osmo_sccp_set_priv(struct osmo_sccp_instance *sccp, void *priv) +{ + sccp->priv = priv; +} + +void *osmo_sccp_get_priv(struct osmo_sccp_instance *sccp) +{ + return sccp->priv; +} + /*! \brief derive a basic local SCCP-Address from a given SCCP instance. * \param[out] dest_addr pointer to output address memory * \param[in] inst SCCP instance -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I5643e6b14590b1478b3c8dabc8a7a619f5505409 Gerrit-Change-Number: 31865 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in libosmo-sccp[master]: Implement sccp_instance->connections as rbtree
by pespin 13 Mar '23

13 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31828 ) Change subject: Implement sccp_instance->connections as rbtree ...................................................................... Implement sccp_instance->connections as rbtree As a result we move from: INSERT=O(1) SEARCH=O(n) REMOVE=O(1) to: INSERT=O(log(N)) SEARCH=O(log(N)) REMOVE=O(log(N)) So we get rid of O(n) complexity every time we need to find a conn object based on conn_id. When a big number of SCCP conns is handled, this saves a lot of CPU time every time a conn needs to be looked up, for instance each time a message is received. For instance, given 1500 SCCP conns, searching is ~10 steps while it took 1500 steps beforehand. Morever, since when creating a new conn_id the code looks if it exists prior to it, that means in practice inserting used to took O(n), while now it takes O(log(N)). Change-Id: I28ac67038207e2fad89ea291629cec5b2f912461 --- M src/sccp_internal.h M src/sccp_scoc.c M src/sccp_user.c 3 files changed, 83 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/sccp_internal.h b/src/sccp_internal.h index 23b3ef3..bfdca34 100644 --- a/src/sccp_internal.h +++ b/src/sccp_internal.h @@ -2,6 +2,8 @@ #include <osmocom/core/fsm.h> #include <osmocom/core/prim.h> +#include <osmocom/core/linuxlist.h> +#include <osmocom/core/linuxrbtree.h> #include <osmocom/sigtran/sccp_sap.h> #include <osmocom/sigtran/osmo_ss7.h> #include <osmocom/sigtran/protocol/mtp.h> @@ -42,8 +44,8 @@ struct osmo_sccp_instance { /* entry in global list of ss7 instances */ struct llist_head list; - /* list of 'struct sccp_connection' in this instance */ - struct llist_head connections; + /* rbtree root of 'struct sccp_connection' in this instance */ + struct rb_root connections; /* list of SCCP users in this instance */ struct llist_head users; /* routing context to be used in all outbound messages */ diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index 53cdf78..db1db23 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -52,6 +52,7 @@ #include <osmocom/core/msgb.h> #include <osmocom/core/utils.h> #include <osmocom/core/linuxlist.h> +#include <osmocom/core/linuxrbtree.h> #include <osmocom/core/logging.h> #include <osmocom/core/timer.h> #include <osmocom/core/fsm.h> @@ -72,8 +73,8 @@ /* a logical connection within the SCCP instance */ struct sccp_connection { - /* part of osmo_sccp_instance.list */ - struct llist_head list; + /* entry in (struct sccp_instance)->connections */ + struct rb_node node; /* which instance are we part of? */ struct osmo_sccp_instance *inst; /* which user owns us? */ @@ -452,14 +453,47 @@ static struct sccp_connection *conn_find_by_id(const struct osmo_sccp_instance *inst, uint32_t id) { struct sccp_connection *conn; + const struct rb_node *node = inst->connections.rb_node; - llist_for_each_entry(conn, &inst->connections, list) { - if (conn->conn_id == id) + while (node) { + conn = container_of(node, struct sccp_connection, node); + if (id < conn->conn_id) + node = node->rb_left; + else if (id > conn->conn_id) + node = node->rb_right; + else return conn; } return NULL; } +static int conn_add_node(struct osmo_sccp_instance *inst, struct sccp_connection *conn) +{ + struct rb_node **n = &(inst->connections.rb_node); + struct rb_node *parent = NULL; + + while (*n) { + struct sccp_connection *it; + + it = container_of(*n, struct sccp_connection, node); + + parent = *n; + if (conn->conn_id < it->conn_id) { + n = &((*n)->rb_left); + } else if (conn->conn_id > it->conn_id) { + n = &((*n)->rb_right); + } else { + LOGP(DLSCCP, LOGL_ERROR, + "Trying to reserve already reserved conn_id %u\n", conn->conn_id); + return -EEXIST; + } + } + + rb_link_node(&conn->node, parent, n); + rb_insert_color(&conn->node, &inst->connections); + return 0; +} + bool osmo_sccp_conn_id_exists(const struct osmo_sccp_instance *inst, uint32_t id) { return conn_find_by_id(inst, id) ? true : false; @@ -477,7 +511,10 @@ conn->inst = user->inst; conn->user = user; - llist_add_tail(&conn->list, &user->inst->connections); + if (conn_add_node(user->inst, conn) < 0) { + talloc_free(conn); + return NULL; + } INIT_TIMER(&conn->t_conn, conn_tmr_cb, conn); INIT_TIMER(&conn->t_ias, tx_inact_tmr_cb, conn); @@ -494,7 +531,7 @@ conn->fi = osmo_fsm_inst_alloc(&sccp_scoc_fsm, conn, conn, LOGL_DEBUG, name); if (!conn->fi) { - llist_del(&conn->list); + rb_erase(&conn->node, &user->inst->connections); talloc_free(conn); return NULL; } @@ -545,7 +582,7 @@ conn_stop_connect_timer(conn); conn_stop_inact_timers(conn); conn_stop_release_timers(conn); - llist_del(&conn->list); + rb_erase(&conn->node, &conn->inst->connections); osmo_fsm_inst_term(conn->fi, OSMO_FSM_TERM_REQUEST, NULL); @@ -1934,10 +1971,12 @@ void sccp_scoc_flush_connections(struct osmo_sccp_instance *inst) { - struct sccp_connection *conn, *conn2; - - llist_for_each_entry_safe(conn, conn2, &inst->connections, list) + struct rb_node *node; + while ((node = rb_first(&inst->connections))) { + struct sccp_connection *conn = container_of(node, struct sccp_connection, node); conn_destroy(conn); + } + } #include <osmocom/vty/vty.h> @@ -1970,11 +2009,14 @@ void sccp_scoc_show_connections(struct vty *vty, struct osmo_sccp_instance *inst) { struct sccp_connection *conn; + struct rb_node *node; vty_out(vty, "I Local Conn. Remote %s", VTY_NEWLINE); vty_out(vty, "O Ref SSN PC State Ref SSN PC %s", VTY_NEWLINE); vty_out(vty, "- ------ --- ------- ---------------- ------ --- -------%s", VTY_NEWLINE); - llist_for_each_entry(conn, &inst->connections, list) + for (node = rb_first(&inst->connections); node; node = rb_next(node)) { + conn = container_of(node, struct sccp_connection, node); vty_show_connection(vty, conn); + } } diff --git a/src/sccp_user.c b/src/sccp_user.c index 839ef64..64e2d31 100644 --- a/src/sccp_user.c +++ b/src/sccp_user.c @@ -229,7 +229,6 @@ inst->ss7 = ss7; inst->priv = priv; - INIT_LLIST_HEAD(&inst->connections); INIT_LLIST_HEAD(&inst->users); inst->ss7_user.inst = ss7; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I28ac67038207e2fad89ea291629cec5b2f912461 Gerrit-Change-Number: 31828 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in libosmo-sccp[master]: Implement sccp_instance->connections as rbtree
by pespin 13 Mar '23

13 Mar '23

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31828 ) Change subject: Implement sccp_instance->connections as rbtree ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I28ac67038207e2fad89ea291629cec5b2f912461 Gerrit-Change-Number: 31828 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 13 Mar 2023 10:33:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: sccp: Introduce APIs to get/set osmo_sccp_instance priv data pointer
by daniel 13 Mar '23

13 Mar '23

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31865 ) Change subject: sccp: Introduce APIs to get/set osmo_sccp_instance priv data pointer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I5643e6b14590b1478b3c8dabc8a7a619f5505409 Gerrit-Change-Number: 31865 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 10:32:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-sccp[master]: Implement sccp_instance->connections as rbtree
by daniel 13 Mar '23

13 Mar '23

Attention is currently required from: neels, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31828 ) Change subject: Implement sccp_instance->connections as rbtree ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I28ac67038207e2fad89ea291629cec5b2f912461 Gerrit-Change-Number: 31828 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 10:31:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: sccp: Introduce APIs to get/set osmo_sccp_instance priv data pointer
by osmith 13 Mar '23

13 Mar '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31865 ) Change subject: sccp: Introduce APIs to get/set osmo_sccp_instance priv data pointer ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I5643e6b14590b1478b3c8dabc8a7a619f5505409 Gerrit-Change-Number: 31865 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 10:25:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-sccp[master]: Implement sccp_instance->connections as rbtree
by osmith 13 Mar '23

13 Mar '23

Attention is currently required from: neels, laforge, pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31828 ) Change subject: Implement sccp_instance->connections as rbtree ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I28ac67038207e2fad89ea291629cec5b2f912461 Gerrit-Change-Number: 31828 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 10:24:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0