March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by fixeria 13 Mar '23

13 Mar '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/31842 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31842 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ieb4ddc5799819c24ed357218c7b0197bcb6b5c91 Gerrit-Change-Number: 31842 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 10:47:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: tests: there shall be no libraries in LDFLAGS
by fixeria 13 Mar '23

13 Mar '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/31841 ) Change subject: tests: there shall be no libraries in LDFLAGS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I95b07b5a7735fb2753281555a4544f1ba967579e Gerrit-Change-Number: 31841 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 10:47:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31773 ) Change subject: tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS ...................................................................... tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS The '-I' is a preprocessor flag, so it should be in AM_CPPFLAGS. Change-Id: Ic3e3dc75789850d2884d3e757f05ff01e136a5f4 --- M tests/llc/Makefile.am M tests/rlcmac/Makefile.am M tests/sndcp/Makefile.am 3 files changed, 23 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/llc/Makefile.am b/tests/llc/Makefile.am index ee57c5f..ca0ed1d 100644 --- a/tests/llc/Makefile.am +++ b/tests/llc/Makefile.am @@ -1,8 +1,11 @@ +AM_CPPFLAGS = \ + -I$(top_srcdir)/include/ \ + $(NULL) + AM_CFLAGS = \ -Wall \ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ - -I$(top_srcdir)/include/ \ $(NULL) AM_LDFLAGS = \ diff --git a/tests/rlcmac/Makefile.am b/tests/rlcmac/Makefile.am index 8d19656..9d1f5b0 100644 --- a/tests/rlcmac/Makefile.am +++ b/tests/rlcmac/Makefile.am @@ -1,8 +1,11 @@ +AM_CPPFLAGS = \ + -I$(top_srcdir)/include/ \ + $(NULL) + AM_CFLAGS = \ -Wall \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOCORE_CFLAGS) \ - -I$(top_srcdir)/include/ \ $(NULL) AM_LDFLAGS = \ diff --git a/tests/sndcp/Makefile.am b/tests/sndcp/Makefile.am index aff2abf..603388e 100644 --- a/tests/sndcp/Makefile.am +++ b/tests/sndcp/Makefile.am @@ -1,8 +1,11 @@ +AM_CPPFLAGS = \ + -I$(top_srcdir)/include/ \ + $(NULL) + AM_CFLAGS = \ -Wall \ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ - -I$(top_srcdir)/include/ \ $(NULL) AM_LDFLAGS = \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic3e3dc75789850d2884d3e757f05ff01e136a5f4 Gerrit-Change-Number: 31773 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-gprs[master]: {rlcmac,llc,sndcp}: AM_LDFLAGS shall not contain *_LIBS
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31772 ) Change subject: {rlcmac,llc,sndcp}: AM_LDFLAGS shall not contain *_LIBS ...................................................................... {rlcmac,llc,sndcp}: AM_LDFLAGS shall not contain *_LIBS The LDFLAGS is for stuff like: '-Wl,--wrap=foo', '-version-info', '-no-undefined', '-no-install', etc. but not for libraries. Change-Id: Ib211c37419a8c6a0bdfc202f6f91b255cc8420e2 --- M src/llc/Makefile.am M src/rlcmac/Makefile.am M src/sndcp/Makefile.am 3 files changed, 12 insertions(+), 15 deletions(-) Approvals: pespin: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/llc/Makefile.am b/src/llc/Makefile.am index 8d64231..1549c4c 100644 --- a/src/llc/Makefile.am +++ b/src/llc/Makefile.am @@ -14,11 +14,6 @@ $(LIBOSMOGSM_CFLAGS) \ $(NULL) -AM_LDFLAGS = \ - $(LIBOSMOCORE_LIBS) \ - $(LIBOSMOGSM_LIBS) \ - $(NULL) - lib_LTLIBRARIES = \ libosmo-gprs-llc.la \ $(NULL) diff --git a/src/rlcmac/Makefile.am b/src/rlcmac/Makefile.am index 78bf9ed..b31dc9d 100644 --- a/src/rlcmac/Makefile.am +++ b/src/rlcmac/Makefile.am @@ -14,11 +14,6 @@ $(LIBOSMOCORE_CFLAGS) \ $(NULL) -AM_LDFLAGS = \ - $(LIBOSMOGSM_LIBS) \ - $(LIBOSMOCORE_LIBS) \ - $(NULL) - lib_LTLIBRARIES = \ libosmo-gprs-rlcmac.la \ $(NULL) diff --git a/src/sndcp/Makefile.am b/src/sndcp/Makefile.am index 26ca24f..ca72ecb 100644 --- a/src/sndcp/Makefile.am +++ b/src/sndcp/Makefile.am @@ -14,11 +14,6 @@ $(LIBOSMOGSM_CFLAGS) \ $(NULL) -AM_LDFLAGS = \ - $(LIBOSMOCORE_LIBS) \ - $(LIBOSMOGSM_LIBS) \ - $(NULL) - lib_LTLIBRARIES = \ libosmo-gprs-sndcp.la \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31772 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ib211c37419a8c6a0bdfc202f6f91b255cc8420e2 Gerrit-Change-Number: 31772 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-gprs[master]: tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS
by fixeria 13 Mar '23

13 Mar '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31773 ) Change subject: tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic3e3dc75789850d2884d3e757f05ff01e136a5f4 Gerrit-Change-Number: 31773 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 10:45:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-sgsn[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/31839 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... tests: use -no-install libtool flag to avoid ./lt-* scripts This option should be used for any executables which are used only for testing, or for generating other files and are consequently never installed. By specifying this option, we are telling Libtool that the executable it links will only ever be executed from where it is built in the build tree. Libtool is usually able to considerably speed up the link process for such executables. Change-Id: I8af6a38d7abbf06aa8268981c80c3bfda2f80a27 --- M tests/gprs/Makefile.am M tests/gtphub/Makefile.am M tests/sgsn/Makefile.am M tests/slhc/Makefile.am M tests/sndcp_xid/Makefile.am M tests/v42bis/Makefile.am M tests/xid/Makefile.am 7 files changed, 28 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/tests/gprs/Makefile.am b/tests/gprs/Makefile.am index f90fd6e..ddfd2ae 100644 --- a/tests/gprs/Makefile.am +++ b/tests/gprs/Makefile.am @@ -1,5 +1,6 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOABIS_CFLAGS) +AM_LDFLAGS = -no-install EXTRA_DIST = gprs_test.ok diff --git a/tests/gtphub/Makefile.am b/tests/gtphub/Makefile.am index 6bb1a56..22b2a52 100644 --- a/tests/gtphub/Makefile.am +++ b/tests/gtphub/Makefile.am @@ -12,6 +12,8 @@ $(LIBGTP_CFLAGS) \ $(NULL) +AM_LDFLAGS = -no-install + EXTRA_DIST = \ gtphub_test.ok \ $(NULL) @@ -28,6 +30,7 @@ -Wl,--wrap=gtphub_resolve_ggsn_addr \ -Wl,--wrap=gtphub_ares_init \ -Wl,--wrap=gtphub_write \ + $(AM_LDFLAGS) \ $(NULL) gtphub_test_LDADD = \ diff --git a/tests/sgsn/Makefile.am b/tests/sgsn/Makefile.am index d22a8d9..c6c1f4a 100644 --- a/tests/sgsn/Makefile.am +++ b/tests/sgsn/Makefile.am @@ -22,6 +22,8 @@ $(NULL) endif +AM_LDFLAGS = -no-install + EXTRA_DIST = \ sgsn_test.ok \ $(NULL) @@ -45,6 +47,7 @@ -Wl,--wrap=gprs_subscr_request_update_location \ -Wl,--wrap=gprs_subscr_request_auth_info \ -Wl,--wrap=osmo_gsup_client_send \ + $(AM_LDFLAGS) \ $(NULL) sgsn_test_LDADD = \ diff --git a/tests/slhc/Makefile.am b/tests/slhc/Makefile.am index 0167f44..33cb7fa 100644 --- a/tests/slhc/Makefile.am +++ b/tests/slhc/Makefile.am @@ -1,5 +1,6 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBCARES_CFLAGS) +AM_LDFLAGS = -no-install EXTRA_DIST = slhc_test.ok diff --git a/tests/sndcp_xid/Makefile.am b/tests/sndcp_xid/Makefile.am index 4513c05..c4702b8 100644 --- a/tests/sndcp_xid/Makefile.am +++ b/tests/sndcp_xid/Makefile.am @@ -1,5 +1,6 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBCARES_CFLAGS) +AM_LDFLAGS = -no-install EXTRA_DIST = sndcp_xid_test.ok diff --git a/tests/v42bis/Makefile.am b/tests/v42bis/Makefile.am index 56b31f6..0e544a6 100644 --- a/tests/v42bis/Makefile.am +++ b/tests/v42bis/Makefile.am @@ -1,5 +1,6 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBCARES_CFLAGS) +AM_LDFLAGS = -no-install EXTRA_DIST = v42bis_test.ok diff --git a/tests/xid/Makefile.am b/tests/xid/Makefile.am index d3c205e..d3a260b 100644 --- a/tests/xid/Makefile.am +++ b/tests/xid/Makefile.am @@ -11,6 +11,8 @@ $(LIBCARES_CFLAGS) \ $(NULL) +AM_LDFLAGS = -no-install + EXTRA_DIST = \ xid_test.ok \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/31839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8af6a38d7abbf06aa8268981c80c3bfda2f80a27 Gerrit-Change-Number: 31839 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-pcu[master]: tests/Makefile.am: do not overwrite global LDFLAGS
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31838 ) Change subject: tests/Makefile.am: do not overwrite global LDFLAGS ...................................................................... tests/Makefile.am: do not overwrite global LDFLAGS We still want -no-install to be used for these tests. Change-Id: I926df1918fd24ea7be4b390d168a8c76ef9931c0 --- M tests/Makefile.am 1 file changed, 21 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index df63dd1..1c7b072 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -57,7 +57,10 @@ $(LIBOSMOCTRL_LIBS) \ $(LDADD) \ $(NULL) -tbf_TbfTest_LDFLAGS = -Wl,--wrap=pcu_sock_send +tbf_TbfTest_LDFLAGS = \ + -Wl,--wrap=pcu_sock_send \ + $(AM_LDFLAGS) \ + $(NULL) bitcomp_BitcompTest_SOURCES = bitcomp/BitcompTest.cpp ../src/egprs_rlc_compression.cpp bitcomp_BitcompTest_LDADD = \ @@ -105,7 +108,9 @@ $(NULL) ms_MsTest_LDFLAGS = \ - -Wl,-u,bssgp_prim_cb + -Wl,-u,bssgp_prim_cb \ + $(AM_LDFLAGS) \ + $(NULL) llc_LlcTest_SOURCES = llc/LlcTest.cpp llc_LlcTest_LDADD = \ @@ -117,7 +122,9 @@ $(NULL) llc_LlcTest_LDFLAGS = \ - -Wl,-u,bssgp_prim_cb + -Wl,-u,bssgp_prim_cb \ + $(AM_LDFLAGS) \ + $(NULL) llist_LListTest_SOURCES = llist/LListTest.cpp llist_LListTest_LDADD = \ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I926df1918fd24ea7be4b390d168a8c76ef9931c0 Gerrit-Change-Number: 31838 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-pcu[master]: {src,tests}/Makefile.am: libraries shall not be in AM_LDFLAGS
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31788 ) Change subject: {src,tests}/Makefile.am: libraries shall not be in AM_LDFLAGS ...................................................................... {src,tests}/Makefile.am: libraries shall not be in AM_LDFLAGS Change-Id: Ibd7eb55e2cfe7daed2f8a8d74c6a3ede6f29308f --- M src/Makefile.am M tests/Makefile.am 2 files changed, 32 insertions(+), 17 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/Makefile.am b/src/Makefile.am index e747d74..25d58c6 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -34,7 +34,6 @@ endif AM_CXXFLAGS = -Wall -AM_LDFLAGS = -lrt noinst_LTLIBRARIES = libgprs.la @@ -165,6 +164,7 @@ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOGSM_LIBS) \ + -lrt \ $(NULL) endif @@ -214,6 +214,7 @@ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOGSM_LIBS) \ + -lrt \ $(NULL) #MOSTLYCLEANFILES += testSource testDestination diff --git a/tests/Makefile.am b/tests/Makefile.am index 7c50969..df63dd1 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,5 +1,10 @@ AM_CPPFLAGS = $(STD_DEFINES_AND_INCLUDES) $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOGB_CFLAGS) $(LIBOSMOGSM_CFLAGS) -I$(top_srcdir)/src/ -I$(top_srcdir)/include/ -AM_LDFLAGS = -lrt -no-install +AM_LDFLAGS = -no-install + +LDADD = \ + $(LIBOSMOCORE_LIBS) \ + -lrt \ + $(NULL) check_PROGRAMS = \ rlcmac/RLCMACTest \ @@ -23,7 +28,7 @@ rlcmac_RLCMACTest_SOURCES = rlcmac/RLCMACTest.cpp rlcmac_RLCMACTest_LDADD = \ $(top_builddir)/src/libgprs.la \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) alloc_AllocTest_SOURCES = alloc/AllocTest.cpp @@ -32,7 +37,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) alloc_MslotTest_SOURCES = alloc/MslotTest.cpp @@ -41,7 +46,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) tbf_TbfTest_SOURCES = tbf/TbfTest.cpp @@ -50,7 +55,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) tbf_TbfTest_LDFLAGS = -Wl,--wrap=pcu_sock_send @@ -58,7 +63,7 @@ bitcomp_BitcompTest_LDADD = \ $(top_builddir)/src/libgprs.la \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) edge_EdgeTest_SOURCES = edge/EdgeTest.cpp @@ -67,7 +72,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) emu_pcu_emu_SOURCES = emu/pcu_emu.cpp emu/test_replay_gprs_attach.cpp \ @@ -78,7 +83,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) types_TypesTest_SOURCES = types/TypesTest.cpp @@ -87,7 +92,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) ms_MsTest_SOURCES = ms/MsTest.cpp @@ -96,7 +101,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) ms_MsTest_LDFLAGS = \ @@ -108,7 +113,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) llc_LlcTest_LDFLAGS = \ @@ -116,14 +121,14 @@ llist_LListTest_SOURCES = llist/LListTest.cpp llist_LListTest_LDADD = \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) codel_codel_test_SOURCES = codel/codel_test.c codel_codel_test_LDADD = \ $(top_builddir)/src/libgprs.la \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) fn_FnTest_SOURCES = fn/FnTest.cpp @@ -132,7 +137,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) app_info_AppInfoTest_SOURCES = app_info/AppInfoTest.cpp @@ -141,7 +146,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) ulc_PdchUlcTest_SOURCES = ulc/PdchUlcTest.cpp @@ -150,7 +155,7 @@ $(LIBOSMOGB_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOCORE_LIBS) \ + $(LDADD) \ $(NULL) # The `:;' works around a Bash 3.2 bug when the output is not writeable. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibd7eb55e2cfe7daed2f8a8d74c6a3ede6f29308f Gerrit-Change-Number: 31788 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-pcu[master]: tests/Makefile.am: do not overwrite global LDFLAGS
by fixeria 13 Mar '23

13 Mar '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31838 ) Change subject: tests/Makefile.am: do not overwrite global LDFLAGS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I926df1918fd24ea7be4b390d168a8c76ef9931c0 Gerrit-Change-Number: 31838 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 10:43:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: utils/Makefile.am: remove duplicate libosmogsm.la
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31844 ) Change subject: utils/Makefile.am: remove duplicate libosmogsm.la ...................................................................... utils/Makefile.am: remove duplicate libosmogsm.la It's already listed in $(LDADD), no need to append it again. Change-Id: I03f5f4330e828a938dafd93b9fdb576afb2b7f12 --- M utils/Makefile.am 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/utils/Makefile.am b/utils/Makefile.am index 6e11dcd..d81d0a6 100644 --- a/utils/Makefile.am +++ b/utils/Makefile.am @@ -40,7 +40,7 @@ $(top_builddir)/src/gb/libosmogb.la \ $(top_builddir)/src/vty/libosmovty.la \ $(top_builddir)/src/ctrl/libosmoctrl.la \ - $(top_builddir)/src/gsm/libosmogsm.la + $(NULL) osmo_ns_dummy_CFLAGS = $(TALLOC_CFLAGS) endif endif -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31844 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I03f5f4330e828a938dafd93b9fdb576afb2b7f12 Gerrit-Change-Number: 31844 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0