March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libasn1c[master]: src/Makefile.am: libraries shall not be in LDFLAGS but in LIBADD
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libasn1c/+/31860 ) Change subject: src/Makefile.am: libraries shall not be in LDFLAGS but in LIBADD ...................................................................... src/Makefile.am: libraries shall not be in LDFLAGS but in LIBADD Change-Id: I53dd51ab1f4666c42851a6cbdf1ee970530edee1 --- M src/Makefile.am 1 file changed, 19 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/Makefile.am b/src/Makefile.am index 29b5e64..019ff98 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -11,5 +11,14 @@ lib_LTLIBRARIES = libasn1c.la -libasn1c_la_LDFLAGS = $(LIBTALLOC_LIBS) -lm -version-info $(LIBVERSION) -no-undefined +libasn1c_la_LIBADD = \ + $(LIBTALLOC_LIBS) \ + -lm \ + $(NULL) + +libasn1c_la_LDFLAGS = \ + -version-info $(LIBVERSION) \ + -no-undefined \ + $(NULL) + libasn1c_la_SOURCES = ANY.c constraints.c GeneralizedTime.c NumericString.c T61String.c asn_codecs_prim.c constr_CHOICE.c GeneralString.c ObjectDescriptor.c TeletexString.c asn_SEQUENCE_OF.c constr_SEQUENCE.c GraphicString.c OBJECT_IDENTIFIER.c UniversalString.c asn_SET_OF.c constr_SEQUENCE_OF.c IA5String.c OCTET_STRING.c UTCTime.c ber_decoder.c constr_SET.c INTEGER.c per_decoder.c UTF8String.c ber_tlv_length.c constr_SET_OF.c ISO646String.c per_encoder.c VideotexString.c ber_tlv_tag.c constr_TYPE.c NativeEnumerated.c per_support.c VisibleString.c BIT_STRING.c NativeInteger.c PrintableString.c xer_decoder.c BMPString.c der_encoder.c NativeReal.c REAL.c xer_encoder.c BOOLEAN.c ENUMERATED.c NULL.c RELATIVE-OID.c xer_support.c per_opentype.c asn1helpers.c -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/31860 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I53dd51ab1f4666c42851a6cbdf1ee970530edee1 Gerrit-Change-Number: 31860 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in gapk[master]: Makefile.am: remove unused AM_CPPFLAGS variable
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/gapk/+/31857 ) Change subject: Makefile.am: remove unused AM_CPPFLAGS variable ...................................................................... Makefile.am: remove unused AM_CPPFLAGS variable Change-Id: I435e1153db2092c8f1632a84c1f546b98031e101 --- M Makefile.am 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/Makefile.am b/Makefile.am index 0093f0e..a1642d4 100644 --- a/Makefile.am +++ b/Makefile.am @@ -4,8 +4,6 @@ pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = libosmogapk.pc -AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include - SUBDIRS = include if ENABLE_GSMHR -- To view, visit https://gerrit.osmocom.org/c/gapk/+/31857 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I435e1153db2092c8f1632a84c1f546b98031e101 Gerrit-Change-Number: 31857 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in gapk[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/gapk/+/31855 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... tests: use -no-install libtool flag to avoid ./lt-* scripts This option should be used for any executables which are used only for testing, or for generating other files and are consequently never installed. By specifying this option, we are telling Libtool that the executable it links will only ever be executed from where it is built in the build tree. Libtool is usually able to considerably speed up the link process for such executables. Change-Id: Ib5402f99805437ad1ea49792b99434b57b616a2f --- M tests/Makefile.am 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index dee4060..e0a3c96 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -10,6 +10,8 @@ $(LIBOSMOCODEC_CFLAGS) \ $(NULL) +AM_LDFLAGS = -no-install + check_PROGRAMS = \ procqueue/pq_test \ io/pq_file_test \ -- To view, visit https://gerrit.osmocom.org/c/gapk/+/31855 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ib5402f99805437ad1ea49792b99434b57b616a2f Gerrit-Change-Number: 31855 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: {examples,stp}/Makefile.am: fix typo in $(COVERAGE_[C]FLAGS)
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31777 ) Change subject: {examples,stp}/Makefile.am: fix typo in $(COVERAGE_[C]FLAGS) ...................................................................... {examples,stp}/Makefile.am: fix typo in $(COVERAGE_[C]FLAGS) Change-Id: I8dc7119765df97f44a6f2c5d6eecec847fcc46dc --- M examples/Makefile.am M stp/Makefile.am 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/examples/Makefile.am b/examples/Makefile.am index 1993a01..d93987d 100644 --- a/examples/Makefile.am +++ b/examples/Makefile.am @@ -1,5 +1,5 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -AM_CFLAGS=-Wall -g $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMONETIF_CFLAGS) $(COVERAGE_FLAGS) +AM_CFLAGS=-Wall -g $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMONETIF_CFLAGS) $(COVERAGE_CFLAGS) AM_LDFLAGS=$(COVERAGE_LDFLAGS) noinst_HEADERS = internal.h diff --git a/stp/Makefile.am b/stp/Makefile.am index ae37487..f0282e7 100644 --- a/stp/Makefile.am +++ b/stp/Makefile.am @@ -1,5 +1,5 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -AM_CFLAGS=-Wall -g $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMONETIF_CFLAGS) $(COVERAGE_FLAGS) +AM_CFLAGS=-Wall -g $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMONETIF_CFLAGS) $(COVERAGE_CFLAGS) AM_LDFLAGS=$(COVERAGE_LDFLAGS) bin_PROGRAMS = osmo-stp -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8dc7119765df97f44a6f2c5d6eecec847fcc46dc Gerrit-Change-Number: 31777 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31831 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... tests: use -no-install libtool flag to avoid ./lt-* scripts This option should be used for any executables which are used only for testing, or for generating other files and are consequently never installed. By specifying this option, we are telling Libtool that the executable it links will only ever be executed from where it is built in the build tree. Libtool is usually able to considerably speed up the link process for such executables. Change-Id: I9758aaaa56b2453f33f90400342ebd1fd412ec3a --- M tests/m2ua/Makefile.am M tests/mtp/Makefile.am M tests/sccp/Makefile.am M tests/ss7/Makefile.am M tests/vty/Makefile.am M tests/xua/Makefile.am 6 files changed, 23 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/m2ua/Makefile.am b/tests/m2ua/Makefile.am index b1d5266..6f060c4 100644 --- a/tests/m2ua/Makefile.am +++ b/tests/m2ua/Makefile.am @@ -1,5 +1,6 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) +AM_LDFLAGS = -no-install EXTRA_DIST = m2ua_test.ok diff --git a/tests/mtp/Makefile.am b/tests/mtp/Makefile.am index d2b46a9..a3f22f1 100644 --- a/tests/mtp/Makefile.am +++ b/tests/mtp/Makefile.am @@ -1,5 +1,7 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) +AM_LDFLAGS = -no-install + check_PROGRAMS = mtp_parse_test EXTRA_DIST = mtp_parse_test.ok diff --git a/tests/sccp/Makefile.am b/tests/sccp/Makefile.am index 21f3f05..fc4f0c8 100644 --- a/tests/sccp/Makefile.am +++ b/tests/sccp/Makefile.am @@ -1,5 +1,6 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) +AM_LDFLAGS = -no-install EXTRA_DIST = sccp_test.ok diff --git a/tests/ss7/Makefile.am b/tests/ss7/Makefile.am index 1f873db..ecc69e0 100644 --- a/tests/ss7/Makefile.am +++ b/tests/ss7/Makefile.am @@ -1,7 +1,7 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) -AM_LDFLAGS = -static +AM_LDFLAGS = -static -no-install LDADD = $(top_builddir)/src/libosmo-sigtran.la \ $(LIBOSMOCORE_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMONETIF_LIBS) $(LIBSCTP_LIBS) diff --git a/tests/vty/Makefile.am b/tests/vty/Makefile.am index 7e7a083..9ed31b0 100644 --- a/tests/vty/Makefile.am +++ b/tests/vty/Makefile.am @@ -1,7 +1,7 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) -AM_LDFLAGS = -static +AM_LDFLAGS = -static -no-install LDADD = $(top_builddir)/src/libosmo-sigtran.la \ $(LIBOSMOCORE_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMONETIF_LIBS) $(LIBSCTP_LIBS) diff --git a/tests/xua/Makefile.am b/tests/xua/Makefile.am index 92ba76d..546039c 100644 --- a/tests/xua/Makefile.am +++ b/tests/xua/Makefile.am @@ -1,7 +1,7 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) -AM_LDFLAGS = -static +AM_LDFLAGS = -static -no-install LDADD = $(top_builddir)/src/libosmo-sigtran.la \ $(LIBOSMOCORE_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMONETIF_LIBS) $(LIBSCTP_LIBS) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31831 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9758aaaa56b2453f33f90400342ebd1fd412ec3a Gerrit-Change-Number: 31831 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: tests/*/Makefile.am: -Wall is not a preprocessor flag
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31778 ) Change subject: tests/*/Makefile.am: -Wall is not a preprocessor flag ...................................................................... tests/*/Makefile.am: -Wall is not a preprocessor flag Change-Id: I1a143636dfc5d4ea85938472fd367ac88e3cc4ae --- M tests/m2ua/Makefile.am M tests/mtp/Makefile.am M tests/ss7/Makefile.am M tests/vty/Makefile.am M tests/xua/Makefile.am 5 files changed, 15 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/m2ua/Makefile.am b/tests/m2ua/Makefile.am index aa88258..b1d5266 100644 --- a/tests/m2ua/Makefile.am +++ b/tests/m2ua/Makefile.am @@ -1,4 +1,4 @@ -AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -Wall +AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) EXTRA_DIST = m2ua_test.ok diff --git a/tests/mtp/Makefile.am b/tests/mtp/Makefile.am index c770a16..d2b46a9 100644 --- a/tests/mtp/Makefile.am +++ b/tests/mtp/Makefile.am @@ -1,4 +1,5 @@ -AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include $(LIBOSMOCORE_CFLAGS) -Wall +AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include +AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) check_PROGRAMS = mtp_parse_test EXTRA_DIST = mtp_parse_test.ok diff --git a/tests/ss7/Makefile.am b/tests/ss7/Makefile.am index 6ca75b3..1f873db 100644 --- a/tests/ss7/Makefile.am +++ b/tests/ss7/Makefile.am @@ -1,4 +1,4 @@ -AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -Wall +AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) AM_LDFLAGS = -static diff --git a/tests/vty/Makefile.am b/tests/vty/Makefile.am index 00e3a1f..7e7a083 100644 --- a/tests/vty/Makefile.am +++ b/tests/vty/Makefile.am @@ -1,4 +1,4 @@ -AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -Wall +AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) AM_LDFLAGS = -static diff --git a/tests/xua/Makefile.am b/tests/xua/Makefile.am index ad4577d..92ba76d 100644 --- a/tests/xua/Makefile.am +++ b/tests/xua/Makefile.am @@ -1,4 +1,4 @@ -AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -Wall +AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) AM_LDFLAGS = -static -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I1a143636dfc5d4ea85938472fd367ac88e3cc4ae Gerrit-Change-Number: 31778 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: tests/*/Makefile.am: -Wall is not a preprocessor flag
by fixeria 13 Mar '23

13 Mar '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31778 ) Change subject: tests/*/Makefile.am: -Wall is not a preprocessor flag ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I1a143636dfc5d4ea85938472fd367ac88e3cc4ae Gerrit-Change-Number: 31778 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 10:54:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: {examples,stp}/Makefile.am: fix typo in $(COVERAGE_[C]FLAGS)
by fixeria 13 Mar '23

13 Mar '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31777 ) Change subject: {examples,stp}/Makefile.am: fix typo in $(COVERAGE_[C]FLAGS) ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8dc7119765df97f44a6f2c5d6eecec847fcc46dc Gerrit-Change-Number: 31777 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 10:54:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: Makefile.am: remove unneeded AM_LDFLAGS with LIBS
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31830 ) Change subject: Makefile.am: remove unneeded AM_LDFLAGS with LIBS ...................................................................... Makefile.am: remove unneeded AM_LDFLAGS with LIBS Change-Id: I10150c00dbe69648b95ea4c414db0ad6c6bdd254 --- M src/Makefile.am 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/Makefile.am b/src/Makefile.am index 43b00b2..45d4df7 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -13,12 +13,6 @@ $(COVERAGE_CFLAGS) \ $(NULL) -AM_LDFLAGS = \ - $(LIBOSMOCORE_LIBS) \ - $(LIBOSMOGSM_LIBS) \ - $(COVERAGE_LDFLAGS) \ - $(NULL) - SUBDIRS = \ osmo-bsc \ utils \ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31830 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I10150c00dbe69648b95ea4c414db0ad6c6bdd254 Gerrit-Change-Number: 31830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31832 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... tests: use -no-install libtool flag to avoid ./lt-* scripts This option should be used for any executables which are used only for testing, or for generating other files and are consequently never installed. By specifying this option, we are telling Libtool that the executable it links will only ever be executed from where it is built in the build tree. Libtool is usually able to considerably speed up the link process for such executables. Change-Id: I37f078bdc17e128298b956f493ff5c03ef476f98 --- M tests/abis/Makefile.am M tests/acc/Makefile.am M tests/bsc/Makefile.am M tests/codec_pref/Makefile.am M tests/gsm0408/Makefile.am M tests/handover/Makefile.am M tests/nanobts_omlattr/Makefile.am M tests/paging/Makefile.am M tests/subscr/Makefile.am 9 files changed, 29 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/tests/abis/Makefile.am b/tests/abis/Makefile.am index d17eff8..6f00191 100644 --- a/tests/abis/Makefile.am +++ b/tests/abis/Makefile.am @@ -14,6 +14,8 @@ $(COVERAGE_CFLAGS) \ $(NULL) +AM_LDFLAGS = -no-install + EXTRA_DIST = \ abis_test.ok \ $(NULL) diff --git a/tests/acc/Makefile.am b/tests/acc/Makefile.am index a169c5c..4199d4e 100644 --- a/tests/acc/Makefile.am +++ b/tests/acc/Makefile.am @@ -14,6 +14,8 @@ $(COVERAGE_CFLAGS) \ $(NULL) +AM_LDFLAGS = -no-install + EXTRA_DIST = \ acc_test.ok \ $(NULL) diff --git a/tests/bsc/Makefile.am b/tests/bsc/Makefile.am index 6b5c3e8..be9690c 100644 --- a/tests/bsc/Makefile.am +++ b/tests/bsc/Makefile.am @@ -18,6 +18,7 @@ AM_LDFLAGS = \ $(COVERAGE_LDFLAGS) \ + -no-install \ $(NULL) EXTRA_DIST = \ diff --git a/tests/codec_pref/Makefile.am b/tests/codec_pref/Makefile.am index ec25da5..5e77f0e 100644 --- a/tests/codec_pref/Makefile.am +++ b/tests/codec_pref/Makefile.am @@ -12,8 +12,7 @@ $(LIBOSMOSIGTRAN_CFLAGS) \ $(NULL) -AM_LDFLAGS = \ - $(NULL) +AM_LDFLAGS = -no-install EXTRA_DIST = \ codec_pref_test.ok \ diff --git a/tests/gsm0408/Makefile.am b/tests/gsm0408/Makefile.am index 4802025..e13f687 100644 --- a/tests/gsm0408/Makefile.am +++ b/tests/gsm0408/Makefile.am @@ -13,6 +13,8 @@ $(LIBOSMOSIGTRAN_CFLAGS) \ $(NULL) +AM_LDFLAGS = -no-install + check_PROGRAMS = \ gsm0408_test \ $(NULL) diff --git a/tests/handover/Makefile.am b/tests/handover/Makefile.am index b5726b6..0ff387b 100644 --- a/tests/handover/Makefile.am +++ b/tests/handover/Makefile.am @@ -18,6 +18,7 @@ AM_LDFLAGS = \ $(COVERAGE_LDFLAGS) \ + -no-install \ $(NULL) EXTRA_DIST = \ diff --git a/tests/nanobts_omlattr/Makefile.am b/tests/nanobts_omlattr/Makefile.am index 8c64356..b45e9b5 100644 --- a/tests/nanobts_omlattr/Makefile.am +++ b/tests/nanobts_omlattr/Makefile.am @@ -12,6 +12,8 @@ $(LIBOSMOSIGTRAN_CFLAGS) \ $(NULL) +AM_LDFLAGS = -no-install + check_PROGRAMS = \ nanobts_omlattr_test \ $(NULL) diff --git a/tests/paging/Makefile.am b/tests/paging/Makefile.am index 5472c48..7fb7ff1 100644 --- a/tests/paging/Makefile.am +++ b/tests/paging/Makefile.am @@ -28,6 +28,7 @@ paging_test_LDFLAGS = \ -Wl,--wrap=abis_rsl_sendmsg \ + -no-install \ $(NULL) paging_test_LDADD = \ diff --git a/tests/subscr/Makefile.am b/tests/subscr/Makefile.am index e18b96a..634ea59 100644 --- a/tests/subscr/Makefile.am +++ b/tests/subscr/Makefile.am @@ -17,6 +17,7 @@ AM_LDFLAGS = \ $(COVERAGE_LDFLAGS) \ + -no-install \ $(NULL) EXTRA_DIST = \ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31832 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I37f078bdc17e128298b956f493ff5c03ef476f98 Gerrit-Change-Number: 31832 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log March 2023