February 2023 - gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: tunmap: refactor nft ruleset: fix "martians" and "1024"

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31165 ) Change subject: tunmap: refactor nft ruleset: fix "martians" and "1024" ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iccb975a1c0f8a2087f7b7dc4942a6b41f5675a13 Gerrit-Change-Number: 31165 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 04 Feb 2023 15:03:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: Add osmo_sockaddr_size() to return the size of the variant used

by msuraev

Attention is currently required from: daniel. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31172 ) Change subject: Add osmo_sockaddr_size() to return the size of the variant used ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File include/osmocom/core/socket.h: https://gerrit.osmocom.org/c/libosmocore/+/31172/comment/6ef82b76_fdd9e61a PS1, Line 42: { NULL check for addr is missing. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I952b6bb752441fe019fc18f89bce4bbfbe58994a Gerrit-Change-Number: 31172 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 04 Feb 2023 10:12:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: Add SI10 support

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31036 ) Change subject: Add SI10 support ...................................................................... Add SI10 support Add data structures and checks for System information Type 10. Related: OS#5783 Change-Id: I3a5da543f083f31e873c67b5ec1b5a439187d8f3 --- M include/osmocom/gsm/protocol/gsm_04_08.h M src/gsm/sysinfo.c 2 files changed, 15 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve msuraev: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index ff9eb64..e494b58 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -1134,6 +1134,20 @@ #endif } __attribute__ ((packed)); +/* Section 9.1.50 System Information type 10 (ASCI) */ +struct gsm48_system_information_type_10 { +#if OSMO_IS_LITTLE_ENDIAN + uint8_t rr_short_pd:1, /* < RR short PD : bit > See 3GPP TS 24.007 §11.3.2 */ + msg_type:5, /* < message type : bit(5) > See 3GPP TS 44.018 Table 10.4.2 */ + l2_header:2; /* < short layer 2 header : bit(2) > See 3GPP TS 44.006 §6.4a */ + uint8_t rest_octets[0]; /* < SI10 Rest Octets : bit(160) > See 3GPP TS 44.018 §10.5.2.44 */ +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t l2_header:2, msg_type:5, rr_short_pd:1; + uint8_t rest_octets[0]; +#endif +} __attribute__ ((packed)); + /* Section 9.1.43a System Information type 13 */ struct gsm48_system_information_type_13 { struct gsm48_system_information_type_header header; diff --git a/src/gsm/sysinfo.c b/src/gsm/sysinfo.c index b615871..40e2652 100644 --- a/src/gsm/sysinfo.c +++ b/src/gsm/sysinfo.c @@ -46,7 +46,7 @@ /* bs11 forgot the l2 len, 0-6 rest octets */ osmo_static_assert(sizeof(struct gsm48_system_information_type_5) == 18, _si5_size); osmo_static_assert(sizeof(struct gsm48_system_information_type_6) == 11, _si6_size); - +osmo_static_assert(sizeof(struct gsm48_system_information_type_10) == 1, _si10_size); osmo_static_assert(sizeof(struct gsm48_system_information_type_13) == 3, _si13_size); static const uint8_t sitype2rsl[_MAX_SYSINFO_TYPE] = { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a5da543f083f31e873c67b5ec1b5a439187d8f3 Gerrit-Change-Number: 31036 Gerrit-PatchSet: 11 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in libosmocore[master]: Add SI10 support

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31036 ) Change subject: Add SI10 support ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a5da543f083f31e873c67b5ec1b5a439187d8f3 Gerrit-Change-Number: 31036 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 04 Feb 2023 10:07:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ggsn[master]: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of d...

by arehbein

arehbein has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31186 ) Change subject: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of deprecated functions ...................................................................... Abandoned Patch was already merged/misunderstanding/somehow my local repository wasn't updated properly and I didn't get a merge conflict warning either -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I6d5b394f47b9a54b99b979737f57a04d6ea8056f Gerrit-Change-Number: 31186 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 4 months

1
0
0 0

Change in osmo-bts[master]: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of d...

by arehbein

arehbein has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31184 ) Change subject: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of deprecated functions ...................................................................... Abandoned Patch was already merged/misunderstanding/somehow my local repository wasn't updated properly and I didn't get a merge conflict warning either -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I155235460d13077fdcebfca1a9ea901d3ee18455 Gerrit-Change-Number: 31184 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 4 months

1
0
0 0

Change in osmo-gbproxy[master]: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of d...

by arehbein

arehbein has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/31185 ) Change subject: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of deprecated functions ...................................................................... Abandoned Patch was already merged/misunderstanding/somehow my local repository wasn't updated properly and I didn't get a merge conflict warning either -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/31185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ibc5f9d4c3dc8cd0b4644f82cdb99c65911fef08d Gerrit-Change-Number: 31185 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 4 months

1
0
0 0

Change in osmo-hlr[master]: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of d...

by arehbein

arehbein has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31187 ) Change subject: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of deprecated functions ...................................................................... Abandoned Merge conflict -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I317003a36d81030e3c64316a407b50f9db89913d Gerrit-Change-Number: 31187 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 4 months

1
0
0 0

Change in osmo-hnbgw[master]: osmo-hnbgw: Transition to use of ctrl_interface_setup(), ctrl_interfa...

by arehbein

arehbein has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31188 ) Change subject: osmo-hnbgw: Transition to use of ctrl_interface_setup(), ctrl_interface_setup2() ...................................................................... Abandoned Merge conflict -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iec6e9ed93b5cd04b231bca77a6832dc4c18b209f Gerrit-Change-Number: 31188 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 4 months

1
0
0 0

Change in osmo-hnbgw[master]: osmo-hnbgw: Transition to use of ctrl_interface_setup(), ctrl_interfa...

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31188 ) Change subject: osmo-hnbgw: Transition to use of ctrl_interface_setup(), ctrl_interface_setup2() ...................................................................... osmo-hnbgw: Transition to use of ctrl_interface_setup(), ctrl_interface_setup2() Related Change: I0fd87fd41fd3ac975273968d24f477daa3cd3aa9 Related: OS#5809 Change-Id: Iec6e9ed93b5cd04b231bca77a6832dc4c18b209f --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/88/31188/1 diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 2836ae1..a8dfd6c 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -773,8 +773,8 @@ exit(1); } - g_hnb_gw->ctrl = ctrl_interface_setup_dynip2(g_hnb_gw, ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_HNBGW, - hnb_ctrl_node_lookup, _LAST_CTRL_NODE_HNB); + g_hnb_gw->ctrl = ctrl_interface_setup2(g_hnb_gw, OSMO_CTRL_PORT_HNBGW, + hnb_ctrl_node_lookup, _LAST_CTRL_NODE_HNB); if (!g_hnb_gw->ctrl) { LOGP(DMAIN, LOGL_ERROR, "Failed to create CTRL interface on %s:%u\n", ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_HNBGW); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iec6e9ed93b5cd04b231bca77a6832dc4c18b209f Gerrit-Change-Number: 31188 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023