February 2023 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: bsc_vty: use gsmnet_from_vty() everywhere, not vty->index

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31190 ) Change subject: bsc_vty: use gsmnet_from_vty() everywhere, not vty->index ...................................................................... bsc_vty: use gsmnet_from_vty() everywhere, not vty->index Change-Id: Ic08d1213c3b353bdf9b425e24382b6c5bd229c9c --- M src/osmo-bsc/bsc_vty.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/90/31190/1 diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index cc9de74..4b7f24c 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -2289,7 +2289,7 @@ "Timezone offset (45 minutes)\n", CMD_ATTR_IMMEDIATE) { - struct gsm_network *net = vty->index; + struct gsm_network *net = gsmnet_from_vty(vty); int tzhr = atoi(argv[0]); int tzmn = atoi(argv[1]); @@ -2313,7 +2313,7 @@ "DST offset (hours)\n", CMD_ATTR_IMMEDIATE) { - struct gsm_network *net = vty->index; + struct gsm_network *net = gsmnet_from_vty(vty); int tzhr = atoi(argv[0]); int tzmn = atoi(argv[1]); int tzdst = atoi(argv[2]); @@ -2333,7 +2333,7 @@ "Disable network timezone override, use system tz\n", CMD_ATTR_IMMEDIATE) { - struct gsm_network *net = vty->index; + struct gsm_network *net = gsmnet_from_vty(vty); net->tz.override = 0; @@ -2349,7 +2349,7 @@ "Periodic Location Updating Interval\n" "Periodic Location Updating Interval in Minutes\n") { - struct gsm_network *net = vty->index; + struct gsm_network *net = gsmnet_from_vty(vty); struct osmo_tdef *d = osmo_tdef_get_entry(net->T_defs, 3212); OSMO_ASSERT(d); @@ -2367,7 +2367,7 @@ "Periodic Location Updating Interval\n" "Periodic Location Updating Interval\n") { - struct gsm_network *net = vty->index; + struct gsm_network *net = gsmnet_from_vty(vty); struct osmo_tdef *d = osmo_tdef_get_entry(net->T_defs, 3212); OSMO_ASSERT(d); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic08d1213c3b353bdf9b425e24382b6c5bd229c9c Gerrit-Change-Number: 31190 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: SI13: drop meaningless error check

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31091 ) Change subject: SI13: drop meaningless error check ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/31091/comment/21d871b0_8184acdb PS1, Line 9: always return positive integer > ... writing code against some potentially-could-be API which we do not even have plans introducing instead of writing it against current documented API is meaningless. Signed rc is already the API, so a negative value is possible from the API point of view. There is nothing in the docstring saying that the returned value is always positive. You're simply assuming that the implementation of osmo_gsm48_rest_octets_si13_encode(), which is a library function, will never change. How can you be sure about that... > ... especially given that other uses of such functions like osmo_gsm48_rest_octets_si1_encode() do not have this kind of useless checks. Actually osmo_gsm48_rest_octets_si2quater_encode() may return a negative value, and there is such a 'useless' check in make_si2quaters(). Also, the unit test for osmo_gsm48_rest_octets_si13_encode() in libosmocore.git does check if rc is negative. These checks are not useless after all, and it's sad that we don't have them in all cases. So IMO this patch is meaningless. I am against merging it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib1aeaa57ad0929fd2e1296737969d89485f0ac7b Gerrit-Change-Number: 31091 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sat, 04 Feb 2023 20:09:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: SI13: drop meaningless error check

by msuraev

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31091 ) Change subject: SI13: drop meaningless error check ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/31091/comment/0be1420c_e89c06fc PS1, Line 9: always return positive integer > But it still returns a signed integer, and some day somebody may add an additional checks making it […] I disagree - writing code against some potentially-could-be API which we do not even have plans introducing instead of writing it against current documented API is meaningless. It also adds unnecessary confusion for the reader - especially given that other uses of such functions like osmo_gsm48_rest_octets_si1_encode() do not have this kind of useless checks. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib1aeaa57ad0929fd2e1296737969d89485f0ac7b Gerrit-Change-Number: 31091 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 04 Feb 2023 19:19:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: use extract_paging_group() for PCU_IF_SAPI_PCH

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31168 ) Change subject: pcu_sock: use extract_paging_group() for PCU_IF_SAPI_PCH ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31168 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If4ffe8eafd2e54e323cbc075c09d457a74ebe83f Gerrit-Change-Number: 31168 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 04 Feb 2023 19:10:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: bankd_main: Avoid uninitialized variable

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31182 ) Change subject: bankd_main: Avoid uninitialized variable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I29f911cb2c8ad67cf1ce4486e1583612fb0b98a6 Gerrit-Change-Number: 31182 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 04 Feb 2023 19:09:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: rspro_server: Handle ipa_server_link_ipen() error case

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31181 ) Change subject: rspro_server: Handle ipa_server_link_ipen() error case ...................................................................... Patch Set 1: (1 comment) File src/server/rspro_server.c: https://gerrit.osmocom.org/c/osmo-remsim/+/31181/comment/126d109e_6b549f25 PS1, Line 870: talloc_free(srv); > Don't you need to call pthread_rwlock_destroy() here, btw? ... or call rspro_server_destroy(), which does so. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic32d53a236b80711651fb4ee196ac3b95148e61f Gerrit-Change-Number: 31181 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 04 Feb 2023 19:08:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: rspro_server: Handle ipa_server_link_ipen() error case

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31181 ) Change subject: rspro_server: Handle ipa_server_link_ipen() error case ...................................................................... Patch Set 1: -Code-Review (1 comment) File src/server/rspro_server.c: https://gerrit.osmocom.org/c/osmo-remsim/+/31181/comment/501fbe9f_43d37348 PS1, Line 870: talloc_free(srv); Don't you need to call pthread_rwlock_destroy() here, btw? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic32d53a236b80711651fb4ee196ac3b95148e61f Gerrit-Change-Number: 31181 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 04 Feb 2023 19:07:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: rspro_server: Handle ipa_server_link_ipen() error case

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31181 ) Change subject: rspro_server: Handle ipa_server_link_ipen() error case ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-remsim/+/31181/comment/d9ce197c_c580f984 PS1, Line 7: ipen typo: open https://gerrit.osmocom.org/c/osmo-remsim/+/31181/comment/81de39d2_ef609274 PS1, Line 13: COD CID -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic32d53a236b80711651fb4ee196ac3b95148e61f Gerrit-Change-Number: 31181 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 04 Feb 2023 19:06:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: remsim_server: handle osmo_fd_register() failure case

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31180 ) Change subject: remsim_server: handle osmo_fd_register() failure case ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I7c2448303fba7caa27df65ac5f4d91ddf232ceb6 Gerrit-Change-Number: 31180 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 04 Feb 2023 19:04:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: rest_api: strtoul canot return negative

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31179 ) Change subject: rest_api: strtoul canot return negative ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic5019e216dd7b26be0bd988df218a2cb5775e411 Gerrit-Change-Number: 31179 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 04 Feb 2023 19:03:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023