February 2023 - gerrit-log - lists.osmocom.org

Change in osmo-hlr[master]: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of d...

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31187 ) Change subject: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of deprecated functions ...................................................................... ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of deprecated functions Related change: https://gerrit.osmocom.org/c/libosmocore/+/30444/12 Related: OS#5809 Change-Id: I317003a36d81030e3c64316a407b50f9db89913d --- M src/ctrl.c 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/87/31187/1 diff --git a/src/ctrl.c b/src/ctrl.c index 11b0f5c..b8ecf0b 100644 --- a/src/ctrl.c +++ b/src/ctrl.c @@ -771,9 +771,7 @@ struct ctrl_handle *hlr_controlif_setup(struct hlr *hlr) { int rc; - struct ctrl_handle *hdl = ctrl_interface_setup_dynip2(hlr, - hlr->ctrl_bind_addr, - OSMO_CTRL_PORT_HLR, + struct ctrl_handle *hdl = ctrl_interface_setup2(hlr, OSMO_CTRL_PORT_HLR, hlr_ctrl_node_lookup, _LAST_CTRL_NODE_HLR); if (!hdl) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I317003a36d81030e3c64316a407b50f9db89913d Gerrit-Change-Number: 31187 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-ggsn[master]: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of d...

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31186 ) Change subject: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of deprecated functions ...................................................................... ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of deprecated functions Related change: https://gerrit.osmocom.org/c/libosmocore/+/30444/12 Related: OS#5809 Change-Id: I6d5b394f47b9a54b99b979737f57a04d6ea8056f --- M ggsn/ggsn_main.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/86/31186/1 diff --git a/ggsn/ggsn_main.c b/ggsn/ggsn_main.c index 2d917c1..bc9e0c3 100644 --- a/ggsn/ggsn_main.c +++ b/ggsn/ggsn_main.c @@ -227,8 +227,7 @@ if (rc < 0) exit(1); - g_ctrlh = ctrl_interface_setup_dynip(NULL, ctrl_vty_get_bind_addr(), - OSMO_CTRL_PORT_GGSN, NULL); + g_ctrlh = ctrl_interface_setup(NULL, OSMO_CTRL_PORT_GGSN, NULL); if (!g_ctrlh) { LOGP(DGGSN, LOGL_ERROR, "Failed to create CTRL interface.\n"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I6d5b394f47b9a54b99b979737f57a04d6ea8056f Gerrit-Change-Number: 31186 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-gbproxy[master]: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of d...

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/31185 ) Change subject: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of deprecated functions ...................................................................... ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of deprecated functions Related change: https://gerrit.osmocom.org/c/libosmocore/+/30444/12 Related: OS#5809 Change-Id: Ibc5f9d4c3dc8cd0b4644f82cdb99c65911fef08d --- M src/gb_proxy_main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/85/31185/1 diff --git a/src/gb_proxy_main.c b/src/gb_proxy_main.c index ba49a77..da69f9c 100644 --- a/src/gb_proxy_main.c +++ b/src/gb_proxy_main.c @@ -341,7 +341,7 @@ /* Start control interface after getting config for * ctrl_vty_get_bind_addr() */ - ctrl = ctrl_interface_setup_dynip(gbcfg, ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_GBPROXY, NULL); + ctrl = ctrl_interface_setup(gbcfg, OSMO_CTRL_PORT_GBPROXY, NULL); if (!ctrl) { LOGP(DGPRS, LOGL_FATAL, "Failed to create CTRL interface.\n"); exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/31185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ibc5f9d4c3dc8cd0b4644f82cdb99c65911fef08d Gerrit-Change-Number: 31185 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-bts[master]: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of d...

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31184 ) Change subject: ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of deprecated functions ...................................................................... ctrl: Use ctrl_interface_setup()/ctrl_interface_setup2() instead of deprecated functions Related change: https://gerrit.osmocom.org/c/libosmocore/+/30444/12 Related: OS#5809 Change-Id: I155235460d13077fdcebfca1a9ea901d3ee18455 --- M src/common/bts_ctrl_lookup.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/84/31184/1 diff --git a/src/common/bts_ctrl_lookup.c b/src/common/bts_ctrl_lookup.c index a3e3c8b..a6dee32 100644 --- a/src/common/bts_ctrl_lookup.c +++ b/src/common/bts_ctrl_lookup.c @@ -94,8 +94,7 @@ struct ctrl_handle *hdl; int rc = 0; - hdl = ctrl_interface_setup_dynip(bts, bind_addr, port, - bts_ctrl_node_lookup); + hdl = ctrl_interface_setup(bts, port, bts_ctrl_node_lookup); if (!hdl) return NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I155235460d13077fdcebfca1a9ea901d3ee18455 Gerrit-Change-Number: 31184 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: transfer E1 connection information to PCU

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31144 ) Change subject: pcu_sock: transfer E1 connection information to PCU ...................................................................... Patch Set 3: (3 comments) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/cedf9095_e9b61231 PS1, Line 315: struct gsm_bts_trx_ts *ts; > I don't think that it is a good idea to declare the variables in other places as at the top of a fun […] This is actually a good practice. By having if/for/while scoped variables, you're telling the compiler more about their lifetime, so it may potentially apply some additional optimizations. There is of course a tradeoff between having everything scoped and readability of the code. I recommend reading this thread: https://stackoverflow.com/questions/8474100/where-you-can-and-cannot-declar…. Not critical though, you can leave it as it is. File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/0777971f_311d0d73 PS3, Line 318: if (!trx) this condition can never be true https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/d82e4c57_46600410 PS3, Line 346: LOGP Let's use LOG_TRX here. This will shorten the logging message to: "Sending E1 CCU info for TS%u\n" -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6d44373336b41009ff4c6e459d32d0a81081676c Gerrit-Change-Number: 31144 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Feb 2023 20:34:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-e1-recorder[master]: handle telnet_init_default() error case

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/31183 ) Change subject: handle telnet_init_default() error case ...................................................................... handle telnet_init_default() error case Closes: CID#307532 Change-Id: I0210b535b844529e217fd5d6ffb01f94a262dc9c --- M src/e1_recorder.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-recorder refs/changes/83/31183/1 diff --git a/src/e1_recorder.c b/src/e1_recorder.c index 68d4543..5873140 100644 --- a/src/e1_recorder.c +++ b/src/e1_recorder.c @@ -207,8 +207,12 @@ exit(1); } - /* start telne tafte reading config for vty_get_bind_adr() */ - telnet_init_default(rec_tall_ctx, NULL, 4444); + /* start telnet afte reading config for vty_get_bind_adr() */ + rc = telnet_init_default(rec_tall_ctx, NULL, 4444); + if (rc < 0) { + fprintf(stderr, "Cannot open telnet server port: %s\n", strerror(errno)); + exit(1); + } while (1) { osmo_select_main(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/31183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I0210b535b844529e217fd5d6ffb01f94a262dc9c Gerrit-Change-Number: 31183 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: rspro_server: Handle ipa_server_link_ipen() error case

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31181 ) Change subject: rspro_server: Handle ipa_server_link_ipen() error case ...................................................................... rspro_server: Handle ipa_server_link_ipen() error case >>> CID 307530: Error handling issues (CHECKED_RETURN) >>> Calling "ipa_server_link_open" without checking return value (as is done elsewhere 4 out of 5 times). Closes: COD#307530 Change-Id: Ic32d53a236b80711651fb4ee196ac3b95148e61f --- M src/server/rspro_server.c 1 file changed, 13 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/81/31181/1 diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 550179d..27f9a99 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -844,6 +844,7 @@ { struct rspro_server *srv = talloc_zero(ctx, struct rspro_server); + int rc; OSMO_ASSERT(srv); pthread_rwlock_init(&srv->rwlock, NULL); @@ -854,14 +855,21 @@ pthread_rwlock_unlock(&srv->rwlock); srv->link = ipa_server_link_create(ctx, NULL, host, port, accept_cb, srv); - if (!srv->link) { - talloc_free(srv); - return NULL; - } + if (!srv->link) + goto out_free; - ipa_server_link_open(srv->link); + rc = ipa_server_link_open(srv->link); + if (rc < 0) + goto out_destroy; return srv; + +out_destroy: + ipa_server_link_destroy(srv->link); +out_free: + talloc_free(srv); + + return NULL; } void rspro_server_destroy(struct rspro_server *srv) -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic32d53a236b80711651fb4ee196ac3b95148e61f Gerrit-Change-Number: 31181 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: bankd_main: Avoid uninitialized variable

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31182 ) Change subject: bankd_main: Avoid uninitialized variable ...................................................................... bankd_main: Avoid uninitialized variable There's not really any ResultCode for the kind of error we encounter, but sending some uninitialized memory clearly is not the right way either. >>> CID 307528: Uninitialized variables (UNINIT) >>> Using uninitialized value "res". Closes: CID#307528 Change-Id: I29f911cb2c8ad67cf1ce4486e1583612fb0b98a6 --- M src/bankd/bankd_main.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/82/31182/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 90b05d8..e002b94 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -716,6 +716,7 @@ if (worker->state != BW_ST_CONN_WAIT_ID) { LOGW(worker, "Unexpected connectClientReq\n"); + res = ResultCode_illegalClientId; rc = -102; goto respond_and_err; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I29f911cb2c8ad67cf1ce4486e1583612fb0b98a6 Gerrit-Change-Number: 31182 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: remsim_server: handle osmo_fd_register() failure case

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31180 ) Change subject: remsim_server: handle osmo_fd_register() failure case ...................................................................... remsim_server: handle osmo_fd_register() failure case >>> CID 307531: Error handling issues (CHECKED_RETURN) >>> Calling "osmo_fd_register" without checking return value (as is done elsewhere 83 out of 97 times). Closes: CID#307531 Change-Id: I7c2448303fba7caa27df65ac5f4d91ddf232ceb6 --- M src/server/remsim_server.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/80/31180/1 diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index fad0b14..3687f15 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -124,13 +124,15 @@ if (rc < 0) goto out_rps; osmo_fd_setup(&g_event_ofd, rc, OSMO_FD_READ, event_fd_cb, g_rps, 0); - osmo_fd_register(&g_event_ofd); + rc = osmo_fd_register(&g_event_ofd); + if (rc < 0) + goto out_eventfd; signal(SIGUSR1, handle_sig_usr1); rc = rest_api_init(talloc_rest_ctx, 9997); if (rc < 0) - goto out_eventfd; + goto out_unregister; while (1) { osmo_select_main(0); @@ -140,6 +142,8 @@ exit(0); +out_unregister: + osmo_fd_unregister(&g_event_ofd); out_eventfd: close(g_event_ofd.fd); out_rps: -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I7c2448303fba7caa27df65ac5f4d91ddf232ceb6 Gerrit-Change-Number: 31180 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-remsim[master]: Fix various 'uninitialized variable' bugs reported by coverity

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/31178 ) Change subject: Fix various 'uninitialized variable' bugs reported by coverity ...................................................................... Fix various 'uninitialized variable' bugs reported by coverity The asn1c-generated struct definitions have an automatic _asn_ctx member, and we never initialize that so far. Let's do an explicit memset(). Closes: CID#307545, CID#307543, CID#307541, CID#307536, CID#307536 Closes: CID#307534 Change-Id: I217ebbc92935aefaf55d19a14c93a24e5b8fce64 --- M src/rspro_util.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/78/31178/1 diff --git a/src/rspro_util.c b/src/rspro_util.c index 2ea6caf..23bb839 100644 --- a/src/rspro_util.c +++ b/src/rspro_util.c @@ -515,6 +515,7 @@ void bank_slot2rspro(BankSlot_t *out, const struct bank_slot *in) { + memset(out, 0, sizeof(*out)); out->bankId = in->bank_id; out->slotNr = in->slot_nr; } @@ -527,6 +528,7 @@ void client_slot2rspro(ClientSlot_t *out, const struct client_slot *in) { + memset(out, 0, sizeof(*out)); out->clientId = in->client_id; out->slotNr = in->slot_nr; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/31178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I217ebbc92935aefaf55d19a14c93a24e5b8fce64 Gerrit-Change-Number: 31178 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023