December 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: gbproy/ns: Make components alive

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35228?usp=email ) Change subject: gbproy/ns: Make components alive ...................................................................... gbproy/ns: Make components alive Might help with random test failures on shutdown, see OS#6273 for details. Change-Id: I59578934c6406bea5eb8d55d3641737e555a2d85 Related: OS#6273 --- M gbproxy/GBProxy_Tests.ttcn M library/NS_Emulation.ttcnpp M library/NS_Provider_FR.ttcn M library/RAW_NS.ttcnpp 4 files changed, 20 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/35228/1 diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn index e5bec7d..7a6572a 100644 --- a/gbproxy/GBProxy_Tests.ttcn +++ b/gbproxy/GBProxy_Tests.ttcn @@ -702,7 +702,7 @@ pars.p_tmsi := omit; } - vc_conn := BSSGP_ConnHdlr.create(id); + vc_conn := BSSGP_ConnHdlr.create(id) alive; log("Starting ", id, " for SGSN[", sgsn_idx, "], NRI=", nri, ", P-TMSI=", pars.p_tmsi, ", TLLI=", pars.tlli, ", IMSI=", pars.imsi, " on component=", vc_conn); diff --git a/library/NS_Emulation.ttcnpp b/library/NS_Emulation.ttcnpp index b5fc807..d1700f8 100644 --- a/library/NS_Emulation.ttcnpp +++ b/library/NS_Emulation.ttcnpp @@ -319,7 +319,7 @@ /* Create ipep and add it to the list */ log("Creating NSIP provider for ", ipep.local_ip, ":", ipep.local_udp_port); - ipep.provider_ct := NS_Provider_IPL4_CT.create(nsvc_id & "-provIP"); + ipep.provider_ct := NS_Provider_IPL4_CT.create(nsvc_id & "-provIP") alive; connect(self:NSPIP_PROC, ipep.provider_ct:PROC); ipep.provider_ct.start(NS_Provider_IPL4.main(nsvc_cfg, g_config, nsvc_id)); g_ip_endpoints := g_ip_endpoints & { ipep }; @@ -343,7 +343,7 @@ /* Start the actual NSVC component */ te.cfg := nsvc_cfg; - te.vc_conn := NSVC_CT.create(nsvc_id); + te.vc_conn := NSVC_CT.create(nsvc_id) alive; te.state := NSVC_S_DEAD_BLOCKED; connect(self:NSVC, te.vc_conn:NS_SP); @@ -721,7 +721,7 @@ vc_NSP_IP := nsp_ip #ifdef NS_EMULATION_FR } else if (ischosen(g_nsvc_config.provider.fr)) { - vc_NSP_FR := NS_Provider_FR_CT.create(id & "-provFR"); + vc_NSP_FR := NS_Provider_FR_CT.create(id & "-provFR") alive; connect(self:NSCP, vc_NSP_FR:NSE); vc_NSP_FR.start(NS_Provider_FR.main(g_nsvc_config, g_config, id)); #endif diff --git a/library/NS_Provider_FR.ttcn b/library/NS_Provider_FR.ttcn index eb2fb24..b664b5e 100644 --- a/library/NS_Provider_FR.ttcn +++ b/library/NS_Provider_FR.ttcn @@ -30,7 +30,7 @@ function main(NSVCConfiguration config, NSConfiguration nsconfig, charstring id) runs on NS_Provider_FR_CT system af_packet { /* start Frame Relay Emulation */ - vc_FREMU := FR_Emulation_CT.create(id & "-FRemu"); + vc_FREMU := FR_Emulation_CT.create(id & "-FRemu") alive; var Q933em_Config q933_cfg := valueof(ts_Q933em_Config(ats_is_user := not nsconfig.role_sgsn, bidirectional := false)); q933_cfg.T391 := 1.0; map(vc_FREMU:FR, system:AF_PACKET) param (config.provider.fr.netdev); diff --git a/library/RAW_NS.ttcnpp b/library/RAW_NS.ttcnpp index 6930a72..da1a0cc 100644 --- a/library/RAW_NS.ttcnpp +++ b/library/RAW_NS.ttcnpp @@ -103,7 +103,7 @@ } ip_prov[prov_idx].local_ip := ns_config.nsvc[idx].provider.ip.local_ip; ip_prov[prov_idx].local_udp_port := ns_config.nsvc[idx].provider.ip.local_udp_port; - ip_prov[prov_idx].vc_NSP_IP := NS_Provider_IPL4_CT.create(id & "-provIP" & int2str(prov_idx)); + ip_prov[prov_idx].vc_NSP_IP := NS_Provider_IPL4_CT.create(id & "-provIP" & int2str(prov_idx)) alive; connect(self:NSPIP_PROC, ip_prov[prov_idx].vc_NSP_IP:PROC); ip_prov[prov_idx].vc_NSP_IP.start(NS_Provider_IPL4.main(ns_config.nsvc[idx], ns_config, id)); } @@ -112,7 +112,7 @@ /* the NS_PROV_LINK_STATUS_UP is not sent by the NS_Provider_IPL4 because we connect the port manual */ #ifdef NS_EMULATION_FR } else if (ischosen(ns_config.nsvc[idx].provider.fr)) { - vc_NSP_FR[idx] := NS_Provider_FR_CT.create(id & "-provFR"); + vc_NSP_FR[idx] := NS_Provider_FR_CT.create(id & "-provFR") alive; connect(self:NSCP[idx], vc_NSP_FR[idx]:NSE); vc_NSP_FR[idx].start(NS_Provider_FR.main(ns_config.nsvc[idx], ns_config, id)); NSCP[idx].receive(NS_Provider_Evt:{link_status:=NS_PROV_LINK_STATUS_UP}); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I59578934c6406bea5eb8d55d3641737e555a2d85 Gerrit-Change-Number: 35228 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: Allow receiving MTU ICMPv6 Option in RouterAdv

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35227?usp=email ) Change subject: ggsn: Allow receiving MTU ICMPv6 Option in RouterAdv ...................................................................... ggsn: Allow receiving MTU ICMPv6 Option in RouterAdv This Option is not mandatory, but open5gs-smfd started transmitting it recently (ab64ff9514d8da121500be7b92c9d793ef20b894). Allow it. Change-Id: Icf3e10dc599d41fb65051670fc3aec5ff0c67510 --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 25 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/35227/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 118f1d5..435f71d 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -976,6 +976,16 @@ } } + /* template for receiving/matching an ICMPv6 'MTU' option, rfc4861 4.6.4 */ + template (present) OptionField tr_ICMP6_OptMTU(template (present) integer mtu := ?) := { + mTU := { + typeField := 5, + lengthIndicator := 1, + reserved := ?, + mTU_Value := mtu + } + } + /* template for receiving/matching an ICMPv6 router advertisement */ template (present) PDU_ICMPv6 tr_ICMPv6_RA(template (present) OCT16 prefix, template (present) INT1 prefix_len) := { routerAdvertisement := { @@ -989,9 +999,9 @@ routerLifetime := ?, reachableTime := ?, retransTimer := ?, - options := { - tr_ICMP6_OptPrefix(prefix, prefix_len) - } + options := ({ tr_ICMP6_OptPrefix(prefix, prefix_len) }, + { tr_ICMP6_OptPrefix(prefix, prefix_len), tr_ICMP6_OptMTU } + ) } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icf3e10dc599d41fb65051670fc3aec5ff0c67510 Gerrit-Change-Number: 35227 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: Fix restriction type on several template definitions

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35226?usp=email ) Change subject: ggsn: Fix restriction type on several template definitions ...................................................................... ggsn: Fix restriction type on several template definitions Change-Id: I47a0c3fbf1b4078c2d8157b148330f7750cc3266 --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 26 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/35226/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 48cf725..118f1d5 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -819,7 +819,7 @@ const octetstring c_neigh_solicit:= '6000000000203afffe800000000000000000000000000002ff0200000000000000000001ff00000287009f9600000000fe80000000000000000000000000000201010288b51f2559'O; /* template for sending an ICMPv4 echo request */ - template PDU_ICMP ts_ICMPv4_ERQ(octetstring data := ''O) := { + template (value) PDU_ICMP ts_ICMPv4_ERQ(octetstring data := ''O) := { echo := { type_field := 8, code := 0, @@ -831,7 +831,7 @@ } /* template for receiving/matching an ICMPv4 echo request */ - template PDU_ICMP tr_ICMPv4_ERQ := { + template (present) PDU_ICMP tr_ICMPv4_ERQ := { echo := { type_field := 8, code := 0, @@ -843,7 +843,7 @@ } /* template for receiving/matching an ICMPv4 echo reply */ - template PDU_ICMP tr_ICMPv4_ERP(template octetstring data := *) := { + template (present) PDU_ICMP tr_ICMPv4_ERP(template octetstring data := *) := { echo_reply := { type_field := 0, code := 0, @@ -855,7 +855,7 @@ } /* template for receiving/matching an ICMPv6 Destination Unreachable */ - template PDU_ICMP tr_ICMPv4_DU := { + template (present) PDU_ICMP tr_ICMPv4_DU := { destination_unreachable := { type_field := 1, code := ?, @@ -866,7 +866,7 @@ } /* template to construct IPv4_packet from input arguments, ready for use in f_IPv4_enc() */ - template IPv4_packet ts_IP4(OCT4 srcaddr, OCT4 dstaddr, LIN1 proto, LIN2_BO_LAST tlen, octetstring payload) := { + template (value) IPv4_packet ts_IP4(OCT4 srcaddr, OCT4 dstaddr, LIN1 proto, LIN2_BO_LAST tlen, octetstring payload) := { header := { ver := 4, hlen := 5, @@ -888,7 +888,7 @@ } /* template to generate a 'Prefix Information' ICMPv6 option */ - template OptionField ts_ICMP6_OptPrefix(OCT16 prefix, INT1 prefix_len) := { + template (value) OptionField ts_ICMP6_OptPrefix(OCT16 prefix, INT1 prefix_len) := { prefixInformation := { typeField := 3, lengthIndicator := 8, @@ -904,7 +904,7 @@ } /* template for sending an ICMPv6 echo request */ - template PDU_ICMPv6 ts_ICMPv6_ERQ := { + template (value) PDU_ICMPv6 ts_ICMPv6_ERQ := { echoRequest := { typeField := 128, code := 0, @@ -916,7 +916,7 @@ } /* template for sending an ICMPv6 router solicitation */ - template PDU_ICMPv6 ts_ICMPv6_RS := { + template (value) PDU_ICMPv6 ts_ICMPv6_RS := { routerSolicitation := { typeField := 133, code := 0, @@ -928,12 +928,12 @@ } /* template for sending an ICMPv6 router advertisement */ - template PDU_ICMPv6 ts_ICMPv6_RA(OCT16 prefix, INT1 prefix_len) := { + template (value) PDU_ICMPv6 ts_ICMPv6_RA(OCT16 prefix, INT1 prefix_len) := { routerAdvertisement := { typeField := 134, code := 0, checksum := '0000'O, - curHopLimit := ?, + curHopLimit := 0, reserved := '000000'B, o_Bit := '0'B, m_Bit := '0'B, @@ -947,7 +947,7 @@ } /* template for sending an ICMPv6 neighbor solicitation */ - template PDU_ICMPv6 ts_ICMPv6_NS(OCT16 target_addr) := { + template (value) PDU_ICMPv6 ts_ICMPv6_NS(OCT16 target_addr) := { neighborSolicitation := { typeField := 135, code := 0, @@ -961,7 +961,7 @@ /* derive ICMPv6 link-local address from lower 64bit of link_id */ /* template for receiving/matching an ICMPv6 'Prefix Information' option */ - template OptionField tr_ICMP6_OptPrefix(template OCT16 prefix, template INT1 prefix_len) := { + template (present) OptionField tr_ICMP6_OptPrefix(template (present) OCT16 prefix, template (present) INT1 prefix_len) := { prefixInformation := { typeField := 3, lengthIndicator := 4, @@ -977,7 +977,7 @@ } /* template for receiving/matching an ICMPv6 router advertisement */ - template PDU_ICMPv6 tr_ICMPv6_RA(template OCT16 prefix, template INT1 prefix_len) := { + template (present) PDU_ICMPv6 tr_ICMPv6_RA(template (present) OCT16 prefix, template (present) INT1 prefix_len) := { routerAdvertisement := { typeField := 134, code := 0, @@ -996,7 +996,7 @@ } /* template for receiving/matching an ICMPv6 Destination Unreachable */ - template PDU_ICMPv6 tr_ICMPv6_DU := { + template (present) PDU_ICMPv6 tr_ICMPv6_DU := { destinationUnreachable := { typeField := 1, code := ?, @@ -1007,7 +1007,7 @@ } /* template for receiving/matching an ICMPv6 echo request */ - template PDU_ICMPv6 tr_ICMPv6_ERQ := { + template (present) PDU_ICMPv6 tr_ICMPv6_ERQ := { echoRequest := { typeField := 128, code := 0, @@ -1019,7 +1019,7 @@ } /* template for receiving/matching an ICMPv6 echo reply */ - template PDU_ICMPv6 tr_ICMPv6_ERP(template octetstring data := *) := { + template (present) PDU_ICMPv6 tr_ICMPv6_ERP(template octetstring data := *) := { echoReply := { typeField := 129, code := 0, @@ -1031,7 +1031,7 @@ } /* template to construct IPv6_packet from input arguments, ready for use in f_IPv6_enc() */ - template IPv6_packet ts_IP6(OCT16 srcaddr, OCT16 dstaddr, LIN1 nexthead, octetstring payload, LIN1 hlim := 255) := { + template (value) IPv6_packet ts_IP6(OCT16 srcaddr, OCT16 dstaddr, LIN1 nexthead, octetstring payload, LIN1 hlim := 255) := { header := { ver := 6, trclass := 0, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I47a0c3fbf1b4078c2d8157b148330f7750cc3266 Gerrit-Change-Number: 35226 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[M] Change in osmo-ci[master]: OBS: add jenkins job to check for new distros

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35223?usp=email ) Change subject: OBS: add jenkins job to check for new distros ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I wonder whether we really want to be checking this everyday, given that some of them happen every 6 […] the check itself takes about 5 seconds, I think it is fine :) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0abc49a95197da55f7d83ed4fd1c4ebb6bd14b1e Gerrit-Change-Number: 35223 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Dec 2023 13:33:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: Early exit test if f_wait_icmp6() fails

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35225?usp=email ) Change subject: ggsn: Early exit test if f_wait_icmp6() fails ...................................................................... ggsn: Early exit test if f_wait_icmp6() fails Change-Id: Ida6be6194f98de44dca804759c85016031cae61c --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/35225/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index d6a0403..48cf725 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -1184,8 +1184,8 @@ alt { [] GTPU.receive(tr_GTPU_GPDU(g_peer_u, ?)) -> value ud { if (f_verify_gtpu_txseq(ud.gtpu, use_gtpu_txseq) == false) { - setverdict(fail); - stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Received GTPU with wrong txseq while waiting for ICMPv6: ", expected)); } var octetstring gpdu := ud.gtpu.gtpu_IEs.g_PDU_IEs.data; var IPv6_packet ip6 := f_IPv6_dec(gpdu); @@ -1203,8 +1203,14 @@ } } [] GTPU.receive(tr_GTPU_GPDU(?, ?)) { repeat; } - [] GTPU.receive { setverdict(fail); } - [] T_default.timeout { setverdict(fail); } + [] GTPU.receive { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Received unexpected GTPU while waiting for ICMPv6: ", expected)); + } + [] T_default.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Timeout waiting for ICMPv6: ", expected)); + } } T_default.stop; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35225?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ida6be6194f98de44dca804759c85016031cae61c Gerrit-Change-Number: 35225 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/osmocom-obs-sync: add newest Ubuntu, Raspbian

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35221?usp=email ) Change subject: jobs/osmocom-obs-sync: add newest Ubuntu, Raspbian ...................................................................... jobs/osmocom-obs-sync: add newest Ubuntu, Raspbian Related: OS#6163 Change-Id: I459bd48b50d80fcd07837377e19e89df21d6c328 --- M jobs/osmocom-obs-sync.yml 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/osmocom-obs-sync.yml b/jobs/osmocom-obs-sync.yml index fef1e83..53ae0b3 100644 --- a/jobs/osmocom-obs-sync.yml +++ b/jobs/osmocom-obs-sync.yml @@ -36,9 +36,11 @@ Debian:Testing Raspbian:10 Raspbian:11 + Raspbian:12 Ubuntu:20.04 Ubuntu:22.04 Ubuntu:23.04 + Ubuntu:23.10 " ./scripts/obs/sync_obs_projects.py \ --docker \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I459bd48b50d80fcd07837377e19e89df21d6c328 Gerrit-Change-Number: 35221 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in osmo-pcu[master]: bts: rename struct member gen_idle_blocks to gen_idle_blocks_C0

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35224?usp=email ) Change subject: bts: rename struct member gen_idle_blocks to gen_idle_blocks_C0 ...................................................................... bts: rename struct member gen_idle_blocks to gen_idle_blocks_C0 The struct member gen_idle_blocks controls whether the the PCU has to generate dummy blocks to fill idle periods or if this task is left to the BTS hardware. Since idle dummy blocks only have to be transmitted on the C0 carrier, we should rename the gen_idle_blocks struct member to gen_idle_blocks_C0. Related: OS#6198 Change-Id: If9511ed911f9c5d6d463881a387a9e7d11a15465 --- M src/bts.h M src/gprs_rlcmac_sched.cpp M src/pcu_l1_if.cpp 3 files changed, 22 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/24/35224/1 diff --git a/src/bts.h b/src/bts.h index 86c161b..380c47c 100644 --- a/src/bts.h +++ b/src/bts.h @@ -282,7 +282,7 @@ /* When the PDCH is idle, the timeslot is expected to transmit dummy blocks. Some BTS models will generate * those dummy blocks automatically when no data is transmitted. In contrast, other BTS models may require a * continuous stream of PDCH blocks that already has the gaps filled with dummy blocks. */ - bool gen_idle_blocks; + bool gen_idle_blocks_C0; }; struct paging_req_cs { diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp index 12b9e50..ac58121 100644 --- a/src/gprs_rlcmac_sched.cpp +++ b/src/gprs_rlcmac_sched.cpp @@ -488,7 +488,7 @@ + pdch->num_tbfs(GPRS_RLCMAC_UL_TBF); bool skip_idle = (num_tbfs == 0); - if (bts->gen_idle_blocks) + if (bts->gen_idle_blocks_C0) skip_idle = skip_idle && trx != 0; if (!skip_idle && (msg = sched_dummy())) { diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 07082d3..fb44bd8 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -552,7 +552,7 @@ + pdch->num_tbfs(GPRS_RLCMAC_UL_TBF); bool skip_idle = (num_tbfs == 0); - if (bts->gen_idle_blocks) + if (bts->gen_idle_blocks_C0) skip_idle = skip_idle && trx != 0; if (skip_idle) { @@ -966,7 +966,7 @@ LOGP(DL1IF, LOGL_INFO, "BTS model: %s\n", get_value_string(gsm_pcuif_bts_model_names, info_ind->bts_model)); bts->bts_model = info_ind->bts_model; - bts->gen_idle_blocks = decide_gen_idle_blocks(bts); + bts->gen_idle_blocks_C0 = decide_gen_idle_blocks(bts); bts->active = true; return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If9511ed911f9c5d6d463881a387a9e7d11a15465 Gerrit-Change-Number: 35224 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[M] Change in osmo-ci[master]: OBS: add jenkins job to check for new distros

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35223?usp=email ) Change subject: OBS: add jenkins job to check for new distros ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I wonder whether we really want to be checking this everyday, given that some of them happen every 6 months or so. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0abc49a95197da55f7d83ed4fd1c4ebb6bd14b1e Gerrit-Change-Number: 35223 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Dec 2023 13:08:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-ci[master]: OBS: lib.osc.get_projects: print apiurl

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35222?usp=email ) Change subject: OBS: lib.osc.get_projects: print apiurl ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35222?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I789d12ce59ff14f526ab0334e78a6b22a063ec06 Gerrit-Change-Number: 35222 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Dec 2023 13:06:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/osmocom-obs-sync: add newest Ubuntu, Raspbian

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35221?usp=email ) Change subject: jobs/osmocom-obs-sync: add newest Ubuntu, Raspbian ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I459bd48b50d80fcd07837377e19e89df21d6c328 Gerrit-Change-Number: 35221 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Dec 2023 13:04:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2023