December 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-mgw[master]: cosmetic: Fix line indentation

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35220?usp=email ) Change subject: cosmetic: Fix line indentation ...................................................................... cosmetic: Fix line indentation Change-Id: I85e47894aa0ed54dbf22a7a88d8cbeadaad4b248 --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/20/35220/1 diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index b5897a6..ceb9592 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -1347,7 +1347,7 @@ for (i = 0; i < mgcp_msg->codecs_len; i++) { /* The following is only applicable for AMR */ if (mgcp_msg->codecs[i] != CODEC_AMR_8000_1 && mgcp_msg->codecs[i] != CODEC_AMRWB_16000_1) - continue; + continue; pt = map_codec_to_pt(mgcp_msg->ptmap, mgcp_msg->ptmap_len, mgcp_msg->codecs[i]); if (mgcp_msg->param.amr_octet_aligned_present && mgcp_msg->param.amr_octet_aligned) MSGB_PRINTF_OR_RET("a=fmtp:%u octet-align=1\r\n", pt); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35220?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I85e47894aa0ed54dbf22a7a88d8cbeadaad4b248 Gerrit-Change-Number: 35220 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[M] Change in libosmocore[master]: socket: Introduce API osmo_sock_multiaddr_get_name_buf()

by pespin

Attention is currently required from: laforge, neels, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35180?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: socket: Introduce API osmo_sock_multiaddr_get_name_buf() ...................................................................... socket: Introduce API osmo_sock_multiaddr_get_name_buf() Change-Id: I48950754ed6f61ee5ffa04a447fab8903f10acc0 --- M TODO-RELEASE M include/osmocom/core/socket.h M src/core/libosmocore.map M src/core/socket.c 4 files changed, 107 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/35180/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I48950754ed6f61ee5ffa04a447fab8903f10acc0 Gerrit-Change-Number: 35180 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 6 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: epdg_gtpc_s2b: fix encoding of the IP address

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35219?usp=email ) Change subject: epdg_gtpc_s2b: fix encoding of the IP address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6a96f5d62fa0b327a462670e40cc6a42cf6b2d3c Gerrit-Change-Number: 35219 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 05 Dec 2023 12:16:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[M] Change in ...osmo-epdg[master]: epdg_gtpc_s2b: add TLV Serving Network

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35218?usp=email ) Change subject: epdg_gtpc_s2b: add TLV Serving Network ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35218/comment/d0a6f587_8f0b… PS1, Line 338: plmn_id = gtp_utils:plmn_to_bin(?MCC, ?MNC, ?MNC_SIZE) this will need to come from CEAI interface at some point? from strongswan I mean. Or maybe as a config option? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35218?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I2a9459859fc660e6433cd8178ab9d1f92ae74fc0 Gerrit-Change-Number: 35218 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 05 Dec 2023 12:13:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: dia: 3gpp_ts29_273_s6b: add missing include of rfc4004

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35217?usp=email ) Change subject: dia: 3gpp_ts29_273_s6b: add missing include of rfc4004 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35217/comment/22bb3831_30d3… PS1, Line 9: Erlang compiler doesn't track includes of includes resulting in missing AVPs. Erlang diameter compiler. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I986154f057f84e131845f6aff79e3ec81aea6a81 Gerrit-Change-Number: 35217 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 05 Dec 2023 12:12:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAR

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAR ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: This is wrong. Youy are mentioning AAR in commit description, but modifying AAA. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I934c87e912882ddef1cbac1466dec66c72b9c77c Gerrit-Change-Number: 35216 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 05 Dec 2023 12:11:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAR

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email ) Change subject: dia: 3gpp_ts29_273_s6b: add missing *[ AVP ] to AAR ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I934c87e912882ddef1cbac1466dec66c72b9c77c Gerrit-Change-Number: 35216 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 05 Dec 2023 12:11:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[M] Change in osmo-bsc[master]: Make BSSGP timing data configurable

by pespin

Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email ) Change subject: Make BSSGP timing data configurable ...................................................................... Patch Set 8: (5 comments) File include/osmocom/bsc/vty.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31882/comment/c7ac3904_99c10ccd PS8, Line 106: /* Add additional group strings for vty command generation here */ IMHOyou should in general avoid filling your commits in a patchset with this type of comments which only make them more complex to review. This kind of stuff is for you keep private during dev imho. File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31882/comment/59055467_74eb3aaf PS8, Line 323: /* TODO: Add other options for group argument bssgp '[(rlc|bssgp|ns)]' when adding additional timer groups. Same with this one. File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31882/comment/6814fd72_fbcff715 PS8, Line 212: .t1_s = osmo_tdef_get(g->tdefs, 1, OSMO_TDEF_S, -1), so you added defines for timers 1..4 but you are not using them? File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31882/comment/00deb420_fbbce117 PS8, Line 1704: struct tdef_data gprs_bssgp_timer_tdef_data[11] = { I still find this is most probably not needed. You can probably change the indices in gprs_bssgp_cfg_strs to directly be the GSM_BTS_TDEF_ID_BSSGP_* values? https://gerrit.osmocom.org/c/osmo-bsc/+/31882/comment/6f2ae417_4db4b14d PS8, Line 1741: int idx = get_string_value(gprs_bssgp_cfg_strs, argv[0]), val = atoi(argv[1]); definetly not in a single line. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id4779f033b5eb1742462d4efc28a0398645acfe6 Gerrit-Change-Number: 31882 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Dec 2023 12:10:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[M] Change in osmo-bsc[master]: Make NSE timing data configurable

by pespin

Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31880?usp=email ) Change subject: Make NSE timing data configurable ...................................................................... Patch Set 7: (5 comments) File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/e1361416_f0442e57 PS7, Line 347: extern const size_t bts_gprs_rlc_timer_templates_bytes; why is this being removed here? it probably should be removed in the previous commit? File src/osmo-bsc/bts_init.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/73d560f5_01f82f49 PS7, Line 111: /* Init per-BTS NS timers */ it will probably help adding an extra blank line before this one. File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/49d596a6_1cb99518 PS7, Line 1662: static const struct tdef_data gprs_ns_timer_tdef_data[7] = { I'm still totally not understanding why do you need this index lookup here. If you want to keep the older indices to keep backward compatibilities, why not using those same timer names in the tdef structure? File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/3ada7b05_d99d0ee3 PS7, Line 225: g = &bts->timer_groups[OSMO_BSC_BTS_TDEF_GROUPS_RLC]; you could fix your proper commit and already use this name so you don't need to change it in the followup commit (and save my time reviewing it). File tests/gprs_params.vty: https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/f5b24ba8_fc25acc3 PS7, Line 36: gprs nsei 0 why did the timers dissappear here? because they are the default values? then ACK. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie46ec5cb7095bc1dfe3effd0e76d6ccfd6bd2f3f Gerrit-Change-Number: 31880 Gerrit-PatchSet: 7 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Dec 2023 12:03:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[L] Change in osmo-bsc[master]: Introduce per-BTS timers, RLC timer commands

by pespin

Attention is currently required from: arehbein, fixeria, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email ) Change subject: Introduce per-BTS timers, RLC timer commands ...................................................................... Patch Set 17: (3 comments) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/4c9b74ec_01aa9c47 PS16, Line 235: > You could submit this a a preparation patch. This has been ignored. https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/22fb9289_e4403213 PS16, Line 346: if (bts->gprs.mode == BTS_GPRS_NONE) { > I looked at what current code does and no or most gprs command didn't work unless we're in gprs mode […] I think for setting timers is totally fine being able to configure them, otherwise config files are going to be failing if someone disables gprs temporarily. Please remove this check, I see no good use for it. https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/5a8d06ab_2271abb0 PS16, Line 351: ++group; > we tend to use group++ unless there's a good reason to use preinc. this comment was ignored. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2c24110d8c977d6cc74c3c8e77bcc709ad9d2675 Gerrit-Change-Number: 31878 Gerrit-PatchSet: 17 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Dec 2023 11:48:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2023