December 2023 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: ara_m: Fix encoding of DeviceInterfaceVersionDO

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35230?usp=email ) Change subject: ara_m: Fix encoding of DeviceInterfaceVersionDO ...................................................................... ara_m: Fix encoding of DeviceInterfaceVersionDO Ever since commit 30de9fd8abc9d7c2c541fea7fa4b97c4ca1a54eb in July we are (properly) using snake_case names in the from_dict (to become bijective with to_dict). This code was not updated by accident, creating an exception when using the `aram_get_config` Change-Id: If216b56b38ab17d13896074aa726278b9ba16923 Related: OS#6119 --- M pySim/ara_m.py 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/30/35230/1 diff --git a/pySim/ara_m.py b/pySim/ara_m.py index b4ac747..68244d1 100644 --- a/pySim/ara_m.py +++ b/pySim/ara_m.py @@ -295,7 +295,7 @@ @staticmethod def get_config(tp, v_major=0, v_minor=0, v_patch=1): cmd_do = DeviceConfigDO() - cmd_do.from_dict([{'DeviceInterfaceVersionDO': { + cmd_do.from_dict([{'device_interface_version_do': { 'major': v_major, 'minor': v_minor, 'patch': v_patch}}]) return ADF_ARAM.xceive_apdu_tlv(tp, '80cadf21', cmd_do, ResponseAramConfigDO) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If216b56b38ab17d13896074aa726278b9ba16923 Gerrit-Change-Number: 35230 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/gerrit: osmo-upf: don't for build debian 10

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35229?usp=email ) Change subject: jobs/gerrit: osmo-upf: don't for build debian 10 ...................................................................... jobs/gerrit: osmo-upf: don't for build debian 10 osmo-upf currently can't build against debian 10, as the required libnftables-dev version there is too low and we don't provide a backport for it. As discussed, disable it for debian 10. Adjust CI to build against debian 11 instead (in addition to the usual almalinux 8, debian 12). Change-Id: I63798d451b66bf728b58b02414c1a44f6156b356 --- M jobs/gerrit-verifications.yml 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 90c5fb5..2efac00 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -393,7 +393,8 @@ -e WITH_MANUALS="$WITH_MANUALS" \ {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - - osmo-upf + - osmo-upf: + pipeline_binpkgs: "almalinux:8 debian:11 debian:12" - pysim: concurrent: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I63798d451b66bf728b58b02414c1a44f6156b356 Gerrit-Change-Number: 35229 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/gerrit: osmo-upf: don't for build debian 10

by laforge

Attention is currently required from: jolly, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35229?usp=email ) Change subject: jobs/gerrit: osmo-upf: don't for build debian 10 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I63798d451b66bf728b58b02414c1a44f6156b356 Gerrit-Change-Number: 35229 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 05 Dec 2023 17:09:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-upf[master]: Use uniform log format for default config files

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Use uniform log format for default config files Related: OS#6272 Change-Id: I5f364aa88a020dd8a0de501b3547ad077457c616 --- M contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg M contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg M contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg M doc/examples/osmo-upf/osmo-upf-create-dev.cfg M doc/examples/osmo-upf/osmo-upf-mockup.cfg M doc/examples/osmo-upf/osmo-upf.cfg 6 files changed, 31 insertions(+), 15 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved laforge: Looks good to me, approved diff --git a/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg b/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg index a6d4635..ab4c4d4 100644 --- a/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg +++ b/contrib/osmo-pfcp-tool-scripts/osmo-pfcp-tool.cfg @@ -1,4 +1,10 @@ log stderr + logging color 1 + logging print category-hex 0 + logging print category 1 + logging timestamp 0 + logging print file basename last + logging print level 1 logging level set-all info local-addr 127.0.0.2 diff --git a/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg b/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg index d619f54..6655223 100644 --- a/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg +++ b/contrib/osmo-pfcp-tool-scripts/osmo-upf-11.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice logging level set-all info logging level session debug diff --git a/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg b/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg index 8b77417..b639e96 100644 --- a/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg +++ b/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice logging level set-all info logging level session debug diff --git a/doc/examples/osmo-upf/osmo-upf-create-dev.cfg b/doc/examples/osmo-upf/osmo-upf-create-dev.cfg index e69f49c..a4195b9 100644 --- a/doc/examples/osmo-upf/osmo-upf-create-dev.cfg +++ b/doc/examples/osmo-upf/osmo-upf-create-dev.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice timer pfcp x24 5000 diff --git a/doc/examples/osmo-upf/osmo-upf-mockup.cfg b/doc/examples/osmo-upf/osmo-upf-mockup.cfg index 1150c34..b5d5c5b 100644 --- a/doc/examples/osmo-upf/osmo-upf-mockup.cfg +++ b/doc/examples/osmo-upf/osmo-upf-mockup.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice timer pfcp x24 5000 diff --git a/doc/examples/osmo-upf/osmo-upf.cfg b/doc/examples/osmo-upf/osmo-upf.cfg index 77b6871..3477daa 100644 --- a/doc/examples/osmo-upf/osmo-upf.cfg +++ b/doc/examples/osmo-upf/osmo-upf.cfg @@ -1,11 +1,11 @@ log stderr logging filter all 1 logging color 1 - logging print level 1 - logging print category 1 logging print category-hex 0 + logging print category 1 + logging timestamp 0 logging print file basename last - logging print extended-timestamp 1 + logging print level 1 logging level set-all notice timer pfcp x24 5000 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I5f364aa88a020dd8a0de501b3547ad077457c616 Gerrit-Change-Number: 35200 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in osmo-upf[master]: Use uniform log format for default config files

by laforge

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email ) Change subject: Use uniform log format for default config files ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I5f364aa88a020dd8a0de501b3547ad077457c616 Gerrit-Change-Number: 35200 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 05 Dec 2023 17:09:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: Allow receiving MTU ICMPv6 Option in RouterAdv

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35227?usp=email ) Change subject: ggsn: Allow receiving MTU ICMPv6 Option in RouterAdv ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icf3e10dc599d41fb65051670fc3aec5ff0c67510 Gerrit-Change-Number: 35227 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Dec 2023 17:09:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: Fix restriction type on several template definitions

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35226?usp=email ) Change subject: ggsn: Fix restriction type on several template definitions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I47a0c3fbf1b4078c2d8157b148330f7750cc3266 Gerrit-Change-Number: 35226 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Dec 2023 17:08:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: Early exit test if f_wait_icmp6() fails

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35225?usp=email ) Change subject: ggsn: Early exit test if f_wait_icmp6() fails ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35225?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ida6be6194f98de44dca804759c85016031cae61c Gerrit-Change-Number: 35225 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Dec 2023 17:08:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in pysim[master]: perform multiple GET RESPONSE cycles if more data is available

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35215?usp=email ) Change subject: perform multiple GET RESPONSE cycles if more data is available ...................................................................... perform multiple GET RESPONSE cycles if more data is available So far we implemented only one round of "Send the APDU, get SW=61xx, call GET RESPONSE". This permitted us to receive only data up to 256 bytes. Let's extend that to doing multiple rounds, concatenating the result. This allows us to obtain arbitrary-length data from the card. See Annex C.1 of ETSI TS 102 221 for examples showing multiple 61xx iterations. Change-Id: Ib17da655aa0b0eb203c29dc92690c81bd1300778 Closes: OS#6287 --- M pySim/transport/__init__.py 1 file changed, 23 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py index e90ced6..2ffb9c3 100644 --- a/pySim/transport/__init__.py +++ b/pySim/transport/__init__.py @@ -137,11 +137,12 @@ # xx is the number of response bytes available. # See also: if (sw is not None): - if ((sw[0:2] == '9f') or (sw[0:2] == '61')): + while ((sw[0:2] == '9f') or (sw[0:2] == '61')): # SW1=9F: 3GPP TS 51.011 9.4.1, Responses to commands which are correctly executed # SW1=61: ISO/IEC 7816-4, Table 5 — General meaning of the interindustry values of SW1-SW2 pdu_gr = pdu[0:2] + 'c00000' + sw[2:4] - data, sw = self.send_apdu_raw(pdu_gr) + d, sw = self.send_apdu_raw(pdu_gr) + data += d if sw[0:2] == '6c': # SW1=6C: ETSI TS 102 221 Table 7.1: Procedure byte coding pdu_gr = pdu[0:8] + sw[2:4] -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib17da655aa0b0eb203c29dc92690c81bd1300778 Gerrit-Change-Number: 35215 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in pysim[master]: perform multiple GET RESPONSE cycles if more data is available

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35215?usp=email ) Change subject: perform multiple GET RESPONSE cycles if more data is available ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: rather trivial change, going ahead and merging it. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib17da655aa0b0eb203c29dc92690c81bd1300778 Gerrit-Change-Number: 35215 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 05 Dec 2023 17:07:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2023