November 2023 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: sigtran-tests: Add note on why this is still using buster

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34971?usp=email ) Change subject: sigtran-tests: Add note on why this is still using buster ...................................................................... sigtran-tests: Add note on why this is still using buster Change-Id: I403401be7e469085f9a82944b3eaa6b8c8ea6319 --- M sigtran-tests/Dockerfile 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/sigtran-tests/Dockerfile b/sigtran-tests/Dockerfile index 51cff39..1faf8c1 100644 --- a/sigtran-tests/Dockerfile +++ b/sigtran-tests/Dockerfile @@ -1,4 +1,7 @@ ARG USER +# needs buster as the code *really* requires old guile-2.0 +# which is not available in more modern distributions, see +# https://github.com/nplab/m3ua-testtool/issues/2 for more info FROM $USER/debian-buster-build -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34971?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I403401be7e469085f9a82944b3eaa6b8c8ea6319 Gerrit-Change-Number: 34971 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

[S] Change in docker-playground[master]: redmine: run 'apt upgrade' in Dockerfile to get glibc fix from Debian

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34970?usp=email ) Change subject: redmine: run 'apt upgrade' in Dockerfile to get glibc fix from Debian ...................................................................... redmine: run 'apt upgrade' in Dockerfile to get glibc fix from Debian https://lwn.net/ml/oss-security/20231003175031.GA16924@localhost.localdomai… Change-Id: Ice5c5e86cd519446fc59c09d64b20836f998d384 --- M redmine/Dockerfile 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified arehbein: Looks good to me, but someone else must approve diff --git a/redmine/Dockerfile b/redmine/Dockerfile index fc1ba89..d6125cb 100644 --- a/redmine/Dockerfile +++ b/redmine/Dockerfile @@ -1,6 +1,7 @@ FROM redmine:4.2-passenger RUN apt-get update && \ + apt-get -y upgrade && \ apt-get install -y --no-install-recommends \ graphviz \ imagemagick \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34970?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ice5c5e86cd519446fc59c09d64b20836f998d384 Gerrit-Change-Number: 34970 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

[S] Change in docker-playground[master]: sigtran-tests: Add note on why this is still using buster

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34971?usp=email ) Change subject: sigtran-tests: Add note on why this is still using buster ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34971?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I403401be7e469085f9a82944b3eaa6b8c8ea6319 Gerrit-Change-Number: 34971 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 07 Nov 2023 12:23:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in docker-playground[master]: redmine: run 'apt upgrade' in Dockerfile to get glibc fix from Debian

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34970?usp=email ) Change subject: redmine: run 'apt upgrade' in Dockerfile to get glibc fix from Debian ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34970?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ice5c5e86cd519446fc59c09d64b20836f998d384 Gerrit-Change-Number: 34970 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 07 Nov 2023 12:23:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-bsc[master]: SI10: Fix uninitialized last_i index

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34969?usp=email ) Change subject: SI10: Fix uninitialized last_i index ...................................................................... SI10: Fix uninitialized last_i index Not only l_bts must be declared outside the for-loop, but also last_i. This is a fixup of I9dbbd066075f9ccb331616a2b59b46b1b44c8b4c. Related: CID#330311 Change-Id: Ia10c5e68cb2940d9360d78f606af25bb207ee55f --- M src/osmo-bsc/system_information.c 1 file changed, 16 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 141a720..cc2e788 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1422,7 +1422,7 @@ { struct bitvec *nbv; struct gsm_bts *s_bts = conn->lchan->ts->trx->bts, *l_bts = NULL; - int i; + int i, last_i = -1; bool any_neighbor = false; int rc; @@ -1447,7 +1447,6 @@ struct gsm_subscriber_connection *c; unsigned int save_cur_bit; int16_t arfcn; - int last_i; arfcn = neigh_list_get_arfcn(s_bts, nbv, i); /* End of list */ if (arfcn < 0) @@ -1478,7 +1477,7 @@ save_cur_bit = bv.cur_bit; /* Nth neighbor, so add rest octets with differential cell info. */ LOGP(DRR, LOGL_INFO, "Append cell ID %d to SI 10.\n", n_bts->cell_identity); - OSMO_ASSERT(l_bts); + OSMO_ASSERT(l_bts && last_i >= 0); rc = si10_rest_octets_encode_other(s_bts, &bv, l_bts, n_bts, last_i, i); if (rc < 0) { LOGP(DRR, LOGL_INFO, "Skip cell ID %d, SI 10 would overflow.\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34969?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia10c5e68cb2940d9360d78f606af25bb207ee55f Gerrit-Change-Number: 34969 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

[S] Change in osmo-bsc[master]: SI10: Fix uninitialized last_i index

by laforge

Attention is currently required from: arehbein, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34969?usp=email ) Change subject: SI10: Fix uninitialized last_i index ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34969/comment/2b37ee52_8a7014a3 PS1, Line 1425: int i, last_i = -1; > iirc, we put initialized variables on their own line I'm not aware of a general rule for that. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34969?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia10c5e68cb2940d9360d78f606af25bb207ee55f Gerrit-Change-Number: 34969 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 12:22:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ci[master]: tarballs: git archive: make proper tar.bz2

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34978?usp=email ) Change subject: tarballs: git archive: make proper tar.bz2 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5830f9123150540a6467c19c64461d2fa1972a52 Gerrit-Change-Number: 34978 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 12:18:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ci[master]: tarballs: git archive: put files in directory

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34977?usp=email ) Change subject: tarballs: git archive: put files in directory ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If37dcdc04278de0d4479cf72e0ca33c90b7deea8 Gerrit-Change-Number: 34977 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 12:17:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ci[master]: tarballs: add osmo_dia2gsup

by fixeria

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34976?usp=email ) Change subject: tarballs: add osmo_dia2gsup ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34976?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9cbd3d3ce27a4b4c9c8e19b2876386d170d4f0a6 Gerrit-Change-Number: 34976 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 07 Nov 2023 12:16:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: logging: ensure ANSI color escape is sent in same line/before newline

by fixeria

Attention is currently required from: manawyrm, neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email ) Change subject: logging: ensure ANSI color escape is sent in same line/before newline ...................................................................... Patch Set 3: (1 comment) File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/34975/comment/ba8f6555_c83d7bc4 PS3, Line 623: "%s\n", OSMO_LOGCOLOR_END I think you can even do `OSMO_LOGCOLOR_END "\n"`, since `OSMO_LOGCOLOR_END` is defined as a string literal. Not sure how many CPU cycles this saves for us though. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Gerrit-Change-Number: 34975 Gerrit-PatchSet: 3 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 12:15:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2023