November 2023 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-hnbgw-test: reduce X31 to 5s

by fixeria

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34979?usp=email ) Change subject: ttcn3-hnbgw-test: reduce X31 to 5s ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I223d38e9ec2ca0f9f2ce2ac5311932789f328c9a Gerrit-Change-Number: 34979 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 07 Nov 2023 14:14:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: osmo-hnbgw.cfg: reduce X31 to 5s

by fixeria

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34980?usp=email ) Change subject: hnbgw: osmo-hnbgw.cfg: reduce X31 to 5s ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1c275a1d10cfe0fe67d71e900881b0c4891af0be Gerrit-Change-Number: 34980 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 07 Nov 2023 14:14:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-hnbgw-test: reduce X31 to 5s

by osmith

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34979?usp=email ) Change subject: ttcn3-hnbgw-test: reduce X31 to 5s ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: https://jenkins.osmocom.org/jenkins/job/osmith-ttcn3-hnbgw-test/1/console `<testsuite name='Titan' tests='40' failures='0' errors='0' skipped='0' inconc='0' time='301.00'>` -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I223d38e9ec2ca0f9f2ce2ac5311932789f328c9a Gerrit-Change-Number: 34979 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 13:25:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: osmo-hnbgw.cfg: reduce X31 to 5s

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34980?usp=email ) Change subject: hnbgw: osmo-hnbgw.cfg: reduce X31 to 5s ...................................................................... hnbgw: osmo-hnbgw.cfg: reduce X31 to 5s Set X31 to 5s as expected by the testsuite. The config files changed here are not used by jenkins, but are used for manual testing by some developers. Related: docker-playground I223d38e9ec2ca0f9f2ce2ac5311932789f328c9a Change-Id: I1c275a1d10cfe0fe67d71e900881b0c4891af0be --- M hnbgw/osmo-hnbgw-with-pfcp.cfg M hnbgw/osmo-hnbgw.cfg 2 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/34980/1 diff --git a/hnbgw/osmo-hnbgw-with-pfcp.cfg b/hnbgw/osmo-hnbgw-with-pfcp.cfg index 550657b..6407e41 100644 --- a/hnbgw/osmo-hnbgw-with-pfcp.cfg +++ b/hnbgw/osmo-hnbgw-with-pfcp.cfg @@ -71,6 +71,9 @@ local-addr 127.0.0.2 local-port 8805 timer pfcp x26 5 + # reduce default X31 from 15 seconds + # https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922 + timer hnbgw X31 5 msc 0 remote-addr msc-naught diff --git a/hnbgw/osmo-hnbgw.cfg b/hnbgw/osmo-hnbgw.cfg index 3ccc28d..60f0aba 100644 --- a/hnbgw/osmo-hnbgw.cfg +++ b/hnbgw/osmo-hnbgw.cfg @@ -51,6 +51,9 @@ hnbap-allow-tmsi 1 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 + # reduce default X31 from 15 seconds + # https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922 + timer hnbgw X31 5 msc 0 remote-addr msc-naught -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1c275a1d10cfe0fe67d71e900881b0c4891af0be Gerrit-Change-Number: 34980 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-hnbgw-test: reduce X31 to 5s

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34979?usp=email ) Change subject: ttcn3-hnbgw-test: reduce X31 to 5s ...................................................................... ttcn3-hnbgw-test: reduce X31 to 5s Set X31 to 5s as expected by the testsuite to fix currently failing: - TC_ranap_cs_mo_disconnect - TC_ranap_ps_mo_disconnect It was recently increased to 15s in the related patch. Related: osmo-hnbgw I24225cfc0addf326c239ec658a27b93b83a3e751 Change-Id: I223d38e9ec2ca0f9f2ce2ac5311932789f328c9a --- M ttcn3-hnbgw-test/osmo-hnbgw.cfg M ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg 2 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/79/34979/1 diff --git a/ttcn3-hnbgw-test/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/osmo-hnbgw.cfg index 377fad8..bed6f51 100644 --- a/ttcn3-hnbgw-test/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/osmo-hnbgw.cfg @@ -73,6 +73,9 @@ mgw remote-ip 172.18.35.203 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 + # reduce default X31 from 15 seconds + # https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922 + timer hnbgw X31 5 msc 0 remote-addr msc-naught diff --git a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg index 1d11602..d10ea6d 100644 --- a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg @@ -80,6 +80,9 @@ local-port 8805 # send PFCP Assoc Setup Req more often timer pfcp x26 5 + # reduce default X31 from 15 seconds + # https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922 + timer hnbgw X31 5 msc 0 remote-addr msc-naught -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I223d38e9ec2ca0f9f2ce2ac5311932789f328c9a Gerrit-Change-Number: 34979 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: logging: ensure ANSI color escape is sent in same line/before newline

by fixeria

Attention is currently required from: manawyrm, neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email ) Change subject: logging: ensure ANSI color escape is sent in same line/before newline ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Gerrit-Change-Number: 34975 Gerrit-PatchSet: 4 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 13:20:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: logging: ensure ANSI color escape is sent in same line/before newline

by osmith

Attention is currently required from: fixeria, manawyrm, neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email ) Change subject: logging: ensure ANSI color escape is sent in same line/before newline ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Gerrit-Change-Number: 34975 Gerrit-PatchSet: 4 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 13:18:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: logging: ensure ANSI color escape is sent in same line/before newline

by manawyrm

Attention is currently required from: fixeria, neels, osmith. manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email ) Change subject: logging: ensure ANSI color escape is sent in same line/before newline ...................................................................... Patch Set 3: (1 comment) File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/34975/comment/15b751bd_93e10840 PS3, Line 623: "%s\n", OSMO_LOGCOLOR_END > I think you can even do `OSMO_LOGCOLOR_END "\n"`, since `OSMO_LOGCOLOR_END` is defined as a string l […] Not many, as snprintf will still have to iterate through the string and look for any %-format strings. I do like it better, though, thanks. Changed it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Gerrit-Change-Number: 34975 Gerrit-PatchSet: 3 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 12:28:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: logging: ensure ANSI color escape is sent in same line/before newline

by manawyrm

Attention is currently required from: manawyrm, neels, osmith. Hello Jenkins Builder, neels, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: logging: ensure ANSI color escape is sent in same line/before newline ...................................................................... logging: ensure ANSI color escape is sent in same line/before newline This fixes multi-line color clobbering in logging daemons like systemd-journald, which work with single-lines only. Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 --- M src/core/logging.c M tests/loggingrb/logging_test.err 2 files changed, 23 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/34975/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Gerrit-Change-Number: 34975 Gerrit-PatchSet: 4 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 7 months

1
0
0 0

[S] Change in osmo-trx[master]: devies: fix band manager dev type

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34972?usp=email ) Change subject: devies: fix band manager dev type ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: if this is the fix mentioned during sysmocom weekly review call: the description doesn't contain any of the implications and it should reflect what this changes from the end user point of view, not just what the programmer did wrong and how the code changed. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34972?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1dda6023ca6f15bc063c3dfbc704db2410ff7c98 Gerrit-Change-Number: 34972 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 12:24:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2023